BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

asix-sigma: more u16 sample memory access nits (timestamps, values) 

Further "flatten" the DRAM layout's declaration for sample data. Declare
timestamps and sample data as uint16_t, keep accessing them via endianess
aware conversion routines. Accessing a larger integer in smaller quantities
is perfectly fine, the inverse direction would be problematic.
This commit is contained in:
Gerhard Sittig 2020-05-13 18:26:54 +02:00
parent a53b8e4d74
commit 2a62a9c44e
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hardware/asix-sigma/protocol.c
View File

@ -1121,7 +1121,7 @@ static int check_and_submit_sample(struct dev_context *devc,
*/
static uint16_t sigma_dram_cluster_ts(struct sigma_dram_cluster *cluster)
{
return read_u16le(&cluster->timestamp[0]);
return read_u16le((const uint8_t *)&cluster->timestamp);
}
/*
@ -1129,7 +1129,7 @@ static uint16_t sigma_dram_cluster_ts(struct sigma_dram_cluster *cluster)
*/
static uint16_t sigma_dram_cluster_data(struct sigma_dram_cluster *cl, int idx)
{
return read_u16le(&cl->samples[idx].sample[0]);
return read_u16le((const uint8_t *)&cl->samples[idx]);
}
/*

6
src/hardware/asix-sigma/protocol.h
View File

@ -205,10 +205,8 @@ enum sigma_read_register {
struct sigma_dram_line {
struct sigma_dram_cluster {
uint8_t timestamp[sizeof(uint16_t)];
struct sigma_dram_event {
uint8_t sample[sizeof(uint16_t)];
} samples[EVENTS_PER_CLUSTER];
uint16_t timestamp;
uint16_t samples[EVENTS_PER_CLUSTER];
} cluster[CLUSTERS_PER_ROW];
};