BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

center-3xx: use common signed LE16 conversion for temperature value 

Prefer the common conversion helper for little endian 16bit signed data.
The previous local implementation only worked for positive values, and
yielded incorrect results for negative temperatures.

This fixes bug #1463.
This commit is contained in:
Gerhard Sittig 2019-12-23 17:00:13 +01:00 committed by Uwe Hermann
parent ca7d442692
commit 56a1bf7b4b
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/hardware/center-3xx/protocol.c
View File

@ -64,7 +64,7 @@ static void log_packet(const uint8_t *buf, int idx)
static int packet_parse(const uint8_t *buf, int idx, struct center_info *info)
{
int i;
uint16_t temp_u16;
int16_t temp_i16;
log_packet(buf, idx);
@ -89,9 +89,8 @@ static int packet_parse(const uint8_t *buf, int idx, struct center_info *info)
/* Byte 7+8/9+10/11+12/13+14: channel T1/T2/T3/T4 temperature. */
for (i = 0; i < NUM_CHANNELS; i++) {
temp_u16 = buf[8 + (i * 2)];
temp_u16 |= ((uint16_t)buf[7 + (i * 2)] << 8);
info->temp[i] = (float)temp_u16;
temp_i16 = RL16S(&buf[7 + 2 * i]);
info->temp[i] = (float)temp_i16;
}
/* Byte 43: Specifies whether we need to divide the value(s) by 10. */