BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gmc-mh-1x-2x: fix potential memory leak 

The scan_2x_bd232() routine used to always prepare one spare context,
and filled it in when a device was found, just to allocate another one
and continue scanning.

Free the last allocated context unconditionally, as it was allocated
unconditionally, and never used.

This was reported by clang's scan-build.
This commit is contained in:
Gerhard Sittig 2018-02-09 18:50:53 +01:00 committed by Uwe Hermann
parent 0d1c51f57f
commit 56e9672b11
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hardware/gmc-mh-1x-2x/api.c
View File

@ -300,11 +300,9 @@ static GSList *scan_2x_bd232(struct sr_dev_driver *di, GSList *options)
} }
}; };
/* Free last alloc if no device found */ /* Free last alloc that was done in preparation. */
if (devc->model == METRAHIT_NONE) { g_free(devc);
g_free(devc); sr_dev_inst_free(sdi);
sr_dev_inst_free(sdi);
}
return std_scan_complete(di, devices); return std_scan_complete(di, devices);