BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

itech-it8500: avoid "new" as a variable identifier 

Strictly speaking the "new" identifier is not a reserved word. Still
it's good practice not to use it for variables in C language sources.
Rename variables to "old_bit" and "new_bit" for consistency.
This commit is contained in:
Gerhard Sittig 2020-10-06 19:26:36 +02:00
parent 8c8fff4773
commit 92cd85149a
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/hardware/itech-it8500/protocol.c
View File

@ -192,40 +192,40 @@ SR_PRIV void itech_it8500_status_change(const struct sr_dev_inst *sdi,
uint16_t old_ds, uint16_t new_ds, uint16_t old_ds, uint16_t new_ds,
enum itech_it8500_modes old_m, enum itech_it8500_modes new_m) enum itech_it8500_modes old_m, enum itech_it8500_modes new_m)
{ {
gboolean old_bit, new_bit;
const char *mode; const char *mode;
gboolean old, new;
/* Check it output status has changed. */ /* Check it output status has changed. */
old = old_os & OS_OUT_FLAG; old_bit = old_os & OS_OUT_FLAG;
new = new_os & OS_OUT_FLAG; new_bit = new_os & OS_OUT_FLAG;
if (old != new) if (old_bit != new_bit)
sr_session_send_meta(sdi, sr_session_send_meta(sdi,
SR_CONF_ENABLED, SR_CONF_ENABLED,
g_variant_new_boolean(new)); g_variant_new_boolean(new_bit));
/* Check if OVP status has changed. */ /* Check if OVP status has changed. */
old = old_ds & DS_OV_FLAG; old_bit = old_ds & DS_OV_FLAG;
new = new_ds & DS_OV_FLAG; new_bit = new_ds & DS_OV_FLAG;
if (old != new) if (old_bit != new_bit)
sr_session_send_meta(sdi, sr_session_send_meta(sdi,
SR_CONF_OVER_VOLTAGE_PROTECTION_ACTIVE, SR_CONF_OVER_VOLTAGE_PROTECTION_ACTIVE,
g_variant_new_boolean(new)); g_variant_new_boolean(new_bit));
/* Check if OCP status has changed. */ /* Check if OCP status has changed. */
old = old_ds & DS_OC_FLAG; old_bit = old_ds & DS_OC_FLAG;
new = new_ds & DS_OC_FLAG; new_bit = new_ds & DS_OC_FLAG;
if (old != new) if (old_bit != new_bit)
sr_session_send_meta(sdi, sr_session_send_meta(sdi,
SR_CONF_OVER_CURRENT_PROTECTION_ACTIVE, SR_CONF_OVER_CURRENT_PROTECTION_ACTIVE,
g_variant_new_boolean(new)); g_variant_new_boolean(new_bit));
/* Check if OTP status has changed. */ /* Check if OTP status has changed. */
old = old_ds & DS_OT_FLAG; old_bit = old_ds & DS_OT_FLAG;
new = new_ds & DS_OT_FLAG; new_bit = new_ds & DS_OT_FLAG;
if (old != new) if (old_bit != new_bit)
sr_session_send_meta(sdi, sr_session_send_meta(sdi,
SR_CONF_OVER_TEMPERATURE_PROTECTION_ACTIVE, SR_CONF_OVER_TEMPERATURE_PROTECTION_ACTIVE,
g_variant_new_boolean(new)); g_variant_new_boolean(new_bit));
/* Check if operating mode has changed. */ /* Check if operating mode has changed. */
if (old_m != new_m) { if (old_m != new_m) {