BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

serial_libsp: extend diag in code path which opens serial ports 

Opening a serial port involves two libserialport calls, while only the
second call's return value gets inspected. Check the lookup before the
open, too, and provide its details in a diag message.
This commit is contained in:
Gerhard Sittig 2021-05-09 19:27:22 +02:00
parent f5c697bfe6
commit ac1866b923
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/serial_libsp.c
View File

@ -55,7 +55,14 @@ static int sr_ser_libsp_open(struct sr_serial_dev_inst *serial, int flags)
char *error;
int sp_flags;
sp_get_port_by_name(serial->port, &serial->sp_data);
ret = sp_get_port_by_name(serial->port, &serial->sp_data);
if (ret != SP_OK) {
error = sp_last_error_message();
sr_err("Error getting port from name %s: (%d) %s.",
serial->port, sp_last_error_code(), error);
sp_free_error_message(error);
return SR_ERR;
}
sp_flags = 0;
if (flags & SERIAL_RDWR)