BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

strutil: Assume bool is true when no value is specified 

Adjust the string to boolean conversion for an edge case. Accept empty
text (either NULL or empty strings) to mean true instead of false.

This behaviour is more useful from the user's point of view, when the
option's name alone will enable a feature, and an explicit "option=yes"
specification is not strictly necessary. All calling applications in
mainline already implemented this semantics.
This commit is contained in:
Gerhard Sittig 2017-06-25 11:28:29 +02:00
parent e7eb29685c
commit ad466f86cc
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/strutil.c
View File

@ -555,8 +555,13 @@ SR_API uint64_t sr_parse_timestring(const char *timestring)
/** @since 0.1.0 */ /** @since 0.1.0 */
SR_API gboolean sr_parse_boolstring(const char *boolstr) SR_API gboolean sr_parse_boolstring(const char *boolstr)
{ {
if (!boolstr) /*
return FALSE; * Complete absence of an input spec is assumed to mean TRUE,
* as in command line option strings like this:
* ...:samplerate=100k:header:numchannels=4:...
*/
if (!boolstr || !*boolstr)
return TRUE;
if (!g_ascii_strncasecmp(boolstr, "true", 4) || if (!g_ascii_strncasecmp(boolstr, "true", 4) ||
!g_ascii_strncasecmp(boolstr, "yes", 3) || !g_ascii_strncasecmp(boolstr, "yes", 3) ||