0fa71943e3
Use std_session_send_df_trigger() where possible.
2020-04-08 23:21:39 +02:00
1372bdcdb5
saleae and other FX2: show firmware name when loading fails
...
The "firmware load failed" message would be even more helpful if users
could learn which firmware file failed to load. Add those filenames to
various FX2-based drivers.
This addresses bug #1262 .
2018-08-30 22:05:56 +02:00
10481ef05d
Fix: Bug #1188 DSLogic triggering
2018-06-16 19:31:44 +02:00
55bcd7ad45
dreamsourcelab-dslogic: Properly set initial voltage threshold.
...
The initial voltage threshold in dev_open() was being set to a
default value in the devc->cur_threshold variable but not actually set
in the device itself.
Patch by Jörg Alpers <jalpers@gmx.net>, thanks a lot!
2018-04-28 23:39:59 +02:00
6c1a76d126
Check usb_get_port_path() return value
...
This function can fail. If so, do not ignore the failure.
2018-02-21 11:37:19 +01:00
7bbe5a2b6a
Ensure device is closed before usb_get_port_path()
...
The usb_get_port_path() function opens the passed device on FreeBSD,
which fails if the device has already been open.
This fixes bug #1109 .
2018-02-21 11:36:58 +01:00
d9b716fc5f
Use UINT64_C instead of "ULL" number suffix.
...
Avoid hardcoding a "ULL" number suffix, use the more portable and more
correct UINT64_C.
2018-02-20 20:03:21 +01:00
051e4beb79
dreamsourcelab-dslogic: avoid division by zero
...
Do not align to block_size when its value is zero.
This was reported by clang's scan-build.
2018-02-09 21:34:17 +01:00
8e2fd23acb
dreamsourcelab-dslogic: avoid NULL pointer dereference
...
Check pointers' validity before dereferencing them.
This was reported by clang's scan-build.
2018-02-09 21:34:17 +01:00
55584d38dd
dreamsourcelab-dslogic: Fixed deinterleaving when non-contiguous set of channels are enabled
2017-09-26 21:48:04 +02:00
f05600f4be
dreamsourcelab-dslogic: Fixed enabling of triggers
2017-09-19 00:31:11 +02:00
16d4c982a3
dreamsourcelab-dslogic: Moved devc and usb assignment into initializers
2017-09-19 00:31:11 +02:00
9f58023066
dreamsourcelab-dslogic: Improved naming of variables in fpga_configure
2017-09-19 00:31:11 +02:00
b7a3d79e46
dreamsourcelab-dslogic: Fixed trigger-stages field in trig_glb
2017-09-19 00:31:11 +02:00
b23ecd6ce7
dreamsourcelab-dslogic: Simplified trigger population
2017-09-19 00:31:06 +02:00
86a1571135
dreamsourcelab-dslogic: Fix incorrect default threshold setting.
...
This was leading to an invalid threshold config value and indirectly
to frontend issues.
Slightly modified patch from James Churchill <pelrun@gmail.com>, thanks!
2017-09-14 11:15:06 +02:00
bc98407b8f
dreamsourcelab-dslogic: config_list: Handle SR_CONF_TRIGGER_MATCH.
...
This fixes bug #1032 .
2017-09-13 13:05:42 +02:00
b3fd09937c
drivers: Use NUM_CHANNELS in favor of hardcoded values.
2017-08-06 17:31:46 +02:00
21fe5dba36
drivers: Drop some unneeded voltage_/volt_ prefixes.
2017-07-31 16:23:32 +02:00
e124cf9b7a
drivers: Drop some unneeded _names suffixes.
2017-07-31 16:23:32 +02:00
efad7cccec
drivers: SR_CONF_CAPTURE_RATIO fixes.
...
Move the check for the capture ratio being 0..100 into the wrappers,
drop unneeded helper functions, fix incorrect variable types, minor
other consistency fixes.
2017-07-31 16:23:32 +02:00
758906aa71
drivers: Remove some unneeded 'ret' variables.
2017-07-31 16:23:31 +02:00
697fb6ddfc
drivers: Factor out std_*_idx*().
2017-07-31 16:23:31 +02:00
94e64a0b89
drivers: Replace struct voltage_threshold with an array.
...
This makes the code-base more consistent and will allow for wider usage
of upcoming array helper functions.
2017-07-31 16:23:31 +02:00
95c1fe62f7
drivers: Use g_variant_new_printf() where possible.
2017-07-31 16:23:31 +02:00
9fb9afb573
drivers: Factor out std_gvar_thresholds().
2017-07-31 16:23:31 +02:00
43995cda36
drivers: Factor out std_gvar_tuple_double().
2017-07-31 16:23:31 +02:00
8dacbcf68f
drivers: Consistently use the exact driver name as LOG_PREFIX.
2017-07-21 18:46:27 +02:00
53012da658
drivers: Use ARRAY_AND_SIZE where possible.
2017-07-21 17:06:40 +02:00
7bc3cfe6ff
drivers: Factor out std_gvar_min_max_step_thresholds().
2017-07-21 16:54:05 +02:00
463160cbca
drivers: Factor out std_gvar_samplerates{,_steps}().
2017-07-21 16:49:01 +02:00
4b25cbffa1
drivers: Drop some unnecessary prefixes.
2017-07-21 15:45:03 +02:00
ca314e060f
drivers: Drop unneeded or duplicate comments.
...
Drop various comments which are not really needed, too verbose, document
obvious things, are duplicated across all drivers, or simply incorrect.
2017-07-21 15:23:56 +02:00
55fb76b348
drivers: Always use same scanopts/drvopts/devopts/devopts_cg* order.
2017-07-19 15:11:01 +02:00
e66d1892d0
drivers: Add and use STD_CONFIG_LIST().
...
This ensures consistent handling of the SR_CONF_SCAN_OPTIONS and
SR_CONF_DEVICE_OPTIONS (with sdi NULL or non-NULL) config keys
and also reduces copy-pasted boilerplate in the drivers a bit.
This function does not handle channel-group specific items, that's
very driver-specific and thus left to the individual drivers.
Also move some generic checks and error messages from the drivers into
the sr_config_list() wrapper.
2017-07-19 15:11:01 +02:00
8bf18daabb
sr_dev_clear(): Always free sdi->priv (devc).
...
Until now, clear_helper() callbacks for std_dev_clear_with_callback()
were expected to g_free(devc), but not all of them did that.
Have std_dev_clear_with_callback() unconditionally g_free(sdi->priv)
(i.e., devc), regardless of whether a clear_helper() callback was
provided or not. It was doing g_free(sdi->priv) when no callback
was provided already anyway.
This makes the individual drivers' clear_helper() implementations
shorter and prevents errors such as missing g_free(devc) calls.
This works, because all drivers either call std_dev_clear_with_callback()
directly, or indirectly via std_dev_clear().
This also allows us to remove some no-longer needed dev_clear()
and clear_helper() implementations that only did g_free(devc)
in favor of std_dev_clear().
2017-07-13 11:59:11 +02:00
53279f13e4
dev_clear(): Consistently name callback 'clear_helper()'.
2017-07-13 11:59:11 +02:00
6e43c3d531
std: Rename std_dev_clear() to std_dev_clear_with_callback().
2017-07-13 11:59:11 +02:00
f1ba6b4b2c
sr_dev_close(): Set status to SR_ST_INACTIVE.
...
This ensures consistent checks and log messages across all drivers
and reduces the per-driver boilerplate.
2017-07-08 14:25:23 +02:00
7e46362338
sr_dev_open(): Set status to SR_ST_ACTIVE upon success.
...
This ensures consistent checks and log messages across all drivers
and reduces the per-driver boilerplate.
2017-07-08 14:25:23 +02:00
6402c37916
sr_dev_open(): Factor out SR_ST_ACTIVE check.
...
This ensures consistent checks and log messages across all drivers
and reduces the per-driver boilerplate.
2017-07-08 14:25:23 +02:00
c3cd66a00c
sr_config_set(): Factor out SR_ERR_DEV_CLOSED check.
...
This ensures consistent checks and log messages across all drivers
and reduces the per-driver boilerplate.
2017-07-07 21:51:19 +02:00
f670835f1f
Add sr_dev_acquisition_start(), factor out SR_ERR_DEV_CLOSED check.
...
This ensures consistent checks and log messages across all drivers
and reduces the per-driver boilerplate.
2017-07-07 21:51:16 +02:00
ecadb11845
dreamsourcelab-dslogic: Drop an assert().
2017-06-21 18:02:50 +02:00
4984ca28f7
dreamsourcelab-dslogic: Don't check for USB manufacturer/product.
...
Before firmware upload some models (e.g. the original DSLogic or the
DSLogic Pro) don't have any USB manufacturer or product strings set, so
they wouldn't be detected.
2017-06-21 18:02:50 +02:00
7962b129c3
dreamsourcelab-dslogic: Drop an unneeded dslogic_ prefix.
2017-06-20 23:33:29 +02:00
44b46d7036
dreamsourcelab-dslogic: Naming and other consistency fixes.
2017-06-20 23:33:29 +02:00
Uwe Hermann
Gerhard Sittig
Joerg Alpers
Romain Tartière
Joel Holdsworth