Commit Graph

454 Commits

Author SHA1 Message Date
Christian Schabesberger cfc72d8dc9
Merge pull request #188 from jimbo1qaz/fix-description-timestamps
Fix timestamp links in Youtube video descriptions
2019-08-22 11:25:16 +02:00
jimbo1qaz e38d906ff9 Fix timestamp links in Youtube video descriptions
For some reason, in NewPipeExtractor,
comments were loaded from JSON by YoutubeCommentsInfoItemExtractor as text,
sent via CommentsInfoItem#getCommentText to NewPipe,
where timestamps are converted to hyperlinks using Linkify:
https://github.com/TeamNewPipe/NewPipe/pull/2168

On the other hand, video descriptions are handled in NewPipeExtractor
by scraping the watch-page HTML.
There, timestamp links were previously mangled (and now properly parsed),
before being sent as HTML via YoutubeStreamExtractor#getDescription
to NewPipe (where HTML gets converted to Spanned).

The logic introduced in this commit is different from the above PR,
since it operates in the extractor, and mutates the HTML DOM
rather than identifying via regex.
2019-08-18 01:05:41 -07:00
Christian Schabesberger 430da57350
Merge pull request #184 from Stypox/duplicate-subscription-fix
Fix inconsistency in youtube channel urls
2019-08-18 00:42:31 +02:00
Christian Schabesberger 58e3996edc
Merge branch 'dev' into duplicate-subscription-fix 2019-08-18 00:42:24 +02:00
Christian Schabesberger f9da8bc0c8
Merge pull request #186 from Stypox/recaptcha-with-url
Add url to ReCaptchaException
2019-08-18 00:42:15 +02:00
Christian Schabesberger 3e2df12f12
Merge branch 'dev' into recaptcha-with-url 2019-08-18 00:41:27 +02:00
Christian Schabesberger 92846076ce
Merge branch 'dev' into duplicate-subscription-fix 2019-08-18 00:41:16 +02:00
Christian Schabesberger a13304248f
Merge pull request #185 from Stypox/search-error-fix
Fix casual search error when playlists are in results
2019-08-18 00:37:59 +02:00
Stypox 06689a2f27
Add url to ReCaptchaException
Sometimes YouTube introduces recaptchas only on some pages. By adding an url to the ReCaptchaException the NewPipe app is able to use that url to load the page that originally caused the problem.
Also removed every instance of exception caught and rethrown with a different description: it makes no sense and it removes part of the useful stacktrace.
2019-08-17 09:09:07 +02:00
Stypox d4e975e4fa
Fix search error with some playlists
Somtimes there were two divs with class "yt-lockup-meta", so the extractor couldn't get the correct one.
2019-08-16 22:47:02 +02:00
Stypox 216a4eb1f5
Complete fix inconsistency in youtube channel urls
It is not always possible to get the url in the form "https://www.youtube.com/channel/...", so a not has been added whenever that happens to be the case (i.e. only in InfoStreamItems).
2019-08-16 21:17:03 +02:00
Stypox 315c5c262f
Typo 2019-08-16 21:14:52 +02:00
Stypox d14c45c948
Fix SoundCloud tests 2019-08-12 17:15:21 +02:00
Stypox b09e402d4f
Fix wrong regex when channel id is at the end of the url
It had no "&" at the end.
2019-08-12 16:55:39 +02:00
Stypox 31e74253f8
Fix tests 2019-08-12 16:38:56 +02:00
Stypox 09c6822b1d
Change youtube channel url test 2019-08-12 13:13:41 +02:00
Stypox b8bc57c53f
Add tests for youtube channel urls
They have to be in the form "https://www.youtube.com/channel/ID"
2019-08-12 11:58:50 +02:00
Stypox 6aa69a2df8
Fix inconsistency in youtube channel urls
Urls from the youtube search extractor were "https://www.youtube.com/user/NAME" instead of "https://www.youtube.com/channel/ID". This fixes TeamNewPipe/NewPipe#2167
2019-08-12 11:57:29 +02:00
Christian Schabesberger 5f65788a2f
Merge pull request #177 from TeamNewPipe/duration_fix
fix duration can not be paresd
2019-07-31 18:03:41 +02:00
Christian Schabesberger 5798c8fdf5 fix duration can not be paresd
update gradle to version 5.1

fix sts issue for agegated videos

GOD DAMN FUCKING BULLSHIT

add duratin for controversal/age gated videos

bring back sts

remove ignores

fix ogg test
2019-07-31 16:11:42 +02:00
Christian Schabesberger 4488c21765
Merge pull request #159 from ritiek/better-soundcloud-thumbnail
Improve thumbnail quality for Soundcloud service
2019-06-27 14:27:23 +02:00
Tobias Groza cfdbc4e1d1
Merge pull request #170 from TobiGr/dev
Fix SoundCloud playlists parsing exception
2019-06-26 01:02:34 +02:00
TobiGr 0d09a9fd61 Fix SoundCloud playlists parsing exception
Closes TeamNewPipe/NewPipe#2344
2019-06-26 00:56:03 +02:00
Tobias Groza c64c90a567
Merge pull request #168 from masozzi/dev
soundcloud parsing helper: fixed id parser regex
2019-06-02 21:06:57 +02:00
Tobias Groza 796c1b7bc0
Merge pull request #164 from TeamNewPipe/fix/test_comments
Fix failing YouTube comments tests
2019-06-02 11:36:16 +02:00
Matteo Sozzi 93d4299f07 soundcloud parsing helper: fixed id parser regex 2019-05-31 20:15:36 +02:00
Tobias Groza 2ac713e70f
Merge pull request #160 from Stypox/invalid-youtube-subscription-fix
Fixed youtube subscription import: ignore ones with invalid url and keep ones with empty title.
2019-05-14 22:26:25 +02:00
Tobias Groza 867ca1cabf Fix failing YouTube comments tests
The comment function has been disabled for the video on which we ran the test. We are testing the comments of a different video now.
2019-05-14 22:11:40 +02:00
Tobias Groza acebbaf073
Merge pull request #163 from Stypox/youtube-url-signature-fix
Fix invalid yt url: signature tag name is not always "signature"
2019-05-14 21:29:31 +02:00
Stypox c70d28597b
Add fallback for urls not conaining the "sp" tag
If ever YouTube changes thing again (or uses old urls for some unknown reason), this prevents the extractor from crashing.
As suggested here: 133cc032d9 (r283529811)
2019-05-14 13:57:45 +02:00
Stypox 133cc032d9
Fix invalid yt url: signature tag name is not always "signature"
Thanks to @omarroth for the suggestion: see TeamNewPipe/NewPipeExtractor#155
2019-05-13 21:25:35 +02:00
Stypox 0eaca52c15
Add test for subscription with invalid url.
Also modified the test for empty title, since now  subscriptions with empty title are not ignored anymore.
2019-04-28 14:19:33 +02:00
Stypox 171f2c49fe
Ignore subscriptions with invalid url and keep ones with empty title.
if a channel if deleted (thus it has an empty title), it is imported in NewPipe anyway, so that if it becomes undeleted in the future, it will be shown in the app.
2019-04-28 14:17:52 +02:00
Stypox d5043cdf49
Add test for subscriptions with empty title.
(youtube subscription extractor)
2019-04-26 19:59:23 +02:00
Stypox 03893abd91
Fixed TeamNewPipe/NewPipe#2226.
(in the youtube subscription extractor)
Ignore subscriptions that have an empty title instead of throwing an error: the youtube subscription_manager XML file can sometimes contain those (i.e. deleted channels).
2019-04-26 18:54:30 +02:00
Ritiek Malhotra c7974b2aed Fetch better quality thumbnails
and fallback to avatar thumbnail if track thumbnail isn't found
2019-04-26 02:59:15 +05:30
Christian Schabesberger d22786b817 Merge branch 'master' into dev 2019-03-23 10:07:28 +01:00
Christian Schabesberger 4c633c2166
Merge pull request #137 from connectety/invidious-support
Invidious support
2019-03-23 10:01:51 +01:00
Christian Schabesberger 5b93db04e6
Merge pull request #152 from yausername/fixMissingAuthorName
fix empty author name
2019-03-23 09:57:44 +01:00
yausername 4effd0b36d fix empty author name 2019-03-23 00:13:18 +05:30
Christian Schabesberger 560c648e92 fix decrypt regex for akamai 2 times in file 2019-03-14 16:49:30 +01:00
Connectety ed78f7dadc
Merge branch 'master' into invidious-support 2019-03-14 16:07:04 +01:00
Christian Schabesberger dd61d66cf5 speed up finding decrypt function 2019-03-14 09:07:19 +01:00
Christian Schabesberger 5eac266a16 Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into dev 2019-03-14 08:50:57 +01:00
Ritvik Saraf 0a7d42f58d set soundcloud default kiosk 2019-03-14 08:49:37 +01:00
Ritvik Saraf 53058802e2 fix comment url 2019-03-14 08:49:37 +01:00
Christian Schabesberger e072bf6461 fix dercrypt error due to wrong dollar sign detection 2019-03-14 08:49:11 +01:00
Christian Schabesberger 5f44031ce7
Merge pull request #146 from yausername/soundcloudDefaultKiosk
set soundcloud default kiosk
2019-03-10 22:28:29 +01:00
Ritvik Saraf cb30b336ab set soundcloud default kiosk 2019-03-11 02:14:58 +05:30
Christian Schabesberger aa4f03a385
Merge pull request #144 from yausername/fixCommentUrl
fix comment url
2019-03-02 23:38:28 +01:00