haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Avoid overwriting the max resolution requested by the tile-view. (#7320) 

Part of [1] replaces a `setPreferredVideoQuality` call with a
`setMaxReceiverVideoQuality` call. The change was part of a bigger
changeset that adds logic that tries to adjust the max based on reduced
ui turned on or off and allow to set prefered through the config.

However, by calling `setMaxReceiverVideoQuality` instead of
`setPreferredVideoQuality`, the new feature overrides the lower
resolution requested by tile-view earlier in some occasions.

This PR reverts back to using `setPreferredVideoQuality` instead of
`setMaxReceiverVideoQuality` as this achieves the same result without
overwriting the max set by the tile-view.

NOTE that this is a quick-fix and all the handling related to setting
the receive resolution will be reworked soon.

[1]: 7d513738d2
This commit is contained in:
George Politis 2020-07-15 15:55:30 +02:00 committed by GitHub
parent 1790c71c80
commit 11fd5363ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
react/features/conference/middleware.js
View File

@ -6,7 +6,7 @@ import {
VIDEO_QUALITY_LEVELS, VIDEO_QUALITY_LEVELS,
conferenceLeft, conferenceLeft,
getCurrentConference, getCurrentConference,
setMaxReceiverVideoQuality setPreferredVideoQuality
} from '../base/conference'; } from '../base/conference';
import { hideDialog, isDialogOpen } from '../base/dialog'; import { hideDialog, isDialogOpen } from '../base/dialog';
import { setActiveModalId } from '../base/modal'; import { setActiveModalId } from '../base/modal';
@ -33,7 +33,7 @@ MiddlewareRegistry.register(store => next => action => {
dispatch(setFilmstripEnabled(!reducedUI)); dispatch(setFilmstripEnabled(!reducedUI));
dispatch( dispatch(
setMaxReceiverVideoQuality( setPreferredVideoQuality(
reducedUI reducedUI
? VIDEO_QUALITY_LEVELS.LOW ? VIDEO_QUALITY_LEVELS.LOW
: VIDEO_QUALITY_LEVELS.HIGH)); : VIDEO_QUALITY_LEVELS.HIGH));