haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(thumbnail): cleanup unused hover properties.

This commit is contained in:
Hristo Terezov 2020-10-16 15:59:33 -05:00
parent c5f6df5210
commit a6e58c3101
2 changed files with 1 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/UI/videolayout/RemoteVideo.js
View File

@ -86,7 +86,6 @@ export default class RemoteVideo extends SmallVideo {
this.bindHoverHandler();
this.flipX = false;
this.isLocal = false;
this.popupMenuIsHovered = false;
this._isRemoteControlSessionActive = false;
/**
@ -137,17 +136,6 @@ export default class RemoteVideo extends SmallVideo {
return this.container;
}
/**
* Checks whether current video is considered hovered. Currently it is hovered
* if the mouse is over the video, or if the connection indicator or the popup
* menu is shown(hovered).
* @private
* NOTE: extends SmallVideo's method
*/
_isHovered() {
return super._isHovered() || this.popupMenuIsHovered;
}
/**
* Generates the popup menu content.
*

25
modules/UI/videolayout/SmallVideo.js
View File

@ -100,15 +100,6 @@ export default class SmallVideo {
*/
this._connectionStatus = null;
/**
* Whether or not the ConnectionIndicator's popover is hovered. Modifies
* how the video overlays display based on hover state.
*
* @private
* @type {boolean}
*/
this._popoverIsHovered = false;
/**
* Whether or not the connection indicator should be displayed.
*
@ -134,7 +125,6 @@ export default class SmallVideo {
this._showRaisedHand = false;
// Bind event handlers so they are only bound once for every instance.
this._onPopoverHover = this._onPopoverHover.bind(this);
this.updateView = this.updateView.bind(this);
this._onContainerClick = this._onContainerClick.bind(this);
@ -513,7 +503,7 @@ export default class SmallVideo {
* @private
*/
_isHovered() {
return this.videoIsHovered || this._popoverIsHovered;
return this.videoIsHovered;
}
/**
@ -836,19 +826,6 @@ export default class SmallVideo {
}
}
/**
* Updates the current state of the connection indicator popover being hovered.
* If hovered, display the small video as if it is hovered.
*
* @param {boolean} popoverIsHovered - Whether or not the mouse cursor is
* currently over the connection indicator popover.
* @returns {void}
*/
_onPopoverHover(popoverIsHovered) {
this._popoverIsHovered = popoverIsHovered;
this.updateView();
}
/**
* Sets the size of the thumbnail.
*/