haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[RN] Remove workaround for video mirroring on iOS 

It's now natively supported:
https://github.com/oney/react-native-webrtc/pull/244
This commit is contained in:
Saúl Ibarra Corretgé 2017-04-04 14:57:06 +02:00 committed by Lyubo Marinov
parent fd10362bef
commit ae8c5287e4
2 changed files with 2 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
react/features/base/media/components/native/Video.js
View File

@ -1,20 +1,8 @@
import React, { Component } from 'react';
import { View } from 'react-native';
import { RTCView } from 'react-native-webrtc';
import { Platform } from '../../../react';
import { styles } from './styles';
/**
* Indicates whether RTCView (is to be considered that it) natively supports
* i.e. implements mirroring the video it renders. If false, a workaround will
* be used in an attempt to support mirroring in Video. If RTCView does not
* implement mirroring on a specific platform but the workaround causes issues,
* set to true for that platform to disable the workaround.
*/
const RTCVIEW_SUPPORTS_MIRROR = Platform.OS === 'android';
/**
* The React Native component which is similar to Web's video element and wraps
* around react-native-webrtc's RTCView.
@ -91,31 +79,15 @@ export class Video extends Component {
const style = styles.video;
const objectFit = (style && style.objectFit) || 'cover';
const { mirror } = this.props;
// XXX RTCView may not support support mirroring, even when
// providing a transform style property (e.g. iOS) . As a
// workaround, wrap the RTCView inside another View and apply the
// transform style property to that View instead.
const mirrorWorkaround = mirror && !RTCVIEW_SUPPORTS_MIRROR;
// eslint-disable-next-line no-extra-parens
const video = (
return (
<RTCView
mirror = { mirrorWorkaround ? false : mirror }
mirror = { this.props.mirror }
objectFit = { objectFit }
streamURL = { streamURL }
style = { style }
zOrder = { this.props.zOrder } />
);
if (mirrorWorkaround) {
return (
<View style = { styles.mirroredVideo }>{ video }</View>
);
}
return video;
}
// RTCView has peculiarities which may or may not be platform specific.

9
react/features/base/media/components/native/styles.js
View File

@ -7,18 +7,9 @@ const video = {
flex: 1
};
/**
* Transform local videos to behave like a mirror.
*/
const mirroredVideo = {
...video,
transform: [ { scaleX: -1 } ]
};
/**
* Native-specific styles for media components.
*/
export const styles = StyleSheet.create({
mirroredVideo,
video
});