haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rn,filmstrip: don't unpin participant when hiding filmstrip 

The filmstrip is currently only hidden when PiP mode is entered. There is no
real reason not to leave the large view as it was.
This commit is contained in:
Saúl Ibarra Corretgé 2019-07-30 14:18:42 +02:00 committed by Saúl Ibarra Corretgé
parent 4d5332cadf
commit b5489b7c81
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
react/features/filmstrip/middleware.js
View File

@ -1,7 +1,6 @@
// @flow // @flow
import { setLastN } from '../base/conference'; import { setLastN } from '../base/conference';
import { pinParticipant } from '../base/participants';
import { MiddlewareRegistry } from '../base/redux'; import { MiddlewareRegistry } from '../base/redux';
import { SET_FILMSTRIP_ENABLED } from './actionTypes'; import { SET_FILMSTRIP_ENABLED } from './actionTypes';
@ -33,16 +32,12 @@ MiddlewareRegistry.register(store => next => action => {
function _setFilmstripEnabled({ dispatch, getState }, next, action) { function _setFilmstripEnabled({ dispatch, getState }, next, action) {
const result = next(action); const result = next(action);
// FIXME The logic for participant pinning / unpinning is not on React yet // FIXME This action is not currently dispatched on web.
// so dispatching the action is not enough. Hence, perform the following
// only where it will be sufficient i.e. mobile.
if (typeof APP === 'undefined') { if (typeof APP === 'undefined') {
const state = getState(); const state = getState();
const { enabled } = state['features/filmstrip']; const { enabled } = state['features/filmstrip'];
const { audioOnly } = state['features/base/conference']; const { audioOnly } = state['features/base/conference'];
enabled || dispatch(pinParticipant(null));
// FIXME Audio-only mode fiddles with lastN as well. That's why we don't // FIXME Audio-only mode fiddles with lastN as well. That's why we don't
// touch lastN in audio-only mode. But it's not clear what the value of // touch lastN in audio-only mode. But it's not clear what the value of
// lastN should be upon exit from audio-only mode if the filmstrip is // lastN should be upon exit from audio-only mode if the filmstrip is