Commit Graph

3673 Commits

Author SHA1 Message Date
George Politis e4b50ba419
send video type to rtcstats (#11426) 2022-05-16 15:56:37 +02:00
Saúl Ibarra Corretgé 05127467c2 feat(notifications) add ability to disable specific notifications
This works together with the broader "notifications" config option. One
might choose to leave the existing option unespecified *thus allowing
all notifications) and then use this new one to be explicit about which
ones to disable.
2022-05-16 13:24:59 +02:00
Horatiu Muresan 420c7c87e3
fix(filmstrip) Do not render filmstrip on prejoin/lobby 2022-05-16 12:30:14 +03:00
Calin Chitu fb6f38800b fix(chat/native) we need to dispatch close and open chat 2022-05-13 18:07:26 +03:00
Calin Chitu ebe81e2835 feat(mobile/navigation) changed navigation container background color 2022-05-12 16:42:04 +02:00
Gabriel Borlea c4106b8d89
fix(face-landmarks) set explicit model paths 2022-05-12 13:30:47 +02:00
Nils Ohlmeier 0638d9d303
feat: enable audio settings menu for Firefox (#11522) 2022-05-11 09:51:00 -04:00
Calinteodor 0fe7383154
fix(chat/native) private message replies (#11521)
Fixes issue #11516
2022-05-10 18:28:23 +03:00
Calin Chitu 9d7b6cafc5 fix(video-menu/native) wrong import path 2022-05-10 15:07:22 +03:00
Hristo Terezov 39d30ea0b4 fix(stage-filmstrip): resize. 2022-05-09 18:17:53 -05:00
pangrr 3fc3a217eb
fix(stats) split stats for camera and screenshare in multi-stream mode (#11475)
* no ssrc when sourceNameSignalingEnabled
* conditionally use source name for stats
* update doc
* always subscribe to participant id
2022-05-09 09:42:45 -04:00
Mihaela Dumitru 36578696bb
feat(config) add gravatar config object (#11509) 2022-05-09 08:36:39 +03:00
Hristo Terezov 084f911699 fix(stage-tile-view): crash when pinning 2022-05-06 16:59:39 -05:00
Saúl Ibarra Corretgé 01bd18b86a fix(notifications) remove unused isDismissAllowed prop 2022-05-06 16:49:08 +02:00
Saúl Ibarra Corretgé e6ce5fd75f fix(rn,navigation) wait until the root navigator is initialized
There is a race condition in the root navigatior's initialization.

It's possible that it's initialized a touch too late and SDK users who
try to navigate to a conference end up stuck in the connecting screen
because the navigator is null.

This PR waits for it to be initilized by very unorthodox means, it's a
horrible hack which we need to undo, but for that we need to break
appart the inheritance relationship between App.{web,native},
AbstractApp and BaseApp because it's very inflexible.

The flags are now initialized very early so the naviggator sees if the
welcome page is enabled or not.
2022-05-06 15:05:37 +02:00
Gabriel Borlea 0c021868b5
feat(face-landmarks): integrate human library
It replaces face-api.

* feat(face-landmarks): integrate human library

* feat(face-landmarks): rewrite worker in typescript

* fix(face-landmarks): allow worker bundle size up to 2 mib

* fix: remove unwanted comment

* code review
2022-05-06 14:41:08 +02:00
Hristo Terezov adef5095da
feat(RN-filmtrip) stop reordering small meetings 2022-05-06 12:18:57 +02:00
Horatiu Muresan 61abf0d882
feat(carmode) Add carmode screen
- opens as a modal
- lastn is 0, mutes local video while open
- long press to talk
- and more
2022-05-06 13:14:10 +03:00
Saúl Ibarra Corretgé e628d99544 fix(av-moderation) use a consistent UID for ask to unmute notifications
This way only one will be shown at a time.
2022-05-06 10:36:53 +02:00
Hristo Terezov f34dde3376 feat(tile-view): expand tiles from last row.
If we have enough space on the last row we expand the width of the tiles
up to 16:9 ratio.
2022-05-05 08:55:02 -05:00
Saúl Ibarra Corretgé d1ac4ea637 fix(rn,reactions) don't show raise hand button in menu if disabled 2022-05-05 13:49:36 +02:00
Robert Pintilii bb0d3b4c66
fix: Stage filmstrip (#11495) 2022-05-05 12:20:20 +03:00
Jaya Allamsetty 346aadc23d fix(participant-pane) Do not show virtual SS as a separate participant. 2022-05-04 10:41:31 -04:00
Saúl Ibarra Corretgé e94607ae4b fix(recording) use generic icon for cloud recording 2022-05-03 17:12:18 +02:00
William Liang f2c3740108
fix(screenshare) use selector for getting screenshare owner display name (#11478) 2022-05-03 10:25:19 -04:00
Saúl Ibarra Corretgé fe7327cd21 fix(rn,dialin-summary) simplify navigation
Only havee the screen in the hierarchy if we have a welcome page, since
it's the only way to access it.

Use goBack() from the navigator directly and avoid duplicating all props
to the screen.
2022-05-03 15:16:29 +02:00
Saúl Ibarra Corretgé 9dd44fc48e feat(local-recordings) drop old "local recordings" implementation
It's about to become very confusing, since we are going to add actual
local recordings with video.

This feature was never fully finalizeed since it required manual
processing of the files, as they were not uploaded anywhere.

In addition, unless one opens the local audio device without any audio
processing first, any tracks opened later will have audio proceessing
turned on, something not desirable for the scenario this feature was
designed for in the first place: podcasts.

This feature will likely come back as a JaaS demo / MVP where the local
recording is made outside of the Jitsi Meet iframe.
2022-05-03 14:40:12 +02:00
Saúl Ibarra Corretgé de7c9bd001 fix(rn,screen-sharing) don't disable button when in audio-only mode
Just like the web.
2022-05-03 14:02:50 +02:00
Saúl Ibarra Corretgé 1c79e6baa3 fix(rn,lobby) use a header for the main lobby screen
It allows us to place the Cancel button there, and declutter the UI of
buttons.
2022-05-02 16:29:40 +02:00
Saúl Ibarra Corretgé d78e8fba25 fix(rn,lobby) match button style 2022-05-02 16:29:40 +02:00
Saúl Ibarra Corretgé 721f4dc3d3 feat(rn,ui) use dark gray for screen headers
Skip the welcome page for now, until we can remove the audio / video
toggle.
2022-05-02 16:01:40 +02:00
Saúl Ibarra Corretgé 625206db20 fix(rn,speakerstats) fix not rendering stats 2022-05-02 16:01:13 +02:00
Дамян Минков 7cd5708ea7
fix: Fixes loading recommendedBrowsers page. (#11465)
* fix: Fixes loading recommendedBrowsers page.

Fixes loading the page and its resources when using html base (cdn).
2022-04-29 12:02:05 -05:00
William Liang d3fe246f61
refactor(multi-stream) refactor virtual screenshare creation and support plan-b clients (#11445)
* fix(multi-stream) update selector to find ss track by videoType or mediaType

* ref(multi-stream) move fake ss creation logic and support video type changed

* refactor(multi-stream) decouple sending and receiving multiple screenshare streams

* fix(multi-stream) fix receiver constraints with signaling and without multi-stream

* fix(mutli-stream) ensure plan b original SS thumbnail displays avatar

* fix(multi-stream) show fake SS for plan b sender

* refactor(multi-stream) poc for moving SS creation to state listener

* remove reference to fake SS creation

* fix lint errors

* rename to virtual screenshare participants

* fix minor bugs

* rename participant subscriber to specify web support only
2022-04-29 10:32:16 -04:00
Saúl Ibarra Corretgé b9c4d28dac fix(auth) fix WaitForOwnerDialog not vanishing
Since all the auth logic is not ported to React on the web,
`_isWaitingForOwner` will always return `false` because the
`waitForOwner()` action is not (yet) used there.

THis fix always tries to hide the dialog no matter what, which is not a
Bad Thing to do anyway.

There is a related bug remaining, however: if one pressed "I am the
host" and then cancel, it doesn't goo back to the previous dialog, but
it completely kils the meeting. This is a compromise we'll have to live
with for a bit longer.

Fixes: https://github.com/jitsi/jitsi-meet/issues/11413
Fixes: https://github.com/jitsi/jitsi-meet/issues/11432
2022-04-29 14:58:22 +02:00
Mihaela Dumitru 02aca27c46
feat(external-api) add breakout room configs to hide auto assign and footer menu buttons (#11443)
* hideAutoAssignButton
* hideFooterMenu
* hideModeratorSettingsTab
* hideMoreActionsButton
* hideMuteAllButton
2022-04-29 12:30:49 +03:00
Saúl Ibarra Corretgé 0ad6bd4d83 fix(dialog) remove obsolete prop no longer used in web 2022-04-29 10:40:21 +02:00
Saúl Ibarra Corretgé 8e65fab544 fix(virtual-background) don't treat timeout as fatal failure
If downloading the model tiemouts, it may succeed in the (near) future,
don't just give up.
2022-04-29 10:07:26 +02:00
pangrr f62cb7a0c7
Fix(multi-stream) fix an issue where avatar shows up occasionally.
* fix occasional unexpected avatar

* fix ss stats popover not shown

* fix linter issue
2022-04-28 18:25:45 -04:00
Mihaela Dumitru 72111114b6
fix(breakout-rooms) reset rooms when conference is left or failed (#11447) 2022-04-28 11:34:23 +03:00
Hristo Terezov 550c730ed4 fix(tile-view):Recalculate on window height change 2022-04-28 08:35:39 +02:00
Robert Pintilii a84d7c17fa
fix(avatar) Center phone icon in participants pane avatars (#11440) 2022-04-27 10:53:58 +03:00
pangrr c03d86e0e3
fix: disabled connectStatusIndicatorIcon cause video not displayed (#11377)
* add and remove JitsiTrackEvents.TRACK_STREAMING_STATUS_CHANGED listener in middlewares

* add/remove listeners in components that use track streaming status

* remove track streaming status handler from ConnectionIndicatorIcon and ConnectionIndicatorContent

* check video track change before hanlding track streaming status
2022-04-26 15:33:50 -05:00
Horatiu Muresan 20f6ba1736 fix(premeeting) Detach premeeting toolbar buttons visibility
- if hiddenPremeetingButtons is undefined, toolbarButtons overwrite decides what buttons to show
- if hiddenPremeetingButtons is empty array, all buttons are show on premeeting screen regardless of toolbarButtons
- if hiddenPremeetingButtons hides some buttons, only those buttons will be hidden regardless of toolbarButtons overwrite
2022-04-26 15:33:09 +03:00
Horatiu Muresan eb64ea6aba
fix(always-on-top) Fix audio mute button disabled status 2022-04-26 15:32:18 +03:00
Calin Chitu 3e004811e0 feat(lobby/native) LobbyScreen and LobbyChatScreen 2022-04-26 14:55:15 +03:00
Jaya Allamsetty 4315e19780
fix(device-selection) Enable device selection on mobile Safari. (#11427)
* fix(device-selection) Enable device selection on mobile Safari.
With https://bugs.webkit.org/show_bug.cgi?id=179363 being fixed, we should now be able to switch between devices in call. Also, before the webkit fix, we were able to continue to use the old track when a new track was created for preview in device settings before joining the call. This doesn't work anymore after the fix. Therefore, always replace the track in redux even if the selected device hasn't changed. Depends on https://github.com/jitsi/lib-jitsi-meet/pull/1993.

* chore(deps): update lib-jitsi-meet@latest.
2022-04-25 15:01:10 -04:00
Saúl Ibarra Corretgé 4d2bd932a7 fix(lastN) fix last N getting stuck on 1
If last N goes down to 1 it will be stuck there since it's > 0 and will
be our `lastNSelected`. When limits are applied we'll take the minimum,
so it will end up being 1.

Once can end up in last N being 1 by several means, the more obvious one
by entering Picture-in-Picture mode on mobile.

Fix it by not using the previous last N value for the current
calculation, at all.

Fixes: https://github.com/jitsi/jitsi-meet/issues/10257
Closes: https://github.com/jitsi/jitsi-meet/pull/10491
2022-04-25 17:44:54 +02:00
Robert Pintilii 97b958e9ea Fix import and naming 2022-04-21 09:01:51 -05:00
Robert Pintilii b00fc92ee6 Native fix 2022-04-21 09:01:51 -05:00
Robert Pintilii f9d1003527 Fixes 2022-04-21 09:01:51 -05:00
robertpin 0abefa87aa ref(stage-filmstrip) Refactor as new layout
Fixes screensharing selection issues. Now when there’s a screen share we just use the old VERTICAL_FILMSTRIP_VIEW layout
Add THUMBAIL_TYPE to determine how to display thumbnails
2022-04-21 09:01:51 -05:00
Gabriel Borlea dde8c586da
feat(external-api): add toggle subtitles command (#10070)
* feat(external-api): add toggle subtitles command

* feat(external-api): add set subtitles command
2022-04-20 11:43:18 +03:00
Hristo Terezov 4153097cc9 fix(prejoin):Disable device selection on iosSafari
It seems that showing the device selection dialog on ios Safari will
leads to not working audio. This is temporary fix until we find out
better solution.
2022-04-19 15:32:45 -05:00
Hristo Terezov 2a5be074d0 fix(video-layout): functions imports. 2022-04-19 15:15:44 -05:00
Horatiu Muresan dbc8f21b01
fix(hangup-button) Add to notify toolbar button clicked 2022-04-19 13:26:07 +03:00
William Liang 5ebe308953 fix(multi-stream) add screenshare display name to i18n 2022-04-18 17:37:22 -05:00
Jaya Allamsetty 7420113079 fix(multi-stream) Do not show join notifications for SS tiles. 2022-04-18 13:19:17 -04:00
Hristo Terezov 221ecac12d feat(tile-vew): Calculate maxColumns dynamically 2022-04-18 11:19:58 -05:00
Jaya Allamsetty 744607a5cc fix(stageFilmstrip) Disable stage filmstrip by default. 2022-04-18 09:57:25 -05:00
Horatiu Muresan 8f641b7bb1 fix(start-silent) Disable AOT mic and unmute notif when start silent 2022-04-18 17:17:51 +03:00
Дамян Минков bbfe7b4f32 fix: Skips clearing tracks on conference failed.
In case of conference failed as max number of occupants reached, we should skip clearing the local tracks to keep state of pre-join screen. Otherwise, on join we will join muted even though on prejoin screen it was unmuted on the initial attempt.
2022-04-15 08:48:26 -05:00
William Liang 4a375aa2a4
fix(multi-stream) update screenshare display name (#11376) 2022-04-14 13:07:17 -04:00
Robert Pintilii a6ad592d25
feat(reactions) Open reactions menu on hover instead of click (#11364)
Fixed issue on DialogPortal where the content would flash to the initial position then move to the correct position
2022-04-13 16:18:54 +03:00
Saúl Ibarra Corretgé 00bb013373 misc(rn,app) log navigation target 2022-04-12 17:12:05 +02:00
Calinteodor 95baf34ba6
feat(participants-pane/native) adjusted styles for when local p is not a moderator (#11349)
* feat(participants-pane/native) adjusted styles for when local p is not a moderator
2022-04-12 14:45:27 +03:00
Saúl Ibarra Corretgé 64385d48e9 fix(security) hide button if the enabled flag is set to false 2022-04-12 12:26:35 +02:00
Saúl Ibarra Corretgé 5d8c87eb76 fix(rn,config) fix loading config due to broken import 2022-04-12 10:53:47 +02:00
Robert Pintilii 8bf42e79a0
fix(stage-filmstrip) Fix issues (#11360)
Fix dominant speaker not removed on leave
Fix video not shown in vertical filmstrip when a remote screensharing was on
Refactor pin/ unpin. Add click to unpin
Remove from stage on unpin, except dominant (just change pin state)
Fix local shows video on both stage and vertical filmstrip
Don't reorder on stage base on queue (sort all by id)
2022-04-12 09:57:01 +03:00
Дамян Минков 930852cd88 fix: Adds testId for context menu items and ids to some components.
Needed to revive the lobby tests.
2022-04-11 13:21:48 -05:00
Дамян Минков fcc8e98aad Revert "fix(avatar): add ZWNJ between initials of letter avatars"
This reverts commit 6085220bfc.
2022-04-11 11:17:49 -05:00
Shahab 6085220bfc fix(avatar): add ZWNJ between initials of letter avatars 2022-04-11 14:11:58 +02:00
Gabriel Borlea 0259d1c260
feat(rtc-stats) add timestamp to face landmarks when sending to rtc stats 2022-04-11 11:26:31 +02:00
William Liang c246174555 fix(multi-stream) use highest video quality for screenshare 2022-04-08 15:18:32 -04:00
William Liang 0cf1b7e3d9 fix(multi-stream) fix screenshare auto pin bug 2022-04-08 12:57:39 -04:00
Saúl Ibarra Corretgé 3097ac8cc4 fix(ios) fix not showing the CarPlay audio interface 2022-04-08 17:29:53 +02:00
Calinteodor 7c523f3250
language(typescript) actionTypes.js -> actionTypes.ts (#10940)
* language(typescript) first ts component, added ts configurations, actionTypes.js are now ts files
2022-04-08 15:24:58 +03:00
Avram Tudor ceb8d3348d
feat(face-landmarks) add API event for providing face landmark data (#11347) 2022-04-08 10:12:38 +03:00
William Liang ae6454c59c fix(multi-stream) only create local ss particpant with multi-stream enabled 2022-04-07 12:17:56 -04:00
Calinteodor 41c068feaf
feat(chat/web) fixed 2 byte char duplication (#11332)
* feat(chat/web) fixed for 2 byte char duplication on Chat
2022-04-07 17:03:07 +03:00
Gabriel Borlea 856ef757d4
fix(face-landmarks): get face models from node_modules instead of having resoruces folder (#11326) 2022-04-07 13:46:04 +03:00
Gabriel Borlea 1fbbe7bc46
fix(speaker-stats): get realtime local face expressions (#11334)
* fix(speaker-stats): get realtime local face expressions

* code review
2022-04-07 13:02:43 +03:00
Calin Chitu ec78cf2784 feat(conference/native) - hide label in one to one meeting 2022-04-07 10:43:37 +02:00
Saúl Ibarra Corretgé bdd8400057 fix(rn) remove no longer needed hack
RN no longer logs pprops in release builds.
2022-04-07 10:35:51 +02:00
Saúl Ibarra Corretgé 23f40db889 feat(rn,deps) update React Native to 0.67 2022-04-07 10:35:51 +02:00
Saúl Ibarra Corretgé a451923ec9 fix(rn,polyfills) remove no longer needed polyfill 2022-04-07 10:35:51 +02:00
Robert Pintilii c05a983c98
feat(stage-filmstrip) Added user configurable max (#11324)
The user can set the max number of participants that can be displayed on stage
Send the number on follow me to all participants
2022-04-07 11:31:53 +03:00
Дамян Минков 6687c3f4ab fix: Adds undefined check to avoid error.
Was breaking DisableSelfViewTest.
2022-04-06 12:30:05 -05:00
Avram Tudor 42703fed47
ref(face-landmarks) refactor namings (#11307)
* ref(face-landmarks) refactor namings

* code review
2022-04-06 12:10:31 +03:00
Дамян Минков a99532b0d8
fix: leaking listeners while waiting on auth dialog (#11288)
* fix: Drop duplicate call of wait for owner.

* fix: Fixes leaking listeners while waiting for host to join.

While waiting for the host to join on the dialog we attempt to join over and over again till we are admitted to enter the meeting. While doing that authRequired flag is on, and we were adding listeners on and on.

* feat: Introduces conference join in progress action.

This event is coming from lib-jitsi-meet and is fired when we receive the first presence of series when joining. It is always fired before joined event.

* fix: Moves testing middleware to use CONFERENCE_JOIN_IN_PROGRESS.

* fix: Moves follow-me middleware to use CONFERENCE_JOIN_IN_PROGRESS.

* fix: Moves some polls logic to middleware and use CONFERENCE_JOIN_IN_PROGRESS.

* fix: Moves reactions middleware to use CONFERENCE_JOIN_IN_PROGRESS.

* fix: Moves recordings middleware to use CONFERENCE_JOIN_IN_PROGRESS.

* fix: Moves shared-video middleware to use CONFERENCE_JOIN_IN_PROGRESS.

* fix: Moves videosipgw middleware to use CONFERENCE_JOIN_IN_PROGRESS.

* squash: Fix comments.

* fix: Fixes join in progress on web.

* fix: Moves variable extraction inside handlers.

* fix: Moves variable extraction inside handlers again.

* fix: Moves etherpad middleware to use CONFERENCE_JOIN_IN_PROGRESS.
2022-04-05 21:13:39 -05:00
William Liang eb716af29b fix(multi-stream) support screenshare tile in stage filmstrip 2022-04-05 17:09:08 -04:00
Robert Pintilii d7c8164b74
fix(follow-me) Make follow me work with stage filmstrip (#11306)
On follow me enabled all participants will see the participants pinned by the moderator
Fix pinned indicator to work when stage filmstrip is disabled
Fix add participant on dominant speaker change: if the participant was already pinned keep it as pinned
Don’t add local participant on stage (on automatic selection)
2022-04-05 16:00:32 +03:00
Robert Pintilii ed9b85f287
ref(overflow-menu) Use ContextMenu component (#11282)
refactor overflow menu to use ContextMenu component
refactor toolboxItem to use ContextMenuItem when needed
2022-04-05 15:19:03 +03:00
Jaya Allamsetty 0713240c3d feat(multi-stream) Whitelist config flags for multi-stream. 2022-04-04 14:58:50 -04:00
William Liang 70090fd716
feat(multi-stream) Add fake participant tile for screen share.
prioritize participants with screen shares
support local screen share track
auto pin screen share
support screen share for large video
ensure fake screen share participants are sorted
fix local screen share in vertical filmstrip
fix local screen share in tile mode
use FakeScreenShareParticipant component for screen share thumbnails
ensure changes are behind feature flag and update jsdocs
fix bug where local screen share was not rendering
update receiver constraints to include SS source names
remove fake ss participant creation on track update
fix: handle screenshare muted change and track removal
refactor: update key values for sortedFakeScreenShareParticipants
address PR comments
refactor getter for screenshare tracks
rename state to sortedRemoteFakeScreenShareParticipants
2022-04-04 14:57:58 -04:00
Avram Tudor 2c165d4313
feat(face-landmarks) merge face expressions and face centering (#11283)
* feat(face-landmarks) merge face expressions and face centering

* code review

* code review

* code review
2022-04-04 16:09:14 +03:00
Robert Pintilii 4b84f71021
fix(filmstrip) Fix resizing on chat toggle (#11305)
Fix pinned indicator to be displayed only for pinned participants
2022-04-04 15:39:32 +03:00
Calin Chitu d415d02f35 feat(participants-pane/native) adjusted styles for participants container 2022-04-04 14:10:12 +03:00
Robert Pintilii c2399deb55
ref(AOT) Change buttons to not use abstract classes (#11302)
This reduces the bundle size by about 100KB
It also decouples the AOT buttons from the classes that are used to implement other features
2022-04-04 13:38:49 +03:00
Avram Tudor 3443d256f2
fix(highlights) allow highlighting moments if recording is running (#11301) 2022-04-04 12:08:11 +03:00