haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/qa/libs/kimath/geometry/test_shape_line_chain.cpp

518 lines
22 KiB
C++
Raw Normal View History

pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
We don't keep a CHANGELOG.TXT Direct interested readers to AUTHORS.TXT instead.
2021-10-06 02:46:53 +00:00
* Copyright (C) 2019-2021 KiCad Developers, see AUTHORS.TXT for contributors.
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
#include <geometry/shape_arc.h>
#include <geometry/shape_line_chain.h>
Implement SHAPE_LINE_CHAIN::DetectArcs and add qa test
2021-03-14 20:28:49 +00:00
#include <trigo.h>
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
qa: merge unit_test_utils to qa_utils
2021-02-06 22:20:31 +00:00
#include <qa_utils/geometry/geometry.h>
#include <qa_utils/numeric.h>
#include <qa_utils/wx_utils/unit_test_utils.h>
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
#include "geom_test_utils.h"
Add tests for shape_line_chain collision containing arcs
2021-11-01 19:45:29 +00:00
/**
* NOTE: Collision of SHAPE_LINE_CHAIN with arcs is tested in test_shape_arc.cpp
*/
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
BOOST_AUTO_TEST_SUITE( ShapeLineChain )
BOOST_AUTO_TEST_CASE( ArcToPolyline )
{
SHAPE_LINE_CHAIN base_chain( { VECTOR2I( 0, 0 ), VECTOR2I( 0, 1000 ), VECTOR2I( 1000, 0 ) } );
SHAPE_LINE_CHAIN chain_insert( {
VECTOR2I( 0, 1500 ),
VECTOR2I( 1500, 1500 ),
VECTOR2I( 1500, 0 ),
} );
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
SHAPE_LINE_CHAIN arc_insert1( SHAPE_ARC( VECTOR2I( 0, -100 ), VECTOR2I( 0, -200 ), 180.0 ) );
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
SHAPE_LINE_CHAIN arc_insert2( SHAPE_ARC( VECTOR2I( 0, 500 ), VECTOR2I( 0, 400 ), 180.0 ) );
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
BOOST_CHECK_EQUAL( base_chain.CShapes().size(), base_chain.CPoints().size() );
BOOST_CHECK_EQUAL( arc_insert1.CShapes().size(), arc_insert1.CPoints().size() );
BOOST_CHECK_EQUAL( arc_insert2.CShapes().size(), arc_insert2.CPoints().size() );
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( arc_insert1 ) );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( arc_insert2 ) );
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
base_chain.Insert( 0, SHAPE_ARC( VECTOR2I( 0, -100 ), VECTOR2I( 0, -200 ), 1800 ) );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
BOOST_CHECK_EQUAL( base_chain.CShapes().size(), base_chain.CPoints().size() );
base_chain.Replace( 0, 2, chain_insert );
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
BOOST_CHECK_EQUAL( base_chain.CShapes().size(), base_chain.CPoints().size() );
}
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
// Similar test to above but with larger coordinates, so we have more than one point per arc
BOOST_AUTO_TEST_CASE( ArcToPolylineLargeCoords )
{
SHAPE_LINE_CHAIN base_chain( { VECTOR2I( 0, 0 ), VECTOR2I( 0, 100000 ), VECTOR2I( 100000, 0 ) } );
SHAPE_LINE_CHAIN chain_insert( {
VECTOR2I( 0, 1500000 ),
VECTOR2I( 1500000, 1500000 ),
VECTOR2I( 1500000, 0 ),
} );
base_chain.Append( SHAPE_ARC( VECTOR2I( 200000, 0 ), VECTOR2I( 300000, 100000 ), 180.0 ) );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
BOOST_CHECK_EQUAL( base_chain.PointCount(), 11 );
base_chain.Insert( 9, VECTOR2I( 250000, 0 ) );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
BOOST_CHECK_EQUAL( base_chain.PointCount(), 12 );
BOOST_CHECK_EQUAL( base_chain.ArcCount(), 2 ); // Should have two arcs after the split
base_chain.Replace( 5, 6, chain_insert );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
BOOST_CHECK_EQUAL( base_chain.PointCount(), 13 ); // Adding 3 points, removing 2
BOOST_CHECK_EQUAL( base_chain.ArcCount(), 3 ); // Should have three arcs after the split
base_chain.Replace( 4, 6, VECTOR2I( 550000, 0 ) );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
BOOST_CHECK_EQUAL( base_chain.PointCount(), 11 ); // Adding 1 point, removing 3
BOOST_CHECK_EQUAL( base_chain.ArcCount(), 3 ); // Should still have three arcs
Implement ClearArcs() and check curved polys don't get a booleanOp We cannot (yet) support passing several curved outlines through clipper. In these cases, the caller should ClearArcs() before processing.
2021-06-19 14:53:49 +00:00
// Test ClearArcs
base_chain.SetClosed( true );
double areaPriorToArcRemoval = base_chain.Area();
base_chain.ClearArcs();
BOOST_CHECK( GEOM_TEST::IsOutlineValid( base_chain ) );
Fix SHAPE_LINE_CHAIN::Simplify() when there are only 3 points in the chain We weren't updating m_shapes properly. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11695 (cherry picked from commit 1fa1b44d0233b7cba3c39a305be19b21a9eaacf2)
2022-08-19 19:49:10 +00:00
BOOST_CHECK_EQUAL( base_chain.CPoints().size(), base_chain.CShapes().size() );
Implement ClearArcs() and check curved polys don't get a booleanOp We cannot (yet) support passing several curved outlines through clipper. In these cases, the caller should ClearArcs() before processing.
2021-06-19 14:53:49 +00:00
BOOST_CHECK_EQUAL( base_chain.PointCount(), 11 ); // We should have the same number of points
BOOST_CHECK_EQUAL( base_chain.ArcCount(), 0 ); // All arcs should have been removed
BOOST_CHECK_EQUAL( base_chain.Area(), areaPriorToArcRemoval ); // Area should not have changed
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
}
SHAPE_LINE_CHAIN: Only fix up arc indices if last pt is part of an arc Fixes https://gitlab.com/kicad/code/kicad/-/issues/9843
2021-12-03 18:26:50 +00:00
// Test that duplicate point gets removed when line is set to be closed
BOOST_AUTO_TEST_CASE( SetClosedDuplicatePoint )
{
// Test from issue #9843
SHAPE_LINE_CHAIN chain;
chain.Append(
SHAPE_ARC( { -859598, 2559876 }, { -1632771, 1022403 }, { -3170244, 249230 }, 0 ) );
chain.Append(
SHAPE_ARC( { -3170244, -1657832 }, { -292804, -317564 }, { 1047464, 2559876 }, 0 ) );
chain.Append( VECTOR2I( -859598, 2559876 ) ); // add point that is equal to first arc start
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
BOOST_CHECK_EQUAL( chain.PointCount(), 31 );
// CLOSED CHAIN
chain.SetClosed( true );
Fix SHAPE_LINE_CHAIN::Simplify() when there are only 3 points in the chain We weren't updating m_shapes properly. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11695 (cherry picked from commit 1fa1b44d0233b7cba3c39a305be19b21a9eaacf2)
2022-08-19 19:49:10 +00:00
BOOST_CHECK_EQUAL( chain.CPoints().size(), chain.CShapes().size() );
SHAPE_LINE_CHAIN: Only fix up arc indices if last pt is part of an arc Fixes https://gitlab.com/kicad/code/kicad/-/issues/9843
2021-12-03 18:26:50 +00:00
BOOST_CHECK_EQUAL( chain.PointCount(), 30 ); // (-1) should have removed coincident points
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
}
Fix SHAPE_LINE_CHAIN::Simplify() when there are only 3 points in the chain We weren't updating m_shapes properly. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11695 (cherry picked from commit 1fa1b44d0233b7cba3c39a305be19b21a9eaacf2)
2022-08-19 19:49:10 +00:00
// Test that duplicate point gets removed when we call simplify
BOOST_AUTO_TEST_CASE( SimplifyDuplicatePoint )
{
SHAPE_LINE_CHAIN chain;
chain.Append( { 100, 100 } );
chain.Append( { 100, 100 }, true ); //duplicate point to simplify
chain.Append( { 200, 100 } );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
BOOST_CHECK_EQUAL( chain.PointCount(), 3 );
chain.Simplify();
BOOST_CHECK_EQUAL( chain.CPoints().size(), chain.CShapes().size() );
BOOST_CHECK_EQUAL( chain.PointCount(), 2 ); // (-1) should have removed coincident points
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
}
SHAPE_LINE_CHAIN splitArc on Insert, Remove and Replace This ensures that the arc shapes remain correct after removing a point belonging to an arc or inserting a point in the middle of an arc. Simplify implementation of Replace( ..., aP ). Now a Remove operation followed by an Insert operation. Improve QA test for SHAPE_LINE_CHAIN Append, Insert and Replace Implement SHAPE_LINE_CHAIN::splitArc to break up an arc into two Implement SHAPE_ARC::ConstructFromStartEndCenter and add qa test
2021-05-09 22:27:02 +00:00
Add SHAPE_LINE_CHAIN tests for arcs with shared points
2021-11-20 15:57:58 +00:00
// Test special case where the last arc in the chain has a shared point with the first arc
SHAPE_LINE_CHAIN: Only fix up arc indices if last pt is part of an arc Fixes https://gitlab.com/kicad/code/kicad/-/issues/9843
2021-12-03 18:26:50 +00:00
BOOST_AUTO_TEST_CASE( ArcWrappingToStartSharedPoints )
Add SHAPE_LINE_CHAIN tests for arcs with shared points
2021-11-20 15:57:58 +00:00
{
// represent a circle with two semicircular arcs
SHAPE_ARC arc1( VECTOR2I( 100000, 0 ), VECTOR2I( 0, 100000 ), VECTOR2I( -100000, 0 ), 0 );
SHAPE_ARC arc2( VECTOR2I( -100000, 0 ), VECTOR2I( 0, -100000 ), VECTOR2I( 100000, 0 ), 0 );
// Start a chain with the two arcs
SHAPE_LINE_CHAIN chain;
chain.Append( arc1 );
chain.Append( arc2 );
BOOST_CHECK_EQUAL( chain.PointCount(), 13 );
//BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
// OPEN CHAIN
// Start of the chain is not yet a shared point, so can't be an arc end either
BOOST_CHECK_EQUAL( chain.IsSharedPt( 0 ), false );
BOOST_CHECK_EQUAL( chain.IsArcEnd( 0 ), false );
BOOST_CHECK_EQUAL( chain.IsArcStart( 0 ), true );
// Index 6 is the shared point between the two arcs in the middle of the chain
BOOST_CHECK_EQUAL( chain.IsSharedPt( 6 ), true );
BOOST_CHECK_EQUAL( chain.IsArcEnd( 6 ), true );
BOOST_CHECK_EQUAL( chain.IsArcStart( 6 ), true );
// End index is not yet a shared point
int endIndex = chain.PointCount() - 1;
BOOST_CHECK_EQUAL( chain.IsSharedPt( endIndex ), false );
BOOST_CHECK_EQUAL( chain.IsArcEnd( endIndex ), true );
BOOST_CHECK_EQUAL( chain.IsArcStart( endIndex ), false );
for( int i = 0; i < chain.PointCount(); i++ )
{
BOOST_CHECK_EQUAL( chain.IsPtOnArc( i ), true ); // all points in the chain are arcs
}
// CLOSED CHAIN
chain.SetClosed( true );
BOOST_CHECK_EQUAL( chain.PointCount(), 12 ); // (-1) should have removed coincident points
//BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
// Start of the chain should be a shared point now, so can't be an arc end either
BOOST_CHECK_EQUAL( chain.IsSharedPt( 0 ), true );
BOOST_CHECK_EQUAL( chain.IsArcEnd( 0 ), true );
BOOST_CHECK_EQUAL( chain.IsArcStart( 0 ), true );
// Index 6 is the shared point between the two arcs in the middle of the chain
BOOST_CHECK_EQUAL( chain.IsSharedPt( 6 ), true );
BOOST_CHECK_EQUAL( chain.IsArcEnd( 6 ), true );
BOOST_CHECK_EQUAL( chain.IsArcStart( 6 ), true );
// End index is in the middle of an arc, so not an end point or shared point
endIndex = chain.PointCount() - 1;
BOOST_CHECK_EQUAL( chain.IsSharedPt( endIndex ), false );
BOOST_CHECK_EQUAL( chain.IsArcEnd( endIndex ), false );
BOOST_CHECK_EQUAL( chain.IsArcStart( endIndex ), false );
}
Fix SHAPE_LINE_CHAIN::Split when inserting a point on an arc Ensure the arc is split into two at the point specified. Partly fixes https://gitlab.com/kicad/code/kicad/-/issues/9023 Additional work required to ensure that the shove state is preserved.
2021-09-25 18:36:51 +00:00
// Test SHAPE_LINE_CHAIN::Split()
BOOST_AUTO_TEST_CASE( Split )
{
SEG seg1( VECTOR2I( 0, 100000 ), VECTOR2I( 50000, 0 ) );
SEG seg2( VECTOR2I( 200000, 0 ), VECTOR2I( 300000, 0 ) );
SHAPE_ARC arc( VECTOR2I( 200000, 0 ), VECTOR2I( 300000, 0 ), 180.0 );
// Start a chain with 2 points (seg1)
SHAPE_LINE_CHAIN chain( { seg1.A, seg1.B } );
BOOST_CHECK_EQUAL( chain.PointCount(), 2 );
// Add first arc
chain.Append( arc );
BOOST_CHECK_EQUAL( chain.PointCount(), 9 );
// Add two points (seg2)
chain.Append( seg2.A );
chain.Append( seg2.B );
BOOST_CHECK_EQUAL( chain.PointCount(), 11 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
BOOST_TEST_CONTEXT( "Case 1: Point not in the chain" )
{
SHAPE_LINE_CHAIN chainCopy = chain;
BOOST_CHECK_EQUAL( chainCopy.Split( VECTOR2I( 400000, 0 ) ), -1 );
BOOST_CHECK_EQUAL( chainCopy.PointCount(), chain.PointCount() );
BOOST_CHECK_EQUAL( chainCopy.ArcCount(), chain.ArcCount() );
}
BOOST_TEST_CONTEXT( "Case 2: Point close to start of a segment" )
{
SHAPE_LINE_CHAIN chainCopy = chain;
VECTOR2I splitPoint = seg1.A + VECTOR2I( 5, -10 );
BOOST_CHECK_EQUAL( chainCopy.Split( splitPoint ), 1 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chainCopy ) );
BOOST_CHECK_EQUAL( chainCopy.GetPoint( 1 ), splitPoint );
BOOST_CHECK_EQUAL( chainCopy.PointCount(), chain.PointCount() + 1 ); // new point added
BOOST_CHECK_EQUAL( chainCopy.ArcCount(), chain.ArcCount() );
}
BOOST_TEST_CONTEXT( "Case 3: Point exactly on the segment" )
{
SHAPE_LINE_CHAIN chainCopy = chain;
VECTOR2I splitPoint = seg1.B;
BOOST_CHECK_EQUAL( chainCopy.Split( splitPoint ), 1 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chainCopy ) );
BOOST_CHECK_EQUAL( chainCopy.GetPoint( 1 ), splitPoint );
BOOST_CHECK_EQUAL( chainCopy.PointCount(), chain.PointCount() );
BOOST_CHECK_EQUAL( chainCopy.ArcCount(), chain.ArcCount() );
}
BOOST_TEST_CONTEXT( "Case 4: Point at start of arc" )
{
SHAPE_LINE_CHAIN chainCopy = chain;
VECTOR2I splitPoint = arc.GetP0();
BOOST_CHECK_EQUAL( chainCopy.Split( splitPoint ), 2 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chainCopy ) );
BOOST_CHECK_EQUAL( chainCopy.GetPoint( 2 ), splitPoint );
BOOST_CHECK_EQUAL( chainCopy.PointCount(), chain.PointCount() );
BOOST_CHECK_EQUAL( chainCopy.ArcCount(), chain.ArcCount() );
}
BOOST_TEST_CONTEXT( "Case 5: Point close to start of arc" )
{
SHAPE_LINE_CHAIN chainCopy = chain;
VECTOR2I splitPoint = arc.GetP0() + VECTOR2I( -10, 130 );
BOOST_CHECK_EQUAL( chainCopy.Split( splitPoint ), 3 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chainCopy ) );
BOOST_CHECK_EQUAL( chainCopy.GetPoint( 3 ), splitPoint );
BOOST_CHECK_EQUAL( chainCopy.IsSharedPt( 3 ), true ); // must be a shared point
BOOST_CHECK_EQUAL( chainCopy.PointCount(), chain.PointCount() + 1 ); // new point added
BOOST_CHECK_EQUAL( chainCopy.ArcCount(), chain.ArcCount() + 1 ); // new arc should have been created
}
}
Add qa Test for SHAPE_LINE_CHAIN::Slice
2021-08-03 19:12:32 +00:00
// Test SHAPE_LINE_CHAIN::Slice()
BOOST_AUTO_TEST_CASE( Slice )
{
SEG targetSegment( VECTOR2I( 200000, 0 ), VECTOR2I( 300000, 0 ) );
SHAPE_ARC firstArc( VECTOR2I( 200000, 0 ), VECTOR2I( 300000, 0 ), 180.0 );
SHAPE_ARC secondArc( VECTOR2I( -200000, -200000 ), VECTOR2I( -300000, -100000 ), -180.0 );
int tol = SHAPE_ARC::DefaultAccuracyForPCB(); // Tolerance for arc collisions
// Start a chain with 3 points
SHAPE_LINE_CHAIN chain( { VECTOR2I( 0, 0 ), VECTOR2I( 0, 100000 ), VECTOR2I( 100000, 0 ) } );
BOOST_CHECK_EQUAL( chain.PointCount(), 3 );
// Add first arc
chain.Append( firstArc );
BOOST_CHECK_EQUAL( chain.PointCount(), 10 );
// Add two points (target segment)
chain.Append( targetSegment.A );
chain.Append( targetSegment.B );
BOOST_CHECK_EQUAL( chain.PointCount(), 12 );
// Add a second arc
chain.Append( secondArc );
BOOST_CHECK_EQUAL( chain.PointCount(), 20 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
//////////////////////////////////////////////////////////
/// CASE 1: Start at arc endpoint, finish middle of arc /
//////////////////////////////////////////////////////////
BOOST_TEST_CONTEXT( "Case 1: Start at arc endpoint, finish middle of arc" )
{
SHAPE_LINE_CHAIN sliceResult = chain.Slice( 9, 18 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( sliceResult ) );
BOOST_CHECK_EQUAL( sliceResult.ArcCount(), 1 );
SHAPE_ARC sliceArc0 = sliceResult.Arc( 0 );
BOOST_CHECK_EQUAL( secondArc.GetP0(), sliceArc0.GetP0() ); // equal arc start points
BOOST_CHECK( secondArc.Collide( sliceArc0.GetArcMid(), tol ) );
BOOST_CHECK( secondArc.Collide( sliceArc0.GetP1(), tol ) );
BOOST_CHECK_EQUAL( sliceResult.PointCount(), 10 );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 0 ), firstArc.GetP1() ); // equal to arc end
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 1 ), targetSegment.A );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 2 ), targetSegment.B );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 3 ), sliceArc0.GetP0() ); // equal to arc start
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( 3 ), true );
for( int i = 4; i <= 8; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( i ), false );
for( int i = 3; i <= 7; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( i ), false );
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( 9 ), true );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 9 ), sliceArc0.GetP1() ); // equal to arc end
}
//////////////////////////////////////////////////////////////////
/// CASE 2: Start at middle of an arc, finish at arc startpoint /
//////////////////////////////////////////////////////////////////
BOOST_TEST_CONTEXT( "Case 2: Start at middle of an arc, finish at arc startpoint" )
{
SHAPE_LINE_CHAIN sliceResult = chain.Slice( 5, 12 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( sliceResult ) );
BOOST_CHECK_EQUAL( sliceResult.ArcCount(), 1 );
SHAPE_ARC sliceArc0 = sliceResult.Arc( 0 );
BOOST_CHECK_EQUAL( firstArc.GetP1(), sliceArc0.GetP1() ); // equal arc end points
BOOST_CHECK( firstArc.Collide( sliceArc0.GetArcMid(), tol ) );
BOOST_CHECK( firstArc.Collide( sliceArc0.GetP0(), tol ) );
BOOST_CHECK_EQUAL( sliceResult.PointCount(), 8 );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 0 ), sliceArc0.GetP0() );// equal to arc start
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( 0 ), true );
for( int i = 1; i <= 4; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( i ), false );
for( int i = 0; i <= 3; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( i ), false );
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( 4 ), true );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 4 ), sliceArc0.GetP1() ); // equal to arc end
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 5 ), targetSegment.A );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 6 ), targetSegment.B );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 7 ), secondArc.GetP0() );
}
//////////////////////////////////////////////////////////////////
/// CASE 3: Full arc, nothing else /
//////////////////////////////////////////////////////////////////
BOOST_TEST_CONTEXT( "Case 3: Full arc, nothing else" )
{
SHAPE_LINE_CHAIN sliceResult = chain.Slice( 3, 9 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( sliceResult ) );
BOOST_CHECK_EQUAL( sliceResult.ArcCount(), 1 );
SHAPE_ARC sliceArc0 = sliceResult.Arc( 0 );
// Equal arc to original inserted arc
BOOST_CHECK_EQUAL( firstArc.GetP1(), sliceArc0.GetP1() );
BOOST_CHECK_EQUAL( firstArc.GetArcMid(), sliceArc0.GetArcMid() );
BOOST_CHECK_EQUAL( firstArc.GetP1(), sliceArc0.GetP1() );
BOOST_CHECK_EQUAL( sliceResult.PointCount(), 7 );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 0 ), sliceArc0.GetP0() ); // equal to arc start
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( 0 ), true );
for( int i = 1; i <= 6; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( i ), false );
for( int i = 0; i <= 5; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( i ), false );
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( 6 ), true );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 6 ), sliceArc0.GetP1() ); // equal to arc end
}
//////////////////////////////////////////////////////////////////
/// CASE 4: Full arc, and straight segments to next arc start /
//////////////////////////////////////////////////////////////////
BOOST_TEST_CONTEXT( "Case 4: Full arc, and straight segments to next arc start" )
{
SHAPE_LINE_CHAIN sliceResult = chain.Slice( 3, 12 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( sliceResult ) );
BOOST_CHECK_EQUAL( sliceResult.ArcCount(), 1 );
SHAPE_ARC sliceArc0 = sliceResult.Arc( 0 );
// Equal arc to original inserted arc
BOOST_CHECK_EQUAL( firstArc.GetP1(), sliceArc0.GetP1() );
BOOST_CHECK_EQUAL( firstArc.GetArcMid(), sliceArc0.GetArcMid() );
BOOST_CHECK_EQUAL( firstArc.GetP1(), sliceArc0.GetP1() );
BOOST_CHECK_EQUAL( sliceResult.PointCount(), 10 );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 0 ), sliceArc0.GetP0() ); // equal to arc start
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( 0 ), true );
for( int i = 1; i <= 6; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcStart( i ), false );
for( int i = 0; i <= 5; i++ )
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( i ), false );
BOOST_CHECK_EQUAL( sliceResult.IsArcEnd( 6 ), true );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 6 ), sliceArc0.GetP1() ); // equal to arc end
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 7 ), targetSegment.A );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 8 ), targetSegment.B );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( 9 ), secondArc.GetP0() );
}
Fix SHAPE_LINE_CHAIN::Slice when end is an arc followed by a point Fixes https://gitlab.com/kicad/code/kicad/-/issues/9770
2021-11-25 15:05:27 +00:00
BOOST_TEST_CONTEXT( "Case 5: Chain ends in arc and point" )
{
SHAPE_LINE_CHAIN chainCopy = chain;
chainCopy.Append( VECTOR2I( 400000, 400000 ) );
SHAPE_LINE_CHAIN sliceResult = chainCopy.Slice( 11, -1 );
BOOST_CHECK_EQUAL( sliceResult.GetPoint( -1 ), VECTOR2I( 400000, 400000 ) );
}
Add qa Test for SHAPE_LINE_CHAIN::Slice
2021-08-03 19:12:32 +00:00
}
Fix SHAPE_LINE_CHAIN::NearestPoint when aAllowInternalShapePoints=false Fixes https://gitlab.com/kicad/code/kicad/-/issues/8770
2021-08-08 19:56:46 +00:00
// Test SHAPE_LINE_CHAIN::NearestPoint( VECTOR2I )
BOOST_AUTO_TEST_CASE( NearestPointPt )
{
SEG seg1( VECTOR2I( 0, 100000 ), VECTOR2I( 50000, 0 ) );
SEG seg2( VECTOR2I( 200000, 0 ), VECTOR2I( 300000, 0 ) );
SHAPE_ARC arc( VECTOR2I( 200000, 0 ), VECTOR2I( 300000, 0 ), 180.0 );
// Start a chain with 2 points (seg1)
SHAPE_LINE_CHAIN chain( { seg1.A, seg1.B } );
BOOST_CHECK_EQUAL( chain.PointCount(), 2 );
// Add first arc
chain.Append( arc );
BOOST_CHECK_EQUAL( chain.PointCount(), 9 );
// Add two points (seg2)
chain.Append( seg2.A );
chain.Append( seg2.B );
BOOST_CHECK_EQUAL( chain.PointCount(), 11 );
BOOST_CHECK( GEOM_TEST::IsOutlineValid( chain ) );
VECTOR2I ptOnArcCloseToStart( 297553, 31697 ); //should be index 3 in chain
VECTOR2I ptOnArcCloseToEnd( 139709, 82983 ); //should be index 6 in chain
BOOST_CHECK_EQUAL( chain.NearestPoint( ptOnArcCloseToStart, true ), ptOnArcCloseToStart );
BOOST_CHECK_EQUAL( chain.NearestPoint( ptOnArcCloseToStart, false ), arc.GetP0() );
BOOST_CHECK_EQUAL( chain.NearestPoint( ptOnArcCloseToEnd, true ), ptOnArcCloseToEnd );
BOOST_CHECK_EQUAL( chain.NearestPoint( ptOnArcCloseToEnd, false ), arc.GetP1() );
}
SHAPE_LINE_CHAIN::Replace Don't call front() or back() if empty Fixes https://gitlab.com/kicad/code/kicad/-/issues/8949
2021-08-12 15:32:06 +00:00
// Test SHAPE_LINE_CHAIN::Replace( SHAPE_LINE_CHAIN )
BOOST_AUTO_TEST_CASE( ReplaceChain )
{
BOOST_TEST_INFO( "8949 crash" );
std::vector<VECTOR2I> linePts = {
{ 206000000, 140110000 }, { 192325020, 140110000 }, { 192325020, 113348216 },
{ 192251784, 113274980 }, { 175548216, 113274980 }, { 175474980, 113348216 },
{ 175474980, 136694980 }, { 160774511, 121994511 }, { 160774511, 121693501 },
{ 160086499, 121005489 }, { 159785489, 121005489 }, { 159594511, 120814511 },
{ 160086499, 120814511 }, { 160774511, 120126499 }, { 160774511, 119153501 },
{ 160086499, 118465489 }, { 159113501, 118465489 }, { 158425489, 119153501 },
{ 158425489, 119645489 }, { 157325020, 118545020 }, { 157325020, 101925020 },
{ 208674980, 101925020 }, { 208674980, 145474980 }, { 192325020, 145474980 },
{ 192325020, 140110000 }
};
SHAPE_LINE_CHAIN baseChain( linePts, false );
baseChain.SetWidth( 250000 );
BOOST_CHECK_EQUAL( baseChain.PointCount(), linePts.size() );
SHAPE_LINE_CHAIN replaceChain( { VECTOR2I( 192325020, 140110000 ) }, false );
BOOST_CHECK_EQUAL( replaceChain.PointCount(), 1 );
baseChain.Replace( 1, 23, replaceChain );
BOOST_CHECK_EQUAL( baseChain.PointCount(), linePts.size() - ( 23 - 1 ) );
Fix SHAPE_LINE_CHAIN::Replace at end of chain
2021-08-13 20:52:11 +00:00
// Replacing the last point in a chain is special-cased
baseChain.Replace( baseChain.PointCount() - 1, baseChain.PointCount() - 1, VECTOR2I( -1, -1 ) );
BOOST_CHECK_EQUAL( baseChain.CLastPoint(), VECTOR2I( -1, -1 ) );
SHAPE_LINE_CHAIN::Replace Don't call front() or back() if empty Fixes https://gitlab.com/kicad/code/kicad/-/issues/8949
2021-08-12 15:32:06 +00:00
}
Fix SHAPE_LINE_CHAIN::NearestPoint when aAllowInternalShapePoints=false Fixes https://gitlab.com/kicad/code/kicad/-/issues/8770
2021-08-08 19:56:46 +00:00
pcbnew: Adding arcs to PNS This is allows ARCs in tracks to be synchronized with the PNS router. Note this does not yet include the UI components to route curved traces
2019-05-17 00:13:21 +00:00
BOOST_AUTO_TEST_SUITE_END()