haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove negation from PCB_BASE_FRAME::PlaceModule() parameter 

Negated parameters make code confusing. Now the parameter
description is accurate.
This commit is contained in:
Maciej Suminski 2018-03-05 16:27:07 +01:00
parent 4be12292a0
commit 0521b63503
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/pcb_base_frame.h
View File

@ -333,9 +333,9 @@ public:
* @param aModule A MODULE object point of the module to be placed.
* @param aDC A wxDC object point of the device context to draw \a aModule on
* or NULL if no display screen need updated.
* @param aDoNotRecreateRatsnest A bool true redraws the module rats nest.
* @param aRecreateRatsnest A bool true redraws the module rats nest.
*/
void PlaceModule( MODULE* aModule, wxDC* aDC, bool aDoNotRecreateRatsnest = false );
void PlaceModule( MODULE* aModule, wxDC* aDC, bool aRecreateRatsnest = true );
// module texts
void RotateTextModule( TEXTE_MODULE* Text, wxDC* DC );

2
pcbnew/dialogs/dialog_exchange_footprints.cpp
View File

@ -467,7 +467,7 @@ void PCB_EDIT_FRAME::Exchange_Module( MODULE* aOldModule,
/* place module without ratsnest refresh: this will be made later
* when all modules are on board */
PlaceModule( aNewModule, NULL, true );
PlaceModule( aNewModule, NULL, false );
// Copy full placement and pad net names (when possible)
// but not local settings like clearances (use library values)

4
pcbnew/pcb_footprint_edit_utils.cpp
View File

@ -349,7 +349,7 @@ void PCB_EDIT_FRAME::Change_Side_Module( MODULE* Module, wxDC* DC )
}
void PCB_BASE_FRAME::PlaceModule( MODULE* aModule, wxDC* aDC, bool aDoNotRecreateRatsnest )
void PCB_BASE_FRAME::PlaceModule( MODULE* aModule, wxDC* aDC, bool aRecreateRatsnest )
{
wxPoint newpos;
@ -413,7 +413,7 @@ void PCB_BASE_FRAME::PlaceModule( MODULE* aModule, wxDC* aDC, bool aDoNotRecreat
m_Pcb->GetConnectivity()->Update( aModule );
if( GetBoard()->IsElementVisible( LAYER_RATSNEST ) && !aDoNotRecreateRatsnest )
if( GetBoard()->IsElementVisible( LAYER_RATSNEST ) && aRecreateRatsnest )
Compile_Ratsnest( aDC, true );
if( aDC )