haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

symbol checker: do not forget to display error messages about pins not on grid. 

Fixes #16759
https://gitlab.com/kicad/code/kicad/-/issues/16759
This commit is contained in:
jean-pierre charras 2024-01-26 10:19:58 +01:00
parent 74e02d7701
commit 12357cfba6
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
eeschema/symbol_checker.cpp
View File

@ -292,6 +292,8 @@ void CheckLibSymbol( LIB_SYMBOL* aSymbol, std::vector<wxString>& aMessages,
|| ( (pin->GetPosition().y % clamped_grid_size) != 0 ) ) || ( (pin->GetPosition().y % clamped_grid_size) != 0 ) )
{ {
// pin is off grid // pin is off grid
msg.Empty();
if( aSymbol->HasConversion() && pin->GetConvert() ) if( aSymbol->HasConversion() && pin->GetConvert() )
{ {
if( aSymbol->GetUnitCount() <= 1 ) if( aSymbol->GetUnitCount() <= 1 )
@ -312,7 +314,7 @@ void CheckLibSymbol( LIB_SYMBOL* aSymbol, std::vector<wxString>& aMessages,
aUnitsProvider->MessageTextFromValue( pin->GetPosition().x ), aUnitsProvider->MessageTextFromValue( pin->GetPosition().x ),
aUnitsProvider->MessageTextFromValue( -pin->GetPosition().y ), aUnitsProvider->MessageTextFromValue( -pin->GetPosition().y ),
'A' + pin->GetUnit() - 1 ); 'A' + pin->GetUnit() - 1 );
} }
} }
else else
{ {
@ -335,6 +337,9 @@ void CheckLibSymbol( LIB_SYMBOL* aSymbol, std::vector<wxString>& aMessages,
'A' + pin->GetUnit() - 1 ); 'A' + pin->GetUnit() - 1 );
} }
} }
msg += wxT( "<br><br>" );
aMessages.push_back( msg );
} }
} }