haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QA: Remove expected failure from fixed tests 

Commit 55fcbddde8 fixed a couple of
failures in the SHAPE_POLY_SET tests, so these no longer
need the expected failure markers.

(cherry picked from commit 371149756d)
This commit is contained in:
John Beard 2019-04-17 11:46:38 +01:00
parent ab39f06003
commit 440e135e3a
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qa/common/geometry/test_shape_poly_set_collision.cpp
View File

@ -113,13 +113,11 @@ BOOST_AUTO_TEST_CASE( PointOnEdge )
BOOST_CHECK( !common.holeyPolySet.PointOnEdge( VECTOR2I( 200, 200 ) ) ); BOOST_CHECK( !common.holeyPolySet.PointOnEdge( VECTOR2I( 200, 200 ) ) );
} }
#ifdef HAVE_EXPECTED_FAILURES
/** /**
* This test checks that the function Contains, whose behaviour has been updated to also manage * This test checks that the function Contains, whose behaviour has been updated to also manage
* holey polygons, does the right work. * holey polygons, does the right work.
*/ */
BOOST_AUTO_TEST_CASE( pointInPolygonSet, *boost::unit_test::expected_failures( 1 ) ) BOOST_AUTO_TEST_CASE( pointInPolygonSet )
{ {
// Check that the set contains the points that collide with it // Check that the set contains the points that collide with it
for( const VECTOR2I& point : collidingPoints ) for( const VECTOR2I& point : collidingPoints )
@ -137,7 +135,7 @@ BOOST_AUTO_TEST_CASE( pointInPolygonSet, *boost::unit_test::expected_failures( 1
/** /**
* This test checks the behaviour of the Collide (with a point) method. * This test checks the behaviour of the Collide (with a point) method.
*/ */
BOOST_AUTO_TEST_CASE( Collide, *boost::unit_test::expected_failures( 1 ) ) BOOST_AUTO_TEST_CASE( Collide )
{ {
// When clearance = 0, the behaviour should be the same as with Contains // When clearance = 0, the behaviour should be the same as with Contains
@ -162,8 +160,6 @@ BOOST_AUTO_TEST_CASE( Collide, *boost::unit_test::expected_failures( 1 ) )
BOOST_CHECK( common.holeyPolySet.Collide( VECTOR2I( 11, 11 ), 5 ) ); BOOST_CHECK( common.holeyPolySet.Collide( VECTOR2I( 11, 11 ), 5 ) );
} }
#endif
/** /**
* This test checks the behaviour of the CollideVertex method, testing whether the collision with * This test checks the behaviour of the CollideVertex method, testing whether the collision with
* vertices is well detected * vertices is well detected