haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QA: Fix faulty test of SHAPE_POLY_SET Collision 

This test assumed points on a edge are counted as colliding.
This is not true: points on an edge are NOT counted at inside
the poly_set.

THe test does still consider points on a *hole* edge as collisions.
The API to SHAPE_POLY_SET is unclear on if this is correct.
This commit is contained in:
John Beard 2019-01-29 17:38:31 +00:00 committed by Wayne Stambaugh
parent 93ecd44f5a
commit 55fcbddde8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qa/common/geometry/test_shape_poly_set_collision.cpp
View File

@ -57,11 +57,11 @@ struct CollisionFixture
// On a hole edge => inside the polygon
collidingPoints.push_back( VECTOR2I( 40, 25 ) );
// On the outline edge => inside the polygon
collidingPoints.push_back( VECTOR2I( 0, 10 ) );
// Create points not colliding with the poly set.
// On the outline edge => outside the polygon
nonCollidingPoints.push_back( VECTOR2I( 0, 10 ) );
// Completely outside of the polygon
nonCollidingPoints.push_back( VECTOR2I( 200, 200 ) );