haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-enable moving of all footprint text in board 

Seems like a lot of people really like to be able to modify the text
positions/content of their footprints

Fixes https://gitlab.com/kicad/code/kicad/-/issues/18024
This commit is contained in:
Seth Hillbrand 2024-05-22 10:34:49 -07:00
parent debc94ff49
commit 47e4ebb32a
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pcbnew/tools/pcb_selection_tool.cpp
View File

@ -2857,19 +2857,8 @@ bool PCB_SELECTION_TOOL::Selectable( const BOARD_ITEM* aItem, bool checkVisibili
// Most footprint children can only be selected in the footprint editor. // Most footprint children can only be selected in the footprint editor.
if( aItem->GetParentFootprint() && !m_isFootprintEditor && !checkVisibilityOnly ) if( aItem->GetParentFootprint() && !m_isFootprintEditor && !checkVisibilityOnly )
{ {
if( aItem->Type() == PCB_TEXT_T ) if( aItem->Type() != PCB_FIELD_T && aItem->Type() != PCB_PAD_T
{ && aItem->Type() != PCB_TEXT_T )
text = static_cast<const PCB_TEXT*>( aItem );
// Special case for version 8 until we have a consistent way to convert these text
// to fields
if( !text->GetText().Contains( wxT( "${REFERENCE}" ) )
&& !text->GetText().Contains( wxT( "${VALUE}" ) ) )
{
return false;
}
}
else if( aItem->Type() != PCB_FIELD_T && aItem->Type() != PCB_PAD_T )
{ {
return false; return false;
} }