haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable flaky ngspice tests 

These need to be re-done in a way that is more
tolerant of the inherent instability/noise in
the simulated circuits (or more ideally, changed
to test a particular thing that can be more
well-defined rather than just simulating a circuit
and seeing if the numbers come out a certain way)

(cherry picked from commit e427099cff)
This commit is contained in:
Jon Evans 2024-02-08 18:46:30 -05:00
parent 5992d7331a
commit 73053a2177
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qa/unittests/eeschema/sim/test_sim_regressions.cpp
View File

@ -109,6 +109,9 @@ BOOST_FIXTURE_TEST_CASE( ImmediateSBCKT, TEST_SIM_REGRESSIONS_FIXTURE )
}
// This test is flaky and fails on ngspice-42 / Linux.
// Please replace it with something that is more stable
#if 0
BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE )
{
LOCALE_IO dummy;
@ -120,6 +123,7 @@ BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE )
TestTranPoint( 0.01, { { "V(out)", -0.060 } } );
TestTranPoint( 0.02, { { "V(out)", 0.856 } } );
}
#endif
BOOST_FIXTURE_TEST_CASE( DualNMOSAmp, TEST_SIM_REGRESSIONS_FIXTURE )

4
qa/unittests/eeschema/test_netlist_exporter_spice.cpp
View File

@ -197,6 +197,9 @@ BOOST_AUTO_TEST_CASE( Directives )
#endif
// This test is flaky and fails on ngspice-42 / Linux.
// Please replace it with something that is more stable
#if 0
BOOST_AUTO_TEST_CASE( LegacyLaserDriver )
{
LOCALE_IO dummy;
@ -213,6 +216,7 @@ BOOST_AUTO_TEST_CASE( LegacyLaserDriver )
// Test D1 current after the pulse
TestTranPoint( 150e-9, { { "I(D1)", 0 } } );
}
#endif
BOOST_AUTO_TEST_CASE( LegacyPotentiometer )