haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a few (minor) compil and Coverity warnings.

This commit is contained in:
jean-pierre charras 2022-08-25 20:21:00 +02:00
parent fb74bdb059
commit a306246558
5 changed files with 22 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/pg_properties.cpp
View File

@ -169,7 +169,7 @@ bool PGPROPERTY_DISTANCE::StringToDistance( wxVariant& aVariant, const wxString&
// Conversion to internal units // Conversion to internal units
long newValueIU; long newValueIU = 0;
switch( unit ) switch( unit )
{ {

2
eeschema/cross-probing.cpp
View File

@ -618,7 +618,7 @@ findItemsFromSyncSelection( const SCHEMATIC& aSchematic, const std::string aSync
} }
// Init sync maps from the sync string // Init sync maps from the sync string
for( int i = 0; i < syncArray.size(); i++ ) for( size_t i = 0; i < syncArray.size(); i++ )
{ {
wxString syncEntry = syncArray[i]; wxString syncEntry = syncArray[i];

1
eeschema/dialogs/panel_setup_buses.cpp
View File

@ -28,6 +28,7 @@
PANEL_SETUP_BUSES::PANEL_SETUP_BUSES( wxWindow* aWindow, SCH_EDIT_FRAME* aFrame ) : PANEL_SETUP_BUSES::PANEL_SETUP_BUSES( wxWindow* aWindow, SCH_EDIT_FRAME* aFrame ) :
PANEL_SETUP_BUSES_BASE( aWindow ), PANEL_SETUP_BUSES_BASE( aWindow ),
m_frame( aFrame ), m_frame( aFrame ),
m_lastAlias( 0 ),
m_errorGrid( nullptr ), m_errorGrid( nullptr ),
m_errorRow( -1 ) m_errorRow( -1 )
{ {

26
eeschema/eeschema_config.cpp
View File

@ -139,10 +139,14 @@ void SCH_EDIT_FRAME::LoadSettings( APP_SETTINGS_BASE* aCfg )
SCH_BASE_FRAME::LoadSettings( eeconfig() ); SCH_BASE_FRAME::LoadSettings( eeconfig() );
SCH_SEARCH_DATA* searchData = dynamic_cast<SCH_SEARCH_DATA*>( m_findReplaceData.get() ); SCH_SEARCH_DATA* searchData = dynamic_cast<SCH_SEARCH_DATA*>( m_findReplaceData.get() );
searchData->replaceReferences = eeconfig()->m_FindReplaceExtra.replace_references;
searchData->searchAllFields = eeconfig()->m_FindReplaceExtra.search_all_fields; if( searchData )
searchData->searchAllPins = eeconfig()->m_FindReplaceExtra.search_all_pins; {
searchData->searchCurrentSheetOnly = eeconfig()->m_FindReplaceExtra.search_current_sheet_only; searchData->replaceReferences = eeconfig()->m_FindReplaceExtra.replace_references;
searchData->searchAllFields = eeconfig()->m_FindReplaceExtra.search_all_fields;
searchData->searchAllPins = eeconfig()->m_FindReplaceExtra.search_all_pins;
searchData->searchCurrentSheetOnly = eeconfig()->m_FindReplaceExtra.search_current_sheet_only;
}
GetRenderSettings()->m_ShowPinsElectricalType = false; GetRenderSettings()->m_ShowPinsElectricalType = false;
} }
@ -164,11 +168,15 @@ void SCH_EDIT_FRAME::SaveSettings( APP_SETTINGS_BASE* aCfg )
// hierarchy panel // hierarchy panel
SCH_SEARCH_DATA* searchData = dynamic_cast<SCH_SEARCH_DATA*>( m_findReplaceData.get() ); SCH_SEARCH_DATA* searchData = dynamic_cast<SCH_SEARCH_DATA*>( m_findReplaceData.get() );
eeconfig()->m_FindReplaceExtra.replace_references = searchData->replaceReferences;
eeconfig()->m_FindReplaceExtra.search_all_fields = searchData->searchAllFields; if( searchData )
eeconfig()->m_FindReplaceExtra.search_all_pins = searchData->searchAllPins; {
eeconfig()->m_FindReplaceExtra.search_current_sheet_only = eeconfig()->m_FindReplaceExtra.replace_references = searchData->replaceReferences;
searchData->searchCurrentSheetOnly; eeconfig()->m_FindReplaceExtra.search_all_fields = searchData->searchAllFields;
eeconfig()->m_FindReplaceExtra.search_all_pins = searchData->searchAllPins;
eeconfig()->m_FindReplaceExtra.search_current_sheet_only =
searchData->searchCurrentSheetOnly;
}
} }
} }

3
pcbnew/pcb_painter.cpp
View File

@ -401,7 +401,8 @@ PCB_PAINTER::PCB_PAINTER( GAL* aGal, FRAME_T aFrameType ) :
PAINTER( aGal ), PAINTER( aGal ),
m_frameType( aFrameType ), m_frameType( aFrameType ),
m_maxError( ARC_HIGH_DEF ), m_maxError( ARC_HIGH_DEF ),
m_holePlatingThickness( 0 ) m_holePlatingThickness( 0 ),
m_lockedShadowMargin( 0 )
{ {
} }