haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't allow degenerate polygons. 

Fixes https://gitlab.com/kicad/code/kicad/issues/5883
This commit is contained in:
Jeff Young 2020-10-13 20:16:40 +01:00
parent ef3b7052e0
commit b3cd829d9f
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
common/preview_items/centreline_rect_item.cpp
View File

@ -30,8 +30,8 @@
using namespace KIGFX::PREVIEW; using namespace KIGFX::PREVIEW;
static SHAPE_POLY_SET getRectangleAlongCentreLine( static SHAPE_POLY_SET getRectangleAlongCentreLine( const VECTOR2D& aClStart,
const VECTOR2D& aClStart, const VECTOR2D& aClEnd, double aAspect ) const VECTOR2D& aClEnd, double aAspect )
{ {
SHAPE_POLY_SET poly; SHAPE_POLY_SET poly;
poly.NewOutline(); poly.NewOutline();
@ -48,11 +48,15 @@ static SHAPE_POLY_SET getRectangleAlongCentreLine(
*/ */
// vector down the centre line of the rectangle // vector down the centre line of the rectangle
const VECTOR2D cl = aClEnd - aClStart; VECTOR2D cl = aClEnd - aClStart;
// don't allow degenerate polygons
if( cl.x == 0 && cl.y == 0 )
cl.x = 1.0;
// the "side" of the rectangle is the centre line rotated by 90 deg // the "side" of the rectangle is the centre line rotated by 90 deg
// and scaled by the aspect ratio // and scaled by the aspect ratio
const VECTOR2D side = cl.Rotate( M_PI / 2.0 ) * aAspect; VECTOR2D side = cl.Rotate( M_PI / 2.0 ) * aAspect;
VECTOR2D pt = aClStart + ( side / 2.0 ); VECTOR2D pt = aClStart + ( side / 2.0 );
poly.Append( pt ); poly.Append( pt );