haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pcbnew: disable commit 3692c511 on non Windows platforms 

A zone refill display progress bar is shown when deselecting the zone after geometry changes.
However, on Linux, there are some artifact between the progress bar refresh and the board view refresh:
the filled areas are incorrectly shown: the insulated islands remain displayed,
although they are removed from the actual filled areas list
So it is disabled until a fix is found.
This commit is contained in:
jean-pierre charras 2019-03-17 08:31:00 +01:00
parent 0de25e557b
commit b558366a4e
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pcbnew/tools/point_editor.cpp
View File

@ -644,8 +644,17 @@ void POINT_EDITOR::finishItem()
if( zone->IsFilled() && m_refill && zone->NeedRefill() ) if( zone->IsFilled() && m_refill && zone->NeedRefill() )
{ {
ZONE_FILLER filler( board() ); ZONE_FILLER filler( board() );
// A progress reporter can be usefull. However it works fine only on Windows
// so enable it only on Windows.
// On Linux, the filled areas are incorrectly shown: the insulated islands
// remain displayed, although they are removed from the actual filled areas list
//
// Fix me: try to make it working on Linux.
//
#ifdef __WINDOWS__
WX_PROGRESS_REPORTER reporter( getEditFrame<PCB_BASE_FRAME>(), _( "Refill Zones" ), 4 ); WX_PROGRESS_REPORTER reporter( getEditFrame<PCB_BASE_FRAME>(), _( "Refill Zones" ), 4 );
filler.SetProgressReporter( &reporter ); filler.SetProgressReporter( &reporter );
#endif
filler.Fill( { zone } ); filler.Fill( { zone } );
} }
} }