haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid divide-by-zero.

This commit is contained in:
Jeff Young 2020-01-15 18:12:06 +00:00
parent bc6139359b
commit dcfb7cadce
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pcbnew/board_stackup_manager/panel_board_stackup.cpp
View File

@ -887,7 +887,7 @@ bool PANEL_SETUP_BOARD_STACKUP::transferDataFromUIToStackup()
// The board thickness and the thickness from stackup settings should be compatible // The board thickness and the thickness from stackup settings should be compatible
// so verify that compatibility // so verify that compatibility
int pcbTickness = GetPcbThickness() ; int pcbThickness = GetPcbThickness() ;
int stackup_thickness = 0; int stackup_thickness = 0;
wxString txt; wxString txt;
@ -1017,8 +1017,8 @@ bool PANEL_SETUP_BOARD_STACKUP::transferDataFromUIToStackup()
row++; row++;
} }
int delta = std::abs( stackup_thickness - pcbTickness ); int delta = std::abs( stackup_thickness - pcbThickness );
double relative_error = (double)delta/pcbTickness; double relative_error = pcbThickness ? (double)delta / pcbThickness : 1;
const double relative_error_max = 0.01; const double relative_error_max = 0.01;
// warn user if relative_error > 0.01 // warn user if relative_error > 0.01
@ -1027,9 +1027,9 @@ bool PANEL_SETUP_BOARD_STACKUP::transferDataFromUIToStackup()
wxString msg; wxString msg;
msg.Printf( _( "Board thickness %s differs from stackup thickness %s\n" msg.Printf( _( "Board thickness %s differs from stackup thickness %s\n"
"Allowed max error %s" ), "Allowed max error %s" ),
StringFromValue( m_units, pcbTickness, true, true ), StringFromValue( m_units, pcbThickness, true, true ),
StringFromValue( m_units, stackup_thickness, true, true ), StringFromValue( m_units, stackup_thickness, true, true ),
StringFromValue( m_units, KiROUND( relative_error_max*pcbTickness), StringFromValue( m_units, KiROUND( relative_error_max * pcbThickness),
true, true ) ); true, true ) );
if( !error_msg.IsEmpty() ) if( !error_msg.IsEmpty() )