haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable flaky ngspice tests 

These need to be re-done in a way that is more
tolerant of the inherent instability/noise in
the simulated circuits (or more ideally, changed
to test a particular thing that can be more
well-defined rather than just simulating a circuit
and seeing if the numbers come out a certain way)
This commit is contained in:
Jon Evans 2024-02-08 18:46:30 -05:00
parent febe759e49
commit e427099cff
3 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qa/tests/eeschema/test_netlist_exporter_spice.cpp
View File

@ -195,6 +195,9 @@ BOOST_AUTO_TEST_CASE( Directives )
#endif #endif
// This test is flaky and fails on ngspice-42 / Linux.
// Please replace it with something that is more stable
#if 0
BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) BOOST_AUTO_TEST_CASE( LegacyLaserDriver )
{ {
LOCALE_IO dummy; LOCALE_IO dummy;
@ -211,6 +214,7 @@ BOOST_AUTO_TEST_CASE( LegacyLaserDriver )
// Test D1 current after the pulse // Test D1 current after the pulse
TestTranPoint( 150e-9, { { "I(D1)", 0 } } ); TestTranPoint( 150e-9, { { "I(D1)", 0 } } );
} }
#endif
BOOST_AUTO_TEST_CASE( LegacyPotentiometer ) BOOST_AUTO_TEST_CASE( LegacyPotentiometer )

4
qa/tests/spice/test_netlist_exporter_spice.cpp
View File

@ -195,6 +195,9 @@ BOOST_AUTO_TEST_CASE( Directives )
#endif #endif
// This test is flaky and fails on ngspice-42 / Linux.
// Please replace it with something that is more stable
#if 0
BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) BOOST_AUTO_TEST_CASE( LegacyLaserDriver )
{ {
LOCALE_IO dummy; LOCALE_IO dummy;
@ -211,6 +214,7 @@ BOOST_AUTO_TEST_CASE( LegacyLaserDriver )
// Test D1 current after the pulse // Test D1 current after the pulse
TestTranPoint( 150e-9, { { "I(D1)", 0 } } ); TestTranPoint( 150e-9, { { "I(D1)", 0 } } );
} }
#endif
BOOST_AUTO_TEST_CASE( LegacyPspice ) BOOST_AUTO_TEST_CASE( LegacyPspice )

4
qa/tests/spice/test_sim_regressions.cpp
View File

@ -111,6 +111,9 @@ BOOST_FIXTURE_TEST_CASE( ImmediateSBCKT, TEST_SIM_REGRESSIONS_FIXTURE )
} }
// This test is flaky and fails on ngspice-42 / Linux.
// Please replace it with something that is more stable
#if 0
BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE ) BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE )
{ {
LOCALE_IO dummy; LOCALE_IO dummy;
@ -122,6 +125,7 @@ BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE )
TestTranPoint( 0.01, { { "V(out)", -0.060 } } ); TestTranPoint( 0.01, { { "V(out)", -0.060 } } );
TestTranPoint( 0.02, { { "V(out)", 0.856 } } ); TestTranPoint( 0.02, { { "V(out)", 0.856 } } );
} }
#endif
BOOST_FIXTURE_TEST_CASE( DualNMOSAmp, TEST_SIM_REGRESSIONS_FIXTURE ) BOOST_FIXTURE_TEST_CASE( DualNMOSAmp, TEST_SIM_REGRESSIONS_FIXTURE )