haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix minor compil and Coverity warnings.

This commit is contained in:
jean-pierre charras 2022-01-25 12:52:13 +01:00
parent 6e9516925c
commit f651e31965
4 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
common/font/stroke_font.cpp
View File

@ -61,7 +61,8 @@ std::vector<BOX2D>* g_defaultFontGlyphBoundingBoxes;
STROKE_FONT::STROKE_FONT() : STROKE_FONT::STROKE_FONT() :
m_glyphs( nullptr ), m_glyphs( nullptr ),
m_glyphBoundingBoxes( nullptr ) m_glyphBoundingBoxes( nullptr ),
m_maxGlyphWidth( 0.0 )
{ {
} }

2
gerbview/widgets/gerbview_layer_widget.cpp
View File

@ -225,7 +225,7 @@ void GERBER_LAYER_WIDGET::onPopupSelection( wxCommandEvent& event )
case ID_LAYER_MOVE_DOWN: case ID_LAYER_MOVE_DOWN:
layer = m_frame->GetActiveLayer(); layer = m_frame->GetActiveLayer();
if( layer < ( GetImagesList()->GetLoadedImageCount() - 1 ) ) if( layer < ( (int)GetImagesList()->GetLoadedImageCount() - 1 ) )
{ {
m_frame->RemapLayers( GetImagesList()->SwapImages( layer, layer + 1 ) ); m_frame->RemapLayers( GetImagesList()->SwapImages( layer, layer + 1 ) );
m_frame->SetActiveLayer( layer + 1 ); m_frame->SetActiveLayer( layer + 1 );

4
pcbnew/teardrop/teardrop.cpp
View File

@ -193,7 +193,7 @@ int TEARDROP_MANAGER::SetTeardrops( BOARD_COMMIT* aCommitter,
if( count || removed_cnt || track2trackCount ) if( count || removed_cnt || track2trackCount )
{ {
ZONE_FILLER filler( m_board, aCommitter ); ZONE_FILLER filler( m_board, aCommitter );
filler.Fill( m_board->Zones() ); (void)filler.Fill( m_board->Zones() );
if( aCommitter ) if( aCommitter )
aCommitter->Push( _( "Add teardrops" ) ); aCommitter->Push( _( "Add teardrops" ) );
@ -389,7 +389,7 @@ int TEARDROP_MANAGER::RemoveTeardrops( BOARD_COMMIT* aCommitter, bool aCommitAft
if( count ) if( count )
{ {
ZONE_FILLER filler( m_board, aCommitter ); ZONE_FILLER filler( m_board, aCommitter );
filler.Fill( m_board->Zones() ); (void)filler.Fill( m_board->Zones() );
if( aCommitter && aCommitAfterRemove ) if( aCommitter && aCommitAfterRemove )
aCommitter->Push( _( "Remove teardrops" ) ); aCommitter->Push( _( "Remove teardrops" ) );

5
pcbnew/teardrop/teardrop_utils.cpp
View File

@ -402,7 +402,8 @@ bool TEARDROP_MANAGER::ComputePointsOnPadVia( TEARDROP_PARAMETERS* aCurrParams,
{ {
// Compute the 2 anchor points on pad/via of the teardrop shape // Compute the 2 anchor points on pad/via of the teardrop shape
PAD* pad = dynamic_cast<PAD*>( aViaPad.m_Parent ); PAD* pad = ( aViaPad.m_Parent->Type() == PCB_PAD_T ) ? static_cast<PAD*>(aViaPad.m_Parent)
: nullptr;
SHAPE_POLY_SET c_buffer; SHAPE_POLY_SET c_buffer;
// aHeightRatio is the factor to calculate the aViaPad teardrop prefered height // aHeightRatio is the factor to calculate the aViaPad teardrop prefered height
@ -428,7 +429,7 @@ bool TEARDROP_MANAGER::ComputePointsOnPadVia( TEARDROP_PARAMETERS* aCurrParams,
TransformCircleToPolygon( c_buffer, aViaPad.m_Pos, aViaPad.m_Width/2 , TransformCircleToPolygon( c_buffer, aViaPad.m_Pos, aViaPad.m_Width/2 ,
ARC_LOW_DEF, ERROR_INSIDE, 16 ); ARC_LOW_DEF, ERROR_INSIDE, 16 );
} }
else else // Only PADS can have a not round shape
{ {
wxASSERT( pad ); wxASSERT( pad );
force_clip_shape = true; force_clip_shape = true;