haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Export footprint pad holes to STEP regardless 

Footprint pad holes form a part of the board outline regardless of
whether the footprint is in the BOM or not

Fixes https://gitlab.com/kicad/code/kicad/issues/14013

(cherry picked from commit daf70f9b6a)
This commit is contained in:
Seth Hillbrand 2023-02-28 12:01:01 -08:00
parent 4213bb3a62
commit fb798a4150
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pcbnew/exporters/step/exporter_step.cpp
View File

@ -138,6 +138,13 @@ bool EXPORTER_STEP::composePCB( FOOTPRINT* aFootprint, VECTOR2D aOrigin )
{ {
bool hasdata = false; bool hasdata = false;
// Dump the pad holes into the PCB
for( PAD* pad : aFootprint->Pads() )
{
if( m_pcbModel->AddPadHole( pad, aOrigin ) )
hasdata = true;
}
if( ( aFootprint->GetAttributes() & FP_EXCLUDE_FROM_BOM ) && !m_params.m_includeExcludedBom ) if( ( aFootprint->GetAttributes() & FP_EXCLUDE_FROM_BOM ) && !m_params.m_includeExcludedBom )
{ {
return hasdata; return hasdata;
@ -168,13 +175,6 @@ bool EXPORTER_STEP::composePCB( FOOTPRINT* aFootprint, VECTOR2D aOrigin )
} }
} }
// Dump the pad holes into the PCB
for( PAD* pad : aFootprint->Pads() )
{
if( m_pcbModel->AddPadHole( pad, aOrigin ) )
hasdata = true;
}
// Exit early if we don't want to include footprint models // Exit early if we don't want to include footprint models
if( m_params.m_boardOnly ) if( m_params.m_boardOnly )
{ {
@ -389,4 +389,4 @@ bool EXPORTER_STEP::Export()
} }
return true; return true;
} }