haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix broken conditional check while walking global power connected items 

Per the if statement and logic, we want to walk into looking up connections if we are a pin on a chip.
IsGlobalPower is a test for it's in a power symbol, so we want it false not true.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16699
This commit is contained in:
Marek Roszko 2024-01-21 19:53:35 -05:00
parent d6b39c672e
commit fb8dc75108
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
eeschema/connection_graph.cpp
View File

@ -3432,7 +3432,7 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph
// We want to throw unconnected errors for power symbols even if they are connected to other // We want to throw unconnected errors for power symbols even if they are connected to other
// net items by name, because usually failing to connect them graphically is a mistake // net items by name, because usually failing to connect them graphically is a mistake
if( pin && !has_other_connections if( pin && !has_other_connections
&& pin->IsGlobalPower() && !pin->IsGlobalPower()
&& !pin->GetLibPin()->GetParent()->IsPower() ) && !pin->GetLibPin()->GetParent()->IsPower() )
{ {
wxString name = pin->Connection( &sheet )->Name(); wxString name = pin->Connection( &sheet )->Name();