cb115189f6
Symbol Fields Table: menu shortcut should start in edit tab
...
The BOM shortcut goes to Export, this makes them symmetrical.
2023-09-27 09:14:25 -04:00
92cbd0f599
Allow Never Show Rescue Symbols to be turned back off.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15733
2023-09-25 23:58:15 +01:00
7835b8ddc7
Bring various appearance managers into line over preset editing.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15726
2023-09-25 12:35:54 +01:00
f8e33be07f
Break out the boundary violating parts of gal into common through subclassing
2023-09-23 09:37:47 -04:00
398a336d91
BOM Generator: redirect BOM buttons to new exporter
...
Also add legacy generator menu item.
2023-09-20 11:12:03 -04:00
9541e45502
BOM Exporter: allow using presets from the command line
2023-09-20 10:57:43 -04:00
6425c5cc1a
Symbol Fields Table: fix issues with selecting row of starting selection
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15684
2023-09-20 09:42:52 -04:00
dd0743d766
Symbol Fields Table: add fixes around preset modifications
2023-09-20 09:42:52 -04:00
75294dc35b
Make sure newly-added library rows get parent table set
2023-09-18 21:10:33 -04:00
22b733209d
Fail GAL on its header leaking audit
...
Maybe we should rethink directly accessing GAL so much, but at least 600 files didn't need GAL leaked into them due to view_overlay.h
2023-09-18 19:52:27 -04:00
1decd31baf
Vertically center wxGrid cells by default.
2023-09-18 17:15:34 +03:00
6f62565093
Handle flipped horiz/vert justifications in FIELDS_GRID_TABLE.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15677
2023-09-18 12:38:34 +01:00
be4c89011c
Don't confuse "significant digits" with "decimal places".
...
Also raises the default significant digits for cursors to 3.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15669
2023-09-17 12:42:06 +01:00
c80eb44900
Disentangle IBIS model controls from built-in model controls.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13855
2023-09-17 12:42:06 +01:00
ede542f911
Collect comment lines into following spice unit.
...
This can't distinguish a header block comment in front of a file
with multiple spice units, and so will include that into the first
unit only.
Also fixes the pin assignments reference textbox to use a
fixed-width font as many .subckt's contain ASCII graphics for
pin definitions (not that it helps any with the test case from
the given bug).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15660
2023-09-15 20:08:45 +01:00
3a1be0f603
Fix wrong path in rescue dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15439
2023-09-15 00:43:07 +01:00
485db8bccd
Remove extra nag/grid assertion
...
When editing the properties, if you accidentally make an extra line, you
should be able to remove the data and have it ignored.
2023-09-14 14:39:51 -07:00
ff49d5ada9
Fix ambiguous overloads on wx 3.3
2023-09-14 19:05:46 +03:00
f2c6f25967
Add colors-overridden warning to Symbol Editor's shape properties dialog.
...
(Note: could be cherry-picked as the strings are all from the
schematic editor.)
2023-09-14 16:53:22 +01:00
4ac5404822
Move HTML_WINDOW to widgets folder, also fix some fbps that were wrongly not edited
...
Somebody manually edited at least 3 files fixed here....so the fbps were wrong
2023-09-11 19:10:16 -04:00
5da4dfd4a7
Work around wxGTK printing offset in eeschema.
...
Affects landscape Letter, Legal, A4 paper.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1907
2023-09-10 21:53:03 +03:00
11de95778b
Unwrap the FROM_UTF8 macro in favor of direct function
...
The extern just gets annoying to try to export the func later. We also yeet TO_UTF8 to string_utils.h for parity.
2023-09-09 00:10:57 -04:00
0310973e3f
Push TEXT_SPIN_STYLE from SCH_TEXT out to SCH_LABEL_BASE.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15444
2023-09-07 17:42:51 +01:00
24d3df5416
ADDED: Altium SchLib Support
2023-09-06 19:15:35 +00:00
7a2a2e2df0
Remove error-prone SetReporter() API.
2023-09-06 11:37:50 +01:00
ee2f954bbe
Revert "Set reporter in DIALOG_SIM_MODEL::TransferDataToWindow."
...
This reverts commit 26f398a4b1
2023-09-06 08:02:01 +03:00
4fe7c7a902
Prevent crash trying to load missing spice lib
2023-09-05 21:13:29 -04:00
634524dde5
Validate new symbol / save as symbol info before exiting dialog.
2023-09-05 22:07:58 +01:00
a5a93f808e
Populate symbol library type choices from SCH_IO_MGR list.
2023-09-05 07:19:15 +03:00
9999ac5662
Generate NC-pin errors when connected to other items.
...
Also removes the NC row in the pin map as it hasn't been used since
6.0 (see #1826 ).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15558
2023-09-04 17:27:39 +01:00
fe0fb92441
Reduce visual clutter in GAL display options.
2023-09-04 13:06:46 +01:00
f39bc64212
Show grey background in pin table for pins with no alternates defined.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14030
2023-09-03 15:34:18 +01:00
a72df46200
Show grey background in pin table for pins with no alternates defined.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14030
2023-09-03 15:34:18 +01:00
e6b0a6abca
ADDED: lib tree previews.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2418
2023-09-02 23:30:22 +01:00
f3f57f77d9
Use STD_BITMAP_BUTTON for change symbols dialog.
2023-09-01 18:48:46 +01:00
377ffb00b0
Re-run autoplacement after symbol replacement (when appropriate).
...
Also prevents an internal wxWidgets assert by clearing grid
selection before deleting rows.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15541
2023-08-31 23:28:59 +01:00
cb003d8ab4
Don't count pins of both De Morgan variants when matching to footprint pads.
...
(And remove un unused variable from grid settings dialog.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15550
2023-08-31 11:36:39 +01:00
e128896ba6
Schematic plugins refactoring, fixes for PCB plugins.
...
- Move PLUGIN_FILE_DESC to common.
- SCH_PLUGIN: rename Load -> LoadSchematicFile, Save -> SaveSchematicFile.
- Use PLUGIN_FILE_DESC and CanRead* in schematic plugins.
- Return none/unknown types from Find/GuessPluginType functions.
- Iterate over file types for file wildcards.
- Clean-up header checking in IO plugins.
- Use PCB plugin list in IO_MGR::GuessPluginTypeFromLibPath.
2023-08-31 05:08:03 +03:00
30a6d33177
Better fix for primary param in value field with other params in params field.
...
(Replaces 2c8178829982c6e15e443b5a7868b8c953d5126f.)
2023-08-30 00:53:01 +01:00
e0b2202e77
Improve naming for alternate pin fuction assignments.
2023-08-29 18:07:27 +01:00
f6a901f84a
Attempt to fix ctrl-enter from parameter grid on MSW.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15244
2023-08-29 00:09:18 +01:00
ae05bf723e
Symbol Library Table: Convert CADSTAR and other non-current Symbol Libraries
...
Anything other than database libraries and kicad s-expr libraries should be converted
2023-08-28 20:49:42 +02:00
2c81788299
HasAutofill should not preclude a primary parameter in the value field
2023-08-28 17:44:45 +01:00
4325f4e038
ADDED: alternate pin functions in context menu.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12852
2023-08-28 12:51:41 +01:00
7037076360
Symbol Library Table: Show CADSTAR Parts Libraries in file selector
...
Even if same extension, it is good to display it as a way of showing what
we support
2023-08-27 20:52:45 +02:00
b3aa8a0c49
Fix a few (minor) compil warnings.
2023-08-26 09:40:09 +02:00
1db9febcfe
Remove duplicate references from change symbol dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15480
2023-08-25 14:08:21 -04:00
26f398a4b1
Set reporter in DIALOG_SIM_MODEL::TransferDataToWindow.
...
It could've been set to point to local variable "reporter" in loadLibrary.
Fixes KICAD-15C
2023-08-25 20:59:56 +03:00
d00a6b4987
Dialogs: add some margins back for GTK
2023-08-24 12:38:54 -04:00
1026596964
Allow symbols to be derived from other derived symbols.
...
[CHANGED] Symbols can now be derived from other derived symbols removing
the requirement to derive from root symbols.
2023-08-24 07:59:32 -04:00
a97ba79883
Give Symbol Fields Table GUI a KiCad look & feel.
2023-08-24 11:21:19 +01:00
d1765c3855
Work-around non-functional row-major radio button groups on Mac.
2023-08-24 11:21:19 +01:00
e3b8de9a78
Work-around non-functional row-major radio button groups on Mac.
2023-08-24 11:21:19 +01:00
db8e15ce88
Require wxWidgets 3.2
...
Removes old defines and work arounds for earlier wx versions and adds a
CMake requirement to use at least 3.2 (or the minimum matching wxPython
version)
2023-08-23 22:02:56 +00:00
3d0dc2fc1b
Symbol Fields Table: better selection event control
...
wxGrid changes the selection every time it gets a grid change event so
we need to selectively suppress these.
2023-08-21 08:56:38 -04:00
a9c4534a38
Schematic/Fields Table: handle sheet changes
2023-08-20 16:13:47 -04:00
08a01bb667
Show warning dialog message when is not possible to create the BOM file.
2023-08-19 21:05:16 +00:00
6c5ec288a5
Don't unload project out from under someone else.
...
(Can only currently happen if you import settings from the current
project, but will happen in even more cases once we do MDI.)
Possibly Sentry KICAD-169.
2023-08-18 22:20:09 +01:00
a7e74bf4bc
Fix a few minor compil and Coverity warnings.
2023-08-17 20:31:40 +02:00
53b2fda184
Fix some minor compil and Coverity warnings.
2023-08-17 10:06:17 +02:00
e1d5089c74
Symbol Fields Table: handle recursive sheet add/delete/update
2023-08-14 14:19:26 -04:00
dc103b88d1
Symbol Fields Table: make non-modal
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:19:26 -04:00
63690d4a0b
Symbol Fields Table: fix broken delete
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15405
2023-08-14 08:42:03 -04:00
5d001d4858
ADDED: ERC over cli....mostly
2023-08-13 20:31:19 -04:00
f341fde938
Move RecordERCExclusions and ResolveERCExclusions out of the schematic frame
2023-08-13 19:50:05 -04:00
50a4a8639e
Move ERC test flow to ERC_TESTER::RunTests
2023-08-13 19:44:10 -04:00
061d18cbb0
Support json reports as option in erc/drc dialogs
2023-08-13 19:19:19 -04:00
e842a788db
Split ERC report to its own class like drc
2023-08-13 19:19:19 -04:00
1b080ed02f
Get rid of SIM_NOTEBOOK. It's completely unnecessary.
2023-08-09 12:09:29 +01:00
bdecdce1b4
Exclude from Sim: move from field to attribute
2023-08-08 12:36:36 -04:00
88cb1ed8b5
Show row selections in bus alias and members grids.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15374
2023-08-08 15:59:16 +01:00
1dd92b1bb1
Assign focus to the notebook in the ERC/DRC window after running
...
After running the ERC/DRC, the window would not get focus returned to it
on GTK naturally unless the user pressed the arrow key. This prevented
the ESC key from closing the window after the run was complete and
nothing else was clicked/pressed.
Instead of pulling focus to the dataview with the errors in it (which
would cause problems in GTK, such as moving the viewport to the first
marker (https://gitlab.com/kicad/code/kicad/-/issues/11925 ), give focus
to the notebook container instead. This will not select the marker, but
still allow the ESC to propagate into the dialog immediately.
2023-08-08 14:02:54 +01:00
111d73067d
Symbol Fields Table: don't deref non-existant ref
2023-08-08 08:17:43 -04:00
fc869502f4
Fix symbol properties dialog height when symbol has many pins.
2023-08-08 00:00:52 +03:00
fe32492252
Symbol Fields Table: scope control for limited view of symbols
2023-08-07 15:05:24 -04:00
6ae8968a5b
Symbol Fields Table: add selection controls
...
Allows cross-probing to other editors.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8188
2023-08-07 15:05:24 -04:00
ddbefe13cd
Improve default margins.
2023-08-06 20:57:42 +01:00
5e112ca78e
ADDED: parameterize font metrics and allow customization of overbar height.
2023-08-06 20:57:41 +01:00
4c4bbdc8f3
Stricter API for LIB_TABLE
...
Prevent nickname map or row parent getting out of sync
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15315
2023-08-06 00:56:51 -04:00
d3329a0781
Only re-build the members grid when we have to.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15320
2023-08-04 23:39:47 +01:00
8762859c6d
Fix a display issue in wxStyledTextCtrl widgets in dialogs (Windows specific).
...
It happens when a text is using some esoteric unicode chars.
Fixes #15314
https://gitlab.com/kicad/code/kicad/-/issues/15314
2023-08-03 18:35:49 +02:00
c61da43ee2
Coverity: fix copy paste pointless cast
2023-08-03 08:27:12 -04:00
686dfba77a
ADDED autocomplete for value field in Symbol Properties dialog.
2023-08-02 20:45:52 +01:00
3428bd8e83
Symbol Fields Table: convert to SCH_COMMIT
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11899
2023-08-02 12:51:33 -04:00
37fdcce0a0
Fields Editor Table: add checkboxes for fields representing attributes
...
DNP, Exclude from ..., etc.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15300
2023-08-01 14:33:30 -04:00
df04171234
Fields Editor Table: apply correct column attr to new fields
2023-08-01 14:33:30 -04:00
39297adc61
Fields Table Editor: remove old assumptions about Qty being last col
2023-08-01 14:33:30 -04:00
25e391719e
Fields Table: convert special strings like Quantity to named variables
...
Before, we did not actually prevent users from adding a field also named
Quantity to their symbols. This of course does not play nicely with the
assumptions that Quantity is a special column in the fields editor.
By making it a named variable, the user can safely add it to a symbol
and it will not be editable, and will also work in the fields table
editor as expected.
2023-08-01 10:55:32 -04:00
744452d092
Sch/PCB: allow back-updating schematic fields from PCB
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15285
2023-07-31 10:38:43 -04:00
1548b14f84
DIALOG_LIB_SYMBOL_PROPERTIES: fix incorrect state of two wxCheckboxes.
...
When opening the dialog, m_excludeFromBomCheckBox and m_excludeFromBoardCheckBox
states were the opposite of the actual symbol property.
Fixes #15269
https://gitlab.com/kicad/code/kicad/-/issues/15269
2023-07-30 08:42:33 +02:00
148e111579
Refactor pin orientation to be an enum class
...
Add various LIB_PIN properties
2023-07-26 23:46:15 -04:00
f7f67c6d53
Sort the bus alias set by name
...
If we place pointers in a set, they are sorted by the pointer value in
memory, not the data, so we need a custom comparator
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11890
2023-07-21 09:03:35 -07:00
e4b262d6e1
Fixed-y-scale bug fixes.
...
Default dialog to SPICE command.
Any of the three axis locks must lock the plotWindow Y axis (otherwise
locking Y2 but not Y1 doesn't preclude zooming).
2023-07-20 17:41:23 +01:00
06f19aa761
Implement y axis locking for secondary y axes.
...
Still a bit of a work-in-progress.
Also fixes some bugs with formatting of measurements and cursor values.
2023-07-20 17:21:19 +01:00
9c08d4febe
ADDED support for simulation plot margins and GUI for Y axis locking.
2023-07-19 23:40:10 +01:00
a586bbc3ea
Symbol editor, DIALOG_FIELD_PROPERTIES: fix missing initialization of font.
...
In Symbol editor, tying to change the font of a field did nothing.
2023-07-18 18:40:53 +02:00
30928796bd
Repair new switch-based Global Update Text & Graphics.
...
We were forgetting to handle wire and bus labels.
2023-07-16 20:41:23 +01:00
a16033f624
Fix logic errors in DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::visitItem().
...
(We can't exit out if it doesn't match a particular type as we haven't
checked the other types yet. Use a switch to prevent this.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15206
2023-07-16 14:43:29 +01:00
3233bbe0ba
Make exported date time strings use ISO8601 format
...
Also rename the function to be explicit on its result format
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15185
2023-07-14 23:24:12 -04:00
ff044cd0cf
Mostly a terminology update...
...
... but also makes DIALOG_SIM_COMMAND and SIMULATOR_REPORTER a bit
more simulator-agnostic.
2023-07-14 17:46:06 +01:00
c4179cb996
Correctly initialize New Simulation Command dialog.
2023-07-13 23:37:48 +01:00
841b693c91
Add pole-zero command parsing and printing.
2023-07-13 16:04:29 +01:00
4cad021ef4
Add Open preferences folder button in Preferences Dialog
2023-07-13 14:10:31 +00:00
e26dcbece4
Symbol Fields Table: add item number support
2023-07-12 15:08:50 -04:00
7cb8d3d1c9
Schematic fields: implement fields with variables as names
...
Special case that always fills in the value with the value of the
variable
2023-07-12 12:16:14 -04:00
eedf319ba4
Don't double-offset effective text shapes.
...
Also fixes several bugs with intersheet ref fields. (It's possible for
other fields to have an ID of 0.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15165
2023-07-10 19:32:00 +01:00
d2f9994fc5
SCH_SHEET::GetContextualTextVars() will return Project text vars.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15123
2023-07-10 12:40:04 +01:00
a66360525a
Broaden "Style footprint fields" to cover graphics as well.
...
Also cleans up the layout of the symbol & fp properties dialogs.
Also fixes the background colour of the link textEdit controls on Mac.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8161
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15152
2023-07-09 12:45:55 +01:00
70ffd971e3
Fix a bug found by Coverity.
2023-07-08 12:51:21 +02:00
922f7128a9
Move item updating and view refresh to SCH_COMMIT::Push().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15132
2023-07-07 15:40:01 +01:00
bde9c2cbc5
ADDED FFT analyses.
...
CHANGED abandon the unpredictable behaviour of the Simulation Command
dialog. You now separately add simulation tabs (which have invariant
command types once created), and the dialog edits the current tab.
Also a bunch of bug fixes to make multiple simulation plots actually
work.
2023-07-07 12:33:50 +01:00
443a5dc3bb
Syntax help for SPICE functions.
2023-07-07 12:33:49 +01:00
886a7c2c04
ADDED: S-parameters simulation
2023-07-04 16:01:12 +00:00
d563d66b86
ADDED Fourier analyses of .tran data.
2023-07-04 16:54:38 +01:00
492ef62053
ADDED support to save contributions from all noise generators.
...
You must first check the checkbox in the Simulation Command dialog,
after which the signals will appear in the User Defined Signals
autocomplete lists.
2023-07-04 11:05:10 +01:00
7d3fa8fb4e
Plotting for noise simulations.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2369
2023-07-03 23:12:28 +01:00
80340c607c
ADDED noise simulation GUI.
2023-07-03 16:26:20 +01:00
86458ae582
Eeschema printing: fix bg fill when paper orientation or size differs.
2023-07-03 02:15:05 +03:00
f5d7edaa73
PANEL_SYM_EDITING_OPTIONS: Fix a focus event issue (perhaps platform specific)
2023-07-02 19:46:56 +02:00
ec9b2919ba
Allow user-entered repeat pin spacing, but force to grid multiples.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14207
2023-07-02 17:23:01 +01:00
bb4fb9088f
Gracefully handle no symbols found in change symbols dialog
...
Fixes KICAD-2BJ
2023-06-29 23:21:15 +01:00
4cb993d872
ADDED: Cadence Allegro PCB Designer netlist exporter
2023-06-28 22:47:30 +00:00
2278f5dbca
Don't try to be smart about enabling the Clear Annotation button.
...
(At a minimum it would need to also handle when the scope changes, but
it's not clear we're adding anything by enabling/disabling it to start
with.)
2023-06-28 14:56:50 +01:00
2fb6f19a84
Separate immediate and delayed action dispatch
...
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
2023-06-27 00:57:59 +01:00
d4b7144448
Properties: expose symbol attributes
...
Flip polarity of exclude-from-BOM and -board for symbols
to match that of footprints and match the GUI display.
2023-06-24 22:03:06 -04:00
237cc7eee1
Move TestDanglingEnds() to SCH_COMMIT.
...
Also fixes a bug where Convert Symbol wasn't undoable.
Also cleans up some SetModified() call no longer needed with SCH_COMMIT.
Also fixes bug where revert of a modification didn't update the screen's
RTree.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15030
2023-06-23 19:59:46 +01:00
7804c2177c
Do not force focus on dataview in RC dialogs
...
On GTK, this causes the first item to be selected, firing the
selection handler and causing unwanted side effects.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11925
2023-06-23 08:09:53 -04:00
bc0da92703
Fixes after merge request feedback
2023-06-22 16:20:05 +00:00
2651d7ff5b
Fixes crash in wire property dialog
...
Fixes crash when changes are applied with the style combo in the
indeterminate state.
2023-06-22 16:20:05 +00:00
85f889bc19
Fields: Description now mandatory
...
Propagate from symbols to footprints, footprints keep a library
description, too. (GetLibDescription())
2023-06-20 18:34:52 +00:00
7d84fa2a9d
Validators: drop unused is m_isLibEditor
2023-06-20 18:34:52 +00:00
ddafa2e75d
Common: move SCH_FIELD_VALIDATORS to FIELD_VALIDATORS
...
Fields are now common across PCB/SCH
2023-06-20 18:34:52 +00:00
b1cdcca9e6
Use hypertext link for Edit Ingored Tests in both ERC and DRC.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15010
2023-06-19 23:53:42 +01:00
e3eb0abc5f
Recompute intersheet refs while printing.
...
Also fixes a bug where the schematic offset wasn't being added to
intersheet refs when printing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14978
2023-06-17 18:12:13 +01:00
f9d4b75726
Symbol Fields Table: performance optimizations
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14972
2023-06-17 12:56:00 -04:00
d3be62f644
Adapt panels to PAGED_DIALOG sizing algorithm.
...
Also some cosmetic fixes (GTK).
2023-06-16 19:12:37 +03:00
caf0bb6baa
Cosmetic fixes in schematic formatting panel (GTK)
2023-06-16 19:12:37 +03:00
f5da58e17d
PAGED_DIALOG: allow setting initial size in ctor.
2023-06-16 18:53:00 +03:00
1f5719ef3a
Pass proper parent to symbol viewer frame when changing symbols
...
Fixes sentry KICAD-1Z9
Fixes sentry KICAD-22J
2023-06-14 21:25:06 +01:00
782c73300b
Move drawing sheet datastructures to EDA_IU_SCALE.
...
Or mostly, at least. Plotters still define their own mils-to-iu scale.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14934
2023-06-12 22:34:25 +01:00
62f24aca1e
Fix Connectivity Asserts in new COMMIT structure
...
The connection graph should only be updated within the commit structure
because this is the only time the connectivity should be changed. We
want any connectivity changes to be included in the commit as well, so
this should be stored prior to the undo/redo list mods
2023-06-12 13:35:06 -07:00
a29f261d31
dialog_sim_model: ensure the Model panel is always correctly built.
...
Fixes #14904
https://gitlab.com/kicad/code/kicad/-/issues/14904
2023-06-12 16:41:21 +02:00
8f1b9119bf
Upgrade some symbol editor stuff to SCHEMATIC_COMMIT.
...
Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
2023-06-09 22:41:47 +01:00
e698156975
Upgrade many editing actions to SCHEMATIC_COMMIT.
2023-06-09 22:41:47 +01:00
73b653c276
Upgrade more dialogs to SCHEMATIC_COMMIT.
2023-06-09 22:41:47 +01:00
dcfd426333
Upgrade some dialogs to SCHEMATIC_COMMIT.
2023-06-09 22:41:47 +01:00
639da0eb5a
Fix a wxWidgets alert when deleting the last entry in a lib table.
2023-06-09 08:09:22 +02:00
30cbfc794f
Cross-probing from Pin Table to Symbol Editor canvas.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8301
2023-06-07 14:37:34 +01:00
6e2bea8128
Symbol Fields Table: fix grid tricks show/hide column corruption
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14874
2023-06-05 08:27:26 -04:00
fb7925806c
Symbol Fields: allow hiding reference column
2023-06-05 08:27:26 -04:00
26c25c5475
Move bitmap setup to ctor in eeschema annotation options.
2023-06-05 15:03:03 +03:00
f3d3ade1dc
Increased mutex safety.
...
Don't even query the size() without having at least a shared_lock.
*May* prevent KICAD-4S, but seems unlikely.
2023-06-05 11:01:10 +01:00
039f23eba8
Symbol Fields Table: check against data model col for grouping
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14870
2023-06-04 14:42:55 -04:00
bb6555ff36
Symbol Fields Table: remember export filename
...
https://gitlab.com/kicad/code/kicad/-/issues/14872
2023-06-04 13:45:07 -04:00
9e6c56525a
EEschema, DIALOG_SYMBOL_FIELDS_TABLE: minor cosmetic fix
...
Fixes #14868
https://gitlab.com/kicad/code/kicad/-/issues/14868
2023-06-04 17:24:07 +02:00
5875f89531
Centralize text size clamping.
...
Also introduces alg::clamp to improve readability of
std::max( min, std::max( value, max ) )
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14876
2023-06-03 20:29:51 +01:00
04532a61f4
Symbol Fields Dialog: don't change sheets on load
...
Late bind the range selection event so we don't lose our selection as a
result of loading data into the table, then jumping to the selected
value.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14186
2023-06-02 08:22:10 -04:00
0eb45a7f27
Schematic: symbol fields dialog: restore size, not min size
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14861
2023-06-01 18:02:57 -04:00
cfb45be71e
Improved tooltips for all-unit-interchangeable and De Morgan.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14583
2023-05-31 17:54:19 +01:00
6b845b9054
Fix compil warnings and a wxWidgets alert.
2023-05-30 09:00:46 +02:00
688a61df63
Add options editor to symbol library table + cleanup unused options
2023-05-28 23:56:42 +02:00
a119bd604d
Refactor: Move DIALOG_PLUGIN_OPTIONS to common and use enum for event ID
2023-05-28 23:56:41 +02:00
1518ddde74
Push much of text var autocomplete down into SCINTILLA_TRICKS.
...
Shared code == fewer bugs. Well, in theory anyway....
2023-05-25 10:24:50 +01:00
c08f482ed4
Eeschema, panel color settings: minor fix: ensure color swatches are show/hidden
...
according to the option Override Colors state.
2023-05-21 14:16:11 +02:00
d4c9d9d60a
Fix issue with colours in the new lazy-loaded preference panels.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14784
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14782
2023-05-21 10:56:21 +01:00
102d61ed39
Terminology cleanup.
2023-05-20 21:04:39 +01:00
58f4943597
ADDED voltage- & current-controlled voltage & current sources
...
Added GUI support for ngspice VCVS, VCCS, CCVS and CCCS.
2023-05-20 21:04:39 +01:00
8b1fd62d35
Make pad & via teardrops 1st-class citizens (props of the pad/via)
...
Change teardrop generation to rely more heavily on BOARD_CONNECTIVITY
for improved performance.
Add updating of teardrops on BOARD_COMMIT::Push().
Also converts m_CopperItemRTreeCache to std::shared_ptr.
We don't copy it around anyway, and having to create a new set
of std::unique_ptr's for each operation is likely to be more
expensive than std::shared_ptr's overhead.
2023-05-19 18:02:03 +01:00
831a6d55fc
Fix potential stale pointer bug in schematic highlight connection code.
...
SCH_CONNECTION objects are temporary and can become stale any time the
connectivity is updated. Keeping them around to reference later is a
bad idea. Even if the object pointer is still valid in an SCH_ITEM in
the undo/redo buffers, comparing the pointer against another pointer as
a test to see if they are the same connection is not valid. Saving the
connection name is safe and ensures the connection is the same even if
the pointers differ.
2023-05-16 20:06:21 -04:00
3be8bfe193
Fix a few Coverity warnings (not initialized vars)
2023-05-14 10:11:38 +02:00
ddc6ecf7be
Lazy loading of Schematic Setup panels.
2023-05-11 11:43:10 +01:00
9ae8255202
Insta-prefs.
2023-05-10 18:14:14 +01:00
fdcc97e604
De Morgan conversions are equivalences, not additional items to simulate.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14230
2023-05-09 18:09:15 +01:00
7a7a23c83a
Fix crash when database lib config is not valid
2023-05-07 09:06:37 -04:00
b41d446f58
Fix a bunch more issues with sheetpaths and allowExtraText.
...
A sheetpath is required to correctly resolve text variables.
Depending on currentSheet is rife with bugs.
There are many places where we do *not* want to be prepending
field names to the field values, such as netlisting,
building PDF hypertext menus, etc.
Also, Find/Replace needs to work on unresolved text, as
that's what we're going to display (and if replace nuked
your variable references you wouldn't be happy).
2023-05-05 17:23:52 +01:00
4c2fcb6614
Line width in Plot dialog is minimum, not default.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14367
2023-05-03 17:34:36 +01:00
b53f337938
More accurate terminology for cross-probe settings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13088
2023-05-03 10:50:31 +01:00
df7d62fdd3
Added a sort-order dropdown to lib-tree filters.
...
Also simplifies the scoring algorithm so that it only
differentiates between exact-match, match-at-start and
any-match. The rest of the position-based matching
stuff is gone, as is the knowledge of the name vs the
keywords vs the description. All that is left to the
provider of the weighted search terms array.
2023-05-01 21:26:43 +01:00
39cc686dc4
Back Annotation: add support for DNP and Exclude from BOM attributes
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14584
2023-05-01 08:54:14 -04:00
c1bebf6490
Symbol Fields Table: fix crash
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14532
2023-04-30 10:53:46 -04:00
dc847db19d
Add initial support for database library settings UI
...
For now, just for diagnostic purposes (settings changes are not preserved)
2023-04-29 18:15:00 -04:00
f4b43617e7
Add COMMIT structure to Schematic and Symbol editors
...
Provides a single-point access for modifying the schematic and symbol
elements that allows chaining updates and reverting partial changes.
Standardizes the undo hierarchy between pcb and schematic editors
As this is another layer on the existing undo/redo structure, the
initial commit does not replace all undo/redo calls currently existing.
These will be handled in a series of follow-on commits
2023-04-28 17:05:47 -07:00
ae7456e055
SYMBOL_LIB_TABLE and PANEL_SYM_LIB_TABLE: fix some issues:
...
- Ensure a change in plugin type is detected
- do not force automatic plugin type selection for *.lib files that need
an access to these libraries: they can be not always available.
2023-04-27 12:54:18 +02:00
d816fb071f
Use fileds from flattened lib symbol when updating.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14577
2023-04-26 12:47:55 +01:00
69500bfcaa
LTSpice schematic import based on the work of Chetan Shinde.
2023-04-24 13:52:52 +01:00
c617abe8e9
SCH_BITMAP and PCB_BITMAP: rename m_image to m_bitmapBase. Add more info
...
in GetMsgPanelInfo() (PPI, scale).
m_image name was confusing: it is not a wxImage, but a BITMAP_BASE item,
and m_image name was already in use in BITMAP_BASE, used inside SCH_IMAGE.
Bitmap properties dialog: show PPI value and add Title to dialog.
2023-04-22 17:28:06 +02:00
6e8a5acc66
Bug Fixes for new incremental connectivity
...
- Ensure that critical paths (ERC/netlister) are fully-rechecked
- Handle symbol/pin distinction in change markers
- Fully connect hierarchical pins in one pass descending
2023-04-21 13:35:18 -07:00
a154571438
Add ability to update subgraphs based on changeset
...
Previously, almost all connectivity updates were full updates, meaning
that the entire connectivity graph would be rebuilt each time a change
was made to the schematic. This update modifies the update to only
correct the subgraphs that are directly affected by the change.
It uses the existing connection graph to find all affected subgraphs as
well as connections to the changes based on the visible schematic.
These elements are removed from the existing connectivity graph and
marked dirty. They then have a new connectivity graph built only around
their changes. The resulting graph is merged into the original.
Currently, this ability is behind an advanced config flag
`IncrementalConnectivity` while testing.
Fixes https://gitlab.com/kicad/code/kicad/issues/10846
Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-19 16:14:35 -07:00
09d7e24b6d
Symbol Fields Editor: drop some settings dynamic_casts
...
Not needed, and confusing.
2023-04-19 09:52:31 -04:00
2c34a08bf1
Ignore empty field-name-templates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14552
2023-04-18 17:31:25 +01:00
d4b4abd001
Apply symbol attributes from base symbol, not derived symbol.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13740
2023-04-15 17:47:32 +01:00
d64cb7f81b
More uniform handling of power symbols and exclude-from-simulation.
2023-04-14 19:42:13 +01:00
9f56b75f01
Clean up atrophied code.
2023-04-14 19:42:13 +01:00
4eb0ccffe5
Bring Sim Command dialog layout in line with Kicad std dialog layout.
2023-04-14 13:00:31 +01:00
75267a7366
Fixes issues pointed in the reviews
...
Wraps string literals with 'wxS', form is generated by wxFormBuilder
2023-04-14 11:01:01 +00:00
82e8198fee
Adds missing transient simulation settings
...
Adds maximum step size setting used by transient analysis solver,
and 'use initial conditions (uic)' setting. Enabling uic disables
DC operating point analysis and may introduce singularities. It requires
a careful selection of initial conditions of circuit elements.
Fixes https://gitlab.com/kicad/code/kicad/issues/2515
2023-04-14 11:01:01 +00:00
8e29a054f3
Performance improvement for GetShownColumns.
...
(This needs to be fast as it's called from OnUpdateUI events.)
2023-04-13 13:45:22 +01:00
6c05801d9e
Make the property grid compatible with wx 3.3
2023-04-12 18:57:12 +01:00
ea59d583d5
ADDED exclude-from-simulation property to text items and textboxes.
2023-04-09 19:03:36 +01:00
c6bcfda84c
DIALOG_IMAGE_PROPERTIES: fix some issues:
...
- add missing dialog_image_properties_base.fpb file
- fix not displayed image.
2023-04-08 16:41:55 +02:00
16b4ec3c7e
Allow bus elements to connect
...
Previously, bus elements that were not instantiated as individual nets
could not connect to each other. This caused issues for complex
schematics where busses needed to connect to other busses with elements
that resolved to the same net names. Functionally, this means mixing
bus elements, which we will replace with first-class elements in version
8 but currently can only be accomplished either by using bus aliases and
this patch or by individually instantiating each bus element as a
local label
Fixes https://gitlab.com/kicad/code/kicad/issues/14300
2023-04-04 15:23:29 -07:00
247c2edbed
Symbol Fields Table: various bug and coverity fixes
2023-04-04 11:27:09 -04:00
791a9e6c78
Symbol Fields Table: fix up Rename field function
2023-04-04 11:27:09 -04:00
b7b7dc6558
Symbol Fields Table: general settings saving cleanup
2023-04-03 09:07:52 -04:00
9c3d93eb34
BOM Generator: wire up forced exclusion, optional DNP exclusion
2023-04-03 09:07:52 -04:00
79a829395d
BOM Generator: minor bug fixes and string changes
2023-04-03 09:07:52 -04:00
c5cc313da9
Symbol Fields Table: BOM presets saved in JSON settings
2023-04-03 09:07:52 -04:00
753ae21fd4
BOM Generator: wire up to kicad-cli
2023-04-03 09:07:52 -04:00
8433f94886
Symbol Fields: move more strings to template field names usage
2023-04-03 09:07:52 -04:00
6a726709b5
Symbol Fields Table: wire up BOM format presets
2023-04-03 09:07:51 -04:00
bb7d55e5a4
Symbol Fields Table: fix Qty column
...
Really need to refactor these strings out of everything...
2023-04-03 09:07:51 -04:00
106747a03b
Symbol Fields Table: file chooser + working export
2023-04-03 09:07:51 -04:00
b59fd76c15
Symbol Fields Table: export formatting options started
...
Also move export into the data model and out of the dialog so we can
eventually do this without a GUI.
2023-04-03 09:07:51 -04:00
97eed8c8a2
Fields Data Model: pull more UI controls interaction out of class
2023-04-03 09:07:51 -04:00
cccd708860
Symbol Fields Table: move data model into its own file
2023-04-03 09:07:51 -04:00
21c81b19fa
Symbol Fields Table: upgrade dialog in prep for exporter
2023-04-03 09:07:51 -04:00
a39ce5bf9e
Dialog Symbol Fields Table: allow re-labeling columns
2023-04-03 09:07:51 -04:00
d117d4e8f5
Symbol Fields Table: Add Presets
...
No backing store in JSON settings yet.
2023-04-03 09:07:51 -04:00
f98e36efa9
Symbol Fields Table: allow hiding references
...
If that's what the user wants, let them.
2023-04-03 09:07:51 -04:00
9b942ee8f3
Symbol Fields Table: fix up some display/field/canonical name confusion
2023-04-03 09:07:51 -04:00
d8df792c6a
Fields Symbol Table: really move columns when the user moves them
...
Move the internal columns and rebuild the table when a user moves the
columns. This is the only way to fix selection issues across reordered
columns.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12295
2023-04-03 09:07:51 -04:00
79b20812d0
Symbol Fields Table: move towards field names instead of fixed indices
...
Qty column can now be hidden.
We eventually need to get to the point that we are able to rearrange the
columns in the internal data model to work around wxGrid selection
issues.
2023-04-03 09:07:51 -04:00
1982c1af80
Symbol Fields Table: save current table properties
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5006
2023-04-03 09:07:51 -04:00
e53ee9df4b
Symbol Fields Table: add rename column functionality
2023-04-03 09:07:51 -04:00
7252c7471c
Use enums for column ids.
...
(The nickname, in particular, is no longer column 1.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14291
2023-04-02 15:10:06 +01:00
1788db53e5
Don't complain about no sim model when running Sim Model Editor dialog.
...
Also removes some atrophied code, and makes sure changes to the parameter
grid for raw spice models gets saved.
2023-03-25 20:22:04 +00:00
a0d02fbab1
Make multivector.h header order independent.
...
Attempt to clean up all redundant headers that multivector.h touches.
2023-03-23 13:26:32 -04:00
016c958021
Always build spice simulator support
...
The simulator has advanced considerably, and it is seeing lots of active
development, so make it a required part of KiCad. Additionally, the
build without the simulator has actually been broken for a while, so no
one clearly is building without ngspice right now.
2023-03-20 16:54:32 +00:00
ef0d561a5c
Less nagging. (If we need a field name, then create one.)
...
Also cleans up empty fields when exiting the dialog.
2023-03-19 20:43:18 +00:00
afe813cae5
Remove accelerator keys from schematic find/replace dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14304
2023-03-18 23:33:23 +00:00
e8ead30baf
WIP: CADSTAR Parts now shows up in library tables and is handled correctly (todo: read cadstar header)
2023-03-16 21:07:05 +01:00
6d296038f3
Improve simulation error reporting.
...
1) More REPORTER, less exception processing
2) Remove UI calls from SPICE_MODEL
3) Don't replace netlist with errors; show both
4) Don't bail out of netlist generation after single error
Fixes https://gitlab.com/kicad/code/kicad/issues/14295
2023-03-16 16:12:29 +00:00
8b144539e8
DIALOG_LABEL_PROPERTIES, add global label: better filtering of candidates.
...
The list of candidates (names) must be restricted to existing global labels
and symbols creating a global net name: power symbols having only one power
input pin (a power output does not create net name).
Fixes #14319
https://gitlab.com/kicad/code/kicad/issues/14319
2023-03-16 15:31:39 +01:00
37b0a5a504
Add quick DRC action for Diff Footprints.
...
Also makes the strings match the GUI better so people will know where
to find them later.
And fixes a couple of ERC items that referred to Board Setup (oops).
2023-03-14 11:52:23 +00:00
66f6168163
Fix mode-less dialog issues.
...
Don't assume the dialog is mode-less and call Destroy() from within a
dialog method. This will most assuredly crash if the dialog is shown
modally or quasi-modally.
Don't leak memory for mode-less dialogs created on the stack. Make sure
when the parent frame window is closed that all mode-less dialog memory
is cleaned up. Dialogs are not child windows like controls and toolbars
so their memory does not automatically get cleaned up when the parent
window is destroyed.
Do not directly access frame parent window's pointer in dialog destructors.
Apparently the tear down order when destroying mode-less dialogs is not
guaranteed so the parent window may get deleted before the dialog causing
a crash when accessing the parent window pointer from the dialog dtor.
Do not close mode-less dialogs in the parent frame's destructor. This
doesn't guarantee that the dialog(s) will be destroyed before the parent
but it may reduce some careless mode-less dialog event handling in the
future.
2023-03-13 12:04:01 -04:00
c4ef08bead
Exercise more caution with user filenames.
...
In particular, don't assume "1" is an extension in "Schematic_1.1".
Fixes https://gitlab.com/kicad/code/kicad/issues/14263
2023-03-12 15:52:45 +00:00
b32ba16da4
UI: Add Numpad Enter as "Return" equivalent in missing places
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14244
2023-03-10 16:25:17 -05:00
bc0d59801a
Graphical diff for schematic vs library symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13736
2023-03-09 18:04:52 +00:00
13de3c0656
Use constants for the names of the built-in colors
...
- Avoid repetition and errors from typos
- Allow simple changes
- Simpler data type handling, the constants are wxString
(Cherry-picked from f135881bd6
2023-03-07 10:34:42 +00:00
a1fb8e1b1d
Coverity fixes and code cleaning.
2023-03-06 07:12:18 -05:00
7547e550aa
Use name (even for fallback models) *if* it's specified in dropdown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
2023-03-06 11:17:39 +00:00
610e787ada
Move to requiring explicit action to save project settings
2023-03-04 14:25:07 -05:00
4e99812145
Coverity fixes and code cleaning.
2023-03-04 13:02:05 -05:00
d1b7fa6b0f
Slight improvement to property grid col widths in SME.
2023-03-04 00:10:01 +00:00
b6d0b65261
Naming conventions and commenting. No functional changes.
2023-03-04 00:10:01 +00:00
48740dd3f8
Clean exposure of CONNECTION_SUBGRAPH
...
Removes internals from public consumption.
2023-03-03 14:07:17 -08:00
d545216432
Prefer Clamp() to std::min( std::max() ).
2023-03-03 21:29:37 +00:00
59fc62e898
Correct parent symbol for lib_text
...
The edited symbol should be pulled from the parent window when there is
not an existing text object
2023-03-03 12:39:07 -08:00
f41f04b301
Hook up AddField handler to GRID_TRICKS for SCH dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/git/14153
2023-03-02 18:17:41 +00:00
789bf6455a
Coverity fixes and code cleaning.
2023-03-02 09:04:47 -05:00
Mike Williams
Jeff Young
Marek Roszko
Jon Evans
Alex Shvartzkop
Seth Hillbrand
Roberto Fernandez Bautista
jean-pierre charras
Wayne Stambaugh
Josue Huaroto
Ian McInerney
Fabien Corona
Ian McInerney
Youbao
Erik Agsjö
Okan Demir
Salvador E. Tropea