0b187e7122
SCH/LIB SYMBOL: never allow null LIB_SYMBOLs in SCH_SYMBOL
...
Also always always flatten incoming lib symbols.
2024-06-10 08:36:42 -04:00
ed0869aa0c
Share more library tree code.
2024-06-08 19:06:10 +01:00
cb7d51dbe4
Formatting.
2024-06-07 12:10:41 +01:00
d8c2929163
SCH_SHEET_PATH::IsContainedWithin() didn't do what I thought it did....
2024-06-07 12:09:58 +01:00
c0ee987e8b
Fix typo.
2024-06-07 10:52:11 +01:00
360d185e3b
Clear parent symbol references when flattening derived library symbols.
...
Broken parent symbols could lead to invalid return values and flattened
library symbols cannot be derived from a parent symbol.
2024-06-06 18:53:27 -04:00
6dcb9bb664
Do not allow trailing/leading whitespace in mandatory fields
...
Reference, Value, Footprint and Datasheet all reference elements that
should not use trailing/leading whitespace or similar hidden charaters.
Other fields may utilize leading/trailing whitespace for obscure
purposes but won't break functionality as they are display only
2024-06-06 11:48:20 -07:00
edc7603d2a
Make it clear that GetSheets() is heavy.
...
Also removes the side-effect that SCH_SHEET_LIST's
c'tor would sort the list (and write virtual page
numbers) anytime the starting sheet was the root.
Also, definitely don't build a SHEET_LIST (sorted or
otherwise) if you're not even going to use it.
Also don't build SCH_SHEET_LISTs on idle events. Better
to just always have the Next Sheet button enabled (we
already beep if you click it and there's no next sheet).
Also, use a SCREEN_LIST when you can. It's much cheaper
to create.
2024-06-06 18:00:59 +01:00
cbfc692e24
Performance for large hierarchies: symbol fields table
...
Don't bother to sort sheet list when we're going to
sort the symbols anyway.
2024-06-06 11:53:01 +01:00
758974f5aa
Performance for large hierarchies: sorting
...
Cache page numbers during sort.
Don't construct SCH_SHEET_PATH when reference will do.
Don't construct SCH_SHEET_PATH when KIID_PATH will do.
2024-06-06 11:53:01 +01:00
a6e8cfe35f
Performance for large hierarchies: avoid sorting
...
Don't sort SCH_SHEET_LISTs if we're just scanning the doc.
2024-06-06 11:53:01 +01:00
44c588f122
Performance for large hierarchies: lazy eval
...
Don't create SCH_SHEET_LISTs until we have to, and then
only create them once.
2024-06-06 11:53:01 +01:00
e543ff0578
Performance for large hierarchies: lookups
...
Don't bother to sort sheet lists when we're just looking
up a UUID, sheet count, other symbol units, etc.
2024-06-06 11:52:57 +01:00
68fbe98b1d
Performance for large hierarchies: ERC
...
Share constructs between ERC tests.
Large SCH_SHEET_LISTs, in particular, can be very
expensive to construct.
2024-06-06 11:41:37 +01:00
82b310f666
Do not update schematic editor net navigator when it's not shown.
...
Since the addition of all nets to the net navigator, performance on very
complex designs is unacceptable. Not updating the net navigator is a
cheap and dirty short term fix. Users with complex designs will not be
able to use the net navigator. A better fix to resolve the performance
issues needs to be implemented.
2024-06-05 11:46:19 -04:00
8e855156c8
Import child sheets relative to project, not parent.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17785
2024-06-04 17:47:55 +01:00
7679f40b2b
SCH_REFERENCE: drop separate pointer to LIB_SYMBOL
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/18115
2024-06-04 10:03:00 -04:00
42caceb799
Tidy incorrect column width (and fix some formatting).
2024-06-04 13:00:02 +01:00
e5bad195b6
Fix a bunch of failures to resolve text variables.
2024-06-04 12:46:34 +01:00
26fc2bd071
Reduce compiler warnings.
2024-06-04 11:18:45 +01:00
a74e834b33
Formatting.
2024-06-04 11:16:11 +01:00
9f2c9636f0
Update conn minor check to use Advanced Config
2024-06-03 11:56:37 -07:00
74998790e8
Turn off incremental connectivity for small schematics
...
The benefit of incremental connectivity is only for larger
schematics. For smaller schematics, the downside of larger bug surface
outweighs the current benefits
2024-06-03 11:33:29 -07:00
32289ffce7
schematic: fix broken undo of sheets, new and changed
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11855
2024-06-03 13:45:52 -04:00
549ea93be2
Fix typo
2024-06-03 10:41:37 -07:00
ec0fdfffff
ADDED: markers for excluded-from-sim items.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 17:12:15 +01:00
5e1a16e821
Regularize DNP printing & plotting with painting.
2024-06-03 12:53:37 +01:00
aca73b699c
Fix uninitialized variables.
2024-06-03 11:44:10 +01:00
6aab0d66c2
Fix uninitialized variables.
2024-06-03 11:44:10 +01:00
900c7e0257
Centralize exclude-from-sim processing.
2024-06-03 11:44:10 +01:00
40854cec0e
Remove cover types.
2024-06-03 11:44:10 +01:00
aee7680a6c
ADDED: support for DNP & friends at the sheet level.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14387
2024-06-02 22:41:22 +01:00
1f69680d91
Expose global Field Name Templates to symbol editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2382
2024-06-02 19:31:27 +01:00
14f3a22f3d
ADDED: support editing unit in Reference Field Properties.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17362
2024-06-02 13:42:34 +01:00
4a01f322ff
Special-case hit-testing of filled schematic rule areas.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17879
2024-06-01 22:48:02 +01:00
11193d2cda
Make sure ERC pin-to-pin checks are always in same order.
...
Comparing U1.pin1 : U2.pin1 will return the same
results as U2.pin1 : U1.pin1, but will result in a
different serialization of any exclusions.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17004
2024-06-01 11:37:34 +01:00
878a795be1
Formatting.
2024-06-01 11:37:34 +01:00
79a354bf0e
Unify SCH_PIN ambiguity in equality operator
...
Remove != operator that is not used for C++20 and reworked
SCH_PIN==SCH_ITEM operator that was not reciprocal
2024-05-31 13:42:36 -07:00
a9ae86eefd
Cleanup geometry functions
...
Added Distance(VECTOR2) function that returns a double. Removed
superfluous EuclideanNorm, GetLineLength, integer constructor for
EDA_ANGLE (this promotes to double in the CTOR), DistanceLinePoint and
HitTestPoints
Also extended the size for arc calculations that get distances to center
points to avoid overflow
2024-05-31 12:26:37 -07:00
1322e0bc73
symbol editor: allows rotation of fields in derived symbols.
...
Fields in derived symbols are editable, so the context menu must allow rotations.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18003
2024-05-31 17:32:31 +02:00
ac59a65d8d
Resolve variables in LIB_SYMBOLs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18099
2024-05-29 22:52:55 +01:00
d82522304c
Improve clarity.
2024-05-29 19:53:20 +01:00
ec89d2c22e
Formatting.
2024-05-29 17:56:15 +01:00
cc350cf279
symbol fields table: remember includeExcludedFromBOm correctly
2024-05-29 08:41:25 -04:00
bab97f91cc
Tidy up string find API usages.
2024-05-28 15:30:29 +01:00
43a622cadf
Ensure we are checking all ERC errors
...
Also, handle the possiblity that we return NULL when calling
DeserializeFromString in the case where we don't handle all cases or the
file is corrupted
2024-05-28 06:55:34 -07:00
07470efc0b
Autosize bitmap buttons in wxFB.
2024-05-27 00:12:55 +03:00
df3eaf0e03
Trim before sorting.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17046
2024-05-26 19:28:24 +01:00
8204577fba
Throw duplicate pin error as it prevents other checks.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14761
2024-05-26 16:18:54 +01:00
b2e0c2606f
Avoid referencing parents after deletion
...
We look at the parent when deleting EDA_ITEMs but when clearing the test
sheet, we delete the sheet before the pin, causing a use-after-free.
Avoid this by setting parents to null in this case
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17961
2024-05-26 07:35:46 -07:00
Mike Williams
Jeff Young
Wayne Stambaugh
Seth Hillbrand
jean-pierre charras
Alex Shvartzkop