13c647ef6f
Fix resources leak reported by coverity
...
For unique_ptr, release only set the ownership to null, but don't free the resource behind. On the other hand, reset do.
Closes Coverity ID 483269
Closes Coverity ID 471974
Closes Coverity ID 471973
2024-03-03 16:23:49 +00:00
c76c4ba304
schematic: do not skip item repaint if item's parent type != SCHEMATIC_T
...
the item repaint was skipped when unhighlightning symbols after dragging
and unselecting.
Fixes https://gitlab.com/kicad/code/kicad/issues/17193
Fixes https://gitlab.com/kicad/code/kicad/issues/17206
2024-03-03 16:21:29 +00:00
4851b0f1ac
Database library cache: fix memory leak
2024-03-03 16:20:32 +00:00
66b378087a
Remove close button from pcbnew search panel
...
For consistency with the other panels, removes the circular 'x' close
button from the search panel. Toggling visibility remains possible
through the View menu
2024-03-03 16:18:23 +00:00
0c8e08ed58
Move some language changes to a event on the frame
2024-03-03 11:02:26 -05:00
0bde79bd6c
PCB_PAINTER: do not draw PCB_SHAPEs on netname layer in FP editor.
...
Fixes #17250
https://gitlab.com/kicad/code/kicad/-/issues/17250
2024-03-03 17:00:17 +01:00
66925ec2a2
Update net navigator when cross probing from board editor net highlight.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16838
2024-03-03 08:56:48 -05:00
fe1c73ed7c
Performance: Cache BOARD::GetMaxClearanceValue
2024-03-03 13:54:46 +00:00
f6cf78fd7c
plot_board_layers.cpp: when plotting pads, Save/restore corner radius ratio
...
instead of corner radius.
The corner radius comes from corner radius ratio, so saving/restoring the corner
radius can create rounding errors when trying to recalculate the ratio from the radius.
2024-03-03 11:56:41 +01:00
612c7015a7
REMOVED: Clicking on pin selects symbol setting
...
This is now redundant with the selection filter
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17114
2024-03-02 22:18:51 -05:00
c51e9917ba
Fix ordering of selection filter and net navigator
2024-03-02 20:21:16 -05:00
585cf841e5
Create a singular point for events like EDA_EVT_UNITS_CHANGED to be exported out of kicommon
2024-03-02 16:29:08 -05:00
ed18a9bcc2
Correctly handle footprint graphic knockouts for no-net case
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17223
2024-03-02 15:39:07 -05:00
3a3ceb8ffc
Allow specifying a minimum for a via_count constraint
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17234
2024-03-02 15:26:28 -05:00
b8f4bef3f8
Set schematic as default screenshot
2024-03-02 15:06:46 -05:00
fdc16fe60d
Remove project manager from screenshots
...
It's not very important or visually appealing,
let's just use the editors as the way to represent
KiCad in software centers that show screenshots.
2024-03-02 15:05:38 -05:00
46f9a9a005
Make the update check cmake option default for all platforms
2024-03-02 14:15:52 -05:00
9c371e2ef5
Don't draw the selection if it's not from the current screen.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17132
2024-03-02 18:57:39 +00:00
a4929f9c27
Step exporter: handle circles correctly
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17137
2024-03-02 19:09:33 +01:00
d458bcad16
kicad_cli fp ugrade: create directory with extension
2024-03-02 18:21:13 +01:00
d81605f4ea
DIALOG_PAD_PROPERTIES: fix a incorrect test to show a warning.
2024-03-02 17:16:27 +01:00
1082930c34
Don't steal command-keys from a wxGrid.
...
It's unlikely to win you friends.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17229
2024-03-02 15:28:22 +00:00
428f2087bd
Eeschema: fix crash when editing a old legacy schematic with missing libs,
...
and trying to edit a dummy symbol. (crash due to a null pointer due to missing lib)
Fixes #17232
https://gitlab.com/kicad/code/kicad/-/issues/17232
2024-03-02 15:23:23 +01:00
c97c69a2f0
First alt-pin menu item must be fetched from the LIB_PIN.
...
(The SCH_PIN will return any alt function already assigned.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17221
2024-03-02 12:17:22 +00:00
43e1b36d4d
SHAPE_LINE_CHAIN: Fix indices rotation after clipper
...
Also fix IsArcStart and IsArcEnd functions to work with chains that only
have arcs.
2024-03-02 12:09:09 +00:00
0d340d0610
SHAPE_LINE_CHAIN: Move .h definitions to .cpp
...
No functional changes, just allow faster rebuilds
2024-03-02 12:09:09 +00:00
8c22f8df31
SHAPE_LINE_CHAIN: Fix/unify constructors
2024-03-02 12:09:09 +00:00
5920ee4598
SHAPE_LINE_CHAIN: Add test case of seg+large angle arc
2024-03-02 12:09:09 +00:00
4508512343
Sanitise filename before saving footprint library
2024-03-02 13:06:23 +01:00
a4a99e3aff
kicad_cli: Allow upgrade of legacy and non-kicad footprint libraries
2024-03-02 13:06:23 +01:00
70fe2a8f1e
kicad_cli: Allow upgrade of legacy and non-kicad symbol libraries
2024-03-02 13:06:23 +01:00
bd1d449cd3
Check for NETINFO_ITEM before dereferencing it.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17230
2024-03-02 11:37:22 +00:00
1ee49cca5e
FOOTPRINT_CHOOSER_FRAME: rework on bottom panel to allow a long string in
...
the check box for filter by FP names to be displayed without overlapping other
widgets.
2024-03-02 11:24:54 +01:00
1297ddc88d
pcbnew: Added default master pad properties
...
CHANGED: Automatically selects the right pad type for the footprint type. Resets the pad properties if the master pad properties do not match the pad type.
https://gitlab.com/kicad/code/kicad/-/issues/16563
2024-03-02 00:13:39 +00:00
464f185387
Performance
...
Cache VIEW_ITEM's bbox in VIEW_TREE for faster removals.
Fixes https://gitlab.com/kicad/code/kicad/issues/16841
2024-03-02 00:03:46 +00:00
0129191ec0
Limit where the intersection of two lines can be
...
This avoids generating lines where we are unable to select them because
they get too close to the border
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16959
2024-03-01 15:57:24 -08:00
8dddd9cc2c
Separate "use board stackup colors" into separate checkbox.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17085
2024-03-01 23:45:06 +00:00
14667e2033
Don't wait for unused events
...
We only need the UI update and mouse/keyboard while updating our DRC
window. Waiting for other events gets into a race condition with the
schematic editor that can cause a hang
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17003
2024-03-01 15:21:42 -08:00
e7d4127f99
Update contributors
2024-03-01 13:45:46 -08:00
d3334ed9f0
Do not re-number aperture pads
...
Aperture pads do not have numbers, so reserving space for them will
cause the actual numbered pads to become out of order
2024-03-01 13:04:19 -08:00
005affd473
FOOTPRINT_CHOOSER_FRAME: Fix a UI problem specific to Linux
...
On the bottom on the frame, some widgets were not correctly placed.
Fixes #17217
https://gitlab.com/kicad/code/kicad/-/issues/17217
2024-03-01 19:56:22 +01:00
0d03f2febc
When failing to import, ensure extant screen
...
We need at least the root screen in order to handle any action in
Eeschema. Because this is destroyed by starting to load the new
schematic, when failing, we need to reset to null.
This is not as good as resetting to the previous state but that will
take refactoring our file load routines in schematic editor
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16993
2024-03-01 18:48:14 +00:00
8d19d27483
Fix zone manager crash when no board is loaded
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17187
2024-03-01 15:58:01 +00:00
a902898522
schematic: legacy kicad schematic files don't have a default description field
...
Without this, we would parse a legacy schematic symbol field at the same
index as the new description field's index into description, instead of into
a user field.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17202
2024-03-01 10:40:03 -05:00
defcb49ac8
Support Altium Schematic ASCII import
2024-02-29 20:49:20 +00:00
656821b282
Improve 3D appearance manager preset compare.
2024-02-29 22:04:57 +03:00
41147dc3b3
kicad_advanced: Make OCE tesselation deflection configurable
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17168
2024-02-29 19:04:39 +00:00
24529e5242
ADDED: library tree context menu option to open sym/fp library files from the defined text editor.
...
Short description:
Works for Symbol and Footprint Editor behind an advanced config option.
For Symbol Editor it is shown for a single item selection (library or symbol).
For Footprint Editor it is shown for a footprint selection.
(fp editor allows a single tree item selection only).
Option stays hidden if current frame has been modified.
Also small fix(?) for similar action to the project manager.
(Call for the Execution has moved inside the file loop.)
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15736
2024-02-29 19:01:59 +00:00
15e963bb32
Don't leak blank_cursor on warp (X11)
...
Also, for completeness, unref cur_cursor which we ref'd before hiding
it.
2024-02-29 18:55:28 +00:00
48130c6982
The ruler tool is not part of InteractiveEdit.
...
(In particular, it should not return true to IsEditorTool().)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17164
2024-02-29 17:57:38 +00:00
Lucas Dumont
Petri Hodju
Roberto Fernandez Bautista
JamesJ
Marek Roszko
jean-pierre charras
Wayne Stambaugh
Yon Uriarte
Jon Evans
Jeff Young
Jan Wichmann
Seth Hillbrand
Ethan Chien
Mike Williams
Alex Shvartzkop
arturo182
aris-kimi
Johannes Maibaum