haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
33,703 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

8437 Commits

Author SHA1 Message Date
Mike Williams d9449b9beb Annotation: annotate all sheet instances for new symbols 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11841
 2022-07-25 18:44:55 +00:00
Mike Williams bf550afa8c Annotation: use full hierarchy for sheet based numbering on paste 2022-07-25 18:44:55 +00:00
Mike Williams 63917c4ef9 Annotation: disable use next number for page number based annotation 
It's broken, so don't allow it.
 2022-07-25 18:44:55 +00:00
Mike Williams 17f6c0ecf1 Annotate: correctly annotate duplicated items across reused subsheets 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11840
 2022-07-25 18:44:55 +00:00
Mike Williams 8db69c2f0d Annotation: convert annotate unique to use options method 2022-07-25 18:44:55 +00:00
Mike Williams 7c979e6375 Schematic: move annotation options parsing into common function 2022-07-25 18:44:55 +00:00
jean-pierre charras 993c446fdf Fix some warnings detected by PVS-STUDIO (most are not used vars) 2022-07-25 18:23:52 +02:00
Jeff Young e10158ff10 ADDED show pin names on footprint pads when assigning to symbol. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4576
 2022-07-24 23:41:41 +01:00
jean-pierre charras 82167a7c96 Avoid crashes when, for some reason, a dll cannot be loaded. 
In this case a null pointer was returned by the internal code.
This pointer is now tested against nullptr to avoid the application crashing.
Fixes #12080
https://gitlab.com/kicad/code/kicad/issues/12080
 2022-07-24 19:42:50 +02:00
Jeff Young e36491f231 Make EEschema highlight net consistent with PCBNew. 
In particular, highlight net on an already highlighted net clears
highlight.

Fixes https://gitlab.com/kicad/code/kicad/issues/11016
 2022-07-24 09:16:31 +01:00
Jeff Young 0e07ce9d2e Minor dialog cleanup. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11517
 2022-07-24 09:09:25 +01:00
Jeff Young 8b7d4a8869 Minor dialog cleanup. 2022-07-24 08:59:37 +01:00
jean-pierre charras 0604d7b813 Fix minor compil and Coverity warnings. 2022-07-24 09:33:43 +02:00
Jeff Young 3aabea5191 Add side handles to sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11525
 2022-07-23 23:57:31 +01:00
Jeff Young 3def3d659e Allow click-selection and greedy-drag selection of visible pin text. 
Stingy drag still works only on the pin itself.

Fixes https://gitlab.com/kicad/code/kicad/issues/11723
 2022-07-23 23:27:14 +01:00
Jeff Young 404015b0a5 Pay attention to units for page frames. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11408
 2022-07-23 20:17:04 +01:00
Jeff Young fa679d3601 Pinned libs can also be found in program settings. 2022-07-23 20:17:04 +01:00
Jeff Young f48755cc67 Restore unique-item filtering when collecting nearby items from view. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12076
 2022-07-23 15:09:58 +01:00
Jeff Young cb77e68076 Don't assume a SCH_EDIT_FRAME in EE_SELECTION_TOOL. 
It's also used in the symbol editor.

But in any case, pins of other units have no business being in an
SCH_SYMBOL anyway.

Fixes https://gitlab.com/kicad/code/kicad/issues/12076
 2022-07-23 14:28:07 +01:00
Jeff Young 16b9a7a1e5 Attempt to fix Locale issue. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9659
 2022-07-23 11:20:04 +01:00
Jeff Young 0d5302f375 Add preference for esc-clears-net-highlighting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8760
 2022-07-23 10:32:43 +01:00
Lorenzo Marcantonio 593eaf7ea3 Fix graphic glitch in eeschema when moving a field 
Fixes #12061
https://gitlab.com/kicad/code/kicad/issues/12061
 2022-07-22 11:41:30 +02:00
Jeff Young def87c969e Redo the pinned-libraries storage architecture. 
1) always use preferences directly
2) allow nicknames from either preferences or project
3) store-after-modify

Fixes https://gitlab.com/kicad/code/kicad/issues/12000

Fixes https://gitlab.com/kicad/code/kicad/issues/11892
 2022-07-22 09:31:10 +01:00
Jeff Young bdffbbd43b Handle rotation while moving from move tool. 
This keeps us from getting CancelInteractive events in the move tool
when the EditTool runs to do the rotate.

Fixes https://gitlab.com/kicad/code/kicad/issues/12004
 2022-07-22 09:31:09 +01:00
Jeff Young 9652dcf96d ADDED conversion between textbox and other text types. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12031
 2022-07-22 09:31:07 +01:00
passionateengineer 3389e456b1 Fixes inverted Y position in pin table. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11988
 2022-07-20 15:12:59 +00:00
Seth Hillbrand f78671fc2e Make textbox placement modal 
Placing a symbol from symbol editor starts the TwoClickPlace in a
different context.  We need to prevent multiple contexts of the same
tool

Fixes https://gitlab.com/kicad/code/kicad/issues/11891
 2022-07-19 09:20:43 -07:00
Jeff Young 45393f228a Promote pin selections to symbols when preference is set. 
Also make additional line slop zoom-relative.

Fixes https://gitlab.com/kicad/code/kicad/issues/12034
 2022-07-19 10:31:49 +01:00
Jeff Young e5a664c6b3 Try a slightly different tack for cancelling net highlighting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12029
 2022-07-19 10:31:49 +01:00
Alex c6d9dcdad5 Schematic editor: allow box-selecting pins. 2022-07-18 18:51:52 +00:00
Alex d343d87b73 Speed-up EE_SELECTION_TOOL::RequestSelection. 2022-07-18 18:51:52 +00:00
Seth Hillbrand 283446a3a8 Flag ERC error on non-stacked pins 
Pins that are explicitly connected in the schematic should not have an
"unconnected pin" ERC error.  But stacked pins do not count as
explicitly connected because the schematic designer has not connected
them

(cherry picked from commit 865bb54591)
 2022-07-17 20:17:11 -07:00
Seth Hillbrand 93fb00d815 Protect the Kiway dereference 
Also find a few more places where we are reaching into a new frame to
perform actions that need to have dialogs closed.

Running actions should also wait for the next cycle rather than being
immediately executed when we are calling into a new frame.  This allow
for the cleanup actions onClose() to happen prior to the next action
starting

Fixes https://gitlab.com/kicad/code/kicad/issues/11891
 2022-07-14 11:37:45 -07:00
Seth Hillbrand 00c7b64b13 Make annotation case-insensitive 
U1 and u1 are allowed but if they both exist in the same schematic, they
will throw an ERC and annotation error.  Reannotating will make them U1
and u2.

Fixes https://gitlab.com/kicad/code/kicad/issues/11862
 2022-07-14 09:56:48 -07:00
Mike Williams d44e34d513 Images: Add full properties editor 
Converts dialog_image_editor to panel_image_editor. Embeds this panel in
a new properties dialog for the schematic and PCB editors that allows
editing position, layer, locked status, etc. like other items.
 2022-07-14 11:23:23 +00:00
Mike Williams 1f4079802c Schematic: drop undefined/unused function 2022-07-14 11:23:23 +00:00
Seth Hillbrand b5bf1da251 Keep track of blocking windows 
Allows the calling KiWAY player to send messages to the blocking window
before signaling a separate call

Fixes https://gitlab.com/kicad/code/kicad/issues/11891

Fixes https://gitlab.com/kicad/code/kicad/issues/11772
 2022-07-13 19:25:24 -07:00
Seth Hillbrand 91e4d5e0ea Add Apply button to "Edit Text and Graphics" 
Allows the user to apply multiple sets of changes without closing the
window

Fixes https://gitlab.com/kicad/code/kicad/issues/11904
 2022-07-13 16:44:15 -07:00
Seth Hillbrand 0dab566270 Fix name escaping in symbol editor 
When renaming a symbol, be sure to handle name escaping in all of the
various places that we do renaming (!)

Fixes https://gitlab.com/kicad/code/kicad/issues/11939
 2022-07-12 12:06:30 -07:00
Jeff Young d24e6c3408 Auto-annotate (and then don't re-annotate) power symbols. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11942
 2022-07-11 21:46:01 -06:00
Jeff Young 57acce9e55 Share more code between selection tools. 2022-07-11 19:04:08 -06:00
Jeff Young c243c7e1b8 Don't lock user out of OK'ing libraries dialog. 2022-07-11 19:04:08 -06:00
Alex aaf99eb0cc Performance optimizations. 2022-07-11 21:25:12 +00:00
Mike Williams e454595348 Eeschema: Changing pin length adjusts offset according to orientation 
ADDED: When pin length is changed now, the pin position is adjusted
according to its orientation such that the connection point for wires
moves instead of the other side of the stem base. For pins coming out of
component boxes, etc. this keeps them attached to the box while the
length is changed.
 2022-07-11 13:58:06 -04:00
Jeff Young 0a623bff9f Save fp browser list widths and apply known hack to work around wxWidgets bug. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11744

Fixes https://gitlab.com/kicad/code/kicad/issues/11745
 2022-07-10 23:07:04 -06:00
Jeff Young d07c6699ce Bring symbol editor in line with eeschema for empty text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11799
 2022-07-10 20:37:26 -06:00
Jeff Young 4685dc49cc Show more than 9 items in disambiguation menu. 
(But only the first 9 get hotkeys.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11966
 2022-07-10 20:11:22 -06:00
Jeff Young b759d860c0 Don't disambiguate if the user is dragging a multiple selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10108
 2022-07-10 19:45:56 -06:00
Jeff Young e122dc38bd Add context menu item for clearing net highlighting. 
In selection tools, drawing tools, router tool, line_wire_bus tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/11920
 2022-07-10 17:15:20 -06:00
Jeff Young 98c7572f5e Minor dialogs fixes for Mac. 2022-07-10 11:30:25 -06:00
Jeff Young 63d83f4186 Minor dialogs fixes for Mac. 2022-07-10 11:15:52 -06:00
Jeff Young 1ce3744c70 Honour stroke colour in LIB_SHAPE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11955
 2022-07-10 10:47:22 -06:00
Jeff Young eb27a3f8b9 Added pinning support to various EDA_LIST_DIALOGs. 
Footprint Save As, Symbol Save As, etc.
 2022-07-09 20:44:49 -06:00
Jeff Young 05219e4d9a Add pinned library support to Choose Symbol and Choose Footprint. 2022-07-09 20:06:31 -06:00
Jeff Young 190fb23e88 Add pinned library support to Footprint and Symbol Viewers. 
Also includes adding libraray and symbol filters to Symbol Viewer.
 2022-07-09 17:41:10 -06:00
Jeff Young 00fc225306 Give <esc>-with-no-selection-clears-net-highlight a test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8760
 2022-07-09 11:56:16 -06:00
jean-pierre charras fb5604022c Eeschema: DIALOG_SCH_FIND: ensure the search flags actually used are up to date. 
Flags are encoded using internal wx values, that can change with wxWidgets versions.
They need to be always rebuilt from the displayed options in dialog.
Fixes #11960
https://gitlab.com/kicad/code/kicad/issues/11960
 2022-07-09 10:28:53 +02:00
Jeff Young 70aec5d576 Don't drag both ends after Break Wire. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11915
 2022-07-08 23:03:41 -06:00
Jeff Young 0953395c87 LIB_SHAPE slightly abuses SHAPE_POLY_SET by using it for line chains. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11956
 2022-07-08 21:35:40 -06:00
Jeff Young ded611aed5 Patch annoying large checkbox cols in wxWidgets 3.1.x on OSX. 2022-07-08 17:27:05 -06:00
Jeff Young 5479514819 Honour m_resolveTextVars flag for properties as well as fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11937
 2022-07-08 17:27:05 -06:00
Jeff Young a16fc5b537 Go back to native headers for Symbol Fields dialog. 
Some of the drag issues are fixed in wxWidgets 3.1.x, and the balance
of problems now favours native.

Fixes https://gitlab.com/kicad/code/kicad/issues/9771

Fixes https://gitlab.com/kicad/code/kicad/issues/11835

Fixes https://gitlab.com/kicad/code/kicad/issues/11836
 2022-07-08 17:27:05 -06:00
Jeff Young fe1bff7d29 Remove empty infobar message. 
I'm not sure what this was for, but it seems like a bad idea and I
got a few crashes near here.
 2022-07-08 17:27:05 -06:00
Jeff Young 62cef3d830 Add LAYER_PRIVATE_NOTES for private text & graphics in symbol editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11957
 2022-07-08 17:27:05 -06:00
jean-pierre charras f47a4ec92a Eeschema: fix typo in commit 428bbc2 that make it not working. 2022-07-08 09:48:34 +02:00
Seth Hillbrand 428bbc201b Ensure last column of csv export has terminator 
Last shown column can be different from the last exported column

Fixes https://gitlab.com/kicad/code/kicad/issues/11981
 2022-07-07 11:23:18 -07:00
Seth Hillbrand 6fef054c51 Handle basic rounding error in schematic import 
The fractional part of Altium schematic units is an integer number of
1/10000 mil segments, which is 2.54 nm.  The internal unit of eeschema
is 10 nm, so each fractional unit in Altium is 0.254 base eeschema
units.  To be consistent with
cf33cfcad1
we round to the nearest 10nm for each element

Fixes https://gitlab.com/kicad/code/kicad/issues/11742
 2022-07-07 11:13:11 -07:00
jean-pierre charras 4db72f2d55 Fix minor compil and Coverity warnings. 2022-07-07 12:38:34 +02:00
jean-pierre charras 7b28804f67 Fix a minor compil and Coverity warning 2022-07-06 13:54:17 +02:00
Seth Hillbrand ff54b8c718 Overplot schematic symbol fields and pins 
In the absence of z-ordering, we need to ensure that pin text and symbol
fields are always visible in plots as they are in the schematic window.
We do this by overplotting the fields/pins when symbols overlap each
other.

This can be removed if/when we implement https://gitlab.com/kicad/code/kicad/-/issues/2211

Fixes https://gitlab.com/kicad/code/kicad/issues/11969
 2022-07-05 16:39:53 -07:00
Miklos Marton d30af7c164 eeschema: Add automatic rotate feature for placing global and 
hierarchial labels
 2022-07-05 17:02:45 +00:00
Seth Hillbrand cde30d3dba Clarify cross-probing options 
Previous the cross-probing options were mixed between sending and
receiving cross-probe events.  This clarifies so that all of the pcbnew
cross-probe options deal with whether the cross-probe is seen in pcbnew
and all of the eeschema options deal with seeing the event in eeschema.

Also updates the wording in the options panels to be the same where
possible and adds tooltips

Fixes https://gitlab.com/kicad/code/kicad/issues/11454
 2022-07-01 16:47:09 -07:00
Seth Hillbrand 939313088e Units are stored in the instance data 
At the moment, units are stored in the instance data, so when loading
the file, all symbols will have bbox for the first unit.  After calling
`UpdateUnit()`, we need to recache the rtree bounding boxes to get
correct hit tests

Fixes https://gitlab.com/kicad/code/kicad/issues/11681
 2022-06-30 14:59:17 -07:00
Marek Roszko 9b0531db54 Drop xsl/xslt files 
Users may still use xsltproc with kicad as the invocation of third party tools remains.
We simply are not maintaining these xsl sample scripts anymore nor bundling xsltproc.

Fix https://gitlab.com/kicad/code/kicad/-/issues/9074
 2022-06-29 21:22:34 -04:00
Mike Williams 66b3b48e93 Library Editor: Fix missing automatic annotation 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11818
 2022-06-29 14:17:21 +00:00
Jeff Young dbbdc9d2e6 Don't rely on the penWidth already being set when setting the dash style. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11908
 2022-06-29 07:34:45 -06:00
Jeff Young 4a8aaefdc0 Implement line style printing for LIB_SHAPE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11883
 2022-06-29 07:34:45 -06:00
Seth Hillbrand 66d3bf2bc2 Refresh draw objects when common settings change 
Common settings may change colors so make sure that we refresh the draw
objects when the settings change to draw them in the proper colors.
Failing to do this may also cause left over lines on the screen
depending on OpenGL drivers

Fixes https://gitlab.com/kicad/code/kicad/issues/11921

(cherry picked from commit 8aabdcff9c)
 2022-06-28 16:46:19 -07:00
Seth Hillbrand 6a8519dfd9 Fix ERC error missing on stacked pins 
Stacked pins are not connected, so they should be flagged as such.  This
checks for stacked pins that are not part of different symbols

Fixes https://gitlab.com/kicad/code/kicad/issues/11926

(cherry picked from commit 90ef84b958)
 2022-06-28 15:04:14 -07:00
Wayne Stambaugh 4e7b5b9784 Eeschema: fix project rescue bug. 
When a rescue library already existed, the disabled writing of legacy
symbol library table entries prevented the rescue library from being
updated.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11897
 2022-06-28 15:05:06 -04:00
Mike Williams 252afe41f3 Schematic: remove old, invalid angle choice from editing options 2022-06-28 16:29:14 +00:00
Jeff Young 83a2f43661 Apply DRC fixes to ERC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
 2022-06-27 21:07:03 -06:00
Jeff Young d5a6452934 Get rid of special default line style for Eeschema. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11882
 2022-06-27 19:12:45 -06:00
Jeff Young d9cfbc7b96 Fix missing SCH_LABEL case in SCH_PLUGIN. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11913
 2022-06-27 16:21:32 -06:00
Jeff Young 14886e426b Move prior fix from SCH_GLOBAL_LABEL to SCH_LABEL_BASE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
 2022-06-26 20:55:25 -06:00
Seth Hillbrand 03c279ffd4 ADDED: Threadpool 
Thread pools are long-lasting executors that have close to zero overhead
when launching new jobs.  This is advantageous over creating new threads
as we can use this for threading smalling jobs and smaller quanta.  It
also avoids the heuristics needed to determine the optimal number of
threads to spawn
 2022-06-24 22:59:24 +00:00
jean-pierre charras de45e2b1fd Textbox in symbols: fix incorrect position of the box when printing. 
Fixes #11884
https://gitlab.com/kicad/code/kicad/issues/11884
 2022-06-24 17:08:29 +02:00
jean-pierre charras 554b31bb2a eeschema: fix crash when changing the GAL engine, especially if the grid is shown. 
GetGAL()->DrawGrid() was called when switching the engine, outside a paint event,
thus creating a crash (at least on Windows) probably because the new Gal stuff was
not fully initialized.
 2022-06-24 15:49:28 +02:00
Seth Hillbrand 7b9dc1b9f0 Fix Eeschema Arc plotting 
The start/end point plotting is not reliable for eeschema.  We need to
preconvert to angles to get the correct winding as the default plotter
conversion in the PLOTTER class makes pcbnew-based assumptions

Fixes https://gitlab.com/kicad/code/kicad/issues/11885
 2022-06-22 16:46:28 -07:00
Ian McInerney b51d8c9825 Introduce new CMake variable to store kiface install location 2022-06-22 23:40:25 +01:00
jean-pierre charras 82b2df67be Add 2 automatically generated files to the source tree. 
These files are needed by translators, so it is better to add them to the source
without need to build kicad.
 2022-06-22 08:51:04 +02:00
Seth Hillbrand a852286eb5 Cleanup compile warnings 2022-06-21 17:04:56 -07:00
Miklós Márton f2382a7bd1 Add Make selected active/inactive actions to the symbol libraries 
context menu

Fixes #11372
 2022-06-21 23:32:02 +00:00
Seth Hillbrand aeef5b00a8 Unify symbol browser/editor unit display 
Fixes https://gitlab.com/kicad/code/kicad/issues/11881
 2022-06-21 16:22:54 -07:00
Jeff Young 494d79423e Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11809
 2022-06-19 20:56:22 +01:00
Jeff Young 45ab15dc95 Use unit references in status bar. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11854
 2022-06-19 12:54:30 +01:00
jean-pierre charras 50b68df666 Eeschema, SCH_PIN: fix incorrect initialization of m_layer member (now is LAYER_PIN) 
m_layer was not re-initialized in CTOR, so it was the default value (LAYER_WIRE)
This is incorrect for a pin, and can create errors in some functions (like IsType() )
Fixes #1818
https://gitlab.com/kicad/code/kicad/issues/1818
 2022-06-17 11:01:49 +02:00
Jeff Young 34e706bcbc Border colours and line styles for symbol editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11810
 2022-06-16 14:52:38 +01:00
jean-pierre charras c79dd09464 PANEL_SYM_LIB_TABLE: fix a bug in filenames from wxFileDialog dialog. 
We want the full path, so use GetPaths.
GetFilenames sometimes return the full path in wxWidgets 3.1.7, not always the filename
Fixes #11821
https://gitlab.com/kicad/code/kicad/issues/11821
 2022-06-16 13:04:27 +02:00
Roberto Fernandez Bautista 8725c3a35f CADSTAR Schematic: Load symbols even if part definition is incomplete 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11671
 2022-06-15 19:47:50 +01:00
jean-pierre charras 631eecd7d6 symbol_checker: better message about reference prefix. 2022-06-15 18:37:27 +02:00
Jeff Young 2c280e83c3 Handle junctions in MarkConnections. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8579
 2022-06-15 16:28:33 +01:00
jean-pierre charras b56917210d symbol_checker: add test for valid reference prefix. 2022-06-14 20:45:26 +02:00
jean-pierre charras 1140fd0fb0 Eeschema, context menus: move edit value, ref and footprint to a submenu. 
remove also Select All menuitem from the move context menu.
 2022-06-13 11:35:17 +02:00
Jeff Young 52bc2511cd Add a radioButton mode to IMAGE_BUTTON. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11797
 2022-06-12 20:09:46 +01:00
Jeff Young c6604e3576 Labels can connect directly to symbols, other labels, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
 2022-06-12 18:15:58 +01:00
Jeff Young 69c1f88e53 Update symbol instances after sheet rename. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11782
 2022-06-12 15:46:37 +01:00
Marek Roszko 08dbc3a53c Move the symbol editor to the new filedlg customize 2022-06-11 22:59:59 -04:00
Marek Roszko ff94d289c7 Move the eeschema standalone to the new save dialog 2022-06-11 22:06:42 -04:00
Jeff Young a0421b172a Add missing color swatch to Symbol Editor Text Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11791
 2022-06-11 22:14:14 +01:00
Jeff Young e4798199c6 Handle alt pins in plot code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11728
 2022-06-10 22:38:01 +01:00
Jeff Young 29900cad34 Add create-wire logic to labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
 2022-06-10 22:38:01 +01:00
jean-pierre charras e0f0bb2edd Eeschema: Fix issues when converting a label/text to another label text type. 
- make convert to/from SCH_DIRECTIVE_LABEL working.
- Autoplace fields of new labels
Fixes #11779
https://gitlab.com/kicad/code/kicad/issues/11779
 2022-06-10 14:13:22 +02:00
jean-pierre charras b712c2c0da Eeschema: fixes about Hierarchy panel/pane handling 2022-06-09 19:43:09 +02:00
Jeff Young bce1fd337b Second tool hotkey accepts action (ie: acts as click). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11729
 2022-06-09 16:54:04 +01:00
jean-pierre charras 35bde4710c Eeschema, context menu selection: move convert to ... menuitems to a submenu. 
Add also missing icons in a few menuitems.
Fixes #11776
https://gitlab.com/kicad/code/kicad/issues/11776
 2022-06-09 16:46:21 +02:00
jean-pierre charras ef2e51b493 Eeschema: code refactor and fix missing save project setting when closing the sch editor. 2022-06-09 13:39:09 +02:00
Jeff Young 6bfd106bed Add missing text colour to symbol editor textbox dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11770
 2022-06-09 10:37:23 +01:00
Jeff Young b710982875 Fix broken logic for hidden pins. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11771
 2022-06-09 10:37:23 +01:00
Jeff Young 6e50a3518f Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11769
 2022-06-08 23:53:18 +01:00
Jeff Young ec40a98fe2 wxT 2022-06-08 23:53:18 +01:00
jean-pierre charras b401e98c80 Eeschema, hierarchy navigator: fixes and enhancements. 
Work in progress.
 2022-06-08 18:23:03 +02:00
Jeff Young 46fd32b738 Update grid attributes after sorting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11753
 2022-06-08 15:25:13 +01:00
Jeff Young 34932e097c Minor dialog cleanup. 2022-06-08 15:25:13 +01:00
Jeff Young c55a0e4561 Separate last-created-params for textboxes from shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11755
 2022-06-08 15:25:13 +01:00
jean-pierre charras 185016b84b Eeschema, Hierarchy navigator: add tool to Hide/show the panel. 
Add also a close button to the pane.
 2022-06-07 11:11:10 +02:00
Jeff Young 244042ce51 Keep footprint selection in Symbol Chooser history list. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1841
 2022-06-06 22:24:02 +01:00
Wayne Stambaugh dfea73f78c Eeschema: fix symbol library remap bug. 
The original decision to escape the legacy symbol library names results
in them being escaped every time they are opened which cause the curly
braces '}' from the original escaping to be escaped on subsequent
openings.  This resulted in the symbol library names in the rescue
library not matching the library ID in the schematic.

This fix is likely to have other corner case bugs given the potential
for escaped characters in legacy symbol libraries.  Given that we now
have escaped rescue libraries in play, removing the escaping will only
result in more issues so we will have to fix the corner cases as we go.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
 2022-06-05 17:00:57 -04:00
jean-pierre charras 9f38fa43cd Fix some minor compil and Coverity warnings. 2022-06-05 11:44:49 +02:00
Jeff Young 31316760f6 Separate power and symbol saved search strings. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11747
 2022-06-04 22:15:39 +01:00
Jeff Young 718bb461d2 Textbox defaults for libedit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11739
 2022-06-04 21:25:37 +01:00
Roberto Fernandez Bautista ecbf5c1e14 Don't display unit in single unit symbols of annotation error message 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11748
 2022-06-04 16:04:33 +02:00
Jeff Young 099061f46d Process nested formatting within a variable cross-reference. 2022-06-04 00:34:14 +01:00
Roberto Fernandez Bautista 78e465bbd8 Fix crash in sch_navigate_tool when history was empty 2022-06-03 23:07:12 +02:00
Jeff Young ce79a16ed8 Use default schematic text size for textboxes. 
Also adds support for remembering stroke info, fill info, and
spin style for sch text boxes.

Fixes https://gitlab.com/kicad/code/kicad/issues/11739
 2022-06-03 21:48:12 +01:00
Seth Hillbrand 407514919d Prevent null dereference 2022-06-03 10:05:55 -07:00
Mike Williams 8d51b6b6d3 Schematic: Add icons for Any/90/45 angle modes 
Also add a dark mode icon for existing 45hv icon.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11332
 2022-06-03 15:04:52 +00:00
Mike Williams 857990a883 Hierarchy: turn into a left side pane 
Drop auto-closing option as well.
 2022-06-02 21:56:17 +00:00
Jeff Young aaff163d7c Repair Eagle importer page number handling. 
The root sheet needs a page number, and the other sheets need to not
have their last step in the path duplicated.

Fixes https://gitlab.com/kicad/code/kicad/issues/11409
 2022-05-31 17:48:38 +01:00
Jeff Young abba1b04bd Add "Enter Sheet" to Sheet tool (context menu & double-click). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11531
 2022-05-30 14:08:26 +01:00
jean-pierre charras 2701642b1b minor fixes and French translation update 2022-05-30 11:23:20 +02:00
Jeff Young d5d8d36d86 Implement expanding Select Connection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8579
 2022-05-29 22:51:33 +01:00
Eduardo Behr f246646d7a Fix severe simulation memory leaks 2022-05-28 20:40:24 +00:00
Mike Williams f2cf934083 Schematic: Annotation Tweaks 
Fix newly placed symbols to be annotated and not show a ? until
placement.
 2022-05-27 15:54:00 +00:00
Mike Williams efa23a5cbe Schematic: better automatic/recursive annotate 2022-05-27 15:54:00 +00:00
Mike Williams 7f3e5e9b79 Schematic: add recursive annotation control 2022-05-27 15:54:00 +00:00
Mike Williams 85516a4691 Schematic: add automatic annotation toggle 2022-05-27 15:54:00 +00:00
Mike Williams dabd42bbc4 Schematic: Automatic Symbol Annotation 2022-05-27 15:54:00 +00:00
Jeff Young 6114a5d72c Escape pin names when used as netnames. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11687
 2022-05-26 23:54:55 +01:00
Jeff Young cb15bd1635 Fix compile issue. 2022-05-26 10:54:54 +01:00
Jeff Young 616e9b4f4b Be cognizant of symbol transform when setting justification. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11465
 2022-05-26 10:54:08 +01:00
Roberto Fernandez Bautista 55f22c526a Fix annotation of incomplete multi-unit symbols and re-annotation of duplicates 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11496
 2022-05-26 09:23:36 +00:00
Seth Hillbrand 11ae5b75b7 Remove broken assert 
Fixes compile issue for linux/gcc which expects a boolean in the assert
statement that it cannot find from std::map
 2022-05-25 16:36:47 -07:00
Eduardo Behr 6aa50304d9 Eeschema: Fixing simulation plot CSV exporter 2022-05-25 15:00:03 +00:00
Miklós Márton 487c8f8e39 symbol editor: Improve pin duplication 
When duplicating pins in the symbol editor the duplicated pins will have
unique pin numbers assigned if the duplication target had the pin number
specified
 2022-05-25 00:02:16 +00:00
Fabien Corona 0536ab4f6c Remove kicad_pair in transmission lines 
This was a misread from the ngspice doc
 2022-05-25 00:00:07 +00:00
jean-pierre charras eae5e9f00e Symbol checker: fix incorrect test for duplicate pins. 
Fixes #11660
https://gitlab.com/kicad/code/kicad/issues/11660
 2022-05-23 11:20:12 +02:00
Roberto Fernandez Bautista ea29c66608 Fix formatting 2022-05-22 07:14:24 +00:00
Chetan Shinde 4e5febdb19 Fixes the import pin issue, that the they are shown in two different way https://gitlab.com/kicad/code/kicad/-/issues/11391 2022-05-22 04:42:22 +00:00
Jeff Young 8e94c307d2 Provide default case for mirroring single objects. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11649
 2022-05-21 22:50:55 +01:00
Jeff Young d381fd8b29 Typo. 
LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not.

Fixes https://gitlab.com/kicad/code/kicad/issues/11556
 2022-05-20 18:01:01 +01:00
Jeff Young 23fb4c7433 Uniformly use a single facility for location-less prime events. 
Also implements a uniform mechanism for avoiding auto-scroll after
a prime event or dialog which results in a mouse position at the
edge of the canvas.

Fixes https://gitlab.com/kicad/code/kicad/issues/11057
 2022-05-16 23:43:00 +01:00
Jeff Young f2fc78f380 Don't copy modifiers to prime events. 
The modifiers go with the hotkey, not with the action.

Fixes https://gitlab.com/kicad/code/kicad/issues/11618
 2022-05-16 13:51:40 +01:00
jean-pierre charras 359c99991b Eeschema: do not leave a temporary flag set after use in draw symbol function. 
Fixes #11617
https://gitlab.com/kicad/code/kicad/issues/11617
 2022-05-15 18:35:07 +02:00
Roberto Fernandez Bautista 9049c907a1 Fix wxWidgets assert in symbol preview widgets 2022-05-15 15:26:53 +01:00
Jeff Young 79a0ce9137 Unset forced cursor before leaving two-click place. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11607
 2022-05-14 22:38:54 +01:00
Jeff Young 38e5faf21b Overhaul bitmap text for performance. 
Also adjusts metrics to better match stroke font.

Also removes text-halo highlighting as it's too expensive to re-render
when the zoom changes.

Fixes https://gitlab.com/kicad/code/kicad/issues/11460
 2022-05-14 20:09:54 +01:00
Jonathan Haas 5802ede3fd Change default value of MatchByReference to false. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11382
 2022-05-14 12:41:25 +00:00
Marek Roszko 88c7322a0d EDA_TEXT Get/SetTextSize should use VECTOR2I 2022-05-14 08:16:15 -04:00
jean-pierre charras 45b167dff5 Some fixes related to translated/not translated mandatory field names. DIALOG_SYMBOL_FIELDS_TABLE: add new fields to symbols only if the field is not empty. 2022-05-13 11:45:38 +02:00
jean-pierre charras 20d1d0705e Fix a few issues related to field names and their translation. - Do not use translated field names outside strings displayed in dialogs. - fix code that does not work well with default locale. - fix some (not all) I18n issues in DIALOG_UPDATE_SYMBOL_FIELDS. 2022-05-13 11:45:37 +02:00
Seth Hillbrand bbc250720f Resolve title variable when plotting 
Be sure to use variable name if it exists when plotting the file

Fixes https://gitlab.com/kicad/code/kicad/issues/11608

(cherry picked from commit d971cbefcb)
 2022-05-12 15:31:15 -07:00
jean-pierre charras b68514afb1 Fix a wxWidgets alert. 2022-05-12 20:58:48 +02:00
Marek Roszko 5c4f49351d Remove extra compilation of common.cpp 
It's already built in the common target, no eeschema specific code
 2022-05-10 21:31:31 -04:00
Marek Roszko f85251ef75 Fix eda_doc not looking for schematic locally 
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e
 2022-05-10 21:28:48 -04:00
dsa-t ad066ef09a Fix cross-probing in complex hierarchies, remove unused code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11493
 2022-05-09 23:22:03 +03:00
jean-pierre charras 4bd349d922 Update some demos 2022-05-09 19:06:14 +02:00
Mike Williams b7a77a9498 Schematic: Add CSV export to Symbol Fields Table 2022-05-09 12:02:12 -04:00
Jeff Young 8f937b17a2 Remove wxWidgets 3.0.x hack. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11540
 2022-05-07 23:24:55 +01:00
Jeff Young f9f0f6fe24 Implement cross-references for labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11564
 2022-05-07 21:10:04 +01:00
Seth Hillbrand 5cd3c07862 Catch throws in DeleteSymbol 
DeleteSymbol may call SaveSymbol if the name is changed.  In this case,
SaveSymbol may throw back and needs to be caught

Fixes https://gitlab.com/kicad/code/kicad/issues/11566

(cherry picked from commit e05c8f8852)
 2022-05-06 16:13:59 -07:00
Miklós Márton 7e20c0ed9c eeschema: removed unused code 
Fixes #11533
 2022-05-06 17:17:55 +00:00
Jeff Young a644aad1cf Hand-code tab navigation from value field of Label Properties dialog. 
wxWidgets doesn't appear to handle it correctly, doing nothing on OSX
and potentially crashing on GTK.

Fixes https://gitlab.com/kicad/code/kicad/issues/11572
 2022-05-06 18:14:25 +01:00
Seth Hillbrand 5f7ac58f95 Catch errors when saving individual symbols 
Fixes https://gitlab.com/kicad/code/kicad/issues/11566

(cherry picked from commit f4d4f23876)
 2022-05-06 09:55:28 -07:00
Wayne Stambaugh a19490b097 Eeschema: fix broken project symbol rescue. 
The legacy symbol library plugin code was changed to escape symbol names
which broke the LIB_ID string comparison when checking to see if symbols
needed to be rescued.  Escaping the LIB_ID names before comparison resolves
the issue.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
 2022-05-06 08:50:09 -04:00
jean-pierre charras 32077673e8 Symbol editor crash: Fix use of a null pointer. 
LIB_TEXT::Clone() did not copy a member set to nullptr.
Fixes #11569
https://gitlab.com/kicad/code/kicad/issues/11569
 2022-05-06 12:51:26 +02:00
Jeff Young 1751c8e1cf Save selection *before* clearing it. Saving after doesn't do much good. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
 2022-05-06 00:06:00 +01:00
Jeff Young 9c5aa5c3c1 Font and color for FIELDS_GRID_TABLE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
 2022-05-06 00:06:00 +01:00
Jeff Young e80c5a4e4e Add text colour to Edit Text & Graphics Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
 2022-05-06 00:06:00 +01:00
Simon Richter bd7447cff3 Fix variable name 
This is the top left position, not the top right.
 2022-05-05 10:27:19 +00:00
Jeff Young f14dc9e305 Don't plot private symbol text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11548
 2022-05-03 19:41:20 +01:00
Jeff Young babfb29c54 Formatting cleanup. 2022-05-03 13:39:14 +01:00
Jeff Young 67f352717e Fix dodgy type-cast and init line-widths to "inherit". 
Fixes https://gitlab.com/kicad/code/kicad/issues/11535
 2022-05-03 13:39:14 +01:00
jean-pierre charras 3f470359a2 Eeschema, backannotate: fix minor issues in displayed messages. 
Fixes #11530
https://gitlab.com/kicad/code/kicad/issues/11530
 2022-05-03 09:20:46 +02:00
Seth Hillbrand a56955443f Fix botched commit 
(cherry picked from commit ba276fe470)
 2022-05-02 16:29:07 -07:00
Seth Hillbrand 2079d15b3f Catch IO_ERRORs that we throw 
FILEOUTPUT_FORMATTER likes to throw when it gets an issue.  We need to
catch this to avoid the app falling apart

Fixes https://gitlab.com/kicad/code/kicad/issues/11516

(cherry picked from commit 4d47857738)
 2022-05-02 15:15:52 -07:00
Jeff Young f6f316bd8c Promote field selection to field-owner for Autoplace. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11529
 2022-05-02 20:11:21 +01:00
Jeff Young d2610736ff Fix bugs with printing bordered shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11536
 2022-05-02 19:45:55 +01:00
Jeff Young 585ea85f95 LIB_SHAPE default line style is SOLID, not DASHED. 
(Copy/paste error from SCH_SHAPE.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11527
 2022-05-02 17:22:13 +01:00
Jeff Young 036d283433 Don't muck with linestyle default when setting it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11520
 2022-05-02 17:22:13 +01:00