haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,648 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

7839 Commits

Author SHA1 Message Date
Jeff Young da82ba00e4 Resolve text variables before attempting to open datasheet. 
(cherry picked from commit 510dc28a5c)
 2022-02-20 01:03:08 +00:00
Jeff Young 9fcd4113b0 Fix crash bug when adding rows to pin table and then pasting to unit. 
(cherry picked from commit 8a22dab83d)
 2022-02-20 01:03:08 +00:00
Seth Hillbrand 75a4036e45 Trim wires based on how many pins they intersect 
If a wire intersects more than 2 pins from the same symbol, we don't
trim connections.  If the wire intersects exactly two pins from a single
symbol, we remove the wire between the pins.

We avoided doing this before because we didn't have a good metric for
trimming vs. not.  But the per-symbol calculation feels like the least
surprising option.

Fixes https://gitlab.com/kicad/code/kicad/issues/10909

Fixes https://gitlab.com/kicad/code/kicad/issues/1857
 2022-02-19 16:54:19 -08:00
Jeff Young 3b072ca8b4 Sync all fields between units when symbol is edited. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10610

(cherry picked from commit d60ed70d54)
 2022-02-17 14:30:47 +00:00
Jeff Young e56355fc17 Update alt pin assignments in other units. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10849

(cherry picked from commit e499793147)
 2022-02-17 14:30:47 +00:00
Wayne Stambaugh c6c4f9ae4b Eeschema: fix broken symbol library rescue. 
Apparently at some point during V5 development, symbol cache library names
were saved by replacing the LIB_ID separator character ':' with '_'.  This
caused the cache look up to fail there by skipping the symbol rescue which
could result in broken schematics.

I have no idea where this happened during V5 development.  The video demo
in the HEAD of the 5.1 branch shows the issue.  All of the other demo cache
libraries are correct.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10488
 2022-02-17 09:09:19 -05:00
Seth Hillbrand 470d7d228d Fix wxT overzealous replacements 
A couple of regex mistakes slipped through and need to be reverted here
 2022-02-16 17:21:49 -08:00
Jeff Young b8b9f646c6 Show pin dangling symbols in Symbol Editor. 
Even though we don't have connections they're a still a good visual
indication of which end of the pin is which.

Fixes https://gitlab.com/kicad/code/kicad/issues/10742

(cherry picked from commit aedfe08bad)
 2022-02-13 18:29:12 +00:00
Jeff Young f8ac6df0cd Implement undo for Eeschema find/replace. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10824

(cherry picked from commit 33e57930bc)
 2022-02-13 18:19:59 +00:00
Seth Hillbrand bfd5afd6c8 Fix broken wide string for Mac 2022-02-10 09:48:27 -08:00
Seth Hillbrand d75329b6f1 Quote BOM executable for spaces 2022-02-09 10:53:09 -08:00
Seth Hillbrand 861589d837 Use wxEmptyString instead of wxT( "" ) 
Also fixes places where ternaries did autopromotion instead of returning
an empty wxString
 2022-02-09 10:33:52 -08:00
Seth Hillbrand a444addd89 Default eeschema strings to wide 
Prevents stack bug on MacOS
 2022-02-08 15:14:54 -08:00
Jeff Young 4657614e4f More wxString wide literals. 2022-02-04 23:12:09 +00:00
Marek Roszko 50d3a507d0 Mark some limits as constexpr 
gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime


(cherry picked from commit ca7840334c)
 2022-02-04 12:50:54 +00:00
Seth Hillbrand 7642a9db79 Setup selection when repeating 
We need the item to be currently selected when repeating the last symbol
insert.  This ensures we have a valid selection before starting the move
tool and possibly getting odd system behavior from mouse positions

Fixes https://gitlab.com/kicad/code/kicad/issues/10619
 2022-02-03 17:09:31 -08:00
Jeff Young 69b69aa431 Update text variables when they change. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10734
 2022-02-04 00:34:20 +00:00
Seth Hillbrand ccf2a63f45 When undoing creation of the sheet, get out first 
We can't stay in a sheet that is deleted by the action of undo.  Checks
the current sheet and, if we are currently using it, ensures that the
following action is to leave the current sheet

Fixes https://gitlab.com/kicad/code/kicad/issues/10733
 2022-02-03 11:19:33 -08:00
jean-pierre charras 0ffa266315 DIALOG_SPICE_MODEL: fix a cosmetic issue (no room for the help text) 
Fixes #10170
https://gitlab.com/kicad/code/kicad/issues/10170

(cherry picked from commit 7c3f0612f1)
 2022-02-03 15:01:04 +00:00
Jeff Young fecb625459 Resolve text variables in eeschema before passing to pcbnew. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10429

(cherry picked from commit 2b14b60c32)
 2022-02-03 15:00:39 +00:00
Jeff Young 01f3a14dc3 Allow more (lots more) unfold from bus menu entries. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10529

(cherry picked from commit 4665cdcdc5)
 2022-02-03 15:00:39 +00:00
Seth Hillbrand 70d00689ca Fully select a line for transformation 
When not trying to select points, we need to ensure that the full
line is selected for transformation

Fixes https://gitlab.com/kicad/code/kicad/issues/10566
 2022-01-29 17:36:54 -08:00
Seth Hillbrand fddfce4fb1 Force a size event to avoid multiple yields 
When the grid editor is shown, we also want to ensure that the grid gets
resized to account for the new editor.  Queuing the event will ensure
that happens after the editor is emplaced in the grid

Fixes https://gitlab.com/kicad/code/kicad/issues/5690
 2022-01-24 15:31:45 -08:00
Seth Hillbrand a1615cce7e Enforce strictly weak ordering in sheets 
This ensures that irreflexivity is given in sort ordering.  This may
have been triggering issues in MacOS when adding sheets

Fixes https://gitlab.com/kicad/code/kicad/issues/10557
 2022-01-24 10:41:02 -08:00
Seth Hillbrand 871556ebda Allow time to update editor 
On GTK, the full editor needs to be shown and, for some systems, the
editor will not show correctly.  By yielding we should allow the time to
recalculate sizes for the editor in the grid

Fixes https://gitlab.com/kicad/code/kicad/issues/5690
 2022-01-24 09:55:46 -08:00
Seth Hillbrand f12d0cb0e2 Get all eeschema layers properly ordered 
Layers not in the given order are drawn behind everyone else.  Missing
the text prevents global labels from showing properly in GAL order

Fixes https://gitlab.com/kicad/code/kicad/issues/10546
 2022-01-23 10:03:03 -08:00
jean-pierre charras 029e42f8d1 DIALOG_SIM_SETTINGS: fix incorrect validation of DC souces in DC Transfer panel 
From Master branch
Fixes #10568
https://gitlab.com/kicad/code/kicad/issues/10568
 2022-01-23 17:01:55 +01:00
jean-pierre charras e9a5e5466c SYMBOL_VIEWER_FRAME: fix refresh of the canvas after selecting a new symbol. 
From Master branch
 2022-01-21 17:34:51 +01:00
Seth Hillbrand 323a069738 Clear Undo list when renaming 
Our undo/redo list is tied to the screen that gets cleared when we
reload the file after renaming.  We need to clear the Undo list at this
point to prevent possible crashes when moving too far back in the stack

Fixes https://gitlab.com/kicad/code/kicad/issues/10504
 2022-01-20 11:28:41 -08:00
Seth Hillbrand 615eda816e Don't close filled polylines when printing 
Eeschema/libedit support open, filled polylines.  When printing, this
should be drawn as a fill, followed by the polyline to avoid assumptions
about closed polygons in the graphic code

Fixes https://gitlab.com/kicad/code/kicad/issues/10537
 2022-01-20 10:53:57 -08:00
Seth Hillbrand dcb8f29317 Handle rotated symbol rectangles in Eagle import 
Fixes https://gitlab.com/kicad/code/kicad/issues/10360
 2022-01-12 15:10:42 -08:00
dana 57d58fe335 Handle Unicode clipboard data in pcbnew and symbol editor 
Fixes #10323

(cherry picked from commit 8373180cbb)
 2022-01-12 09:23:24 -08:00
Seth Hillbrand 56d87a8613 Catch default autowire case 
Since we are dereferencing the optional, we need to ensure it exists in
all cases

Fixes https://gitlab.com/kicad/code/kicad/issues/10394
 2022-01-12 09:02:39 -08:00
Seth Hillbrand 55020c2b89 Better fix for missing end segment 
Rather than skipping our endEdit() call in libedit, we need to
parameterize whether we want the shape open/closed.  Closed will remove
the last segment if it lands on the first point.  We don't want that
but we do want to remove the last point if it duplicates the second to
last (in the case of double-clicking)

Fixes https://gitlab.com/kicad/code/kicad/issues/10334
 2022-01-10 13:37:47 -08:00
Seth Hillbrand 62f8603353 Don't deduplicate symbol polygons 
SHAPE_LINE_CHAIN will, by default, remove duplicate points when
appending.  We don't want to do this when constructing our polygons in
symbol editor, so we need to explicitly call the routine without
deduplication

Fixes https://gitlab.com/kicad/code/kicad/issues/10289
 2022-01-07 08:25:09 -08:00
Seth Hillbrand 9a2332dfcf Clear edited point when exiting tool 
When leaving the main point editor loop, we need to ensure that the edit
point is cleared as well.  This is usually cleared by a ClearEvent call
but in case this is missed, we need to ensure that other tools are not
caught out

Fixes https://gitlab.com/kicad/code/kicad/issues/10288
 2022-01-07 08:23:31 -08:00
jean-pierre charras 3069b198b1 PANEL_TEMPLATE_FIELDNAMES: fix incorrect management of boolean options 
(it was impossible to disable them)
From Master branch.
Fixes https://gitlab.com/kicad/code/kicad/issues/10280
 2022-01-06 19:44:23 +01:00
Seth Hillbrand 71e7b4b77b Use 'special' escaping for certain fields 
Most fields are escaped using the `\` notation.  But the VALUE field and
the symbol name need to be escaped using braces notation.

Fixes https://gitlab.com/kicad/code/kicad/issues/10097
 2022-01-05 17:18:39 -08:00
Seth Hillbrand b8a7a66a0a Keep symbol synced with edit tool 
Undo/Redo can change the symbol referenced by the symbol drawing tool.
This updates the current symbol before important steps to keep the
system synced

Fixes https://gitlab.com/kicad/code/kicad/issues/10125
 2022-01-05 16:51:41 -08:00
Seth Hillbrand 55087a9e82 Don't remove last point in libedit 
SHAPE_LINE_CHAIN in libedit doesn't make a polygon, so we always need
the last point and it shouldn't be closed

Fixes https://gitlab.com/kicad/code/kicad/issues/9934
 2022-01-05 16:02:50 -08:00
Steffen Mauch 7afe188a29 eeschema: automatic generated symbol library from EAGLE plugin does not include footprint reference 
Fixes https://gitlab.com/kicad/code/kicad/issues/10262

(cherry picked from commit 3ced3afa68)
 2022-01-05 15:28:05 -05:00
Steffen Mauch d60e77176f eeschema: EAGLE plugin does not reference footprint with library suffix 
Fixes https://gitlab.com/kicad/code/kicad/issues/10261

(cherry picked from commit 502e34349e)
 2022-01-05 14:39:43 -05:00
Seth Hillbrand 7f1648934f Update pin cache when undoing 
The pin cache is invalidated by swap, so we need to ensure that it is
reset when we undo a change to the pins in schematic editor

Fixes https://gitlab.com/kicad/code/kicad/issues/10272
 2022-01-05 11:33:03 -08:00
Seth Hillbrand bef762e652 Don't strip extensions twice in BOM export 
Exporting the Bill of Materials uses the netlist exporter.  Both of
these routines were stripping the extension, leading to projects like
"test.project.kicad_pro" having the project name stripped.  We separate
the BOM netlist export from generic plugin netlist export to allow the
correct behavior when exporting netlists and generating BOMs

Fixes https://gitlab.com/kicad/code/kicad/issues/10270
 2022-01-05 11:07:23 -08:00
Seth Hillbrand a05ec04ee8 Set readable flags correctly on open 
Missing files may be thrown during open.  These should have existence
and readable flags set correctly
 2022-01-05 09:54:10 -08:00
Seth Hillbrand b1658fdf9a Don't rename existing schematic file 
We should never leave a situation where the schematic file may no longer
exist (if the first rename succeeds and the second fails).  So, make a
backup copy of the original schematic file and then attempt to rename
the autosave over the first file.  In this case, if either attempt
fails, we do not lose the original file

Fixes https://gitlab.com/kicad/code/kicad/issues/10074

Fixes https://gitlab.com/kicad/code/kicad/issues/10256

Fixes https://gitlab.com/kicad/code/kicad/issues/10219
 2022-01-04 20:27:43 -08:00
Seth Hillbrand a326d777f0 Don't split legacy paths 
The '.' is a valid character in the legacy preferences, not a separator.
Also adds fail-safe catch for JSON throws

Fixes https://gitlab.com/kicad/code/kicad/issues/10211
 2022-01-04 19:08:12 +00:00
Roberto Fernandez Bautista 5e884d14c7 Rename ComparePageNumAndName -> ComparePageNum 2022-01-02 23:27:15 +00:00
Jon Evans ea99c42df6 Move duplicate field handling into field parser 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10130
 2022-01-02 13:19:31 -05:00
Seth Hillbrand addc5574b4 Ensure merged line gets selected if either parent is 
We were only checking for the selection of a single line that gets
merged.  This prevents the merged line from being highlighted but not
selected after merging

Fixes https://gitlab.com/kicad/code/kicad/issues/10202
 2022-01-01 16:53:31 -08:00
Marek Roszko 6fd93eaa1e Silence MSVC warnings about type mismatch and unused var 
(cherry picked from commit 34e90e5045)
 2022-01-01 19:50:11 +00:00
Roberto Fernandez Bautista cf8c614a02 Use virtual page number when real page numbers are blank 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10158

(cherry picked from commit a0d708e04d)
 2022-01-01 18:39:49 +00:00
Roberto Fernandez Bautista e19acb4632 Correctly handle excluding an ERC marker in eeschema when right clicking 
In addition, hide the option to exclude a marker if the selected marker
is already excluded.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10173

(cherry picked from commit 701e256b3f)
 2021-12-30 17:16:04 +00:00
Marek Roszko 67fe8904c0 Add win32 VERSION_INFO resource blocks for the DLLs 
(cherry picked from commit 3f711b8958)
 2021-12-29 04:56:26 +00:00
Mike Williams b80595903c Eeschema: draw dangling end shadows 
(cherry picked from commit bf2c4c1584)
 2021-12-28 16:10:40 -08:00
Marek Roszko 32be48222a Fix parent of schematic setup parent nodes 
(cherry picked from commit 705aa64c24)
 2021-12-28 01:16:18 +00:00
Jeff Young e7cc177d94 Allow a 0 pin-symbol-size. 
This is particularly important when reading legacy projects as 0 is
what signals the painter to use the old algorithm (1/2 pin name/number
size).

Fixes https://gitlab.com/kicad/code/kicad/issues/10100

(cherry picked from commit f089cf44a7)
 2021-12-23 17:01:48 +00:00
Jeff Young ad583eab13 Add hot-updating of units in common wxGrids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10020

(cherry picked from commit 6e2460ad37)
 2021-12-23 17:01:34 +00:00
Jeff Young 76fd029cd6 Don't leave stranded symbols/footprints in editors when doc closes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10026

(cherry picked from commit 9af33cdfe8)
 2021-12-23 17:01:25 +00:00
Jeff Young 2efa878287 Use a bigger hammer to update adjacent segments. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9927

(cherry picked from commit ee5db73113)
 2021-12-23 17:01:22 +00:00
Jeff Young 34d855cd53 Make sure undo/redo of pagesetup is done to correct sheet. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9999

(cherry picked from commit aa4dcb2bf1)
 2021-12-23 17:01:15 +00:00
Jeff Young 9cb36e5bc5 Restore units to a bunch of wxGrids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10063

(cherry picked from commit 8b52e969d6)
 2021-12-23 17:01:10 +00:00
Jeff Young 160328abc7 Fix arc printing for flipped shapes. 2021-12-20 18:07:27 +00:00
dsa-t f2ad8bffe0 Fix a mistake in Altium parser 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10011
 2021-12-16 05:49:39 +03:00
Seth Hillbrand 40d44c94cd Fix single-threaded loads/connectivity 
We cannot set thread counts to hardware_concurrency()-1 without
considering that single core machines will get a thread count of 0.
 2021-12-14 17:18:46 -08:00
Jeff Young 1ca90f31bf Fix hidden column in DIALOG_SYMBOL_FIELDS_TABLE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9987
 2021-12-15 00:03:33 +00:00
Mikolaj Wielgus 2dbc6ef6ca If present, tune Spice_Model instead of Value 
Fixes https://gitlab.com/kicad/code/kicad/issues/9880
 2021-12-14 14:02:25 +01:00
Adam Wolf 4fd5c9cfa8 Adjust macOS BOM plugin Python path 2021-12-13 22:52:31 +00:00
Adam Wolf 5e2ca2aa2a Install kicad_utils.py BOM plugin helper 2021-12-13 22:52:31 +00:00
Wayne Stambaugh 755607b8f8 Fix a few wxUpdateUIEvent retrigger loops. 2021-12-13 15:46:13 -05:00
Jeff Young 653c7b78d7 Move NC pin logic so we set it before we need it. 
Also fixes drawing the dangling symbol in the Pin Properties dialog
and when printing.

Fixes https://gitlab.com/kicad/code/kicad/issues/9962
 2021-12-12 22:25:36 +00:00
Wayne Stambaugh 067fa65756 Eeschema: fix a multitude of LIB_FIELD object comparison and index bugs. 
It is no longer acceptable to set a LIB_FIELD index to -1.  This was
trashing the sorting on load cause all kinds of false field comparison
failures.  There are now assertions when attempting to use -1 as a field
index.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9811
 2021-12-12 17:06:32 -05:00
dsa-t 4ccfc21324 Fix event id intersections when toggling some columns via popup. 
Also increases maximum show/hide column count to 50.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9765
 2021-12-13 00:35:44 +03:00
Jeff Young 885979ba75 Fix selection logic to handle LIB_ITEM as well as SCH_ITEM. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9954
 2021-12-12 17:38:38 +00:00
Jeff Young 88fc6d25a7 Correctly handle deleting multiple selections in some grids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9952
 2021-12-12 17:28:17 +00:00
Jeff Young d1e6c216e1 And the modify bit wasn't getting set either. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
 2021-12-11 01:09:13 +00:00
Jeff Young 15d1abeeef Sigh. But addCorner() *does* need mapCoords(). 
And it's got an off-by-one error in it too.  I don't think this
ever worked at all.

Fixes https://gitlab.com/kicad/code/kicad/issues/9926
 2021-12-11 01:06:36 +00:00
Jeff Young 1f126c5619 Hittesting already handles inverse coordinate system. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
 2021-12-11 00:32:24 +00:00
Seth Hillbrand 91dace3e5e Update Eagle importer 
Fixes arc orientation
Sets root schematic and page numbers

Fixes https://gitlab.com/kicad/code/kicad/issues/9907
 2021-12-10 15:41:25 -08:00
Jeff Young 8c5dd46861 Undo for SCH add/remove corner. 
(PCB_POINT_EDITOR uses a BOARD_COMMIT and so already handles undo.)

Fixes https://gitlab.com/kicad/code/kicad/issues/9925
 2021-12-10 23:08:16 +00:00
Jeff Young 1b2a278de9 Don't put "exclude from board" symbols in CvPCB netlist. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9939
 2021-12-10 23:00:50 +00:00
jean-pierre charras 65cbf2d2b7 Eeschema: fix draw issue for global labels in Cairo mode. 
Fixes #9933
https://gitlab.com/kicad/code/kicad/issues/9933
 2021-12-10 20:47:17 +01:00
Jeff Young 0ad0627bb0 Overhaul drag-select logic to handle children better. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6662
 2021-12-10 18:44:07 +00:00
Jeff Young 4f60d7ac78 Don't use lib tree target if lib tree isn't shown. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9913
 2021-12-10 00:34:22 +00:00
Jeff Young 832eb0d019 Fix off-by-one error in grid snapping. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9013
 2021-12-09 16:35:11 +00:00
Wayne Stambaugh af280f80e0 Fix debug assertion in Altium and CADSTAR schematic importers. 2021-12-09 12:56:03 +00:00
Wayne Stambaugh b7af66e3f9 Eeschema: fix broken page numbers when renaming a sheet file name. 
Always use full sheet paths when storing sheet instances.  Partial sheet
paths cannot be full resolved resulting in lost page numbers when renaming
sheet file name.

Fixes #9782
 2021-12-09 12:56:03 +00:00
Seth Hillbrand f7fb756f78 All imported schematics need connectivity update 
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
 2021-12-08 16:27:24 -08:00
dsa-t 9c619d8f4e Allow some navigation tools when selecting 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9565
 2021-12-07 23:00:39 +00:00
Jeff Young 3d97138d92 Bug fix for dangling symbols on pins. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9667
 2021-12-07 21:39:06 +00:00
Jeff Young c4336de868 Bug fixes in new dangling symbol drawing code. 2021-12-07 21:31:42 +00:00
Seth Hillbrand 84cdc9701f Partially reverts d877f041 
Based on discussion in https://gitlab.com/kicad/code/kicad/-/merge_requests/1029
we will keep the original behavior.  The new routines to get stock paths
are still useful (possibly in scripting) and are kept
 2021-12-06 16:14:40 -08:00
Jeff Young 73b39e836d Set modify bit when editing page layout. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9891
 2021-12-06 23:08:33 +00:00
Jeff Young 2e342ed8c9 Draw dangling symbols on a separate layer. 
This allows us to draw them in front of wires, pins, and most
importantly, junction dots.

Fixes https://gitlab.com/kicad/code/kicad/issues/9667
 2021-12-06 18:50:50 +00:00
Wayne Stambaugh a03e6e4926 Revert "Eeschema: fix broken page numbers when renaming a sheet file name." 
This reverts commit a468a79948.
 2021-12-06 07:47:18 -05:00
Wayne Stambaugh 5ae844ba93 Revert "Fix SCH_SHEET object assignment operator bug." 
This reverts commit 37d53a7147.
 2021-12-06 07:47:02 -05:00
Jon Evans a205595404 PROF_COUNTER -> PROF_TIMER 
I want to add an event counter, and this one is a timer
 2021-12-05 14:25:37 -05:00
Mikolaj Wielgus 10be483430 Make an exception for SCH_TEXT in SELECTION::GetCenter() 
And undo the previous changes in SCH_TEXT::Rotate().

We continue hitting this with a wrench until it gets fixed or becomes
broken beyond any recognition.
 2021-12-04 05:32:48 +01:00
dsa-t cb482eb8eb Symbol Fields Table: Highlight proper symbols even if they aren't annotated 2021-12-03 20:35:54 +00:00
Mikolaj Wielgus 9efbeaa064 Dark theme support for SPICE model editor 2021-12-03 03:41:32 +01:00
Mikolaj Wielgus 83162364e7 Restore old rotation behavior for SCH_LABEL 
Fixes https://gitlab.com/kicad/code/kicad/issues/9861
 2021-12-03 01:43:02 +01:00
Franck Bourdonnec d877f04198 fixe paths 2021-12-02 20:23:00 +00:00
Jeff Young 863699f2d1 Fix logic error in selection tool. 
Any new selection made by clicking is not a hover selection.

Fixes https://gitlab.com/kicad/code/kicad/issues/9857
 2021-12-02 16:56:47 +00:00
Mikolaj Wielgus 4ba110e1ec Restore original SCH_TEXT::GetBoundingBox() 
Didn't intend to commit this, it was a mistake.
 2021-12-02 16:43:19 +01:00
Mikolaj Wielgus bb08ef2f41 Fix SCH_TEXT rotation around a reference point 
Fixes https://gitlab.com/kicad/code/kicad/issues/9690
 2021-12-02 16:35:35 +01:00
Marek Roszko 50c1a91d44 Add a simple open wrapper for the bom python plugins to handle directory creation 2021-12-02 01:07:55 -05:00
Mikolaj Wielgus 3960c2441b Snap rotation center to half-grid, not grid 2021-12-01 17:53:42 +01:00
kliment 9f568d3658 Eeschema: Add support for leading zeroes when auto-incrementing names (fixes #9831) 2021-12-01 13:20:35 +00:00
Wayne Stambaugh 37d53a7147 Fix SCH_SHEET object assignment operator bug. 2021-12-01 07:19:30 -05:00
jean-pierre charras 3a00d76207 Fix a compil warning (shadowed var) and add a comment. 2021-12-01 11:05:16 +01:00
dsa-t bfe595819a Prevent error when loading bitmaps from some old schematics 2021-12-01 09:54:48 +00:00
Ian McInerney 6d8642e44c Remove default settings missed in 025d9f82ea 2021-12-01 01:59:40 +00:00
Seth Hillbrand 85ab4e5886 Don't deselect wires when aligning 
This makes undo/redo look really strange as the other elements get
aligned but the wires do not (or rather their unconnected ends do not)

Fixes https://gitlab.com/kicad/code/kicad/issues/9275
 2021-11-30 16:30:28 -08:00
Wayne Stambaugh a468a79948 Eeschema: fix broken page numbers when renaming a sheet file name. 
Remove duplicate instance data saved in both root SCH_SCREEN and SCH_SHEET
objects that was causing them to be out of sync.  All sheet instance data
is stored in the SCH_SHEET object itself and rebuilt on the fly so it is
always current.

Remove Get/SetPageNumber from SCH_SHEET_PATH object so it doesn't obfuscate
where the actual sheet page number information exists.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9782
 2021-11-30 08:11:24 -05:00
dsa-t 5750e38102 Re-enable and fix Move+Autoplace Fields 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9766
 2021-11-29 20:48:16 +00:00
Jeff Young a0711bdb56 Keep previous commit from violating string freeze. 2021-11-29 20:09:35 +00:00
Jeff Young 78be5df39a Don't allow negative line widths to shrink bounding box. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
 2021-11-29 20:02:03 +00:00
Jeff Young a0f1d77eaa Quiet wxWidgets assert. 2021-11-29 18:54:47 +00:00
jean-pierre charras 91363dd93c PANEL_EESCHEMA_COLOR_SETTINGS: fix a minor cosmetic issue. 2021-11-29 15:30:38 +01:00
Jeff Young 3a51fb6ac6 Be more consistent about annotation warngings. 
This can be a particular problem if you go to run ERC, it shows the
annotation warnging so you re-annotate (but don't notice that your
scope is set to Selection).

Also adds some missing defensive code around closing a modeless RC
checker before the document (which we had for DRC dialog but not the
ERC dialog).

Also fixes a missing override of GetSeverity which kept ERC messages
from having the right prefix.
 2021-11-29 14:24:45 +00:00
Jeff Young a224d8dd6c Disable autoplace fields when dragging/moving. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9766
 2021-11-28 19:18:08 +00:00
Mikolaj Wielgus 9bb370e6b4 SCH_SHEET_PIN: Rename GetEdge, SetEdge to GetSide, SetSide 2021-11-28 20:07:06 +01:00
Jeff Young 80d6b9e76d Tighten up hittesting for symbols and other items. 
Grid-based accuracy doesn't need to be any larger than 1/2 the
diagonal as we'll snap to one side or the other.  And symbols don't
need as much slop as other items since there's plenty of "meat" on
them.

Fixes https://gitlab.com/kicad/code/kicad/issues/9805
 2021-11-28 19:03:51 +00:00
Mikolaj Wielgus 71bfbfaa70 Test SCH_PIN rotation and mirroring 2021-11-28 19:37:13 +01:00
Mikolaj Wielgus 2e1862de1c Run AutoAutoplaceFields() in SCH_SHEET constructor 
A constructor should create a fully initialized object.
 2021-11-28 18:46:28 +01:00
Jeff Young 75d750a3cb Copy lastResolved stuff when pasting. 
This of course assumes the paste came from the same document.  If not
then pasted items will get default lastResolved stuff.
 2021-11-28 17:09:24 +00:00
Jeff Young 58b5ac4970 Don't create SCH_LINE till we know the layer. 
The CTOR makes some decisions on initialization based on the layer.
 2021-11-28 17:09:24 +00:00
Jeff Young f23cd9c9e5 Clearer naming. 2021-11-28 17:09:24 +00:00
Jon Evans d7f5917fb0 ERC: flag duplicated local labels with no pins as floating 
See https://gitlab.com/kicad/code/kicad/-/issues/9593
 2021-11-27 22:34:11 -05:00
Mikolaj Wielgus 65af3a8568 Make sheet pin positions invariant to four rotations more often 2021-11-28 02:18:18 +01:00
Roberto Fernandez Bautista dd219419a0 Quiet wxWidgets asserts (sheet & symbol properties dialogs) 
Ensure we don't set column size smaller than 1. If so, set to
-1 to auto size.
 2021-11-27 21:03:42 +00:00
Roberto Fernandez Bautista 3660597082 Use canonical names when saving sheet name and filename fields 2021-11-27 20:38:51 +00:00
Mikolaj Wielgus f35b0446e6 Properly initialize SCH_TEXT spin style 2021-11-27 19:42:11 +01:00
Jeff Young 9f7db24871 Selection bug fixes for Symbol Editor. 
1) Make sure the y-coord is correctly inverted before calling collision
routines.
2) Give LIB_SHAPE poly lines the same extra slop as SCH_LINEs.

Fixes https://gitlab.com/kicad/code/kicad/issues/9791
 2021-11-27 15:17:05 +00:00
Jeff Young 87e71072b1 Default line width to 0 in symbol editor. 
Also removes some atrophied settings for repeated non-pins in
symbol editor (which only ever repeats pins).

Fixes https://gitlab.com/kicad/code/kicad/issues/9776
 2021-11-27 11:53:38 +00:00
jean-pierre charras b8b8c0d34c dialog text properties: fix a focus issue. 
Fixes #9792
https://gitlab.com/kicad/code/kicad/issues/9792
 2021-11-27 10:08:30 +01:00
Jeff Young 698a668af7 Coverity fixes. 2021-11-26 18:14:29 +00:00
Jon Evans 08cb573e11 Do not propagate bus entries across buses and wires at the same point 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678
 2021-11-25 13:36:30 -05:00
Jon Evans aa5f496727 Properly migrate bus-bus entries on load of legacy schematic 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678
 2021-11-25 12:12:01 -05:00
Jeff Young 5863bc0937 Put Repair Schematic behind Advanced Config. 2021-11-25 12:56:46 +00:00
Simon Schaak c7dd98fb1a Fix outdated syntax in help text 2021-11-25 12:53:29 +00:00
Jon Evans 9f6910f1e6 Expand autoplace collision search to include potential field locations 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9762
 2021-11-25 07:48:05 -05:00
Jeff Young 5e6da9f964 Auto-start-wire tool requires an up-to-date connectivity. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-25 01:24:35 +00:00
Jeff Young 5d751bef74 Be cognizant of connectivity dirtiness when cloning wires. 
While the root case is wires, it really applies to all SCH_ITEMs.

Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-25 01:24:35 +00:00
Jeff Young f11cc904d2 More fixes for realtime connectivity being off. 
Don't update net highlighting until after connectivity has been
rebuilt.

Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-25 01:24:35 +00:00
Jeff Young ed705986e0 No realtime connectivity fixes for junctions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-25 01:24:35 +00:00
Roberto Fernandez Bautista 2eb5d4fa7a Symbol Editor: Allow save as all the time, as long as we have a symbol to save 
There doesn't appear to be any reason why the LIBID needs to be populated
before a "save as", seeing as the user will be inputting the new lib name
and lib nickname via the dialog.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9744
 2021-11-24 19:43:09 +00:00
Jeff Young 7fc04c3cf2 Fixes for realtime connectivity being off. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-24 13:20:44 +00:00
Jeff Young 9e999f4de4 ADDED Repair Schematic. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9749
 2021-11-24 13:20:44 +00:00
Jeff Young 228edd4121 Don't generate duplicate IDs in line/wire/bus tool. 
Also cleans up existing duplicate IDs when reading.

Fixes https://gitlab.com/kicad/code/kicad/issues/9749
 2021-11-24 13:20:44 +00:00
Jeff Young b052d56c7b R/W uuids for junctions. 2021-11-24 13:20:44 +00:00
Jeff Young 696f7c47fb Reduce use of auto. 2021-11-24 13:20:44 +00:00
Seth Hillbrand 65fc47cb8f Don't lose track of the sheet's screen 
Corner cases need to clear screen before loading a new file.  Aborting
needs to restore the screen or risk segfaults

Fixes https://gitlab.com/kicad/code/kicad/issues/9739
 2021-11-23 10:57:12 -08:00
Seth Hillbrand 126563c839 Fix initilization project / ordering 
We cannot resolve the Canvas type without the canvas being initialized.
But saving settings sometimes requests canvas access.  This protects the
calls against failure by checking for canvas before saving
canvas-specific settings

Fixes https://gitlab.com/kicad/code/kicad/issues/9729
 2021-11-22 11:47:42 -08:00
Seth Hillbrand 3f2d86adec Make OpenGL default for all apps 
Fixes https://gitlab.com/kicad/code/kicad/issues/9699
 2021-11-21 12:33:07 -08:00
Jeff Young 016a98df86 Increment numbers which have suffixes too. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9706
 2021-11-21 18:02:17 +00:00
Jeff Young 15f309c8a8 Add a SCH_ITEM::operator= so the connections caches don't get copied. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9710
 2021-11-21 16:54:46 +00:00
Jeff Young c1703212dc "Document" properties go in File menu; Edit menu is for item props. 2021-11-20 22:44:43 +00:00
Seth Hillbrand 2159acc9ce Fix missing handler for multiple labels 
This was intended to handle multiple labels but we missed the selection
condition.

Fixes https://gitlab.com/kicad/code/kicad/issues/9704
 2021-11-20 14:37:18 -08:00
Jeff Young 5a5af91d88 Tidy up the SCH_PREVIEW_PANEL visibility flags. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9701
 2021-11-20 15:28:17 +00:00
Seth Hillbrand 766a09c338 Remove autocomplete when we lose focus 
Prevents the excess dropdown from persisting over windows

Fixes https://gitlab.com/kicad/code/kicad/issues/9651
 2021-11-19 17:24:16 -08:00
Jeff Young c01649fc6e Make it easier to open legacy files. 2021-11-19 13:36:14 +00:00
Jeff Young 7bda077f69 Disable EE_POINT_EDITOR for uneditable symbol graphics. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9675
 2021-11-18 15:38:46 +00:00
Jeff Young 1bb750814d Cleanup dead code. 2021-11-17 12:49:53 +00:00
Jon Evans 9238b27f63 Silence IsWritable warning message 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9656
 2021-11-16 21:02:32 -05:00
Jeff Young 969bef9a36 Fix stroking error when printing polygons. 2021-11-17 01:53:44 +00:00
Jeff Young 7760d3275d Fix printing of LIB_SHAPE arcs. 2021-11-17 01:39:16 +00:00
Jeff Young 20328ab331 Back out last arc change. 2021-11-17 01:03:22 +00:00
Jeff Young 18d8053a6c Fix an arithmetic precedence order bug and fine tune autoplacement. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9345
 2021-11-17 00:49:42 +00:00
Jeff Young b4ac53d93d Attempt #1 to fix LIB_SHAPE arc printing. 2021-11-17 00:34:05 +00:00
Simon Schaak 399f2c116e Symbol editor: save changed field properties 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9648
 2021-11-15 20:40:32 +01:00
Jeff Young 12a75ffb94 A fuller implementation of allowing cut/copy/paste in search boxes. 
This one also works for other text entry widgets, and also works
for other frames.
 2021-11-15 18:13:35 +00:00
Christian Pfluger 9941a52e75 fix for issue #9345 autoplacing in schematic 
this fix moves designator fields to the side in case of collision with
symbols or wires.
 2021-11-14 18:02:36 +01:00
Jon Evans ae24daa033 Do not include text when computing drag origin for a group 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9630
 2021-11-14 11:54:04 -05:00
Jeff Young b747ae5bdf Make sure redraw happens regardless of order of panel commits. 
(We don't control the order of the TransferDataFromWindow calls
for the various panels and here the junction dot size is dependant
on the default netclass wire size.  So that calc has to be done
after all the various TransferDataFromWindow calls are made.)

Fixes https://gitlab.com/kicad/code/kicad/issues/9541
 2021-11-13 23:20:56 +00:00
Jeff Young 025d9f82ea Remove atrophied schematic default wire and bus widths. 
(They're now in the netclasses, and specifically the default netclass
if no other netclass is assigned.)

Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-13 22:56:50 +00:00
Jeff Young efc64e972c Fix pasting into LIB_TREE search control. 
We have a hack for turning accelerator keys that wxWidgets turns into
menu commands back in to accelerator keys -- but it requires that the
corresponding menu items be enabled in order to work.
 2021-11-13 19:45:10 +00:00
Jeff Young cc6e3841ae Formatting. 2021-11-13 19:45:10 +00:00
Wayne Stambaugh 80c5b1efb1 File formatting improvements and fixes. 
Symbol library IDs included the library nickname which is incorrect
and meaningless since it will be overwritten by the symbol library
table code.  This is not a file format change as there are no behavioral
differences.
 2021-11-13 12:57:18 -05:00
Wayne Stambaugh 53f5d616aa Coverity issue fixes. 2021-11-13 11:38:31 -05:00
jean-pierre charras e218471d24 DIALOG_CHANGE_SYMBOLS: fix a bug introduced by my commit 686b32db 
the filtering for mandatory fields was disabled.
 2021-11-13 13:47:09 +01:00
Jeff Young 1e151b1bcb Fix effective pen width when plotting wires. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9625
 2021-11-12 16:27:55 +00:00
Jeff Young da58e9ee4c Don't rely on selection when updating edited symbol in schematic. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9600
 2021-11-11 16:43:06 +00:00
jean-pierre charras 686b32dbd3 fix issue in DIALOG_CHANGE_SYMBOLS, in non English locale. 
Mandatory field names where compared in list, using translated and not translated names.
Fixes #9596
https://gitlab.com/kicad/code/kicad/issues/9596
 2021-11-11 10:56:09 +01:00
Jeff Young 54e00569d8 Don't fetch the root sheet's UUID out of the sheet instances. 
1) we're storing it now anyway
2) the root sheet UUID is the one UUID that's *not* in the instance
array, and previously we were erroneously grabbing the first sub-sheet's
UUID (producing duplicate UUIDs).
 2021-11-09 16:07:30 +00:00
Seth Hillbrand 6e5a918377 Writeable -> Writable 2021-11-08 15:56:51 -08:00
Jeff Young de93a071e2 Fix error in python command string generation. 
(We can now go back to using double-quotes since that bug is fixed.)

Fixes https://gitlab.com/kicad/code/kicad/issues/9552
 2021-11-08 21:05:54 +00:00
Seth Hillbrand cd3ecdfc78 Fix sort to be irreflexive 
Switching the order of the parameters must switch the sort order (no <=)
otherwise the sort is non-determinant and fails std::sort preconditions
 2021-11-08 11:25:13 -08:00
Mikolaj Wielgus 38bd4b07e4 Close the simulator before changing schematic 
Fixes https://gitlab.com/kicad/code/kicad/issues/9501
 2021-11-07 23:35:06 +00:00
Roberto Fernandez Bautista 04a30638f0 eeschema: Pasted items are moving as soon as they are pasted 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9539
 2021-11-07 15:14:11 +00:00
Jeff Young f9a282278c Update junction-dot-size-cache when Schematic Setup changes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9541
 2021-11-07 14:12:44 +00:00
Roberto Fernandez Bautista b572781a8a eeschema: Update anchor position of pasted items after initial move 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9534
 2021-11-06 16:03:41 +00:00
Roberto Fernandez Bautista d1bab3116d eeschema: Warp to origin when moving - add missing text items 
Schematic fields and text items were not being warped to origin when
moving.
 2021-11-06 15:19:22 +00:00
jean-pierre charras 2f22b9dd81 Do not replace delimiter " by ' inside a command string, round 2. 2021-11-05 18:28:44 +01:00
Jeff Young 83e5208213 Fix a couple of holes in the IsTestEnabled() checks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7270
 2021-11-04 16:24:06 +00:00
Jeff Young 996a5b85a6 Overhaul IsJunctionNeeded logic to support all the different cases. 
Several clients were using this with different needs.  The API is
now more explicit (and there are more options under the hood).

Fixes https://gitlab.com/kicad/code/kicad/issues/9518
 2021-11-04 12:57:16 +00:00
Seth Hillbrand cf6b18ec7e Remove escaped double-quotes 
For some reason, escaped double quotes in wxString::Format cause issues
on Mac.  We can replace them with single quotes in most places without
loss of clarity
 2021-11-03 17:03:14 -07:00
Jeff Young 179628d1d2 Repair field properties dialog for rotation and mirroring. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9508
 2021-11-03 18:11:59 +00:00
Roberto Fernandez Bautista 5e040ad126 eeschema settings: Default to mouse drag is drag action on first install 
This is to be consistent with other EDA tools like Altium and CADSTAR.
 2021-11-03 16:58:11 +00:00
Jeff Young c2371f3943 Revert e4b61de792. 
It doesn't seem to fix the testcase on Linux, and the tests pass on
my machine in either configuration.
 2021-11-03 10:30:34 +00:00