Jon Evans
1e61668cee
Make GetSettingsVersion handle extra version appends better
...
Fixes #4015
2020-03-07 09:33:35 -05:00
Seth Hillbrand
4dfe630b28
PNS: Moving the rest of the placer to Fix/Commit
...
Springback introduced a new PNS structure to check for valid placement
as well as separating the Fix/Commit routines. This updates the
remaining placers to utilize the new structure.
Fixes https://gitlab.com/kicad/code/kicad/issues/4008
2020-03-06 09:56:44 -08:00
Seth Hillbrand
f6317fba82
PNS: Protect drag from null deref
...
Items that do not have nets will not be in the index, so we need to
avoid the null pointer when adding drag tagets
Fixes https://gitlab.com/kicad/code/kicad/issues/4009
2020-03-06 09:32:04 -08:00
Jeff Young
44b8bb8f60
Fix a bug when deleting DRC markers from their child items.
2020-03-06 16:23:44 +00:00
Jeff Young
fe3e0307d8
Move sheet name and filename to SCH_FIELD architecture.
...
Only internal storage architecture has changed (so far).
2020-03-06 16:23:44 +00:00
Jeff Young
2f17cbf242
Flag known DRC violations and exclusions in Plot dialog.
2020-03-06 16:23:44 +00:00
Jeff Young
dccc367864
Remove code missed in the modern-toolset move.
2020-03-06 16:23:44 +00:00
Jon Evans
a13208c78b
Revert accidental change to video.pro
2020-03-06 08:31:16 -05:00
Jon Evans
dd56f6f8e2
Increase width of bitmap button on settings migration dialog
2020-03-06 08:15:14 -05:00
Jon Evans
34ceee14ed
Improve color button padding
2020-03-06 08:14:12 -05:00
Jon Evans
775d15d8cf
Use theme preference in PL editor (no UI access yet)
2020-03-06 00:01:02 -05:00
Jon Evans
5ed173ef1b
ADDED: LibEdit can have a different color theme than Eeschema
2020-03-06 00:01:02 -05:00
Jon Evans
643c97a2f4
ADDED: Schematic plotting can use a dedicated color theme
...
ADDED: PDF, PS, and SVG plots can optionally include the page background color
Fixes #1830
2020-03-06 00:01:02 -05:00
Jon Evans
8660b4c144
ADDED: New color theme editor and multi-theme support
2020-03-06 00:01:03 -05:00
Jon Evans
1e104d5bd4
Don't promote globals from locals on a different sheet
...
Fixes #4004
2020-03-05 19:08:55 -05:00
Seth Hillbrand
058fb3afa1
PCAD: Handle mirrored text
...
Mirrored text rotates clockwise in the mirror, so we need to invert the
sign for aligning mirrored PCAD text
Fixes https://gitlab.com/kicad/code/kicad/issues/3992
2020-03-05 15:29:02 -08:00
Seth Hillbrand
0417a6b409
PNS: Fix missing via on zero-length
...
The current node needs to be kept for zero-length lines when placing a
via.
Fixes https://gitlab.com/kicad/code/kicad/issues/4005
2020-03-05 15:02:40 -08:00
Seth Hillbrand
3d151ebd71
Cleanup connectivity parts
...
Removes unneeded casts from the connectivity algo.
2020-03-05 12:41:54 -08:00
Seth Hillbrand
b0d9838fb4
PNS: Correct assertion when dragging
...
Dragging using highlight caused an assertion as the duplicated lines
were being re-added with their old links still inplace. While this was
probably fine as the link references shouldn't be stale, we clear them
to allow for the possibibility that the dragger will adjust the links in
the future.
2020-03-05 08:47:06 -08:00
Wayne Stambaugh
bc7df3239c
Start unit tests for math library trigonometry functions.
...
This only tests the InterceptsPositiveX() and InterceptsNegativeX() used
for finding the midpoint of an arc.
Tidy up some of the trigo.h header Doxygen comments.
2020-03-05 07:34:26 -05:00
jean-pierre charras
3e78403576
Eeschema: cosmetic enhancement: display sheet UUID and path in dialog and bottom frame.
2020-03-05 13:20:38 +01:00
jean-pierre charras
48fba00eb4
Fix a compil warning.
...
Fixes #3964
https://gitlab.com/kicad/code/kicad/issues/3964
2020-03-05 09:54:14 +01:00
Jon Evans
ca1ab0af16
Set expand flags and minimum button size on migration dialog
...
Hopefully fixes #3989
2020-03-04 21:47:28 -05:00
Seth Hillbrand
4c2626f6b0
PNS: Don't use PNS margin to calc bump direction
...
The bump direction should only be concerned with physical points to
calculate the heuristic for loop-back otherwise we get too many false
positives.
Fixes https://gitlab.com/kicad/code/kicad/issues/3971
2020-03-04 19:22:57 -06:00
Seth Hillbrand
e38ab6c699
Treat 0-length ovals as circles
...
Some buggy SVG interpreters can't handle 0-length ovals. In this case,
they are meant to be circles, so we can export as circles in our
plotter.
Fixes https://gitlab.com/kicad/code/kicad/issues/3995
2020-03-04 18:03:20 -06:00
Seth Hillbrand
fe8524b9bb
Update DIFF_PAIR_PLACER to new callbacks
...
Needs to handle changes to PNS_ROUTER. This does not implement
springback or backspace in DIFF_PAIR_PLACER, only allows committing
lines as before
Fixes https://gitlab.com/kicad/code/kicad/issues/3988
2020-03-04 17:23:04 -06:00
Seth Hillbrand
ecbfea68dd
ADDED: Allow creation of nets in pcbnew
...
When editing pcb items, the creation of a new net to connect existing
pads or traces can be a useful shortcut. This inserts the ability to
optionally create a new net from the Net Selector dropdown menu.
2020-03-04 16:11:47 -06:00
Jeff Young
2359d19cf4
Add menu item to DRC dialog to go to Board Setup / Violation Severities.
2020-03-04 21:52:30 +00:00
Jeff Young
d20f36511f
Fix issue with severities not get initialised in DRC_TREE_MODELs.
2020-03-04 21:52:30 +00:00
Jeff Young
0894674869
Save severities settings in the DRC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3978
2020-03-04 21:52:30 +00:00
Seth Hillbrand
12088f240d
Fix a couple crashes with small canvases
...
The canvas size is not guaranteed to be strictly > 0, so we need to
enforce a minimum returned size before dividing by it or passing to GAL
initialization
2020-03-04 14:33:42 -06:00
Seth Hillbrand
011e4116d6
Remove assertion path on closing empty pcb
...
We don't need to save the project settings if we don't open a file or
project
2020-03-04 11:40:28 -06:00
jean-pierre charras
b7cd0c54c2
Fix compil issues, especially on Windows:
...
Replace SEVERITY_ERROR by RPT_SEVERITY_ERROR to avoid collision with a system definition.
Replace other SEVERITY_XXX by RPT_SEVERITY_XX for consistency.
Fix compil warnings and some other compil issues.
2020-03-04 10:48:18 +01:00
Jeff Young
21469efa63
Make sure EESCHEMA definition gets passed into common.cpp.
...
Also includes a fix to seed timestamps that got incorrectly
written out as '00000000' because of the above.
Fixes https://gitlab.com/kicad/code/kicad/issues/3977
2020-03-04 02:04:18 +00:00
Jeff Young
85c2e0d23a
Add user-defined severities, exclusions and colors to DRC markers.
...
Exclusions are currently persisted in the project file.
Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-03-04 00:39:28 +00:00
Michael Kavanagh
265c1663f9
Remove empty choice in Via type dropdown
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3968
2020-03-03 22:12:04 +00:00
Seth Hillbrand
e359144305
Missed one file for previous commit
...
This is the actual fix for issue #3982
2020-03-03 14:05:49 -08:00
Seth Hillbrand
2cff50d7a8
Fix return value for new plugin
...
Even when we throw, we still need to provide a default return value that
will never be reached for MSVC
Fixes #3982 | https://gitlab.com/kicad/code/kicad/issues/3982
2020-03-03 14:02:37 -08:00
Seth Hillbrand
d4cbc348de
PNS: avoid committing route with nothing
...
The node is not neccesarily populated when committing, so we need to
check for validity first.
Fixes #3984 | https://gitlab.com/kicad/code/kicad/issues/3984
2020-03-03 14:02:32 -08:00
Marcus Comstedt
349c0e1a14
gal/opengl: Fix shader link state check
...
The old code caused a bool (size 1) to be overwritten by a GLint (size
4) causing undefined behaviour.
Fixes https://gitlab.com/kicad/code/kicad/issues/3981
2020-03-03 21:47:43 +00:00
Seth Hillbrand
9769e1020b
PNS: Don't link unroutable items
...
The joint map only works for items that are routable, so don't bother
adding unroutable items as this only takes additional time to process
Fixes #3976 | https://gitlab.com/kicad/code/kicad/issues/3976
2020-03-03 12:42:56 -08:00
jean-pierre charras
30bc8fac5d
Annotate dialog: fix incorrect list of changes in complex hierarchies
...
Previously, to list changes, the Reference field was used in comparisons.
In complex hierarchies, this is incorrect: the Reference field contains
only the last displayed reference, not the reference of a given sheet.
The comparison uses now the sheet paths for ref and unit selection.
2020-03-03 19:41:19 +01:00
Marcus Comstedt
55ac575a88
Cairo GAL: fix incorrect use of pixman formats
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3970
2020-03-03 18:07:30 +00:00
Seth Hillbrand
20fde2c16f
eeschema: Fix find from RTree change
...
The RTree doesn't keep pins and fields in the tree, so we need to search
for them differently.
Fixes #3979 | https://gitlab.com/kicad/code/kicad/issues/3979
2020-03-03 09:35:12 -08:00
Wayne Stambaugh
abb8088695
Fix QA test failure due to changes to FormatInternalUnits() function.
2020-03-03 08:06:23 -05:00
Wayne Stambaugh
18f9ba110d
Fix minor symbol library s-expression formatter and parser bugs.
2020-03-03 08:06:23 -05:00
Wayne Stambaugh
9d6f64da9a
Implement symbol library s-expression parser.
...
This implements all existing symbol library object support and the ability
to save and load symbol library files between file formats for round robin
testing.
2020-03-03 08:06:23 -05:00
Wayne Stambaugh
738a93db68
Fix s-expression symbol library formatter build issue due to UUID support.
2020-03-03 08:06:22 -05:00
Wayne Stambaugh
1af503509d
Fix s-expression symbol library formatter build issue.
2020-03-03 08:06:22 -05:00
Wayne Stambaugh
1d205e4442
Fix points formatting in s-expression symbol library file formatter.
2020-03-03 08:06:22 -05:00