haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,103 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

4597 Commits

Author SHA1 Message Date
Jon Evans 8341e3f972 Ensure prefixes and suffixes make it on to bus members 2019-05-07 22:48:25 -04:00
Jon Evans 1de5b83d82 Promote net names to higher in hierarchy when possible 2019-05-07 21:59:36 -04:00
Jon Evans 81993eef83 Ensure bus member links get updated in hierarchical situations 2019-05-07 21:31:53 -04:00
Jon Evans 3d3c280f22 Fix hierarchical linking if parent sheet has a weak driver 2019-05-07 21:31:53 -04:00
Jeff Young a40367ce17 Add a wire between direct-connect items when only is being dragged. 
Fixes: lp:1798968
* https://bugs.launchpad.net/kicad/+bug/1798968
 2019-05-07 20:39:46 +01:00
Jeff Young 469231ae15 Move Pin, Symbol Text and Symbol Anchor to modern toolset. 2019-05-07 20:39:46 +01:00
Jeff Young 2e4d948535 Fix some more hotkey issues. 
Also reformatted the file to make it easier to see what is there and
what is missing.  Apologies to the 100-char-width folks, but we were
just missing to many command IDs in this file.

Fixes: lp:1828006
* https://bugs.launchpad.net/kicad/+bug/1828006
 2019-05-07 20:39:46 +01:00
Jeff Young cf046e0548 Anchor a selected wire at the edge of a drag which is connected to a non-drag item. 
Fixes: lp:1827846
* https://bugs.launchpad.net/kicad/+bug/1827846
 2019-05-07 12:04:19 +01:00
Jeff Young f40408187e A couple of temp hacks for LibEdit <esc> processing while in transition. 
Fixes: lp:1828004
* https://bugs.launchpad.net/kicad/+bug/1828004
 2019-05-07 12:04:19 +01:00
Jeff Young 11ec7d4651 Invert the Y axis of SCH_PIN coords when hit-testing. 
Fixes: lp:1827849
* https://bugs.launchpad.net/kicad/+bug/1827849
 2019-05-07 12:04:19 +01:00
Jeff Young 2097411550 Refresh RequestSelection selection if all items were filtered out. 
If you have, for instance a pin selected and do a cmd-E we'll filter
out the pin and then do nothing.  We should instead treat it as a
hover selection if everything got filtered.
 2019-05-07 12:04:19 +01:00
jean-pierre charras 2c43d4d6bf Eeschema: fix incorrect display of the page number in a complex hierarchy. 
When, inside a complex hierarchy, one switch from an instance of a sheet to an other instance of this sheet,
the page number shown in the worksheet was not updated on screen, and the initial number was displayed.

Fixes: lp:1827981
https://bugs.launchpad.net/kicad/+bug/1827981
 2019-05-07 10:55:26 +02:00
Jon Evans 316be464ab Handle higher-priority connection drivers located in subsheets 
Fixes: lp:1827850
* https://bugs.launchpad.net/kicad/+bug/1827850
 2019-05-06 22:09:05 -04:00
Jeff Young f1a38a6d41 Respond to <esc> from selection tool. 
Fixes: lp:1827917
* https://bugs.launchpad.net/kicad/+bug/1827917
 2019-05-06 21:56:19 +01:00
Jeff Young cd2bd23c37 Fix a bunch of issues with hotkeys, IDs and event processing. 
Fixes: lp:1827894
* https://bugs.launchpad.net/kicad/+bug/1827894
 2019-05-06 21:42:00 +01:00
Jeff Young e5151ed639 Use parent's transform when moving SCH_FIELDs. 
Fixes: lp:1827873
* https://bugs.launchpad.net/kicad/+bug/1827873
 2019-05-06 21:41:44 +01:00
Jeff Young a76bcc204f Use parent's transform when moving SCH_FIELDs. 
Fixes: lp:1827873
* https://bugs.launchpad.net/kicad/+bug/1827873
 2019-05-06 16:59:23 +01:00
Jeff Young b97d65e791 Fix crash bug when deleting sheet pin and disappearing bug when moving them. 
Fixes: lp:1827890
* https://bugs.launchpad.net/kicad/+bug/1827890
 2019-05-06 16:31:02 +01:00
Jeff Young 13beb344ca Fix LIB_FIELD selection bug. (It wasn't checking for convert == 0.) 2019-05-06 16:01:39 +01:00
Jeff Young d12eee9c98 Process new sheets after drawing. 2019-05-06 15:31:23 +01:00
Jeff Young 207900e4f9 Move libedit message panel updating to the Inspection Tool. 2019-05-06 15:31:23 +01:00
Jeff Young a12d769074 Code clarification and commenting. 
Also renames toolbar files to reduce confusion with the modern toolset
tool files.
 2019-05-06 15:31:23 +01:00
Jeff Young 8e75824d29 Use selection tool for locateItem. 2019-05-06 15:31:23 +01:00
Jeff Young f87d371b8b Move to shared COLLECTORS for sch and lib. 2019-05-06 15:31:23 +01:00
Jeff Young cc439f9ab0 Replace accidentally deleted mouse processing for LibEdit. 2019-05-06 03:30:51 +01:00
Jeff Young 49231ac08f Fix missing event processing for Leave Sheet button in toolbar. 2019-05-06 03:30:51 +01:00
Jon Evans 09c9db472e Properly handle buses that have been linked by net wires only 
Fixes: lp:1825532
* https://bugs.launchpad.net/kicad/+bug/1825532
 2019-05-05 19:48:55 -04:00
Jon Evans e9eacbc91c Ensure subgraphs with multiple labels get sorted 2019-05-05 19:09:05 -04:00
Jon Evans 019a731e03 Back-propagate from child sheets when two parents point to one child 2019-05-05 16:05:36 -04:00
Jeff Young b7e67073ef Fix bugs in bus unfold logic. 
The worst of which left you in the bus unfold popup menu event loop
if you cancelled the menu by clicking outside it.
 2019-05-05 19:48:11 +01:00
Jeff Young 0b2e1d00ea Don't allow motion between two clicks of a dblclick to spoil forceHV. 2019-05-05 18:38:49 +01:00
Jeff Young d881f4b21f When unfolding a bus from the selection tool, stay in that tool. 2019-05-05 18:36:18 +01:00
Jeff Young c4fac81dbb Transition from bus to wire tool when unfolding bus. 2019-05-05 17:14:30 +01:00
Jeff Young a42a4b0b52 Implement immediate bus unfold and add bus unfold to selection context menu. 2019-05-05 17:14:30 +01:00
Jeff Young fd546da640 Homogenize hit testing and selection return types. 
Prep work for sharing SCH_SELECTION_TOOL with LibEdit.
 2019-05-05 17:14:30 +01:00
Jeff Young 2d28ab7dd2 More cleanup. 2019-05-05 17:14:30 +01:00
Jeff Young 32765ebffd Do some refactoring in prep for sharing some sch tools with libedit. 2019-05-05 17:14:30 +01:00
Jeff Young ed0e6af66d Move to direct tool registration. 
It was confusing that the primary frames registered their tools
differently than the other frames.  In addition, since the other
frames also added their own tools, foo_actions::RegisterAllTools()
didn't really register all tool but rather those used by the
principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
 2019-05-05 17:14:30 +01:00
Jeff Young dd9c426922 Cleanup a TODO. 2019-05-05 17:14:30 +01:00
Jeff Young b5fd7b9842 Move Leave Sheet to the top of the context menu. 2019-05-05 17:14:30 +01:00
Jeff Young 7e3ad4585a Fix issues with dragging, moving and rotating wires. 2019-05-05 17:14:30 +01:00
Jeff Young 2edb09e583 Double click action should enter sheet. 2019-05-05 17:14:30 +01:00
Jeff Young 4ccfa17ff9 Fix bugs in sheet duplicate & copy/paste. 
Don't edit sheet during AddToScreenAndUndoList() call.  If it's
cancelled and we delete the item, callers will still own pointers
to the freed memory.  Do it in New and Paste instead.
 2019-05-05 17:14:30 +01:00
Jeff Young 554094ada6 Fix de-reference of freed memory issue. 2019-05-05 17:14:30 +01:00
Jeff Young a825cdfa5a Fix new image drawing issue. 2019-05-05 17:14:30 +01:00
Jeff Young bcdc3ad90a Set IS_NEW flag on new images. And a bunch of cleanup of dead code. 2019-05-05 17:14:30 +01:00
Jeff Young 21b315f2af Finish removing GetCurItem() from eeschema. 2019-05-05 17:14:30 +01:00
Jeff Young 6e695aac25 Move bus unfold and symbol unit selection to modern toolkit. 2019-05-05 17:14:30 +01:00
Jeff Young f4b92e6acf Refactor as SCH_DRAWING_TOOL was getting too big. 2019-05-05 17:14:30 +01:00
Jeff Young 2774af928a Remove extra Show Datasheet menu item. 2019-05-05 17:14:30 +01:00
Jeff Young 20b63174dc Support wire & bus drawing from selection tool. 2019-05-05 17:14:30 +01:00
Jeff Young f95f202f81 Restore Jon's change which I accidentally nuked. 2019-05-05 17:14:30 +01:00
Jeff Young f187f91f57 Seth's fixes to regex processing. 2019-05-05 17:14:30 +01:00
Jeff Young 1cc3055481 Allow rotation/mirroring of wires. 2019-05-05 17:14:30 +01:00
Jeff Young 4ca0f4da10 Fixes to the context menu logic around wire/bus drawing. 2019-05-05 17:14:30 +01:00
Jeff Young 7273748c57 Context menu cleanup for eeschema modern toolset. 2019-05-05 17:14:30 +01:00
Jeff Young 90a663facd Implement sheet cleanup in modern toolset. 2019-05-05 17:14:30 +01:00
Jeff Young 1e5334f5d4 Implement DeMorgan conversions in modern toolset. 2019-05-05 17:14:30 +01:00
Jeff Young 7c54fc9c46 Cleanup. 2019-05-05 17:14:30 +01:00
Jeff Young 29f1787af2 Logic improvements and fixes for wire segment selection states. 2019-05-05 17:14:30 +01:00
Jeff Young c09817e08c Context menus for labels. 2019-05-05 17:14:30 +01:00
Jeff Young 0ea156042b Fix over-zealous wire-grabbing for drag. 2019-05-05 17:14:30 +01:00
Jeff Young a61bbea4bd Fix issue with selection being inadvertantly cleared via ClearFlags(). 
Also fixes an undo bug when pick-component-rotate-place-undo.
 2019-05-05 17:14:30 +01:00
Jeff Young 59af079cbd Fix some hotkey collisions. 2019-05-05 17:14:30 +01:00
Jeff Young 58ba573038 Handle cascading selections in placement. 
See https://forum.kicad.info/t/call-for-testers-eemodern/16663/32
 2019-05-05 17:14:29 +01:00
Jeff Young e9dd8542d1 Allow user to change from move to drag and vice versa. 
Also fixes bugs when doing a duplicate in the middle of a move.
 2019-05-05 17:14:29 +01:00
Jeff Young 0af7c87277 Add resize sheet to context menus. Fix bugs in it. 
Also assign a bunch of icons that were missing.
 2019-05-05 17:14:29 +01:00
Jeff Young bbd8659f69 Implement explicit cross-probing (mainly for sheets which are too slow to do automatically). 
Also moves the message panel updaters to SCH_INSPECTION_TOOL.
 2019-05-05 17:14:29 +01:00
Jeff Young 588d13a912 Fix gcc issue with temp variable and move some collection specs. 
Having the collection specs localized with their code improves
encapsulation.

(Thanks to crasic for the original patch.)
 2019-05-05 17:14:29 +01:00
Jeff Young 35e8a340ca Add enter/leave sheet to modern toolset. 2019-05-05 17:14:29 +01:00
Jeff Young 423d430b58 Replace deleteNode and deleteConnection with selectNode and selectConnection. 2019-05-05 17:14:29 +01:00
Jeff Young 1ff7869ec3 Move Edit with Symbol Editor to modern toolset context menu. 2019-05-05 17:12:59 +01:00
Jeff Young f81007f74b Some clean-up and moving message panel update to selection event. 2019-05-05 17:12:59 +01:00
Jeff Young 2244dcd567 Move show datasheet to SCH_INSPECTOR_TOOL and add show marker info. 2019-05-05 17:12:59 +01:00
Jeff Young 902be18a04 More modern toolset context menu work. 
Text/label type changes and bus entry shape changes.  And some
context menu bug fixing.
 2019-05-05 17:12:59 +01:00
Jeff Young ddbd92c274 Add some more context menu stuff to eeschema modern toolset. 2019-05-05 17:12:59 +01:00
Jeff Young b526461a8e Fix colliding hotkeys issue. 
All grid commands need to be shared now as they're implemented
by a common tool.
 2019-05-05 17:12:59 +01:00
Jeff Young f2474d074b Clean out stuff that's already been moved. 2019-05-05 17:12:59 +01:00
Jeff Young 42383ae871 Build out some of the modern toolkit context menus. 2019-05-05 17:12:59 +01:00
Jeff Young da988428cf Add modern toolset cut/copy/paste. They now use the system clipboard. 2019-05-05 17:12:59 +01:00
Jeff Young 2bd4a1b58c Implement properties dialogs in modern toolset. 2019-05-05 17:12:59 +01:00
Jeff Young 9e2bbcb8b6 Clean up delete and fix bug with juctions getting double-deleted. 2019-05-05 17:12:59 +01:00
Jeff Young de347998d1 Implement drag in modern toolset. 2019-05-05 17:12:59 +01:00
Jeff Young 57a491357f Improve encapsulation. SCH_LINE has no business knowing about drags. 2019-05-05 17:12:59 +01:00
Jeff Young eacc3e67a5 Implement repeatDrawItem in modern toolkit and fix bugs. 
Fixes moving of SCH_FIELDS.
Fixes undo operations around SCH_FIELDS and SCH_PINS.
 2019-05-05 17:12:59 +01:00
Jeff Young 4e0208dfba Move duplicate item and block to modern toolset. 2019-05-05 17:12:59 +01:00
Jeff Young a80f7432b7 Update dangling ends when dragging block. 2019-05-05 17:12:59 +01:00
Jeff Young 1c8461bec7 Transition mirroring to modern toolset. 2019-05-05 17:12:59 +01:00
Jeff Young 8c00dac3c7 Add modern toolset notification to eeschema undo/redo. 2019-05-05 17:12:59 +01:00
Jeff Young f200c61897 Start transitioning block operations to modern toolset. 2019-05-05 17:12:59 +01:00
Jon Evans 6d918ea1f1 A few fixes and refactors to connectivity propagation 2019-05-05 00:03:58 -04:00
Jon Evans 2f2d48938e Ensure connection sheet is properly reset at reinit time 2019-05-04 22:23:35 -04:00
Jon Evans e0ada1379f Allow clearing PcbNew highlight through cross-probing 
Fixes: lp:1821486
* https://bugs.launchpad.net/kicad/+bug/1821486
 2019-05-04 16:18:51 -04:00
Michael Kavanagh 2a09664ebc Clean up import and export menus 
Fixes: lp:1822907
* https://bugs.launchpad.net/kicad/+bug/1822907
 2019-05-02 12:25:59 -04:00
Jon Evans 839f0fbfcf Refactor and fix a few issues with bus unfolding 2019-05-01 22:29:02 -04:00
Jon Evans cbc8faf49b Restore start segment behavior to unfold bus action 
This must have gotten lost in the move

Fixes: lp:1826682
* https://bugs.launchpad.net/kicad/+bug/1826682
 2019-05-01 21:03:30 -04:00
Jon Evans efa0c97da9 Make sure net name prefixes carry through to netlist 2019-05-01 20:48:27 -04:00
Jon Evans 4efed8a4dd Ensure global labels get flagged as lonely in all circumstances 
Fixes: lp:1827214
* https://bugs.launchpad.net/kicad/+bug/1827214
 2019-05-01 20:15:21 -04:00
Wayne Stambaugh 7d803437e2 Eeschema: fix broken symbol library links. 
Force the symbol library links whenever the symbol library table has been
modified.  This will use the cache as a fallback when a library has been
removed that contains links in the schematic rather than display.

Fix the SCH_COMPONENT symbol resolver when falling back to the cache.  The
resolver was using the LIB_ID ':' notation which was failing.  Replacing
':' with '_' fixed this issue.  This was also an issue when generating the
symbol message panel information.

Convert wxLogDebug to wxLogTrace in symbol resolver code path.  Add new
trace type KICAD_SYM_RESOLVE.

Fixes lp:1821606

https://bugs.launchpad.net/kicad/+bug/1821606
 2019-04-30 13:05:27 -04:00
Jon Evans 9741b43dae Make lines and bus entries less frustrating to select 2019-04-29 21:28:53 -04:00
Jon Evans a5a2152ff4 Cache subgraphs by sheet path 2019-04-29 19:58:02 -04:00
Jon Evans c054944d67 Set real-time connectivity to on by default with a safety valve 2019-04-29 18:59:32 -04:00
John Beard 42d20cbd96 Pcbnew: use same null check as eeschema for recently used 
When Pcbnew's add footprint browser is run up, it constructs
the recently used list without checking for nulls.

Although the DoAddLibrary call does internally check for
null, it's easier to filter these out before placing into
the vector in the first place.

The same logic in the symbol tree is already handled in the
same way.
 2019-04-29 16:52:39 +01:00
Jon Evans 96d2fc840b A tiny optimization for SCH_CONNECTION 2019-04-28 23:36:41 -05:00
Jeff Young 3aaba79b87 Fix crash when unfolding bus. 
Thanks to Julien Faucher for the investigation into the problem.
 2019-04-28 18:41:17 +01:00
John Beard fcc4a84e0e GAL: add some trace to GAL display options config 
This can be helpful when tracing where certain configurations
come from (some apps load from other apps' config basenames).
 2019-04-27 14:57:14 +01:00
John Beard 33fe9a2761 Eeschema: Symbol preview widget needs common config for Hi-DPI 
Currently, this widget doesn't read the common library settings.
This means it doesn't use the configured DPI scaling or anti-aliasing
settings.

Use the ReadConfig method on the GAL options to fix (rather than
only ReadAppConfig).

Fixes: lp:1825913
* https://bugs.launchpad.net/kicad/+bug/1825913
 2019-04-27 14:57:09 +01:00
John Beard eccadd92fb Eeschema: fix resizing of pin table and edit symbol dialog 
These dialogs had logic to avoid a table re-adjustment unless
the width changed. This was done to avoid spurious resizing
calls under GTK+3. This was commit
13249b723b, fixing bug lp:1817810.

However, by only calling event.Skip() when the width changed,
redraws were inhibited when only the height changed.

Placing the Skip() outside the width-change check fixes this,
and does not re-introduce the lp:1817810 bug (it is the column
adjust call that causes that).

Fixes: lp:1826615
* https://bugs.launchpad.net/kicad/+bug/1826615
 2019-04-27 14:01:05 +01:00
Jeff Young 6536b4766c Move DeactivateTool until after the block items list has been updated. 
Fixes: lp:1825855
* https://bugs.launchpad.net/kicad/+bug/1825855
 2019-04-26 14:49:43 +01:00
Jeff Young 50a9a6e1f7 Fix bug with swapping pin data for undo. 2019-04-26 12:44:35 +01:00
Jeff Young 0844a5c478 Implement more robust pinMap. 
In particular, one that doesn't suffer from pointers going stale
when the m_pins vector is re-sized.
 2019-04-25 23:10:45 +01:00
Jeff Young f9dd1324da Cleanup problems with fighting event loops. 2019-04-25 22:58:58 +01:00
Jeff Young 8049c07a34 Add filtering to RequestSelection(). 2019-04-25 22:58:58 +01:00
Jeff Young e476cfcec5 Move SPICE tools to modern framework. 2019-04-25 22:58:58 +01:00
Jon Evans 3233bedc7a Ensure pin map pointers are valid after pin vector is filled 2019-04-25 16:04:01 -04:00
Jon Evans 0ce32f7be1 Remove UpdatePins call from connectivity calculation 2019-04-25 15:32:51 -04:00
Jon Evans 098102220e Fix detection of lonely local labels 2019-04-25 15:31:44 -04:00
Jon Evans f0376f1379 Improve ERC checking of labels 
Fixes: lp:1824629
* https://bugs.launchpad.net/kicad/+bug/1824629
 2019-04-25 15:10:39 -04:00
Jon Evans e06d37090a A few connectivity performance tweaks 2019-04-25 00:37:10 -04:00
Jon Evans ed27c50692 Improve handling of non-unique connections 2019-04-24 23:47:57 -04:00
John Beard 15bba27406 BITMAP_BASE: Add const image data accessor 
This allows a const BITMAP_BASE to expose const image
data. This is currently done with const_casts, which is
"OK", only as long as the source image is not declared
const, in which case it's undefined behaviour.

Also immediately dereference the pointer to a reference
if it's not checked to make the non-null requirements
explicit at the point of access.
 2019-04-24 17:31:22 +01:00
Jeff Young 5e556f0c6a Fix segfault when finishing a wire at a connection point. 2019-04-24 14:43:10 +01:00
Jeff Young e046e8f593 Fix crash when <esc>ing from Hierarchical Sheet drawing tool. 2019-04-24 13:43:46 +01:00
Jeff Young d281f051ed Move eeschema delete tool to modern toolset. 2019-04-23 14:19:55 +01:00
Jeff Young a967adbf26 Don't toggle selection twice when trying to select. 
Also fixes issues with trying to use a CONTEXT_MENU as a wxMenu.
 2019-04-23 14:19:55 +01:00
Jeff Young b6674e3bcb Prevent segfault when running selection disambiguation menu. 2019-04-23 10:59:07 +01:00
Jon Evans ff6a8cd537 Revert "Remove UpdatePins call from connectivity calculation" 
This reverts commit b351e70d13.

Causes crashes on entering subsheets; don't have time to debug yet
 2019-04-22 23:31:11 -04:00
Jon Evans 782b8227fa Clean up connection message panel info 2019-04-22 22:58:41 -04:00
Jon Evans b351e70d13 Remove UpdatePins call from connectivity calculation 2019-04-22 22:49:24 -04:00
Jon Evans 62811d3209 Squish some warnings 2019-04-22 21:18:47 -04:00
Jeff Young c994961ebf Fix for SCH_PIN operator= from Simon Richter. 2019-04-23 00:27:59 +01:00
Jeff Young b03e9061ff Have another go at fixing 'w' command when wire tool is already active. 2019-04-23 00:11:26 +01:00
Jeff Young 0445a9913f Deactivate tool on block action. 
Fixes: lp:1825855
* https://bugs.launchpad.net/kicad/+bug/1825855
 2019-04-23 00:11:19 +01:00
Jeff Young f6d0166584 Don't exit wire tool at end of wire. 
Fixes: lp:1825871
* https://bugs.launchpad.net/kicad/+bug/1825871
 2019-04-22 22:13:47 +01:00
Jeff Young 1a007c3e4b Implement SCH_SELECTION_TOOL (but still with legacy semantics). 2019-04-22 22:08:18 +01:00
Jeff Young 8e812c012d Second activation of wire or bus tool should start drawing. 
Fixes: lp:1825871
* https://bugs.launchpad.net/kicad/+bug/1825871
 2019-04-22 22:08:18 +01:00
Jeff Young 17b3b8f30d Fix wandering text problem. 
Setting a variable on a temp copy doesn't do much of use.

Fixes: lp:1825853
* https://bugs.launchpad.net/kicad/+bug/1825853
 2019-04-22 22:08:18 +01:00
Jeff Young 5e2cf51309 Improve robustness of SCH_PIN storage architecture. 
In particular, allow short-term storage of pointers to SCH_PINs.
 2019-04-22 11:19:43 +01:00
Jeff Young a461eae8b9 Fix 100s of usages of GetFlags() which conflated != 0 with being edited. 
While this was true long ago, many flags have been added since which
have nothing to do with editing (HIGHLIGHTED, BEGIN_ONPAD, etc.)
 2019-04-22 09:58:06 +01:00
Jeff Young 64ba866146 Fix ignoreMouseEvents getting stuck in drawing tool. 
Fixes: lp:1825613
* https://bugs.launchpad.net/kicad/+bug/1825613
 2019-04-22 09:32:57 +01:00
jean-pierre charras 6e8dd598c0 Minor fixes in translatable strings. Fix also a minor compil warning. 2019-04-22 09:34:28 +02:00
Jon Evans e2c12d8c25 Overhaul connectivity neighbor and global connection processing 2019-04-21 19:10:44 -04:00
Simon Richter ed4c9f7ddb Use format string for composed strings 
Some translations may need this.
 2019-04-20 22:01:43 +01:00
Jon Evans 77fe7d8325 Remove netlist QC code; it's outlived its usefulness 2019-04-19 22:53:16 -04:00
Jon Evans 5b226f6c96 Allow extra tildes at end of bus names 
Fixes: lp:1825579
* https://bugs.launchpad.net/kicad/+bug/1825579
 2019-04-19 22:26:24 -04:00
Jon Evans eca9cc35c6 Update all labels on a migrated bus 2019-04-19 22:10:30 -04:00
Jon Evans a92bb94612 Ignore multiple identical bus labels 
Fixes: lp:1825560
* https://bugs.launchpad.net/kicad/+bug/1825560
 2019-04-19 22:03:22 -04:00
Jeff Young f2d9887409 Make usage of BRIGHTENED consistent (m_Flags, not m_Status). 2019-04-19 17:19:41 +01:00
Jeff Young 5113c3cc58 Hook up <esc> to cancelInteractive ACTION. 2019-04-19 17:08:19 +01:00
Jeff Young 954998ec9a Lay the foundation for handling selected SCH_ITEMs. 2019-04-19 16:54:29 +01:00
Jeff Young e9c1cd2371 Fix duplicate hotkeys. 2019-04-19 01:07:36 +01:00
Jeff Young d88126e519 Tidy up and fix end sheet command. 2019-04-19 01:00:54 +01:00
Jeff Young f274e0f68b Move some more immediate actions to modern toolset. 2019-04-19 00:42:50 +01:00
Jeff Young d0bc84bcbf Don't allow legacy and modern toolset to fight over moving objects. 
Fixes: lp:1825427
* https://bugs.launchpad.net/kicad/+bug/1825427
 2019-04-19 00:42:36 +01:00
Jeff Young 2bcf38d2b6 Add try/catch block around writing a new library. 
Fixes: lp:1825203
* https://bugs.launchpad.net/kicad/+bug/1825203
 2019-04-18 22:00:32 +01:00
Jeff Young cc18464f8f Move sheet drawing and resizing to modern toolset and fix some bugs. 
Fixes: lp:1825204
* https://bugs.launchpad.net/kicad/+bug/1825204
 2019-04-18 18:19:12 +01:00
Jeff Young 8e2ef339b6 Handle modern-toolset panning. 
Fixes: lp:1748850
* https://bugs.launchpad.net/kicad/+bug/1748850
 2019-04-17 23:56:00 +01:00
Jeff Young 0772b54845 Move eeschema zoom-selection to modern toolset. 
Fixes: lp:1825164
* https://bugs.launchpad.net/kicad/+bug/1825164
 2019-04-17 21:49:50 +01:00
Jeff Young c88fd514a0 Implement drawing tools in modern toolset. 
Fixes: lp:1825192
* https://bugs.launchpad.net/kicad/+bug/1825192
 2019-04-17 21:49:50 +01:00
Jeff Young 460909ea9a Move click-to-place tools to modern toolset. 2019-04-16 16:20:52 +01:00
Jeff Young ecfa05e2ca Allow adding symbols/footprints from editors and browsers. 
This was always possible from modal browsers and from the footprint
editor, but it's now also possible from non-modal browsers and the
symbol editor.

Fixes: lp:920380
* https://bugs.launchpad.net/kicad/+bug/920380
 2019-04-16 16:20:51 +01:00
Jeff Young 32c86a4ca4 Move place symbol to modern toolset. 2019-04-16 16:20:51 +01:00
Jon Evans 895d4c9e1a Hide simulator settings tabs that aren't implemented yet 
Calling Hide() is apparently not enough in Windows
 2019-04-15 23:11:39 -04:00
Seth Hillbrand 1437e56b72 eeschema: Prevent invalid '0' element in components 
In the component, an m_unit/m_convert element is 1-indexed as opposed to
the library where they are 0-indexed.  The 0-index in the library is
reserved for those elements that are shared across all conversion/unit
whereas it is invalid for the component.

Fixes: lp:1824764
* https://bugs.launchpad.net/kicad/+bug/1824764

(cherry picked from commit c4be74a9d0)
 2019-04-15 12:40:59 -07:00
jean-pierre charras 6cdde97e6f ngspice dll search: add auxiliary search paths on Linux, like on other platforms 2019-04-15 11:04:59 +02:00
jean-pierre charras 6d4fbcd5bb SIM_PLOT_FRAME_BASE: very minor fix. 2019-04-15 10:13:47 +02:00
jean-pierre charras ad5a1fd963 SIM_PLOT_FRAME: cosmetic enhancement: add icons in main menu. 
Fix also Upeer/lower case issues in main menu strings.
 2019-04-14 15:31:46 +02:00
Jeff Young b63fab92cf Move Eeschema net highlighting to modern toolset. 2019-04-14 12:10:48 +01:00
Jon Evans 078fdb9077 Fix rotation of global and hierarchical labels 
Fixes: lp:1824432
* https://bugs.launchpad.net/kicad/+bug/1824432

(cherry picked from commit 593a5181d7)
 2019-04-13 17:03:27 -04:00
Jon Evans 77706a7ea6 Fix ngspice nested DC sweep command 
Fixes: lp:1824336
* https://bugs.launchpad.net/kicad/+bug/1824336

(cherry picked from commit c29274e760)
 2019-04-13 16:39:00 -04:00
Jon Evans eadf6d93bc Fix ngspice netlisting when net names contain '/' 
Fixes: lp:1821502
* https://bugs.launchpad.net/kicad/+bug/1821502

(cherry picked from commit 216573bf48)
 2019-04-13 15:37:22 -04:00
Jeff Young 94a948fdd1 Move grid selection for both Eeschema and Pcbnew to COMMON_TOOLS. 2019-04-13 18:43:35 +01:00
Jeff Young fc7f5630c7 Move eeschema zoom operations to modern toolset. 2019-04-13 18:43:26 +01:00
Jon Evans 734e61d4c2 Properly initialize sheets when loading them from ERC dialog 
When displaying a sheet from this path, it's possible the sheet will
not have been initialized yet.  Call DisplayCurrentSheet() to make sure
it is initialized, and then call RedrawScreen to update the zoom level.

Fixes: lp:1824362
* https://bugs.launchpad.net/kicad/+bug/1824362

(cherry picked from commit 1c235a5c89)
 2019-04-13 12:30:24 -04:00
jean-pierre charras 68c2f06074 Eeschema: fix crash when exporting a netlist, if the schematic netlist cannot be built. 
It happens when a symbol is not annotated, and if the user closes the opened annotate dialog without making the annotation
 2019-04-13 17:54:33 +02:00
Seth Hillbrand 9ea7fe5338 eeschema: Finish moving Advanced Config bus 
Missed a definition for unfolding bus

Fixes: lp:1824628
* https://bugs.launchpad.net/kicad/+bug/1824628
 2019-04-13 07:29:33 -07:00
Seth Hillbrand 3e7969ab8d eeschema: Place bus unfold on the stack 
When activating a bus unfold, the results should be placed with the new
line generation to allow proper undo ordering.
 2019-04-13 07:28:22 -07:00
Seth Hillbrand 3bdd69ad6b eeschema: Fix undo stacking for break wire 
The break wire command is actually two commands: modify the existing
wire and add a new wire.  This means that the command must append to the
previous commit to avoid breaking the undo stack

Fixes: lp:1824251
* https://bugs.launchpad.net/kicad/+bug/1824251
 2019-04-13 07:11:24 -07:00
Seth Hillbrand 822cd9c6ef eeschema: Remove UR_WIRE_IMAGE 
The wire image undo/redo option required special handling and was only
used in a single location.  Replacing with single change handling
reduces the code complexity
 2019-04-13 07:11:24 -07:00
Seth Hillbrand 94470f7da6 eeschema: Avoid modifying the schematic in undo 
OnModify() is called when staging the undo/redo modifications.  This
requires  that it not create changes that themselves need to be placed
in the undo/redo stack
 2019-04-13 07:11:24 -07:00
jean-pierre charras 2529346940 Some fixes for I18N. Mainly do not translate debug messages or strings giving only a print format (like "%d"). 2019-04-13 10:12:24 +02:00
Seth Hillbrand 2d7ef9813f Fix backward logic in REALTIME 2019-04-12 09:38:12 -07:00
Seth Hillbrand d70ae19cb8 eeschema: Move realtime connectivity to adv config 
This allows realtime connectivity testing by modifying the
kicad_advanced setting rather than recompiling
 2019-04-12 08:37:44 -07:00
John Beard ab2281d26f GAL opts: move config reading into GAL_DISPLAY_OPTIONS 
Move repeated GAL config reading routines into GAL_DISPLAY_OPTIONS.
THe app-level config is in here already, do the same for the
common config.

This means that the configs are loaded consistently, which fixes
the symbol-chooser preview window, which previously didn't use the
same config routine as other GAL canvases.

Future work could move these functions to free functions that
act on the public interface of GAL_DISPLAY_OPTIONS to avoid
GAL_DISPLAY_OPTIONS having to know about wxConfig and wxWindow.

Fixes: lp:1824524
* https://bugs.launchpad.net/kicad/+bug/1824524
 2019-04-12 16:08:11 +01:00
Jon Evans c1ee395303 Don't propagate secondary connections with the same name 2019-04-12 09:26:07 -04:00
Jon Evans 6ff1919ae0 Fix subgraph neighbor calculation 
Subgraphs are not in any particular order so the entire set must be
scanned, not starting at subgraph_it + 1
 2019-04-12 00:23:52 -04:00
Jon Evans 49d8c29608 Fix a few issues with global buses 2019-04-11 23:38:32 -04:00
Jon Evans df600fc1a2 Fix a few ERC issues with no-connects and power pins 
Fixes: lp:1824359
* https://bugs.launchpad.net/kicad/+bug/1824359
 2019-04-11 21:24:39 -04:00
Jeff Young 3c11b89e4c Hook up refresh buttons to library tree synchronisation. 
Fixes: lp:1820057
* https://bugs.launchpad.net/kicad/+bug/1820057
 2019-04-11 19:45:10 +01:00
jean-pierre charras 0fae86b1ba Pcbnew: suppress incorrect wx alert when opening the plot dialog from File/Plot menu 2019-04-11 17:36:51 +02:00
Jon Evans 232b1c799f Add a workaround for bus unfolding without real-time connectivity 
Fixes: lp:1822728
* https://bugs.launchpad.net/kicad/+bug/1822728
 2019-04-11 00:17:22 -04:00
Jon Evans 3b46253056 Add profiling to SchematicCleanUp portion of connectivity calculations 2019-04-10 23:29:17 -04:00
Seth Hillbrand 8c9244e677 Revert "eeschema: Connectivity threading" 
This reverts commit 1a031e771f.

Some nets broken in commit.
 2019-04-10 20:08:42 -07:00
Seth Hillbrand e28c937a5c Limit number of subgraph checks 
Candidate subgraphs only need to be checked once, so start the iteration
from the next element in the driver vector
 2019-04-10 16:40:24 -07:00
Seth Hillbrand 1c93b122f1 SCH_PIN: Guard the calculated map 
Pins are used in threaded application so we need to keep the
precalculation map guarded
 2019-04-10 15:29:00 -07:00
Seth Hillbrand 1a031e771f eeschema: Connectivity threading 
This threads the first step (update item) in the connectivity routine.
Also eliminates the duplicate call for multiple copies of the same
sheet.
 2019-04-10 15:04:22 -07:00
Jeff Young e90452d0e2 When checking for duplicate aliases look in the dialog not the symbol. 
Fixes: lp:1821543
* https://bugs.launchpad.net/kicad/+bug/1821543
 2019-04-10 21:21:00 +01:00
Jon Evans 105520b235 Fix neighbor detection candidate logic 2019-04-10 00:45:41 -04:00
Seth Hillbrand a0981d06a7 Remove std:: aliasing 2019-04-09 21:16:05 -07:00
Seth Hillbrand 9ef442b3a3 eeschema connectivity - Adjust performance in init 
This allow single init for map structures, improving first-run
performance.
 2019-04-09 21:00:11 -07:00
Jon Evans 541c2fdb29 Performance: Move vector inside SCH_SHEET_PATH so hash can be cached 2019-04-09 21:09:48 -04:00
Seth Hillbrand 86d32fa34d CONNECTION_GRAPH: Performance mods 
Reduce loop count and pre-set the needed vectors.  Also thread the
dangling ends calculation on a per-sheet basis.
 2019-04-09 21:09:48 -04:00
Jeff Young fe1c2310e4 Readjust Edit Symbol Properties when symbol references changes. 
The new reference may contain different numbers of units and/or
different deMorgan conversion settings.

Fixes: lp:1822316
* https://bugs.launchpad.net/kicad/+bug/1822316
 2019-04-09 17:06:27 +01:00
Wayne Stambaugh 3d33cba574 Eeschema: fix schematic text object plotting issue. 
Save and restore text thickness in SCH_TEXT::Plot() function to prevent
the plotting default thickness value from stepping on the original text
thickness and causing all of the text objects to magically change to bold.

Fixes lp:1823165

https://bugs.launchpad.net/kicad/+bug/1823165
 2019-04-09 10:14:32 -04:00
jean-pierre charras 59e6d3bf22 Ensure netlist is always up to date when creating a netlist. 
A previous commit updated the netlist only on cross probing, that not covered all cases.
 2019-04-09 10:36:39 +02:00
Seth Hillbrand cf69cb5637 eeschema: Return CONNECTION when initing 2019-04-08 21:59:49 -04:00
Jon Evans bf051b5c41 Cache InNetlist status for components 2019-04-08 21:54:41 -04:00
Jon Evans 94ba1bcb87 Update connection graph before sending netlist to pcbnew 
Fixes: lp:1823449
* https://bugs.launchpad.net/kicad/+bug/1823449
 2019-04-08 21:36:16 -04:00
Jeff Young c78c3c8198 Allow no-connects to be dragged. 
Fixes: lp:1821342
* https://bugs.launchpad.net/kicad/+bug/1821342
 2019-04-09 00:34:26 +01:00
Jeff Young d88df890ed Fix merge issue between fetch netlist stuff and new connectivity graph. 2019-04-08 21:13:46 +01:00
jean-pierre charras 3b194d6993 Fix a collision name between lib_pin.cpp and a Windows header. 2019-04-08 17:10:55 +02:00
Jeff Young 77f15eeeaf Support synchronous messaging over KIWAY EXPRESS. 
This allows us to make the various netlist and pcb update routines
more atomic and less reliant on carefully sequenced asynchronous
messages.

This is also a prelude to adding support for footprint testing
without a netlist.
 2019-04-08 13:26:09 +01:00
Jeff Young b6c0aeb608 Move cut/copy/paste part (in libedit tree) to real clipboard. 
Fixes: lp:1821547
* https://bugs.launchpad.net/kicad/+bug/1821547
 2019-04-08 11:21:58 +01:00
Jon Evans bd487d2c25 Rework logic for linking local subgraphs together 2019-04-07 23:54:47 -04:00
Jon Evans 2162b53d72 Allow selecting more items for highlighting 2019-04-07 23:54:47 -04:00
Jon Evans c07de84c05 Suppress false ERC warnings for invisible power pins 2019-04-07 23:54:47 -04:00
Jeff Young 684bb62fd8 Escape slashes in labels and netnames. 
Also re-allows spaces, as they can already come in through sheet
names.

Fixes: lp:1798621
* https://bugs.launchpad.net/kicad/+bug/1798621
 2019-04-07 00:24:10 +01:00
Wayne Stambaugh 615c49315f Minor symbol library rescue dialog fixes. 
Adjust the sizer proportions slightly to eliminate the reported bug.
This may not be the ideal way to do this and there could be some issues
on other platforms but it does resolve the issue on gtk3.

Fixes lp:1820084

https://bugs.launchpad.net/kicad/+bug/1820084
 2019-04-06 08:15:44 -04:00
Jeff Young d928aa9780 Infer pin properties from last pin and default pin pitch. 
Fixes: lp:1822183
* https://bugs.launchpad.net/kicad/+bug/1822183
 2019-04-05 18:52:51 +01:00
Jeff Young ea43866563 Move legacy netlist read/write to import/export. 
Fixes: lp:1610529
* https://bugs.launchpad.net/kicad/+bug/1610529
 2019-04-05 16:11:15 +01:00
Jeff Young 2aad4a5e57 Remove dead code from removal of eeschema legacy canvas. 2019-04-05 15:54:31 +01:00
Jeff Young 30f7d6a2c1 Clean up some translation issues. 
(As in coordinate translation, not I18N.)
 2019-04-05 11:42:45 +01:00
Wayne Stambaugh ee14da3093 Minor schematic formatter fix. 
Apparently at some point in KiCad's development, a '~' character was
prefixed to the symbol name to indicate that it was not visible.  The
visibility state is now saved in the name field so remove the prefix.
The parser was kept unchanged.

Fixes lp:1632048

https://bugs.launchpad.net/kicad/+bug/1632048
 2019-04-04 10:43:04 -04:00
Jeff Young 3a1b412fbf Use a bigger hammer when refreshing fields in table. 
Fixes: lp:1823050
* https://bugs.launchpad.net/kicad/+bug/1823050
 2019-04-04 12:26:29 +01:00
Jeff Young 95635804bf Replace pin mark/sweep with method that doesn't invalidate iterators. 
Also removes some no-longer-used drawing code (the Draw() routines
are only used for printing with the modern eeschema canvas in place).
 2019-04-04 12:08:33 +01:00
Jon Evans ec2c571abb Fix merging of subgraphs with multiple labels 2019-04-03 23:15:45 -04:00
Jon Evans ff8b7cc6c1 Fix SCH_PIN location calculation 2019-04-03 23:15:22 -04:00
Jon Evans 99e57724e6 Hierarchical ports count as strong drivers 2019-04-03 22:58:14 -04:00
Jon Evans 5a0944e9a0 Don't de-conflict subgraphs across sheets 2019-04-03 22:58:14 -04:00
Jon Evans d5990100e1 Promote locally-labeled nets to global when tied to global buses 
Fixes: lp:1822964
* https://bugs.launchpad.net/kicad/+bug/1822964
 2019-04-03 22:58:14 -04:00
Jon Evans 591894c7e6 Properly construct new line from old 
Fixes: lp:1823072
* https://bugs.launchpad.net/kicad/+bug/1823072
 2019-04-03 16:26:43 -04:00
Jeff Young d8cc2f8280 More cleanup from non-reference return from GetText(). 2019-04-03 19:35:25 +01:00
Jeff Young 5ac96c6127 More mutex locking for SCH_FIELDs. 
Fixes: lp:1822678
* https://bugs.launchpad.net/kicad/+bug/1822678
 2019-04-03 17:04:59 +01:00
Jeff Young 3ace73fbdd Fold various SCH pin shadow data structures into SCH_PIN. 2019-04-03 10:18:11 +01:00
Jeff Young 52246121b9 Add pins to net highlighting. 
Fixes: lp:1763873
* https://bugs.launchpad.net/kicad/+bug/1763873
 2019-04-03 10:18:11 +01:00
Jon Evans 8a9b82c2a2 Switch CONNECTION_GRAPH to wxLogTrace 2019-04-02 22:58:11 -04:00
Jon Evans b11f9fc873 Performance: don't construct temporary SCH_LINEs in MergeOverlap() 2019-04-02 22:46:22 -04:00
Jon Evans 948a61711d Add thread-safety to SCH_FIELD::IsVoid() 
Fixes: lp:1822678
* https://bugs.launchpad.net/kicad/+bug/1822678
 2019-04-02 19:56:53 -04:00
John Beard 4eb30f6b85 QA: Enable eeschema tests 
Redesignate the eagle test as eeschema tests and build
more like the other unit tests.

Enable as a test in Ctest now that the test executes without
crashing.

The loading of the file with the hardocded part is still
not enabled, as this needs more infrastructure to support it.
 2019-04-02 18:26:33 +01:00
John Beard 6f1c3f5ef8 Eeschema: construct simulator cursors on demand 
Statically constructing wxCursors as used for the probe
and tune cursors crashes the qa_eagle_plugin test
instantly.

Fix this by introducing a new class CURSOR_STORE,
which allows to abstract the platform wierdness of wxCursors
and allow the simulator to laziliy init its own cursors
at runtime.

This code isn't properly tested, as these cursors are never
actually used. However, it does allow the eeschema unit test
to run.

Fixes: lp:1781191
* https://bugs.launchpad.net/kicad/+bug/1781191
 2019-04-02 18:26:33 +01:00
Michael Kavanagh b0674b8802 Add Ctrl+, hotkey to preferences dialog 
Also change interactive router settings from Ctrl+, to Ctrl+Shift+,
 2019-04-02 12:57:27 -04:00
Michael Kavanagh fe6bc411dd Fix 'hokey' -> 'hotkey' typo 2019-04-02 12:57:26 -04:00
Jon Evans 3eef4bceac Don't assert unnecessarily when collapsing power ports 
See lp:1822678
 2019-04-02 11:38:35 -04:00
jean-pierre charras e7900e994d Add a specific bitmap to Bus definition menu entry. 2019-04-02 14:31:28 +02:00
Jon Evans 3c27617782 Check driver instead of parent for prepending path to connection name 2019-04-01 20:21:50 -04:00
Jon Evans 8b30cd4389 Fix edge case crash when processing invisible power pins 2019-04-01 20:21:50 -04:00
Jeff Young b9a8680735 Disable alias controls when no alias is selected. 
Fixes: lp:1821698
* https://bugs.launchpad.net/kicad/+bug/1821698
 2019-04-01 13:23:37 +01:00
Jeff Young 81d4a45e73 Ignore BRIGHTENED state when printing. 
Fixes: lp:1788480
* https://bugs.launchpad.net/kicad/+bug/1788480
 2019-04-01 13:23:37 +01:00
Jeff Young 3da5396c8d Fixes for importing board setup properties. 
Save/restore default netclass.
Read layers back in with correct syntax ('.' between keyword and layer name).
Write layers to project file.
Read/write layer enablement bits.
Don't set solder paste margin min to 0 (most of them are negative).

Fixes: lp:1811990
* https://bugs.launchpad.net/kicad/+bug/1811990
 2019-04-01 13:23:37 +01:00
Jon Evans 0f1ab3be2d Update connectivity before engaging highlight tool 2019-03-31 19:58:23 -04:00