haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,935 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

7890 Commits

Author SHA1 Message Date
jean-pierre charras 9af666ba34 Eeschema: ensure reference field is initialized when adding a new symbol in schematic 2022-08-24 14:30:14 +02:00
Seth Hillbrand 9328cf42c5 Don't close blocking dialog in backannotate 
Back annotate is called from a dialog, so this will close itself but not
exit, locking the UI

(cherry picked from commit 28876bef90)

Fixes https://gitlab.com/kicad/code/kicad/issues/12255
 2022-08-22 07:05:30 -07:00
Seth Hillbrand 9e9b38ef6a Revert "cadstar: Report warning that imported text may be different" 
This reverts commit f637a820b6.

New strings are not allowed in v6
 2022-08-20 20:09:40 -07:00
Wayne Stambaugh 39940fe5ab Fix missing legacy value and footprint field instance data. 
The legacy and s-expression (prior to version 20200828) file formats only
supported symbol unit and reference fields so the newly added value and
footprint fields must be updated from the original symbol fields.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12226

(cherry picked from commit 797827b833)
 2022-08-17 14:24:13 -04:00
Wayne Stambaugh cfde5300d7 Fix wxWidgets 3.1 and later deprecated build warnings. 
wxWidgets 3.1 has deprecated wxPATH_NORM_ALL when normalizing file
paths when calling wxFileName::Normalize().  This change keeps the
existing behavior except in places where our own internal
ExpandEnvVarSubstitutions() to expand environment variables.

(cherry picked from commit 898ec0d094)
 2022-08-17 14:07:06 -04:00
Roberto Fernandez Bautista f637a820b6 cadstar: Report warning that imported text may be different 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12195


(cherry picked from commit 69d696660b)
 2022-08-14 21:25:46 +00:00
jean-pierre charras 411d57396c eeschema: Fix issue when saving labels having more than 50 chars 
These labels (or global label...) were saved with a erroneous angle.
Fixes #12151
https://gitlab.com/kicad/code/kicad/issues/12151
 2022-08-05 13:33:35 +02:00
Jeff Young 3bca4f8835 Fix another case of the instance data getting messed up. 
(Or, more accurately in this case, of the instance data not getting
applied to the current view.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11390

(cherry picked from commit 5295342f42)
 2022-08-04 09:22:23 +01:00
Jeff Young 1f3bb83a06 Make EEschema highlight net consistent with PCBNew. 
In particular, highlight net on an already highlighted net clears
highlight.

Fixes https://gitlab.com/kicad/code/kicad/issues/11016

(cherry picked from commit e36491f231)
 2022-08-04 00:08:12 +01:00
Jeff Young efc75047c1 Pay attention to units for page frames. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11408

(cherry picked from commit 404015b0a5)
 2022-08-04 00:07:24 +01:00
Jeff Young fec9331b48 Handle rotation while moving from move tool. 
This keeps us from getting CancelInteractive events in the move tool
when the EditTool runs to do the rotate.

Fixes https://gitlab.com/kicad/code/kicad/issues/12004

(cherry picked from commit bdffbbd43b)
 2022-08-04 00:00:43 +01:00
Seth Hillbrand 7f71eef45b Move sheetpins by their connection point 
Need to calculate the sheet pin anchor position in order to get it
aligned to the grid while moving

Fixes https://gitlab.com/kicad/code/kicad/issues/12134

(cherry picked from commit 225b03d702)
 2022-07-31 20:04:29 -07:00
Jeff Young f3caac5bfd Ensure no string changes for 6.0.x. 2022-07-28 01:14:58 +01:00
Jeff Young 7bd073b5cb Make sure there are no translation changes for 6.0.x. 2022-07-28 01:08:42 +01:00
jean-pierre charras a5b676fa0e Avoid crashes when, for some reason, a dll cannot be loaded. 
In this case a null pointer was returned by the internal code.
This pointer is now tested against nullptr to avoid the application crashing.
Fixes #12080
https://gitlab.com/kicad/code/kicad/issues/12080
 2022-07-26 16:04:27 +02:00
Jeff Young d9fef3da72 Don't allow 0 line-width for unfilled shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12010

(cherry picked from commit d0547cbde7)
 2022-07-25 21:46:27 +01:00
Jeff Young 61bb793324 Save fp browser list widths and apply known hack to work around wxWidgets bug. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11744

Fixes https://gitlab.com/kicad/code/kicad/issues/11745

(cherry picked from commit 0a623bff9f)
 2022-07-25 21:21:23 +01:00
Jeff Young ccb416eead Bring symbol editor in line with eeschema for empty text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11799

(cherry picked from commit d07c6699ce)
 2022-07-25 21:12:15 +01:00
Jeff Young 6e10a496ef Honour m_resolveTextVars flag for properties as well as fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11937

(cherry picked from commit 5479514819)
 2022-07-25 21:03:47 +01:00
Jeff Young 832c689345 Labels can connect directly to symbols, other labels, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768

(cherry picked from commit c6604e3576)
 2022-07-25 20:56:11 +01:00
Jeff Young 0580fc6819 Add create-wire logic to labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768

(cherry picked from commit 29900cad34)
 2022-07-25 20:44:50 +01:00
Jeff Young ce92c676e6 Use unit references in status bar. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11854

(cherry picked from commit 45ab15dc95)
 2022-07-25 19:40:08 +01:00
Jeff Young bb5fd5a2ec Fix broken logic for hidden pins. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11771

(cherry picked from commit b710982875)
 2022-07-25 19:36:58 +01:00
Jeff Young 41a9293106 Update grid attributes after sorting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11753

(cherry picked from commit 46fd32b738)
 2022-07-25 19:36:13 +01:00
Jeff Young 3c4f8a335f Save selection *before* clearing it. Saving after doesn't do much good. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11242

(cherry picked from commit 1751c8e1cf)
 2022-07-25 19:35:06 +01:00
Jeff Young cd5b4ec8f2 Add edge-exclusions to router (for castellated pads). 
Fixes https://gitlab.com/kicad/code/kicad/issues/1790

(cherry picked from commit 833dc70bff)
 2022-07-25 19:30:49 +01:00
Jeff Young 58451335cb Apply DRC fixes to ERC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11844

(cherry picked from commit 83a2f43661)
 2022-07-25 19:23:57 +01:00
Seth Hillbrand 064a9688c0 Make annotation case-insensitive 
U1 and u1 are allowed but if they both exist in the same schematic, they
will throw an ERC and annotation error.  Reannotating will make them U1
and u2.

Fixes https://gitlab.com/kicad/code/kicad/issues/11862

(cherry picked from commit 00c7b64b13)
 2022-07-18 09:49:28 -07:00
Seth Hillbrand c1ec63d4f9 Protect the Kiway dereference 
Also find a few more places where we are reaching into a new frame to
perform actions that need to have dialogs closed.

Running actions should also wait for the next cycle rather than being
immediately executed when we are calling into a new frame.  This allow
for the cleanup actions onClose() to happen prior to the next action
starting

Fixes https://gitlab.com/kicad/code/kicad/issues/11891

(cherry picked from commit 93fb00d815)
 2022-07-18 09:48:50 -07:00
Seth Hillbrand a8c0bc0430 Keep track of blocking windows 
Allows the calling KiWAY player to send messages to the blocking window
before signaling a separate call

Fixes https://gitlab.com/kicad/code/kicad/issues/11891

Fixes https://gitlab.com/kicad/code/kicad/issues/11772

(cherry picked from commit b5bf1da251)
 2022-07-18 09:47:32 -07:00
Seth Hillbrand 902629c139 Fix name escaping in symbol editor 
When renaming a symbol, be sure to handle name escaping in all of the
various places that we do renaming (!)

Fixes https://gitlab.com/kicad/code/kicad/issues/11939

(cherry picked from commit 0dab566270)
 2022-07-18 09:46:57 -07:00
Seth Hillbrand 865bb54591 Flag ERC error on non-stacked pins 
Pins that are explicitly connected in the schematic should not have an
"unconnected pin" ERC error.  But stacked pins do not count as
explicitly connected because the schematic designer has not connected
them
 2022-07-17 20:16:55 -07:00
jean-pierre charras d53c6f8abe Eeschema, DIALOG_SCH_FIND: ensure the search flags actually used are up to date. 
Flags are encoded using internal wx values, that can change with wxWidgets versions.
They need to be always rebuilt from the displayed options in dialog.
From master branch.
 2022-07-12 08:36:15 +02:00
Seth Hillbrand 4d1fcff732 Fix compile error in v6 2022-07-07 12:19:38 -07:00
Seth Hillbrand 95fcf53353 Handle basic rounding error in schematic import 
The fractional part of Altium schematic units is an integer number of
1/10000 mil segments, which is 2.54 nm.  The internal unit of eeschema
is 10 nm, so each fractional unit in Altium is 0.254 base eeschema
units.  To be consistent with
cf33cfcad1
we round to the nearest 10nm for each element

Fixes https://gitlab.com/kicad/code/kicad/issues/11742

(cherry picked from commit 6fef054c51)
 2022-07-07 11:14:25 -07:00
Jeff Young 042b49ee7b Update message panel from PCB point editor and SCH drawing tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11961

(cherry picked from commit 4f62960334)
 2022-07-06 19:48:09 -07:00
Seth Hillbrand 6a1dfd6e32 Overplot schematic symbol fields and pins 
In the absence of z-ordering, we need to ensure that pin text and symbol
fields are always visible in plots as they are in the schematic window.
We do this by overplotting the fields/pins when symbols overlap each
other.

This can be removed if/when we implement https://gitlab.com/kicad/code/kicad/-/issues/2211

Fixes https://gitlab.com/kicad/code/kicad/issues/11969

(cherry picked from commit ff54b8c718)
 2022-07-05 16:47:07 -07:00
Mike Williams 761ddcad21 Schematic: Add shift-space hotkey for consistency with PCB editor 
Already in 7.0/master.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10858
 2022-06-29 12:54:18 +00:00
Seth Hillbrand 8aabdcff9c Refresh draw objects when common settings change 
Common settings may change colors so make sure that we refresh the draw
objects when the settings change to draw them in the proper colors.
Failing to do this may also cause left over lines on the screen
depending on OpenGL drivers

Fixes https://gitlab.com/kicad/code/kicad/issues/11921
 2022-06-28 16:45:55 -07:00
Seth Hillbrand 90ef84b958 Fix ERC error missing on stacked pins 
Stacked pins are not connected, so they should be flagged as such.  This
checks for stacked pins that are not part of different symbols

Fixes https://gitlab.com/kicad/code/kicad/issues/11926
 2022-06-28 15:03:52 -07:00
Wayne Stambaugh b7b955e37b Eeschema: fix project rescue bug. 
When a rescue library already existed, the disabled writing of legacy
symbol library table entries prevented the rescue library from being
updated.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11897

(cherry picked from commit 4e7b5b9784)
 2022-06-28 16:14:47 -04:00
Seth Hillbrand 5cf346c233 Unify symbol browser/editor unit display 
Fixes https://gitlab.com/kicad/code/kicad/issues/11881

(cherry picked from commit aeef5b00a8)
 2022-06-21 16:23:27 -07:00
jean-pierre charras 92fbc42214 PANEL_SYM_LIB_TABLE: fix a bug in filenames from wxFileDialog dialog. 
We want the full path, so use GetPaths.
GetFilenames sometimes return the full path in wxWidgets 3.1.7, not always the filename
Fixes #11821
https://gitlab.com/kicad/code/kicad/issues/11821
 2022-06-16 13:06:19 +02:00
Jeff Young 16d63b7772 Handle alt pins in plot code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11728

(cherry picked from commit e4798199c6)
 2022-06-12 10:39:31 +01:00
Jeff Young 797cb2aaac Typo. 
LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not.

Fixes https://gitlab.com/kicad/code/kicad/issues/11556

(cherry picked from commit d381fd8b29)
 2022-06-12 10:39:31 +01:00
Jeff Young bbe70e2f67 Repair Eagle importer page number handling. 
The root sheet needs a page number, and the other sheets need to not
have their last step in the path duplicated.

Fixes https://gitlab.com/kicad/code/kicad/issues/11409

(cherry picked from commit aaff163d7c)
 2022-06-08 15:58:52 +01:00
Wayne Stambaugh c861c31f24 Eeschema: fix symbol library remap bug. 
The original decision to escape the legacy symbol library names results
in them being escaped every time they are opened which cause the curly
braces '}' from the original escaping to be escaped on subsequent
openings.  This resulted in the symbol library names in the rescue
library not matching the library ID in the schematic.

This fix is likely to have other corner case bugs given the potential
for escaped characters in legacy symbol libraries.  Given that we now
have escaped rescue libraries in play, removing the escaping will only
result in more issues so we will have to fix the corner cases as we go.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
 2022-06-05 18:12:39 -04:00
jean-pierre charras 7168441a1b Symbol checker: fix incorrect test for duplicate pins. 
From master branch
https://gitlab.com/kicad/code/kicad/issues/11660
 2022-06-04 11:07:13 +02:00
Jeff Young c117708220 Unset forced cursor before leaving two-click place. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11607

(cherry picked from commit 79a0ce9137)
 2022-05-31 23:21:43 +01:00
Alex 6b2bb4d808 Allow sheet recursion, fix sheet paths in "Highlight on PCB". 
"Highlight on PCB" and "Select" - "Items in Same Hierarchical Sheet"
actions were extended to select items on subsheets too.

"Highlight on PCB" now uses a proper full sheet path, allowing it to
work in subsheets.

Fixes https://gitlab.com/kicad/code/kicad/issues/11493
 2022-05-25 23:38:52 +00:00
Jonathan Haas 7fdfd77422 Change default value of MatchByReference to false. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11382


(cherry picked from commit 5802ede3fd)
 2022-05-14 12:44:14 +00:00
Seth Hillbrand d971cbefcb Resolve title variable when plotting 
Be sure to use variable name if it exists when plotting the file

Fixes https://gitlab.com/kicad/code/kicad/issues/11608
 2022-05-12 15:30:45 -07:00
Marek Roszko 7563f51212 Fix eda_doc not looking for schematic locally 
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e


(cherry picked from commit f85251ef75)
 2022-05-11 03:33:40 +00:00
Alex bd97aaa63e Symbol Fields Table fields list: improve scrollbar behaviour on Windows. 2022-05-09 23:51:57 +00:00
Mike Williams e811b9a2dd Hierarchy: update just selection on sheet change 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11550
 2022-05-09 17:31:29 +00:00
Jeff Young 8524042352 Implement cross-references for labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11564

(cherry picked from commit f9f0f6fe24)
 2022-05-09 12:22:49 +01:00
Jeff Young 5b24003f6c Promote field selection to field-owner for Autoplace. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11529

(cherry picked from commit f6f316bd8c)
 2022-05-09 12:07:33 +01:00
Jeff Young 362eec7ee3 Update findnext to handle new instance data architecture. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11424

(cherry picked from commit e0f2a5f07c)
 2022-05-09 00:36:27 +01:00
Jeff Young c63c3d1891 Fix minor layout issue in dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11490

(cherry picked from commit 2cccd5b090)
 2022-05-09 00:36:27 +01:00
Jeff Young f4b5b65342 Initialize virtual page no. to something more reasonable. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11295

(cherry picked from commit 52eb210aa8)
 2022-05-09 00:36:27 +01:00
Jeff Young 624d88dff9 Disable background color when printing in black & white. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11180

(cherry picked from commit 6738708a7f)
 2022-05-09 00:36:27 +01:00
Jeff Young 1831e034be Fix missing line keeping tabs from switching. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11417

(cherry picked from commit fc2eb2d7c9)
 2022-05-09 00:36:27 +01:00
Jeff Young 2dcff109df Update Selection Filter title bar with language changes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11421

(cherry picked from commit 4ab2c93070)
 2022-05-09 00:36:27 +01:00
Seth Hillbrand e05c8f8852 Catch throws in DeleteSymbol 
DeleteSymbol may call SaveSymbol if the name is changed.  In this case,
SaveSymbol may throw back and needs to be caught

Fixes https://gitlab.com/kicad/code/kicad/issues/11566
 2022-05-06 16:13:13 -07:00
Seth Hillbrand f4d4f23876 Catch errors when saving individual symbols 
Fixes https://gitlab.com/kicad/code/kicad/issues/11566
 2022-05-06 09:47:55 -07:00
Wayne Stambaugh 827abb01a3 Eeschema: fix broken project symbol rescue. 
The legacy symbol library plugin code was changed to escape symbol names
which broke the LIB_ID string comparison when checking to see if symbols
needed to be rescued.  Escaping the LIB_ID names before comparison resolves
the issue.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563

(cherry picked from commit a19490b097)
 2022-05-06 10:09:19 -04:00
jean-pierre charras ed153bd7d7 Symbol editor crash: Fix use of a null pointer. 
LIB_TEXT::Clone() did not copy a member set to nullptr.
From Master branch
Fixes #11569
https://gitlab.com/kicad/code/kicad/issues/11569
 2022-05-06 12:54:32 +02:00
jean-pierre charras 82631db1bb Eeschema, backannotate: fix minor issues in displayed messages. 
From Master branch
Fixes #11530 https://gitlab.com/kicad/code/kicad/issues/11530
 2022-05-05 11:29:58 +02:00
Seth Hillbrand ba276fe470 Fix botched commit 2022-05-02 16:28:39 -07:00
Seth Hillbrand 4d47857738 Catch IO_ERRORs that we throw 
FILEOUTPUT_FORMATTER likes to throw when it gets an issue.  We need to
catch this to avoid the app falling apart

Fixes https://gitlab.com/kicad/code/kicad/issues/11516
 2022-05-02 15:15:04 -07:00
Seth Hillbrand 729cf7a39d Use instance data to store values 
Previous use of instance was as an "override" of the default value.
This has changed to be used as the primary storage location for all
values.  This means that we cannot clear the instance data when setting
a new value for all instances, instead we have to change the instance
data and the default value is superfluous

Fixes https://gitlab.com/kicad/code/kicad/issues/11439

(cherry picked from commit 1a70465927)
 2022-04-25 13:03:41 -07:00
Seth Hillbrand cf5f36aac5 Fix broken comparison in pin_numbers 
Pin names like "+V" were incorrectly parsed as doubles leading to broken
comparisons.  These caused heap overflows when sorting pin tables

This corrects the comparison so that numeric sorts are only performed
when there is an actual number in the symbol segment.  Also adds unit
tests for common error cases

(cherry picked from commit aac6f576c2)
 2022-04-19 14:49:52 -07:00
Simon Richter cc51807241 Fix minimum size calculation for new hierarchical sheets 
These constants are given in mil, but are used in a context of internal
units.
 2022-04-18 02:16:17 +02:00
Seth Hillbrand 851f893e8e Fix crash due to cleared view data 
When changing fields, we need to update the view before allowing canvas
updates
 2022-04-15 14:56:18 -07:00
jean-pierre charras 2de1bd7a4a Ensure "Open Recent" and "Clear files" menu titles are updated after language change. 
From Master branch.
 2022-04-14 15:06:17 +02:00
Roberto Fernandez Bautista 250942264b CADSTAR Sch: Clear symbol of all elements before overwriting with new one 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11378

(cherry picked from commit 85f6ff48e7)
 2022-04-12 21:42:03 +01:00
Jeff Young b2eb1f829e Dual-purpose IsMovableFromAnchorPoint to keep from moving symbols off-grid. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11360

(cherry picked from commit 8358685920)
 2022-04-12 13:24:34 +01:00
Jeff Young 63ce2307c8 Adjust LIB_SYMBOL compare for use with ERC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10783

(cherry picked from commit 117bd4fc22)
 2022-04-12 13:24:14 +01:00
Jeff Young 03bc9551c7 Don't save schematic symbol back to lib manager. 
Also, since it doesn't get saved, changing symbols will lose any edits.
Make sure to ask the user first.

Fixes https://gitlab.com/kicad/code/kicad/issues/10767

(cherry picked from commit 16acba34d3)
 2022-04-12 13:24:14 +01:00
Jeff Young c8cd214cb0 Make sure to add any now-necessary junctions after a rotate. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11242

(cherry picked from commit 74a578047c)
 2022-04-12 13:24:14 +01:00
Marek Roszko fe11bc8330 Change the behavior of ACTION_MENU::Add to require clones if required outside the function 2022-04-11 20:39:08 -04:00
Seth Hillbrand c2d72180f8 Revert "Change the behavior of ACTION_MENU::Add to require clones if required outside the function" 
This reverts commit 651f50a26d.
 2022-04-11 11:03:19 -07:00
Marek Roszko 651f50a26d Change the behavior of ACTION_MENU::Add to require clones if required outside the function 
Fix https://gitlab.com/kicad/code/kicad/-/issues/10994
 2022-04-10 22:40:58 -04:00
Jeff Young 529048dac1 Better error reporting for DP uncoupled length. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10087

(cherry picked from commit 722b2588f4)
 2022-04-09 23:09:10 +01:00
Jeff Young 48a776f7c5 Repair code that was supposed to be after LoadSymbol(). 
(Even the comment said so.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11199

(cherry picked from commit ed361925ba)
 2022-04-09 21:23:18 +01:00
Jeff Young 43929781a2 On-the-fly translations for pin electrical types. 
Also add on-the-fly translation for editor title bars.

Fixes https://gitlab.com/kicad/code/kicad/issues/11324

(cherry picked from commit 68ca385e07)
 2022-04-09 21:22:50 +01:00
Seth Hillbrand e02229a234 Don't flag pin missing driver when there is an NC 
The NC flag indicates user intention to override the lack of connection
to input pins
 2022-04-07 09:29:02 -07:00
Seth Hillbrand e740db61f5 Show non-driven error on single-pin nets 
Better to have both the single-pin error message and the non-driven
error message when an input pin is not connected than miss error
messages when the pin is connected to a blank net

Fixes https://gitlab.com/kicad/code/kicad/issues/10430
 2022-04-06 16:53:23 -07:00
Wayne Stambaugh 7d9cf00fd9 Improve sheet schematic import messages and simplify code. 
There was also a logic bug when the selected schematic was in a different
path than the current project and was already part of the current project.
The symbol library table reconciliation code was still run which was wrong.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11075

(cherry picked from commit e336a0e403)
 2022-04-04 17:19:40 -04:00
jean-pierre charras 6127ae92a5 PLOTTER: do not clamp coordinates to an arbitrary value. 
Previously, coordinates were clamped to +- 60 inches. It makes no sense to
clamp them at plotter level: max cooed depends on the editor (schematic/board...)
Rename MAX_PAGE_SIZE_MILS to MAX_PAGE_SIZE_EESCHEMA_MILS and use it only for Eeschema.
Fixes #11196
https://gitlab.com/kicad/code/kicad/issues/11196

(cherry picked from commit 21144481d2)
 2022-04-04 13:52:21 -07:00
Jeff Young f7f6ea54fe Fix incorrect m_SyncPinEdit setting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11331

(cherry picked from commit 3f9cfc0ac1)
 2022-04-04 21:51:30 +01:00
Wayne Stambaugh d3a60f7d83 Fix broken symbol field table editor dialog. 
Do not use the symbol field string to populate the value and footprint
grid cells.  The field strings may be empty because the symbol has not
been instantiated yet by entering a sheet.  This fix makes an incorrect
assumption that the first instance value and footprint data in the symbol
is the same for all instances.

Note: this fix is incomplete because the value and footprint fields are
      can now be different between sheet instances.  The entire field
      table editor design will need to be rethought because the current
      grouping doesn't allow different value and footprint instance
      changes.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11194

(cherry picked from commit b87fc45e33)
 2022-04-04 14:32:07 -04:00
Jeff Young 80bf1048d0 Look for sheet pins inside sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11297

(cherry picked from commit 6b99a937d8)
 2022-04-03 18:22:15 +01:00
Jeff Young d85e52e9fd A better is-modified test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10791

(cherry picked from commit 09ba7468ae)
 2022-04-03 18:21:41 +01:00
Jeff Young f89256e51e Implement align-to-grid for sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11201

(cherry picked from commit 8dc680adbb)
 2022-04-03 18:14:23 +01:00
Jeff Young e3e52d055a Don't rely on HasConversion() for Symbol Properties in Symbol Editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11200

(cherry picked from commit 2681ad6cfc)
 2022-04-03 15:51:33 +01:00
Jeff Young 330b1fd733 Don't leave dangling pointers to old document when importing. 
This goes for both selection pointers and undo/redo pointers.

Fixes https://gitlab.com/kicad/code/kicad/issues/10145

(cherry picked from commit 535ecb9b7b)
 2022-04-03 09:49:37 +01:00
jean-pierre charras 39959844e5 SYMBOL_EDITOR_CONTROL::DuplicateSymbol(): fix incorrect validation test. 
DuplicateSymbol() is called both to duplicate and paste. Only duplicate
needs a test to know if a symbol is selected.
Fixes #11053
https://gitlab.com/kicad/code/kicad/issues/11053
 2022-04-02 08:20:27 +02:00
Seth Hillbrand 15fe2f2fd0 Allow common greek letters in passive regex 
Adds common letters (µ and Ω) as prefix and unit

Fixes https://gitlab.com/kicad/code/kicad/issues/11289
 2022-04-01 12:51:21 -07:00
Seth Hillbrand c23679d9bd Consistently handle env/prj variables 
User-defined variables cannot be used for internally-reserved variables

Fixes https://gitlab.com/kicad/code/kicad/issues/11232
 2022-03-31 17:05:25 -07:00