haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
43,235 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

710 Commits

Author SHA1 Message Date
Jeff Young 0413270012 ADDED: Move Corner To... and Move Midpoint To... 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5012
 2023-08-05 16:43:55 +01:00
John Beard 478df24f36 Fix fillets and chamfers when the original lines become zero-length 
This needs the ITEM_MODIFICATION_ROUTINE to learn to delete items.
Condense the item change handlers into a single injected object
(ITEM_MODIFICATION_ROUTINE::CHANGE_HANDLER) and provide the basic
implementation that just takes some callables.

This simplifies the construction of the routines and also would make
a CHANGE_HANDLER object possible that can be reused between different
tools.
 2023-07-30 15:12:28 +01:00
John Beard da0daffa89 Remove more special-casing for fp-edit commit handling 
In the EDIT_TOOL::ModifyLines method, there was some
remaining special-casing for FP childen commits.

One bit was put back by mistake (in
0b32ae3f4b) because I thought I'd
left it out of the refactor. In fact it was removed slightly later in
1218f61d0a.

THe other bit is omitting Modify commits in the FP-editor (what the
reinstatement of the above code was trying to cause). This shouldn't
be needed any more.

However, something is still incomplete here as the tools still don't
work correctly in the footprint editor. However, I don't think it's
substantially _more_ broken with the special casing removed and at
least it's less confusing.

Related to: https://gitlab.com/kicad/code/kicad/-/issues/15253
 2023-07-30 15:10:30 +01:00
jean-pierre charras a16ab0aae1 Replace SHAPE_T::RECT by SHAPE_T::RECTANGLE: RECT creates a collision name 
issue with a Windows header on msys2.
Change very similar to the commit 9a47b344 about class PAD_SHAPE.
No actual code change
 2023-07-25 09:11:55 +02:00
John Beard 0b32ae3f4b Reinstate fp-editor-specific commit handling in fillet/chamfer tools 
This check was omitted in the refactor of the fillet tool, and
resulted in a bug when undoing the action: the modified lines would
not be un-modified.
 2023-07-23 14:48:31 +01:00
Jeff Young 1218f61d0a Implement undo/redo for footprint children. 
Our special-cases to handle the fact that we didn't do this had far
outgrown the code necessary to actually handle it.
 2023-07-15 17:37:31 +01:00
Jeff Young cf8294b5c2 Remove a bunch of blind (and a few redundant) static_casts. 2023-07-13 14:14:45 +01:00
John Beard a72ab9f351 Put fillet, chamfer and extend in a submenu 2023-07-12 19:21:47 +01:00
John Beard 046d978ba7 ADDED: Pcbnew chamfer and extend tools 
Using the new ITEM_MODIFICATION_ROUTINE system, drop in two new
tools: chamfer and line extend. These are two geometric operations
that are relatively common when editing footprints in particular.

Chamfer delegates the geometric calculations to a dedicated unit
in kimath/geometry.
 2023-07-12 19:21:37 +01:00
John Beard 8e0e9ce752 Generalise fillet tool 
Describe the actions of the fillet tools is a generic way, so that the
same general pattern can be used for other tools that modify shapes on
the BOARD.

Basically, an "ITEM_MODIFICATION_ROUTINE" is defined, which is
configured and called multiple times, calling back to the EDIT_TOOL when
it modifies or creates an item.

The motivation here is to make it easier to slot in new line-based
tools like chamfer, extend and so on without having to redo the
complicated item, selection and commit handling each time, and keep the
core "routines" simple and decoupled from the EDIT_TOOL's
internals.

This also resolves #15094 because the new commit handling does the right
thing when items were "conjured up" for the fillet (e.g. when a
rectangle is decomposed into lines).

Fixes: #15094
 2023-07-12 19:21:26 +01:00
jean-pierre charras bdaad32dc8 Pcbnew: fix crash when trying to delete a DIMENSION living in a footprint 
Fixes #15156
https://gitlab.com/kicad/code/kicad/-/issues/15156
 2023-07-09 20:02:56 +02:00
John Beard ef8cf2d12b Avoid inheriting for POSITIONING_TOOLS_MENU 
This only uses the public interface of CONDITIONAL_MENU,
so we can just make on of those and save declaring a wrapper
type.
 2023-07-06 21:11:51 +01:00
Jeff Young 9ff33e5ec6 Remove BOARD_COMMIT( TOOL_MANAGER ). 
It initializes both m_isFootprintEditor and m_isBoardEditor to false,
causing all sorts of trouble.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15072
 2023-07-01 11:52:46 +01:00
Jeff Young 7ed5963b4f Disable positioning tools when a move is in progress. 
Also fixes a typo in EDIT_TOOL::doMoveSelection().

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15090
 2023-06-30 20:37:03 +01:00
Jeff Young 773e1a1ab6 Actions with a COMMIT must be run synchronously. 
Note that "immediate" doesn't mean quite the same thing: while it will
enter the tool immediately, it won't necessarily finish the tool during
the call if the tool has an event loop.  So for something like Rotate
"immediate" and "synchronous" have the same behaviour, but for something
like Move they do not.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15085
 2023-06-30 18:57:37 +01:00
Jeff Young 1411b09178 Remove EDIT_TOOL's quasi-global BOARD_COMMIT. 
It had several encapsulation leakage issues, as well as poorly-defined
behaviour of undo for chained-actions (append-to-board, and then rotate
while moving, for instance).
 2023-06-27 17:04:18 +01:00
Ian McInerney 2fb6f19a84 Separate immediate and delayed action dispatch 
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
 2023-06-27 00:57:59 +01:00
Jeff Young 493828cc6b Eradicate a bunch of calls to dyn_cast. 
Also deletes PAD::GetParent() which fails to look for parent footprint
through groups.
 2023-06-25 11:10:07 +01:00
Ian McInerney f14feafc6b Convert selection vector to EDA_ITEMS for base tool call 
The base tool expects a generic EDA_ITEMS, but the existing vector
doesn't easily cast, so add a temporary one.
 2023-06-20 21:52:50 +01:00
Ian McInerney f899d9676f Remove unneeded parameter from tool call 2023-06-20 21:52:50 +01:00
Ian McInerney 480223f67c More RunAction specialization 2023-06-20 21:52:50 +01:00
Ian McInerney 07cc85e76c Fix more places where casts into RunAction were happening 2023-06-20 21:52:50 +01:00
Ian McInerney b04e54dbea Switch TOOL_EVENT and TOOL_ACTION to have a std::any parameter 
Using std::any from C++17 allows for proper type handling in the
parameter field, removing the need for casting to void* and then casting
the void* to the desired type.
 2023-06-20 21:52:50 +01:00
Mike Williams 6d93950dcc PCB: abolish TEXT_TYPE::TEXT_is_* 
PCB_TEXT is now always what was formerly TEXT_is_DIVERS and PCB_FIELDs
now what mandatory field type they are already.
 2023-06-20 18:34:52 +00:00
Mike Williams 37837dc392 PCB: introduce PCB_FIELD_T 2023-06-20 18:34:52 +00:00
Jeff Young 30336b2fe3 Unify go-back-one-step processing for drawing tools (and router). 
Also warps mouse on all go-back-one-step operations for better feedback.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14981

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9985
 2023-06-19 17:14:32 +01:00
Jeff Young 96a221ceba Refresh delete immediately; don't wait for next mouse motion. 2023-06-10 21:11:05 +01:00
Jeff Young 2ac3f4cc9e Undo strategy based on being in a footprint, not footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14799
 2023-05-23 17:56:12 +01:00
Mike Williams 04a53ea40d Picker Tools: make sure we know what tool we are 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14621
 2023-05-01 12:43:09 -04:00
Jeff Young 28028c941e Retire Local/Draw coords distinction from PAD (the last object to have it). 2023-04-02 18:02:41 +01:00
jean-pierre charras 054de5687c Pcbnew: fix crash when trying to delete a PCB_TEXT. 2023-04-02 12:15:18 +02:00
Jeff Young bbd6c80507 Collapse FP_* down into their PCB_* equivalents. 2023-03-31 22:57:46 +01:00
jean-pierre charras f8051d954a Better handling of PCB_BITMAP items in a footprint. 
- Ensure they can be erased in the FP editor
- Ensure they cannot be selected in the PCB editor (they are not show)
Fixes #13714
https://gitlab.com/kicad/code/kicad/issues/
 2023-01-31 11:16:38 +01:00
Mike Williams b8352b07c5 PCB: Immediate mode copy should deselect if hover selecting 2023-01-19 09:45:47 -05:00
jean-pierre charras 07b4f88e6b Pcbnew: Fillet Lines tool does not set line width and layer. 
When fillet a polygon or a rect, the resulting lines and arcs had incorrect
width and layer.
Fixes #13338
https://gitlab.com/kicad/code/kicad/issues/13338
 2023-01-02 16:52:08 +01:00
Mike Williams 741d1e043a PCB Editor: make Mirror menu items conditional 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13230
 2022-12-27 14:18:47 -05:00
Jeff Young 1f3727f548 Assigning a netclass has no meaning in fp editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13267
 2022-12-26 20:33:04 +00:00
jean-pierre charras 44ab6876d9 fp editor: remove useless "Unroute Selected" from context menu. 
Fixes #13229
https://gitlab.com/kicad/code/kicad/issues/13229
 2022-12-21 13:11:51 +01:00
Mike Williams bd24e85289 PCB: Add Copy With Reference to the Positioning Menu 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11947
 2022-12-20 11:54:05 -05:00
Mike Williams 17bb57cc73 PCB: fix stale ratsnest between moves in Move Individually 2022-11-30 09:11:37 -05:00
Mike Williams ad6ef35c9f PCB: Add skip action to Move Individually 2022-11-29 15:42:03 +00:00
Mike Williams 3042633f4a PCB: block unroute and move individually when already moving 2022-11-28 14:16:08 -05:00
Seth Hillbrand 01138a2e19 Fix fillet action for lines 
Generalize fillet action behavior to all straight lines in pcbnew

Fixes https://gitlab.com/kicad/code/kicad/issues/4742
 2022-11-21 07:01:14 -08:00
Jeff Young 7089e99f4b Integrate move individually into move algo so other commands don't choke. 
Also adds commands to cancel and finish move individually.

Fixes https://gitlab.com/kicad/code/kicad/issues/12750

Fixes https://gitlab.com/kicad/code/kicad/issues/12749
 2022-11-13 13:18:42 +00:00
Jeff Young 03ba14c6d3 Tighten lifecycle management of parent group pointers. 
Also adds some debugging to try to catch dangling pointers.

Also adds a cache for group bounding boxes (which will be expensive
to calculate for large groups).

Fixes https://gitlab.com/kicad/code/kicad/issues/12875
 2022-11-11 17:27:28 +00:00
Jeff Young ae741b93e6 Resore push/pop-less PickerTool. 
(Functionality was accidentallly lost when we removed the opt command
strings.)
 2022-11-07 19:11:12 +00:00
Jeff Young 3b3e6de515 Disable mirror commands when a single footprint is selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12752
 2022-10-28 19:20:24 +01:00
Jeff Young 46752499df We need both a tool-oriented delete and one that doesn't push/pop, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12600
 2022-10-17 13:21:07 +01:00
Alex 4095172259 ADDED: Pack and Move Footprints, improved footprint spread algorithm. 2022-09-28 13:37:23 +00:00
Jeff Young 3a7068b346 Iterate on a copy of the selection since we're going to delete from it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12484
 2022-09-27 23:54:19 +01:00
Mike Williams e66393c4dd PCB Tools: Move Individually 
Allows moving a selection of components one by one.
 2022-09-26 16:17:41 -04:00
Jeff Young 7e71dc084c Implement Mirror H/V for tracks and vias. 
While not that often useful, it's really annoying that it doesn't work
when you *do* find a use-case for it.

Fixes https://gitlab.com/kicad/code/kicad/issues/6853
 2022-09-24 19:55:48 +01:00
Jeff Young 897135a4f0 Support mirroring on the board too. 
Also fixes a few bugs in FP item mirroring.

Fixes https://gitlab.com/kicad/code/kicad/issues/2168
 2022-09-22 15:05:58 +01:00
Jeff Young 513fc872bb Support both X and Y mirroring in FPEditor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12409
 2022-09-21 00:16:27 +01:00
Mike Williams ca0c9f12e0 PCB Editor: Unroute Footprint 
Also works on selected pads.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/1955
 2022-09-19 10:37:10 -04:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Marek Roszko 3d5913c825 Remove convert_to_biu.h, merge contents to base_units.h 2022-09-16 21:09:28 -04:00
Marek Roszko 66e8931405 Remove IU_PER_MM thats standalone 2022-09-16 21:09:27 -04:00
Marek Roszko a8613ee80f Combine Iu2Millimeter & remove PcbMm2iu 2022-09-16 21:09:26 -04:00
Jeff Young 107f409106 Use router's connectivity algorithm, not CONNECTIVITY_DATA's. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-16 22:49:20 +01:00
Mark Roszko b00178adb3 Nuke base_units from orbit 2022-09-16 04:38:10 +00:00
Mike Williams de6e368ac6 PCB: Swap Tool 2022-09-12 09:39:43 -04:00
Jeff Young 9cf3c529d3 Apply the same accuracy band to connectivity as we use for hittesting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-09 21:42:21 +01:00
Jeff Young 98e760da93 Coverity-suggested improvements. 2022-09-09 13:41:13 +01:00
Jeff Young 2743fd583f More improvements to drag tool selection disambiguation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-08 23:43:07 +01:00
Jeff Young a619ef9d53 Improve drop-a-knee-selection-to-a-single-segment algorithm. 
In particular, don't rely on there being only two items in the
collector at the start.

Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-08 14:10:18 +01:00
Jeff Young 895a8a8dbc Work around focus issues for status popups. 
Autoscroll wasn't working on Mac because the status popup's panel
has the focus.  This *may* also fix a problem on MSW of the auto-scroll
not being cancel-able.

Fixes https://gitlab.com/kicad/code/kicad/issues/11425
 2022-09-04 21:08:01 +01:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Jeff Young 5679b9dbdc Remove a few EDA_RECT instances. 2022-08-31 01:22:49 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Seth Hillbrand 91fbb5c957 Don't prevent immediate actions while router active 
Immediate actions that can take place are useful.  We should only be
preventing immediate actions while actively routing or dragging

Fixes https://gitlab.com/kicad/code/kicad/issues/12311
 2022-08-30 10:31:29 -07:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Jeff Young aa2ad3b44c Move KICAD_T[] to std::initializer_list<KICAD_T>. 2022-08-20 10:28:11 +01:00
Alex 371f6d917f Use VECTOR2I::extended_type instead of long, and int for numeric limits. 2022-08-16 12:08:55 +00:00
Alex 405be8d15f Bounds-awareness in Move, Rotate, point editor, drawing tool 2022-08-16 12:08:55 +00:00
Jeff Young a9536b5de9 CHANGED netclass assignments now done via canvas or via patterns. 2022-08-14 22:56:29 +01:00
Jeff Young 6f49b57f9b Cleanup & performance enhancements. 2022-08-01 13:09:51 +01:00
Jeff Young 1bad72f14f Remove bad static_cast. 
(m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
 2022-07-24 23:41:41 +01:00
Mike Williams 3669cb4673 PCB Editor: Add User Background Images 2022-07-14 11:23:23 +00:00
jean-pierre charras f00de04336 FP editor: fix incorrect mirroring of zones in footprint. 
This is due to a call to Mirror() with incorrect parameter.
Unfortunately, depending on FP items, one Mirror parameter has the opposite
meaning about mirror axis.
Fixes #11952
https://gitlab.com/kicad/code/kicad/issues/11952
 2022-07-04 11:14:47 +02:00
jean-pierre charras 57e59a4959 Pcbnew, on line DRC when moving footprints: add visible collisions between courtyards 2022-05-20 12:58:05 +02:00
Mike Williams b42365190e Schematic/PCB: deleting fields sets them to invisible 2022-04-21 16:20:23 +00:00
Jeff Young 29eb5931c2 Be more careful with forced cursor positions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9977
 2022-04-10 23:14:57 +01:00
Jeff Young d299ddbc7e Cleanup. 2022-02-27 12:05:39 +00:00
Jeff Young ae85f57577 Drop a knee between tracks to a single item when dragging. 
This prevents the disambiguation menu from coming up when we don't
really care which element we start the drag on.

Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-02-26 22:54:23 +00:00
Jeff Young 34a9a165c9 More wide-string declarations. 2022-02-05 22:26:31 +00:00
Jeff Young 5739505aa3 TextBoxes for PCBNew. 2022-01-31 20:00:47 +00:00
Jeff Young f8d6bf4cc9 Hide text items which are required on a single-item delete. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9973
 2022-01-22 22:27:41 +00:00
Jeff Young c8a50d9b50 Remove unit-less angles from VECTOR2I/D APIs. 2022-01-20 23:58:20 +00:00
Jeff Young 9b661aea10 EDA_ANGLE for plotters. 
Also fixes a compile error in the PNS Playground.
 2022-01-16 01:19:45 +00:00
Jeff Young 07013d00e1 More EDA_ANGLE. 2022-01-14 16:08:19 +00:00
Jeff Young 5176512de3 Move PCBNew rotation increment to EDA_ANGLE. 2022-01-14 16:08:19 +00:00
Jeff Young c9487bad18 Move BOARD_ITEM::Rotate() to EDA_ANGLE. 2022-01-14 16:08:19 +00:00
Marek Roszko 7d671cff1e Scoop up some more wxPoints 2022-01-01 21:06:40 -05:00
Seth Hillbrand 410ed8a071 Prevent ops on empty selection 
Fixes https://gitlab.com/kicad/code/kicad/issues/10164

(cherry picked from commit bd75cffff3)
 2022-01-01 15:29:18 -08:00
Marek Roszko c4c56de708 Neurotically update position wxPoint usages 2022-01-01 11:55:51 -05:00
Jeff Young 5e4a704155 Remove some more duplicated preferences. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10112
 2021-12-26 13:37:28 +00:00
Jeff Young 4ba3937f8a Cleanup. 2021-12-24 15:43:24 +00:00
Jeff Young a48867ea01 Solder mask integrity testing. 
ADDED DRC test for solder mask aperture bridging copper from different
nets.
ADDED visualization of minimum web width processing for solder masks.
ADDED allow_soldermask_bridges property for footprints.

Fixes https://gitlab.com/kicad/code/kicad/issues/2183

Fixes https://gitlab.com/kicad/code/kicad/issues/1792
 2021-12-23 22:31:14 +00:00
Jeff Young 4b6bf3095a Radial dimensions. 
ADDED radial type dimensions.

Fixes https://gitlab.com/kicad/code/kicad/issues/2056
 2021-12-23 19:34:54 +00:00