78a6c1a909
Smarten the UpdateAllItemsConditionally() tests in SetActiveLayer().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15329
(cherry picked from commit 5842e9c57e
2023-09-30 13:26:18 +01:00
2e0cdebb0c
Do full high-contrast update of vias & pads if netnames are shown.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15657
(cherry picked from commit c7f69503c0
2023-09-30 13:22:17 +01:00
a5f8955d78
Don't import Altium objects to disabled layers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15586
(cherry picked from commit 962f79334f
2023-09-30 13:21:16 +01:00
33da35db04
Fix typo in arguments list to EvalRules().
...
Also fixes a bug where we weren't clearing the previous tabs from
the notebook.
(cherry picked from commit 31e30a5f56
2023-09-30 13:16:39 +01:00
1d6caa9a35
Fix winding of FP_SHAPE arcs
...
Implement "0" versions of some arc calculations and fix some
initialisation bugs in the handling of FP_SHAPE arcs. Also
set m_endsSwapped.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15694
2023-09-30 12:11:50 +00:00
c74b0943f3
StartPlot can fail and leave a broken file handle
...
Related #15782
2023-09-29 23:54:49 +00:00
bb579294a0
Don't search when board is null (during board changes)
...
(cherry picked from commit 98685b37ff
2023-09-29 23:53:02 +00:00
ad9f5f4dd7
Extend boundary size of PCB_VIEW
...
(cherry picked from commit 156288bfcf
2023-09-29 12:12:03 -07:00
bd57957df7
Revise method of selecting footprints in contrast
...
When working in high contrast mode, we want to be able to select a
footprint with only elements in, e.g. silk and fab layers.
The previous design for footprint IsOnLayer had one behavior of every
other element and a different behavior for footprints. This leads to
multiple bugs as new features use the overloaded IsOnLayer expecting it
to report if the element exists on a layer or not.
For footprints, we need a different routine to determine whether or not
to select the footprint when clicking on it. IsOnLayer will report if
the footprint has any elements on a specific layer but we don't want to
use the bbox for a hittest because large footprints with through hole
pads will exist on every layer and have an enormous bbox. Instead, we
filter footprints based on the hittest of each element. This behaves in
a more logical fashion, allowing you to select a footprint by clicking
on a visible element of that footprint.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15284
(cherry picked from commit f3d65b5156
2023-09-29 12:09:11 -07:00
909d199379
Save flip board status in custom preset
...
(cherry picked from commit 2d54bc42cb
2023-09-29 11:07:49 -07:00
a38327a39c
Ensure that layer names are unique when importing
...
Altium allows duplicate layer names but KiCad prefers to have unique
names for each layer. This enforces a unique name for each layer when
importing
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15583
(cherry picked from commit c772d116b2
2023-09-29 11:03:21 -07:00
686048dcce
Be smarter about releasing lockfiles
...
If KiCad crashes or exits without deleting the lockfile, don't show the
warning message unless we are not the one who locked it or there are
other KiCad instances running locally.
This should catch 99% of the cases where the message is shown
incorrectly. There may be some corner cases where the lock file is
created on a network drive using two different machines with the same
name and same user but these cases should be (famous last words)
sufficiently rare as to not be observed in practice
(cherry picked from commit 7fe83993cf
2023-09-29 11:02:42 -07:00
a74cffac39
PANEL_SETUP_BOARD_STACKUP: save the m_HasDielectricConstrains BOARD_STACKUP member.
...
This member was not saved in the board stackup data.
From master branch.
Fixes #15690
https://gitlab.com/kicad/code/kicad/-/issues/15690
2023-09-19 18:05:42 +02:00
6eeca9aa90
Pcbnew: fix some issues with very small arcs (size a few internal units)
...
these very small arcs do not allow to calculate a reliable center position,
and therefore a reliable radius.
So handle them as a very small segments to fix plotting/drawing issues.
From master branch.
Fixes #15639
https://gitlab.com/kicad/code/kicad/-/issues/15639
2023-09-15 17:47:21 +02:00
86beb339b7
Improve error reporting when running Python action plugins.
...
Python error traceback is now logged to stderr.
On Windows, a console window will pop up if wxTheApp gets destroyed,
because message dialogs crash due to hooks that wxWidgets sets up.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15520
(cherry picked from commit a9a2d4aa7a
2023-09-15 13:33:28 +03:00
88f65f4e47
Fix loading of legacy zone fills in .brd files + Don't refill after board import
...
(cherry picked from commit 30a63b7b32
2023-09-14 01:06:34 +03:00
af5b6b0eba
Fix import of legacy stroked zone fill + add parsing of segments fills
...
From master: 54f401c72c
2023-09-14 01:06:34 +03:00
72737b20cd
Fix reading legacy zone fills which were based on stroked polygons.
...
Ported from 448de72823
2023-09-13 03:40:23 +03:00
d05093e6f7
Don't throw the number box baby out with the bathwater....
2023-09-12 17:39:34 +01:00
a7e6928f4e
Don't go through a middle man when reading pad shape primitives.
...
They're both PCB_SHAPEs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15073
(cherry picked from commit 9f5a268f15
2023-09-11 22:20:33 +01:00
c7a4ea97c3
Fix oval pad snapping
...
Previously the snap points computed for oval pads didn't get all the
points correct. This breaks out the "find snap points for ovals"
into a function, reworks the logic, adds some tests.
Also adds "extremum points" when the oval isn't exactly H/V.
(cherry picked from commit 78c8de9b08https://gitlab.com/kicad/code/kicad/-/issues/15594
2023-09-10 00:49:03 +01:00
81ebb1030a
Add forward declarations in pcb_grid_helper.h
...
(cherry pick of part of commit 0f781f328e
2023-09-10 00:45:32 +01:00
86ec36d183
Fix reading/writing thermal spoke angles for custom pads.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15518
2023-09-10 17:32:22 +03:00
207f2e568b
drc_test_provider_text_dims.cpp: ensure glyphs to test are OUTLINE_GLYPH.
...
For non Kicad font texts with a overbar, the overbar is not a OUTLINE_GLYPH.
From Master branch.
Fixes #15604
https://gitlab.com/kicad/code/kicad/-/issues/15604
2023-09-09 10:37:58 +02:00
19753719cb
SVG import: skip shapes that are not stroked and not filled.
...
(cherry picked from commit bc846f5fca
2023-09-08 14:49:08 +03:00
5f025dcd73
SVG import: skip invisible shapes.
2023-09-08 14:49:08 +03:00
0d9d8c28f1
Flip Viewport when Flip board is enabled
...
(cherry picked from commit a8e18e2d8c
2023-09-06 16:56:01 +01:00
123ff326d4
Don't include plating thickness when drawing hole clearance lines.
...
We don't include it in the router, and the code didn't
differentiate between plated and non-plated holes, and it confuses
users.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15575
(cherry picked from commit 0cde8cff1d
2023-09-06 16:31:46 +01:00
9c87a52b6e
Altium PCB import: Polygon Cutout only cuts copper fill.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15587
(cherry picked from commit 4f303a8dc2
2023-09-06 09:26:48 +03:00
32c2135047
Flip the RegisterSettings order to avoid legacy import crashes
2023-09-04 23:22:39 -04:00
702e08b083
Don't call .Load() and cause settings to reload from disk
...
RegisterSettings can load the new settings json as added by not turning off the load now parameter
2023-09-04 22:41:12 -04:00
8f58e1a9e0
DIALOG_EXPORT_STEP_LOG: print the command line sent to kicad-cli in report window.
...
It can be useful in case of problems.
(cherry picked from commit 2bf8602912
2023-09-05 00:26:43 +00:00
61ef88a0ac
Don't allow duplication of footprint items outside of footprint editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15487
(cherry picked from commit 9bba8e5956
2023-09-03 22:44:17 +01:00
02a95b958d
Remove up/down buttons until we implement layer ordering.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14574
(cherry picked from commit d27413a032
2023-09-03 22:43:41 +01:00
5cd88dbd20
Bug fixes for paste margins on custom-shaped pads.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15125
(cherry picked from commit 60419f542a
2023-09-03 22:32:40 +01:00
ec53ed6a37
Don't start a router drag when already in an EDIT_TOOL drag or move.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15312
(cherry picked from commit 624203f2e1
2023-09-03 22:12:43 +01:00
242413a334
Don't start a pack&move when already in an EDIT_TOOL drag or move.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15545
(cherry picked from commit a24a8aaca7
2023-09-03 22:12:24 +01:00
f88dce1627
Don't return separate shapes from a custom-shaped pad.
...
It just confuses the hull generator.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15553
(cherry picked from commit 43862d767e
2023-09-03 22:11:15 +01:00
93fdd35b31
Support SHORT_NET_NAME(pin_number) and friends on symbols.
...
While it's of debatable use in the schematic, some users want to
author them there so that they're then copied onto the board.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15544
(cherry picked from commit d74e9ba040
2023-09-03 22:07:11 +01:00
6ca7c3a3a1
Fix merge errors.
2023-09-02 11:18:34 +01:00
88448ce746
Custom pads with round anchors in pre-7.0 files get 90 degree spokes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15518
(cherry picked from commit 676c6e81a4
2023-09-02 11:18:34 +01:00
480a9ac77d
Implement undo/redo around Pad Edit Mode changes.
...
(cherry picked from commit 69a1b30b8a
2023-09-02 11:18:34 +01:00
889689e31a
Stop trying to zero-out offset of custom-shaped pads.
...
It causes *way* to many issues.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15555
(cherry picked from commit 68c839b214
2023-09-02 11:18:34 +01:00
2e739e743d
Gerber place file: change DCode size of pads others than 1 or A1 to 0.1 mm
...
Previously it was a round shape 0.0 mm (allowed but not visible)
Gerber Format rev 2023-08 changed it to 0.1 mm (still a round shape)
2023-08-31 16:44:14 +02:00
d2d7e630bd
Allow for offset custom-shaped pads with no holes.
...
(cherry picked from commit 0d39cd5e63
2023-08-31 12:37:44 +01:00
d11cd173dc
Fix previous fix for honouring pad offset.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15494
(cherry picked from commit e0cf49e73c
2023-08-31 12:37:44 +01:00
12e0427038
Honour pad offset when creating custom pad anchors (and polygons).
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15494
(cherry picked from commit 300014177f
2023-08-31 12:37:44 +01:00
09490e1f46
Don't snap a footprint (or group) to its children.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15535
(cherry picked from commit d161602e92
2023-08-31 12:37:44 +01:00
f33120c540
Remember footprint library browsers liblist width.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15500
(cherry picked from commit a4d1b29b91
2023-08-31 12:37:44 +01:00
82ed223b02
Handle non-cardinal major-axis arcs when importing DXF.
...
(cherry picked from commit a946f7ab1b
2023-08-31 12:37:44 +01:00
Jeff Young
John Beard
Mark Roszko
Josue Huaroto
Seth Hillbrand
jean-pierre charras
Alex Shvartzkop
Roberto Fernandez Bautista