30ba1b8007
Coverity warning fix.
...
This fixes all of the warnings cause by using std::weak_ptr objects when
recursing the symbol inheritance tree to retrieve the root symbol. The
issue is that the weak pointers are not guaranteed to be valid for each
recursion because the lock will go out of scope. Using a std::shared_ptr
object will ensure the lock is valid until it goes out of scope.
2023-10-28 13:25:30 -04:00
708b42ea69
Fix off-by-one error when creating user-defined signals.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15970
2023-10-28 13:27:48 +01:00
171458a27b
Introduce action friendly names
...
Friendly names can be used to display action information that is clearer
in non-hierarchical contexts (e.g. not in menus).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8075
2023-10-27 23:58:29 +01:00
61d03b41ec
Eeschema: Fix crash of modifying graphic item and abort with ESC by adding re-entrancy guards
2023-10-27 21:19:31 +00:00
6269453416
Coverity warning fixes.
2023-10-27 16:48:14 -04:00
6b29c346b9
When presented with empty text we don't want to Normalize() the SIM_VALUE.
...
But we *do* need to update NUMERICAL_EVALUATOR::m_originalText by
calling NUMERICAL_EVALUATOR::Process().
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15871
2023-10-27 16:59:28 +01:00
8cba785375
Single warning for all locked sheets when saving schematic.
...
Also checks for modified before trying to save at all.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15946
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15963
2023-10-27 14:58:30 +01:00
1290cf6241
Fix missing random sim command
...
(cherry picked from commit 3ce4a5bf7f
2023-10-26 09:47:43 -07:00
ca9fdbbedb
Use a slower method of keeping dangling state correct for current sheet.
...
(The faster method ran into unit test failures. There must be
something in here that's order-specific.)
2023-10-26 15:22:15 +01:00
84b0848a1e
Make sure that current sheet's units and dangling states are correct.
...
We used to store the symbol units of the current sheet and then
restore them, but we didn't handle the dangling states.
The new code uses a different strategy and just makes sure that if
any of the sheets are going to modify the current screen, the current
sheet gets to go last so that its modifications will "stick".
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15392
2023-10-26 13:07:16 +01:00
5bf241a53e
Pcbnew, export component placement: better string in menu (.gbr added).
...
Also fix 2 minor Coverity warnings.
2023-10-25 09:41:08 +02:00
fefb3d96dd
Better clarity and memory leak fixes for LTspice importer.
...
Moves some exception processing to a REPORTER interface so we don't
leak a bunch of memory by exiting early.
Also adds some assertion processing to make sure we're not leaking
in other places.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15158
2023-10-25 00:11:08 +01:00
46aecefb04
Re-enable import non-Kicad project, but make it clear current will be lost.
...
(And there's no sense in asking if they want to save changes first,
as those will be lost too.)
2023-10-25 00:11:08 +01:00
0158377cb7
Fix schematic text properties dialog more, for wx 3.2.3.
2023-10-25 00:12:49 +03:00
d9b5257b9e
DIALOG_TEXT_PROPERTIES: Fix a cosmetic issueFixes #
...
Fixes #15940
https://gitlab.com/kicad/code/kicad/-/issues/15940
2023-10-24 19:28:40 +02:00
4741a5ed4c
Fix memory leak in connection graph
...
When generating virtual connections to represent bus aliases, we need to
store the pointers for future deletion otherwise we will leak the memory
(cherry picked from commit 9260f58803
2023-10-23 13:47:07 -07:00
86208a7922
Improve pin-pin iteration in ERC checks
...
Rather than generating expensive classes to store in a set to check for
duplicate checks, we avoid double-checking elements in the vector. For
large schematics this results in a substantial speed increase
(cherry picked from commit 1a5c515e45
2023-10-23 13:45:43 -07:00
8cbad7a3c0
Compare bus local names
...
When running ERC, we want to check if bus members exist in the bus and
this should be done using m_local_name (i.e. the name it take from the
parent bus) not the resolved name as this will change depending on
connections
(cherry picked from commit 1380feef72
2023-10-23 12:54:58 -07:00
435e3fab8d
Support text variables in STEP export filename.
...
Also fixes some other file browser titles to match Kicad's overall style.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15927
2023-10-23 18:01:47 +01:00
8ec2eb600a
Point editor: manually manage grid lifetime for now
...
Will prevent crashes until we can fix this correctly.
2023-10-23 10:57:54 -04:00
91b6bb8088
Grid helpers: remove view items on destruction
2023-10-23 09:39:08 -04:00
9e48c0b695
Grids: placing symbols should respect connectables, not graphics
2023-10-23 09:34:06 -04:00
dc8a5865d5
Symbol Editor: SCH_HTTP special treatment
...
Added SCH_HTTP to receive special treatment, same like with database libraries!
2023-10-22 19:37:43 +00:00
eb5b3db063
Add bitmap bundle support to BITMAP_SCALE
...
Change a bunch of buttons and toolbars to use it
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14119
2023-10-22 14:02:06 -04:00
71fb1afe4c
Add ngspice lib paths for when running from build dir.
2023-10-22 19:58:17 +03:00
3e4d5d776d
Add --exclude-pdf-property-popups to schematic plotting CLI.
2023-10-22 12:33:55 +01:00
7cca303f65
Expose missing properties for label shapes.
2023-10-22 12:33:55 +01:00
f50de028fb
Make plotting of PDF property popups optional.
2023-10-21 21:52:51 +01:00
68e46ecad5
Don't set modified flag when updating measurement format internally.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15909
2023-10-21 14:26:31 +01:00
eff4e2cc9c
Convert windows file paths to unix notation.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15888
2023-10-21 13:33:22 +01:00
27bf47d752
Protect equality operator against invalid fields
2023-10-21 00:55:57 +02:00
903c01cb20
Make ERC grid error clearer that it's about the connection grid.
...
Also adds a context menu item to edit the connection grid spacing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15908
2023-10-20 21:01:58 +01:00
12118b6246
Make sure measurements are updated from grid before saving workbook.
...
Also fixes a typo when loading measurements.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15909
2023-10-20 17:36:17 +01:00
62eaa7e1c7
Signals already have gain/phase broken out; user-defined signals don't.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15903
2023-10-20 14:09:46 +01:00
d99641be40
ADDED: Git integration support
...
Adds support for project-based git integration, branch support, commit,
revert and updates
Fixes https://gitlab.com/kicad/code/kicad/issues/10441
2023-10-20 12:51:47 +00:00
c4a9703f81
Minor dialog layout fixes.
2023-10-19 11:59:35 -04:00
134685bc32
Optical alignment for capital 'T's.
2023-10-19 15:02:38 +01:00
b089630b4c
Simplify Import Graphics.
...
Removed no-longer-required differentiation between importing
footprint vs board objects.
Renamed files to match the dialog.
Made Position At and Set Layer optional checkboxes.
Removed Group Items checkbox. (In the unlikely event that you don't
want a group, do an UnGroup after importing.)
Flattened out labelled-sizers in the dialog.
Removed importers blacklist, which hasn't been active for at least 4
years.
Fixed undo/redo bug that caused items to be no-longer-grouped after
a redo.
2023-10-19 01:31:13 +01:00
f629898c8b
Coding policy fixes.
2023-10-17 08:07:15 -04:00
bee6e6be01
AddMenuLanguageList should live in EDA_BASE_FRAME, its only user
2023-10-16 19:49:52 -04:00
ba83e84b91
Move SaveCanvasImageToFile to EDA_DRAW_FRAME rather than leaking things to bitmaps
2023-10-16 18:33:11 -04:00
b5eee9dd7e
Coverity warning fixes.
2023-10-16 17:04:14 -04:00
2849388d2e
Symbol Fields Table: save Select option correctly
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15857
2023-10-16 13:42:51 -04:00
7efd414519
Fix minor Coverity and compil warnings
2023-10-15 15:55:31 +02:00
ace7cbddfe
CADSTAR: look for the symbol library .csa file under different names.
2023-10-15 05:56:38 +03:00
77eaf252e2
CADSTAR: use pin labels if pin names are not available.
2023-10-15 05:49:07 +03:00
c7daf511bc
Fix importing a symbol in Symbol editor.
2023-10-15 05:48:17 +03:00
d5d07e64c9
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2023-10-14 23:51:37 +01:00
a16bdb7288
ADDED: Support EAGLE libraries directly in Symbol Library Table.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2214
2023-10-15 01:45:39 +03:00
9ed19192de
Improve editing values with {return} in text fields; Add hyperlink detection.
2023-10-15 01:45:39 +03:00
Wayne Stambaugh
Jeff Young
Ian McInerney
Zhuang Jiezhi
Seth Hillbrand
jean-pierre charras
Alex Shvartzkop
Mike Williams
afkiwers
Jon Evans
Marek Roszko