4741a5ed4c
Fix memory leak in connection graph
...
When generating virtual connections to represent bus aliases, we need to
store the pointers for future deletion otherwise we will leak the memory
(cherry picked from commit 9260f58803
2023-10-23 13:47:07 -07:00
86208a7922
Improve pin-pin iteration in ERC checks
...
Rather than generating expensive classes to store in a set to check for
duplicate checks, we avoid double-checking elements in the vector. For
large schematics this results in a substantial speed increase
(cherry picked from commit 1a5c515e45
2023-10-23 13:45:43 -07:00
8cbad7a3c0
Compare bus local names
...
When running ERC, we want to check if bus members exist in the bus and
this should be done using m_local_name (i.e. the name it take from the
parent bus) not the resolved name as this will change depending on
connections
(cherry picked from commit 1380feef72
2023-10-23 12:54:58 -07:00
435e3fab8d
Support text variables in STEP export filename.
...
Also fixes some other file browser titles to match Kicad's overall style.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15927
2023-10-23 18:01:47 +01:00
8ec2eb600a
Point editor: manually manage grid lifetime for now
...
Will prevent crashes until we can fix this correctly.
2023-10-23 10:57:54 -04:00
91b6bb8088
Grid helpers: remove view items on destruction
2023-10-23 09:39:08 -04:00
9e48c0b695
Grids: placing symbols should respect connectables, not graphics
2023-10-23 09:34:06 -04:00
dc8a5865d5
Symbol Editor: SCH_HTTP special treatment
...
Added SCH_HTTP to receive special treatment, same like with database libraries!
2023-10-22 19:37:43 +00:00
eb5b3db063
Add bitmap bundle support to BITMAP_SCALE
...
Change a bunch of buttons and toolbars to use it
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14119
2023-10-22 14:02:06 -04:00
71fb1afe4c
Add ngspice lib paths for when running from build dir.
2023-10-22 19:58:17 +03:00
3e4d5d776d
Add --exclude-pdf-property-popups to schematic plotting CLI.
2023-10-22 12:33:55 +01:00
7cca303f65
Expose missing properties for label shapes.
2023-10-22 12:33:55 +01:00
f50de028fb
Make plotting of PDF property popups optional.
2023-10-21 21:52:51 +01:00
68e46ecad5
Don't set modified flag when updating measurement format internally.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15909
2023-10-21 14:26:31 +01:00
eff4e2cc9c
Convert windows file paths to unix notation.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15888
2023-10-21 13:33:22 +01:00
27bf47d752
Protect equality operator against invalid fields
2023-10-21 00:55:57 +02:00
903c01cb20
Make ERC grid error clearer that it's about the connection grid.
...
Also adds a context menu item to edit the connection grid spacing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15908
2023-10-20 21:01:58 +01:00
12118b6246
Make sure measurements are updated from grid before saving workbook.
...
Also fixes a typo when loading measurements.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15909
2023-10-20 17:36:17 +01:00
62eaa7e1c7
Signals already have gain/phase broken out; user-defined signals don't.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15903
2023-10-20 14:09:46 +01:00
d99641be40
ADDED: Git integration support
...
Adds support for project-based git integration, branch support, commit,
revert and updates
Fixes https://gitlab.com/kicad/code/kicad/issues/10441
2023-10-20 12:51:47 +00:00
c4a9703f81
Minor dialog layout fixes.
2023-10-19 11:59:35 -04:00
134685bc32
Optical alignment for capital 'T's.
2023-10-19 15:02:38 +01:00
b089630b4c
Simplify Import Graphics.
...
Removed no-longer-required differentiation between importing
footprint vs board objects.
Renamed files to match the dialog.
Made Position At and Set Layer optional checkboxes.
Removed Group Items checkbox. (In the unlikely event that you don't
want a group, do an UnGroup after importing.)
Flattened out labelled-sizers in the dialog.
Removed importers blacklist, which hasn't been active for at least 4
years.
Fixed undo/redo bug that caused items to be no-longer-grouped after
a redo.
2023-10-19 01:31:13 +01:00
f629898c8b
Coding policy fixes.
2023-10-17 08:07:15 -04:00
bee6e6be01
AddMenuLanguageList should live in EDA_BASE_FRAME, its only user
2023-10-16 19:49:52 -04:00
ba83e84b91
Move SaveCanvasImageToFile to EDA_DRAW_FRAME rather than leaking things to bitmaps
2023-10-16 18:33:11 -04:00
b5eee9dd7e
Coverity warning fixes.
2023-10-16 17:04:14 -04:00
2849388d2e
Symbol Fields Table: save Select option correctly
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15857
2023-10-16 13:42:51 -04:00
7efd414519
Fix minor Coverity and compil warnings
2023-10-15 15:55:31 +02:00
ace7cbddfe
CADSTAR: look for the symbol library .csa file under different names.
2023-10-15 05:56:38 +03:00
77eaf252e2
CADSTAR: use pin labels if pin names are not available.
2023-10-15 05:49:07 +03:00
c7daf511bc
Fix importing a symbol in Symbol editor.
2023-10-15 05:48:17 +03:00
d5d07e64c9
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2023-10-14 23:51:37 +01:00
a16bdb7288
ADDED: Support EAGLE libraries directly in Symbol Library Table.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2214
2023-10-15 01:45:39 +03:00
9ed19192de
Improve editing values with {return} in text fields; Add hyperlink detection.
2023-10-15 01:45:39 +03:00
95032bd487
Make ERC off-grid check user-configurable.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14110
2023-10-14 20:47:03 +01:00
b87496b834
Fix loading legacy (until 2009) schematic files.
2023-10-14 15:42:13 +03:00
7b94ecdc01
Fix the insufficient privileges message in symbol remap dialog.
2023-10-14 15:42:13 +03:00
83af481688
Improve EAGLE file header detection.
2023-10-14 15:42:13 +03:00
0b06a1376b
Don't turn an empty string into a '0'.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15871
2023-10-13 19:07:45 +01:00
0fe2e06949
Fix ambiguous cast compiler errors on MSVC
2023-10-12 19:07:12 -04:00
50ec069a01
Fix build warnings.
2023-10-12 10:10:09 -04:00
5d6ef69726
Coding policy and Doxygen comment fixes.
2023-10-12 09:36:28 -04:00
b0f4adf052
Improve borderless items logic in schematic plotting.
2023-10-12 08:40:37 +03:00
97fe27350f
symbol_checker: add more tests to validate the ssymbol.
...
especially, null sized rectangles and circles are tested.
2023-10-10 18:31:10 +02:00
8c017be24a
Clearer naming.
2023-10-10 15:43:45 +01:00
9ff8d02e60
Symbol library manager object changes.
...
* Fix issue handling symbols with multiple inheritance.
* Remove unused code from the symbol library manager object.
* Splits out the library buffer and symbol buffer object so the can be unit
tested without having to mock the symbol library manager object.
* Add unit tests for library buffer and symbol buffer objects.
2023-10-09 14:58:49 -04:00
21adc0aac5
ADDED: Import vector graphics into Schematic editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
60d069757a
ADDED: Import vector graphics into Symbol editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
4d0ee276e8
Suppress "File: " when we're showing the Sheetfile field name.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15637
2023-10-07 10:41:02 +01:00
b161105fce
Fix assertion failure in bus alias dialog.
2023-10-06 21:41:16 +01:00
f197882f78
Enable translations for "Open cancelled by user." in some sch plugins.
2023-10-06 15:35:58 +03:00
e48256d41a
DIALOG_SYMBOL_FIELDS_TABLE::OnExport(): better error messages.
2023-10-06 13:50:59 +02:00
d6c3f4d190
Protect against subgraph loops
...
Optimize the subgraph processing to avoid repeated loops when multiple
items belong to the same subgraph.
(cherry picked from commit 75de21314c
2023-10-05 09:20:26 -07:00
706b42e6f2
SCH_COMMIT: when clearing all item flags, do not clear all item flags.
...
If a item is selected, its SELECTED, STARTPOINT and ENDPOINT flags cannot be cleared,
and must be still selected after changes to allow more move, rotate... commands.
Fix to previous commit 741c6f2d
2023-10-05 16:46:20 +02:00
31c488bc23
NETINFO_ITEMs are owned by BOARD.
...
Lifecylce management must go through BOARD_COMMIT (or at least
the frame's undo/redo lists).
2023-10-04 21:01:33 +01:00
e9bdfe7210
Save trace colors during session.
...
My first thought was to move the color out of the TRACE, which is
really a view object. However we can't make signals a first-class
citizen either, because they change depending on what the current
simulation tab is and so (for instance) we can only load in the
workbook signals for the current tab. Hours later I backed it all
out and arrived at this simpler, less "correct" solution.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14231
2023-10-04 17:13:08 +01:00
ed4d66e76b
Remove dead code.
2023-10-04 17:13:08 +01:00
c010c7b0ea
eeschema: add 'Already placed' category when choosing symbol
2023-10-04 10:29:22 -04:00
979942e31a
Output fields in both multi-unit and single-unit cases.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15811
2023-10-03 17:38:26 +01:00
95f05ee869
Fix copy/pasta.
2023-10-03 17:14:21 +01:00
9f5e583ced
Readability.
2023-10-03 17:14:03 +01:00
9b60e99660
Use wxSTAY_ON_TOP instead of wxFRAME_FLOAT_ON_PARENT for choosers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15808
2023-10-03 14:49:50 +01:00
6fbbf981f0
Handle justification when hit-testing fields.
...
This steals the algo used in SCH_PAINTER to get the right coords
for the text.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15722
2023-10-03 14:36:13 +01:00
0c055e15b7
Keep user-defined signals separate.
...
They can't be plotted till the end of the sim.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15803
2023-10-03 12:59:49 +01:00
827942c560
Clarity.
2023-10-03 12:59:49 +01:00
2dfdf0682f
Don't ask for empty data.
2023-10-03 12:59:49 +01:00
a60411b159
Fix a few compil and Coverity minor warnings.
2023-10-03 08:22:03 +02:00
5759823ca0
Move JOB_EXPORT_SCH_PLOT to kicommon horribly pending further refactor of plotting
2023-10-02 20:48:26 -04:00
a3d83cdb6d
Pass symbol netlist from Field Properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15806
2023-10-02 23:41:06 +01:00
06446bb80e
Only expand lib tree when filtering.
2023-10-02 16:24:53 +01:00
532ac6992a
Fields: make sure footprints get a footprint
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15796
2023-10-02 11:02:10 -04:00
003acbd686
Clear render caches before plotting.
...
Also fixes a bug where text variables in LIB_TEXT weren't getting
expanded when plotting.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15765
2023-10-02 15:39:14 +01:00
6d3b846eb5
Add more missing destructor event cleanups
2023-10-02 07:22:00 -04:00
cf02bb171f
Expose exclusion flags in search pane.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15776
2023-10-01 22:46:34 +01:00
a82a007301
Allow user to affect width of field names column.
...
Without this there's no way to re-adjust the column width when new
items are added. Doing more auto-sizing would be another option,
but at some point we have to stop trying to be smarter than the
user. (And the resize algo already has bugs on Mac causing us to
make the column too short for "${ITEM_NUMBER}" for some reason.)
2023-10-01 20:47:47 +01:00
c5471bbe9f
Gracefully handle unknown schematic formats
...
Fixes KICAD-400
2023-10-01 10:32:33 -04:00
bfbba632df
Guard GetModificationTime with IsValid otherwise it'll return based on INT64_MIN.
...
Fixes KICAD-3Z0
2023-10-01 09:43:09 -04:00
dca964092f
EasyEDA Std: import schematic images.
2023-10-01 16:21:31 +03:00
979274af7c
EasyEDA Std Schematic: import net ports as global labels.
2023-10-01 16:21:28 +03:00
0fc3f20e4d
Fix assert from IsPower in search_handlers.cpp
...
Fixes KICAD-2C6
2023-10-01 09:20:19 -04:00
7005dd7c48
altium: make special string parsing on pcb a bit more generic
...
Only special strings starting with a dot are supported. Parsing of concatenated special strings using quotes needs to be implemented, but at least a few test-cases are already there now.
2023-10-01 15:10:50 +02:00
34769cec63
Filter line-endings from single-line Scintilla editors.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15793
2023-10-01 14:04:45 +01:00
3b3e4fd34a
Move duplicated code of plugin.cpp and sch_plugin.cpp into a new plugin_utils located in commons
2023-10-01 13:58:38 +02:00
a475b01a90
Remove ic parameter from voltage-controlled sources.
...
It was never supported by ngspice (or LTspice or pspice).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15787
2023-10-01 12:16:25 +01:00
b227f9de61
Eeschema: fix a crash when loading a schematic if a symbol in a sheet has
...
a lib_name containing {slash} instead of /
(related to commits #2f51d22b and b2bf28f5Fixes #15791
https://gitlab.com/kicad/code/kicad/-/issues/15791
2023-10-01 09:56:22 +02:00
bbfe01d4c6
Write out datasheet & descr in fields as well as top-level elements.
2023-10-01 00:36:39 +01:00
2f2c8b9414
Fix printf assert
...
Fixes KICAD-41B
2023-09-30 15:38:23 -04:00
423a5b9961
Fix format string specifier.
2023-09-30 17:38:44 +01:00
b2bf28f559
Eeschema: fix a crash when loading a schematic if a symbol in a sheet has
...
a lib_id containing {slash} instead of /
(related to commit #2f51d22b)
Fixes #15791
https://gitlab.com/kicad/code/kicad/-/issues/15791
2023-09-30 18:21:18 +02:00
7bc2d69ab7
Fix a typo and a Coverity warning
2023-09-30 18:17:09 +02:00
e1c51ed192
A few performance improvements from profiling.
...
Most of them are very small; the removal of the Fracture() in
DRC_TEST_PROVIDER_COPPER_CLEARANCE::testZonesToZones() is the only
significant one.
2023-09-29 21:54:59 +01:00
fa11e9138d
ADDED support for pin and fp filtering in FOOTPRINT_CHOOSER.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7176
2023-09-29 17:03:50 +01:00
b592a6634e
Cleanup.
2023-09-29 00:13:13 +01:00
974da4ea7c
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER.
...
Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame
wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-29 00:13:12 +01:00
23033451b1
Cleanup.
2023-09-29 00:13:12 +01:00
49a8c9eb8d
Schematic: pin helpers, add wiring tool
2023-09-28 15:07:11 -04:00
2f51d22b3a
Fix schematic editor crash when updating symbols.
...
Some how symbol names that still have escaped '/' character get mixed with
symbol names that have '/' characters now that it is no longer an invalid
LIB_ID character. This was causing derived symbols to loose the link to
the parent symbol. This fix replaces any instances of "{slash}" with "/"
to convert symbol names to the proper escaping.
Thanks to JP for the inspiration for the fix.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15715
2023-09-28 14:30:15 -04:00
5f88c132c9
Schematic: add pin helpers menu (quickly breakout pins)
2023-09-28 11:44:52 -04:00
be9e4c79ee
CLI: Sanitize filename when exporting symbol as svg
...
When using symbol names as filenames, invalid characters and
characters that might be mis-interpreted (e.g. '/') have to be
removed from the name to prevent unexpected behavior.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15751
2023-09-28 13:02:47 +00:00
Seth Hillbrand
Jeff Young
Mike Williams
afkiwers
Jon Evans
Alex Shvartzkop
Wayne Stambaugh
Marek Roszko
jean-pierre charras
Franck Jullien
Thomas Pointhuber
Matthias Breithaupt