6dfd417767
Make IBIS errors visible / more obvious.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18041
2024-05-19 01:44:16 +03:00
882ff06e24
More PEGTL tomfoolery.
...
(cherry picked from commit 8aaca0509c
2024-05-17 11:25:26 +01:00
f52a51dce3
Reimplement bracedExpr and token lists for CPL models only.
...
This prevents the incompatibility between token lists
and single-token param-value pairs.
(cherry picked from commit 086e609c3d
2024-05-17 11:25:22 +01:00
a96e16b766
Tighter control over braced-expression list separators.
...
(cherry picked from commit 2921d47fb3
2024-05-17 11:25:19 +01:00
81e51b00ca
Remove support for multiple token values for CPL models.
...
It breaks param lists which contain single-token params
(ie: those without the "=<value>" part).
(cherry picked from commit 8bb807f170
2024-05-17 11:25:15 +01:00
eeb9133588
Support multiple brace-expressions for CPL model lines.
...
(Nested brace-expressions, on the other hand, are *not*
an ngspice thing.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17824
(cherry picked from commit 0008991f02
2024-05-17 11:24:21 +01:00
d45769e508
Allow .ends to be preceeded by whitespace.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16560
(cherry picked from commit b934914c59
2024-05-17 11:21:47 +01:00
341f102d79
Fix PEGTL flagParam grammar.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16393
(cherry picked from commit c5162f5483
2024-05-17 11:20:26 +01:00
79443b7e59
Update signals & measurements when netlist might have changed.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17616
(cherry picked from commit 55b2c4dbf4
2024-05-15 11:22:08 +01:00
9c7fb0697c
Don't double up ac and ph params.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17970
2024-05-09 23:36:32 +01:00
c92b11900b
Don't add duplicate SIM fields.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17970
2024-05-09 23:36:32 +01:00
eb7e781bec
Send project path to ngspice for code model input files.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16527
2024-05-08 23:39:34 +03:00
cff58bae7f
Fix internal simulation errors when using some IBIS models.
...
Usage of GC_PWR0 looked like a copy/paste.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17701
2024-04-29 23:24:46 +03:00
2609882346
Update m_LastLegendPosition after setting dirty bit.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17411
(cherry picked from commit 7341d4bf37
2024-03-14 18:07:07 +00:00
091b34c05f
Don't show normal cut/copy/paste items in Signals grid.
...
(Do allow a copy of signal names though.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17395
(cherry picked from commit ed61c5593f
2024-03-14 18:05:47 +00:00
03af8dcc88
Convert OP text variables pin names/numbers to SPICE vectors.
...
Also fixes a wrap-around bug in SPICE_VALUE::Normalize() where
it would lose the run of itself if the value was already
normalized to either the largest or smallest UNIT_PREFIX.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17228
(cherry picked from commit ff8ddae9bd
2024-03-14 18:03:42 +00:00
41f9baf9dc
Cleanup.
2024-02-29 17:38:18 +00:00
2f8f7c11f1
Handle single-source DC analyses correctly.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17119
2024-02-26 18:10:10 +00:00
87944e06ac
Fix missing unit initialization.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17076
2024-02-24 22:35:05 +00:00
14d71c8ca6
Fix collecting of signals for S-Parameters analysis
...
(cherry picked from commit 006f93773c
2024-02-23 20:35:36 +00:00
e68df8e1d1
Performance optimizations for database libraries.
2024-02-23 17:22:20 +00:00
c8495d81bb
Update VDMOS models to ngspice-41 (and later) defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17073
2024-02-23 16:06:55 +00:00
12c8f5b14d
Update compatibility mode and save flags in ngspice.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16955
2024-02-13 14:50:15 +00:00
ca6b40ef1c
Make sure to create power axis when restoring state
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16912
2024-02-08 17:48:12 -05:00
b4c361f5cc
Order matters in PEGTL grammar.
...
(Because a flagParam will also match "param", but not the
other way around.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16900
2024-02-08 14:54:54 +00:00
ff3288dab6
Add quotes around paths when KIBIS generates waveforms via ngspice
...
Fixes #16655
2024-02-01 17:20:16 +00:00
a2b204572d
Don't assert when a sim returns no results.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16749
2024-01-25 15:40:12 +00:00
70bca8bc4e
Provide popups for inductor references.
...
Also fixes a long-standing bug deleting the last field of
a symbol in the Symbol Editor.
2024-01-25 15:30:25 +00:00
340d1b7fad
Guard against nullptr access.
2024-01-25 15:30:25 +00:00
a263b6d343
Mutual inductance statements have no model.
2024-01-23 15:14:09 +00:00
1bd8da41a7
Mutual Inductor isn't an inductor.
...
It's a statement about two other inductors.
2024-01-23 15:07:29 +00:00
4b1fc9c129
Update AM and SFFM source parameters to ngspice-43.
...
Note: there's no migration strategy because they didn't
work at all prior to ngspice-43.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16529
2024-01-10 20:27:52 +00:00
e7746d3bc8
Fix spelling mistakes
2024-01-10 16:17:07 +00:00
84d161a4b7
Don't use referential values as defaults.
2024-01-06 22:01:23 +00:00
7c5eaed69e
Un-comment and repair TRRANDOM sources.
...
Also adds new parameters to AM sources for ngspice-43.
Also fixes a bug in the spice parameter parser (which would
puke on any parameter name starting with one of the flag
parameter strings).
Also fixes a bug where the skipped source parameters would
get set to "0" instead of their default values.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16393
2024-01-06 20:34:36 +00:00
bbdefa05eb
Un-comment and repair AM and SFFM sources.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16529
2024-01-06 14:49:05 +00:00
e438fc2569
Remove dead code. (Coverity)
...
Also fixes a (small) memory leak.
2024-01-04 15:57:30 +00:00
cdb99de862
Use HasSymbol() instead of a null logger.
2023-12-28 21:52:26 +00:00
e59612d56c
Add realloc locking calls for ngspice42.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15941
2023-12-28 19:36:18 +00:00
9a890cdba9
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-27 21:10:01 -05:00
47e07f507e
nullptr safety
...
(Can't actually happen as the 4 base fields are mandatory,
but it'll keep Coverity happy.)
2023-12-18 17:01:55 +00:00
fd91f8933e
Fix a SPICE simulator crash on run of a second OP command.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16341
2023-12-18 09:43:40 -05:00
343828c552
Fix invalid string compare in IBIS parser
...
strcmp returns 0 if strings are the same but compareIbisWord returns
True (1).
Adds an IBIS simulation QA test case to catch this in the future
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16223
(cherry picked from commit ef8b6bf9e1
2023-11-30 09:16:38 -08:00
08e6e0258f
IBIS: add stub for Model Spec; support empty strings in line with keywords.
2023-11-29 00:24:34 +03:00
196e05bc51
Borrow parts of simulator's separator-detection algorithm.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15248
2023-11-20 13:47:24 +00:00
32806a3b8b
Make sure plot tab gets its SpicePlotName updated.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16013
2023-11-04 15:45:08 +00:00
1c746f0134
Correctly parse fft commands with linearize in them.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16011
2023-11-04 15:45:08 +00:00
6b29c346b9
When presented with empty text we don't want to Normalize() the SIM_VALUE.
...
But we *do* need to update NUMERICAL_EVALUATOR::m_originalText by
calling NUMERICAL_EVALUATOR::Process().
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15871
2023-10-27 16:59:28 +01:00
1290cf6241
Fix missing random sim command
...
(cherry picked from commit 3ce4a5bf7f
2023-10-26 09:47:43 -07:00
71fb1afe4c
Add ngspice lib paths for when running from build dir.
2023-10-22 19:58:17 +03:00
Alex Shvartzkop
Jeff Young
Andrej Krpic
Jon Evans
ecorm
Ian McInerney
Marek Roszko
Wayne Stambaugh
Seth Hillbrand