Seth Hillbrand
5324b65fb0
eeschema: Don't trust the pointer
...
We are not guaranteed a selection. Keep pointers to the front items
guarded. This can happen after repeating a new item, e.g.
2019-07-17 18:21:36 -07:00
Seth Hillbrand
b877d17138
Fix compile error
...
wx 3.0 doesn't have emplace_back() so we need to accept the
copy-instantiate penalty
2019-07-17 14:32:22 -07:00
Jeff Young
3de00eef5f
Cleanup.
2019-07-17 21:45:43 +01:00
Jeff Young
d67c2d13c7
Fix re-entrancy problem in cross-probing.
...
Fixes: lp:1836940
* https://bugs.launchpad.net/kicad/+bug/1836940
Fixes: lp:1836937
* https://bugs.launchpad.net/kicad/+bug/1836937
2019-07-17 21:35:28 +01:00
Jeff Young
7c1049d86b
Fix event-loop issue with some pickers.
...
RunAction returns immediately even when called with "run now" flag.
Fixes: lp:1836905
* https://bugs.launchpad.net/kicad/+bug/1836905
2019-07-17 21:35:28 +01:00
jean-pierre charras
1402087562
Kicad manager: cosmetic fix: use small (26x26) icons in tool menu and big (48x48) icons in main frame.
2019-07-17 19:59:42 +02:00
jean-pierre charras
c84c10fa06
PAGED_DIALOG: fix an issue related to TransferDataFromWindow and TransferDataToWindow, on wxWidgets 3.0
...
On wxWidgets 3.1 they are called recursively but not on on wxWidgets 3.0.
We call now TransferDataToWindow and TransferDataFromWindow only once,
but ensure it is called for all pages.
Fixes: lp:1836901
https://bugs.launchpad.net/kicad/+bug/1836901
2019-07-17 16:47:48 +02:00
Simon Richter
e5463b5455
Define compiler flags for MSVC
...
Defines:
- inhibit generation of #pragma comment(lib, ...) from boost
- inhibit warnings about "unsafe" containers
- inhibit warnings about "unsafe" C functions
- inhibit warnings about "deprecated" POSIX functions
- suppress min/max macros from windows.h
Flags:
- source and execution charsets are UTF-8
- suppress warnings about throw() not being fully supported in the compiler
- suppress warnings about values being explicitly cast to bool
- enable string pooling
- enable unreferenced code removal
- enable COMDAT folding
- generate PDB debug information
2019-07-17 08:10:47 -04:00
Simon Richter
05353049b5
Pull in macro definition for strncasecmp on MSVC
2019-07-17 08:10:47 -04:00
Tomasz Wlostowski
6cab769f41
MSVC support for libcontext
...
This uses the Windows native Fiber API.
2019-07-17 08:10:47 -04:00
Simon Richter
884ae5a7ff
Work around missing min/max in Windows headers
...
Windows headers assume min/max to be macros, but we set NOMINMAX to hide
the macro definitions. This pulls in an alternative implementation.
2019-07-17 08:10:47 -04:00
Simon Richter
bed70339b8
Remove own copy of FindOpenSSL.cmake
2019-07-17 08:10:47 -04:00
Simon Richter
cf4393091a
Set _USE_MATH_DEFINES on Windows
...
All compilers need this in standards-compliant mode.
2019-07-17 08:10:47 -04:00
Tomasz Wlostowski
8b492c3c45
Export LIB_TREE_ITEM
2019-07-17 08:10:47 -04:00
Tomasz Wlostowski
5bb06e5ac5
pcbnew: can't return a copy of ptr_vector if items are polymorphic and have no clone() methods. Work it around.
2019-07-17 08:10:47 -04:00
Jeff Young
6cd7d9fb89
Go back to inconsistent cross-probing for now.
...
Selecting in Eeschema has major issues, as does highlighting in
pcbnew. So for now we do highlighting in eeschema and selecting
in pcbnew. Improving highlighting for pcbnew would be the next
logical step....
Fixes: lp:1836640
* https://bugs.launchpad.net/kicad/+bug/1836640
2019-07-17 12:45:34 +01:00
jean-pierre charras
164d40f235
Zone filled, non copper zones: fix missing inflate for non stroked solid areas.
2019-07-17 13:24:21 +02:00
Jeff Young
243a8b6843
Fix open in browser on Mac, and use correct terminology.
...
(Mac uses "Reveal in Finder").
Fixes: lp:1836837
* https://bugs.launchpad.net/kicad/+bug/1836837
2019-07-17 11:57:41 +01:00
Jeff Young
b9749d361b
Turn of pad mask layers if Eagle file specifies stop="no"
...
Fixes: lp:1835930
* https://bugs.launchpad.net/kicad/+bug/1835930
2019-07-17 01:03:34 +01:00
Jeff Young
920f128cc7
Change line-end encoding of multi-line textbox.
...
Fixes: lp:1836757
* https://bugs.launchpad.net/kicad/+bug/1836757
2019-07-16 20:45:44 +01:00
Jeff Young
ba7ad7ddf4
Fix bug with PCBNEW_PICKER_TOOL not doing a push/pop.
...
PICKER_TOOL got updated but PCBNEW_PICKER_TOOL didn't.
2019-07-16 20:25:25 +01:00
Jeff Young
8d79661996
Convert symbol/module cross-probing to a selection model.
...
Net/net cross-probing stays a highlight model.
Fixes: lp:1836600
* https://bugs.launchpad.net/kicad/+bug/1836600
2019-07-16 20:25:25 +01:00
Seth Hillbrand
ae0bdb96e5
Resetting polygon inflate/deflate defaults
...
These are used in too many places throughout pcbnew to change all
polygons. If we need different rounding, we'll want to implement them
on a per-call basis.
2019-07-16 11:46:18 -07:00
Seth Hillbrand
f2db7ecbe4
Partial revert of 1a7cef2950
...
The referenced commit broke the unit tests, creating invalid
connectivity for polygon fills.
2019-07-16 11:08:29 -07:00
jean-pierre charras
6388189f48
Preferences, Hotkey list: Avoid list to be shown twice.
...
The bug was due to the fact TransferDataToWindow was called twice, and the hotkey list was not cleared before rebuild it
2019-07-16 18:30:14 +02:00
Seth Hillbrand
5ff7c61003
eagle: Fix segfault importing flipped footprints
...
We don't have a board reference when importing, so we don't get settings
for flip orientation.
2019-07-16 09:08:58 -07:00
Jeff Young
2c5876ee8c
Add more control over how corners are handled when inflating polygons.
2019-07-16 16:41:21 +01:00
Jeff Young
a61673a144
Fix compile error for those who have to use the somewhat feeble gcc.
2019-07-16 15:11:50 +01:00
Jeff Young
27aacb26f8
Cleanup.
2019-07-16 02:31:07 +01:00
Jeff Young
ceb6a49f0c
Attempt to fix double-selected radio button on GTK.
...
Fixes: lp:1836538
* https://bugs.launchpad.net/kicad/+bug/1836538
2019-07-16 02:23:38 +01:00
Jeff Young
787b16db98
Draw invisible pins in grey in pin preview.
...
Also pins the zoom at 100% as we don't seem to be very good at
calculating the bounding box for short pins.
Fixes: lp:1836658
* https://bugs.launchpad.net/kicad/+bug/1836658
2019-07-16 02:05:22 +01:00
Jeff Young
7d10b29592
Cleanup unused includes.
2019-07-16 01:15:33 +01:00
Jeff Young
3069fd5974
Exit point editor after an <esc> while dragging.
...
Fixes: lp:1836652
* https://bugs.launchpad.net/kicad/+bug/1836652
2019-07-16 01:09:49 +01:00
Jeff Young
e816a0c29d
Push Eeschema & PLEditor PICKER_TOOLs down into common.
...
Also implements a more robust push/pop tool strategy for pickers.
2019-07-16 00:44:01 +01:00
Jeff Young
16f672a9bd
Fix signed/unsigned mismatch.
...
Fixes: lp:1836626
* https://bugs.launchpad.net/kicad/+bug/1836626
2019-07-15 20:01:28 +01:00
Jeff Young
58ca5b71a9
A more robust fix for 36f1d023f0
.
...
This one also handles when the events get out-of-order due to them
starting out in the Simulation window and not getting dispatched until
the mouse goes over the Schematic window.
Fixes: lp:1835907
* https://bugs.launchpad.net/kicad/+bug/1835907
Fixes: lp:1836544
* https://bugs.launchpad.net/kicad/+bug/1836544
2019-07-15 14:15:24 +01:00
jean-pierre charras
dad8c9821b
Fix a minor compil warning.
2019-07-15 10:33:03 +02:00
Jeff Young
6da11de5e0
Be more careful about thermal reliefs for pads on different layers.
...
Fixes: lp:1605049
* https://bugs.launchpad.net/kicad/+bug/1605049
2019-07-14 23:15:39 +01:00
Jeff Young
f30cd67411
Use standard save-changes dialog.
...
(It also has the buttons in the right order for Mac.)
2019-07-14 21:40:21 +01:00
Jeff Young
d767e83dac
Fix arc drawing so that it works in all 4 quadrants.
...
Fixes: lp:1836116
* https://bugs.launchpad.net/kicad/+bug/1836116
2019-07-14 18:18:48 +01:00
Jeff Young
a3c74051c2
Allow edits to self-intersecting polygons.
...
1) Intermediate states might be self-intersecting, and we shouldn't
be policing our users on what order to do things in
2) The polygon might already be self-intersecting, at which point we're
preventing the user from fixing it.
Also includes better const management for SHAPE_POLY_SET API.
Fixes: lp:1833831
* https://bugs.launchpad.net/kicad/+bug/1833831
2019-07-14 18:18:48 +01:00
Jeff Young
fe188489c7
A better hack for the post-ProgressReporter-loss-of-focus issue.
2019-07-14 18:18:48 +01:00
Jeff Young
5091f08f71
Better smoothing for inflating/deflating polygons.
...
When the miter limit is exceeded uses round instead of square
corners.
2019-07-14 18:18:48 +01:00
Jeff Young
928d6c5dff
Implement preserved-corners to prevent divots when filling adjacent zones.
...
Fixes: lp:1460787
* https://bugs.launchpad.net/kicad/+bug/1460787
2019-07-14 18:18:48 +01:00
jean-pierre charras
9259f3a7c9
LIB_LOGGER: fix a crash when closing Kicad, if Libedit was run.
...
wxLog::SetActiveTarget() was initialised to libedit frame,
but the active target was not released after closing and deleting libedit, thus creating a crash on Kicad exit.
2019-07-14 18:46:58 +02:00
Jeff Young
1a7cef2950
Improve performance, commenting and API of some polygon classes.
2019-07-14 10:39:38 +01:00
Jeff Young
560fda70a2
Update position before first mouse-move-event.
...
Fixes: lp:1780426
* https://bugs.launchpad.net/kicad/+bug/1780426
2019-07-14 10:39:38 +01:00
Jeff Young
1dbaa89f95
Fix a bug in tool activation/deactivation and another illegal static_cast.
...
Fixes: lp:1836419
* https://bugs.launchpad.net/kicad/+bug/1836419
2019-07-14 10:39:38 +01:00
Jeff Young
37af3adffb
Add preference for flip axis.
...
Fixes: lp:1836267
* https://bugs.launchpad.net/kicad/+bug/1836267
2019-07-14 10:36:48 +01:00
Jeff Young
a3855cb4f2
Allow thermal spokes to be same width as minimum width.
...
Also some changes for readability and clarity, both in the code
and in the Feature Constraints panel.
Fixes: lp:1835674
* https://bugs.launchpad.net/kicad/+bug/1835674
2019-07-14 10:36:48 +01:00