haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,594 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

1784 Commits

Author SHA1 Message Date
Jeff Young 577bb73320 Revert 7d06651a10. 2019-01-28 20:10:13 +00:00
Seth Hillbrand 9d99fd188f Revert "Change top selection drop-down to combobox" 
This reverts commit 7d06651a10.
 2019-01-28 10:15:32 -08:00
jean-pierre charras e850a482d1 Gerber output: fix a potential minor issue in a G04 line comment. 
In gbr files only ASCII7 chars are allowed.
However, in a comment line a UTF8 string is used. It should not create issues, but it is incorrect.
 2019-01-27 10:14:16 +01:00
jean-pierre charras b8cfabd22e Fix some issues in I10n strings 
Fix typo and missing I10n identifier for 2 strings
 2019-01-26 09:25:12 +01:00
Wayne Stambaugh b13efdb0f2 Initial global footprint library table fixes. 
Fix bug when pcbnew is launched from a folder containing an existing
fp-lib-table file by using same method as setting the initial global
symbol library table.

Fixes lp:1810169

https://bugs.launchpad.net/kicad/+bug/1810169

Fixes lp:1738871

https://bugs.launchpad.net/kicad/+bug/1738871
 2019-01-20 13:51:07 -05:00
jean-pierre charras 9cac0a38cc DIALOG_GRAPHIC_ITEM_PROPERTIES: better tooltip. 
minor other code enhancement (does not create any actual change)
 2019-01-19 12:35:35 +01:00
Tomasz Włostowski 9657039af2 pcbnew: multiple fixes concerning track->pad net propagation used by Track/Via properties dialog: 
- Added ignore netcode option to CONNECTIVITY_DATA::GetConnectedItems()
- PlaceModule() now ensures the module added to the board (and thus to the connectivity database) has correct bounding box necessary for R-trees to work
- Use recursive connected pad search so that the new net is propagated to all pads

Fixes: lp:1787961
* https://bugs.launchpad.net/kicad/+bug/1787961
 2019-01-18 02:53:29 +01:00
Seth Hillbrand 9458ae8221 pcbnew: Prevent GITHUB plugin from being registered 
If the user does not build the GITHUB plugin (deprecated), we cannot use
it in our footprint load and should remove the define to ensure
accidental use is caught at compile time.
 2019-01-15 12:14:02 -08:00
Seth Hillbrand 90ad240660 units: Move common units and add tests 
Centralizing duplicate code from Eeschema and pcbnew and adding unit
tests
 2019-01-08 09:29:32 -08:00
Seth Hillbrand 1e5ba6f1b1 Replace DIM() macro 
The standard DIM() macro was not typesafe as it happily deferred errors
to runtime that can be caught at compile time.  Replacing it with a
generic C++11 constexpr allows for typecasting, comparison and compile
time error checking.
 2019-01-06 08:43:12 -08:00
jean-pierre charras db7dba96ad Fix a few Coverity warnings. 
Mainly not initialized members, and replace not tested dynamic_cast by static_cast.
 2019-01-04 09:49:21 +01:00
Seth Hillbrand 7d06651a10 Change top selection drop-down to combobox 
wxChoice centers the selection on GTK.  So when switching from a
mid-list item to an item at the top, the list is always cut off for
choice lists located on the top toolbar.  Using a combobox provides a
drop-down that allows easier access to all elements in the box.

Fixes: lp:1808569
* https://bugs.launchpad.net/kicad/+bug/1808569
 2019-01-03 14:48:28 -08:00
Seth Hillbrand efbc50b7b8 prevent NULL dereference in dialog_text_properties 2019-01-02 19:40:29 -08:00
Seth Hillbrand b39061855e pcbnew: Translate scripting test window 2019-01-02 14:49:55 -08:00
Jeff Young dffa399eab Set mirrored when creating footprint texts on back layer. 2018-12-31 21:50:09 +00:00
Jeff Young 061d993448 Warn the user when global track/via edits fail. 2018-12-31 21:50:09 +00:00
Jeff Young 4d9b4428fa It's never a good idea to dereference a freed pointer. 
Fixes: lp:1809897
* https://bugs.launchpad.net/kicad/+bug/1809897
 2018-12-27 13:33:19 +00:00
Jeff Young 0c0dda54bf Close any active editor before rebuilding netclass lists. 
Fixes: lp:1809555
* https://bugs.launchpad.net/kicad/+bug/1809555
 2018-12-24 01:55:02 +00:00
jean-pierre charras 5f3cbff977 Pcbnew, DIALOG_SET_GRID_BASE: A few cosmetic enhancements and fix a wxWidgets minor alert 2018-12-21 10:15:15 +01:00
Jeff Young 95dcc30ffb Load footprint browser with last-selected footprint. 2018-12-16 21:59:42 +00:00
Jeff Young f0c0f04348 Fix ReadNetList and UpdatePCB issues with new footprints. 
Make sure the view is rebuilt before selecting the new footprints
so that they're shown only in the selection overlay.

Don't start the drag until the dialog is closed so we don't have
a bunch of extraneous mouse warping.

Fixes: lp:1775265
* https://bugs.launchpad.net/kicad/+bug/1775265
 2018-12-10 19:48:58 +00:00
jean-pierre charras 7f20c55ed6 Pcbnew, Plot dialog, Gerber format: Enable or disable adding net metadata both in X1 and X2 format. Previously, this option was existing only in X2 format. Should be existing in both formats. 
A bit of cleaning code related to this option.
 2018-12-09 08:38:23 +01:00
Jeff Young 6a7ee5b107 Add locale handling for orientation combobox. 
Fixes: lp:1806851
* https://bugs.launchpad.net/kicad/+bug/1806851
 2018-12-05 18:08:50 +00:00
Jeff Young 4f5771f79f Don't nag user about changes they made in a text editor. 
Fixes: lp:1806748
* https://bugs.launchpad.net/kicad/+bug/1806748
 2018-12-04 23:32:55 +00:00
Jeff Young da40def69d Standardize on "local coordinates" terminology. 2018-12-04 23:32:55 +00:00
Seth Hillbrand 26765161c1 drc: Add board outline and edge crossing 
This adds a check for contiguous board outlines to the DRC.  It also
uses the calculated outline to ensure that traces are not crossing the
outlines.

Fixes: lp:1648055
* https://bugs.launchpad.net/kicad/+bug/1648055
 2018-12-02 07:54:52 -08:00
jean-pierre charras 5eb5b5ce58 DIALOG_TEXT_PROPERTIES: hide visibility option, because this option exists only for footprint texts, and do nothing for other texts. 
Texts on board (not on footprints) cannot be invisible, at least in 5.0 and previous versions.
 2018-12-02 10:30:48 +01:00
Jeff Young 45ee95f5e2 Apply CharHook uniformly as other platforms appear to have issues. 
Fixes: lp:1806124
* https://bugs.launchpad.net/kicad/+bug/1806124
 2018-12-01 11:57:16 +00:00
Jeff Young ff6a3482ec Remove on-kill-focus-validation. 
Fixes: lp:1805361
* https://bugs.launchpad.net/kicad/+bug/1805361
 2018-11-29 19:00:21 +00:00
jean-pierre charras 558c38b5c5 Very minor enhancement in plot dialog. 
Inside the layers listbox, the context menu can select all fabrication layers.
The courtyard layers (only used for DRC) are now not selected.
 2018-11-24 17:48:05 +01:00
Jeff Young 2e1920abad Add tooltips to library manager dialogs. 
Fixes: lp:1804930
* https://bugs.launchpad.net/kicad/+bug/1804930
 2018-11-24 15:06:21 +00:00
Jeff Young b2db49f4ac Add browse buttons to Library Manager dialogs. 
Fixes: lp:1804924
* https://bugs.launchpad.net/kicad/+bug/1804924
 2018-11-24 15:06:21 +00:00
Jeff Young 647fa6547d Update grid drop-down when changing user grid. 2018-11-23 23:33:02 +00:00
jean-pierre charras 149c4b55a6 DIALOG_TRACK_VIA_PROPERTIES_BASE: fix a minor wxWidgets alert. 2018-11-23 15:46:54 +01:00
jean-pierre charras d03e82602e PANEL_COMMON_SETTINGS: minor fixes, mainly cosmetic. 2018-11-22 17:11:49 +01:00
Jeff Young 5a74b55074 Reset delayedFocusPage even if it's already the right page. 
Fixes: lp:1804315
* https://bugs.launchpad.net/kicad/+bug/1804315
 2018-11-21 19:51:04 +00:00
jean-pierre charras 65a967dca1 Fix minor I10n issues. 2018-11-18 14:40:36 +01:00
Jeff Young 0de9cb345c Add shortcuts to setting dialogs for track widths, via sizes and grid sizes. 
Fixes: lp:1803671
* https://bugs.launchpad.net/kicad/+bug/1803671
 2018-11-17 00:35:06 +00:00
Jeff Young 3c6adbdf03 Indent layer properties for better comprehension. 2018-11-17 00:35:06 +00:00
jean-pierre charras b35b1bb644 Fix a few minor I18n issues. 
Especially remove trailing and leading spaces in sentences, always annoying in translations, and never useful in sources.
 2018-11-16 18:12:01 +01:00
Jeff Young 4050991d28 Move ERC marker focusing to GAL architecture. 
Fixes: lp:1802537
* https://bugs.launchpad.net/kicad/+bug/1802537
 2018-11-16 10:38:44 +00:00
jean-pierre charras 8c8ccf83e6 Fix a few I18n minor issues. 2018-11-16 09:43:40 +01:00
jean-pierre charras 1f3d5cee0e Fix a few minor I18n issues. 2018-11-15 09:34:29 +01:00
Jeff Young 86273e86b9 Added user and grid origins to Position Relative dialog. 
Also fixed a refresh bug when doing Position Relative.

Fixes: lp:1792699
* https://bugs.launchpad.net/kicad/+bug/1792699
 2018-11-12 23:09:45 +00:00
Jeff Young fdff010199 Fix copy/paste errors in delayedFocusRow stuff. 
Fixes: lp:1802907
* https://bugs.launchpad.net/kicad/+bug/1802907
 2018-11-12 17:08:45 +00:00
Jeff Young 6789103961 Save internal values rather than textbox content. 
Fixes: lp:1802442
* https://bugs.launchpad.net/kicad/+bug/1802442
 2018-11-11 20:26:19 +00:00
Jeff Young 295013e4a9 Clarify fp reference filter and add fp id filter. 
Fixes: lp:
* https://bugs.launchpad.net/kicad/+bug/
 2018-11-11 20:26:19 +00:00
jean-pierre charras acfa13c038 Fix typo 2018-11-09 15:46:09 +01:00
Jeff Young 5c726744b6 Move Zone Properties dialog to Connect() strategy. 
If checkboxes don't have individual IDs FormBuilder won't assign
them and the event table ends up connecting each checkbox to all
of the checkbox handlers in the dialog.

Fixes: lp:1801746
* https://bugs.launchpad.net/kicad/+bug/1801746
 2018-11-08 21:27:15 +00:00
jean-pierre charras 93d3e4ccf8 dialog_footprint_wizard_list_base.cpp: fix a minor wxWidgets alert. 2018-11-04 15:50:29 +01:00
Maciej Suminski afda69c9cc Removed default line width setting from the printing dialog 2018-10-31 19:17:30 +01:00
Maciej Suminski 3d15092643 Fixed loading layer visibility setting for printouts 2018-10-31 19:17:30 +01:00
Maciej Suminski 90b6156448 Store line width setting for printouts 2018-10-31 19:17:30 +01:00
Maciej Suminski d3ea63e133 Removed a redundant parameter from BOARD_PRINTOUT constructor 2018-10-31 19:17:30 +01:00
Maciej Suminski dea778842b Grand printing dialogs refactor 
Patch introduces a generic printing settings window that is customized by pcbnew and gerbview.
 2018-10-31 19:17:30 +01:00
Maciej Suminski e81c3a59a2 Refactored and unified board editor and footprint editor print dialogs 2018-10-31 19:17:30 +01:00
Maciej Suminski 698a380827 Clear selection before printing 
Selected objects are hidden in VIEW, that makes them disappear from
printouts.
 2018-10-31 19:17:30 +01:00
Maciej Suminski 5b94f20e6f Adapted printout controllers to the new printing routines 2018-10-31 19:17:30 +01:00
jean-pierre charras c05ca469ae Pcbnew, DIALOG_PLOT_BASE: Fix a minor wxWidgets alert. 2018-10-29 17:34:14 +01:00
jean-pierre charras eabae68ab8 PANEL_SETUP_LAYERS_BASE: cosmetic enhancements. 2018-10-29 15:21:03 +01:00
jean-pierre charras 633bc7f2d5 Pcbnew, DIALOG_TEXT_PROPERTIES_BASE: fix many minor wxASSERTs 2018-10-26 13:09:05 +02:00
Jeff Young adfe2fc267 Make sure user isn't surprised by Match All setting. 
If they selected the dialog with a footprint selected, they're
probably not expecting Match All.
 2018-10-23 20:54:42 +01:00
Thomas Pointhuber 22e5e52598 Fix warning: 'HAVE_CLOCK_GETTIME' macro redefined 2018-10-19 09:59:06 +02:00
Jeff Young ff992f4a64 Keep track of which nets are currently in use. 
Fixes: lp:1798006
* https://bugs.launchpad.net/kicad/+bug/1798006
 2018-10-18 12:14:23 +01:00
Jeff Young e9a80a5d7f Some minor dialog layout fixups. 2018-10-17 11:23:02 +01:00
jean-pierre charras 9795a3572d dialog_pns_length_tuning_settings: fix incorrect dialog size. 
This was due to the fact sizers recalculate the sizes before initialization of a bitmap.
 2018-10-17 11:48:15 +02:00
Jeff Young 6e3f226e45 Update texts with %V and %R when values or references is chosen. 
(This in addition to updating them when other fields is chosen.)
 2018-10-16 17:46:01 +01:00
Jeff Young 51deb9d562 Fix issue with updating Footprint graphic items. 
dyn_cast doesn't handle inheritance.
 2018-10-16 17:07:59 +01:00
Jeff Young 3dcd52021a Simplify exchange footprints dialog and support wildcards. 2018-10-15 19:59:47 +01:00
Jeff Young 0585382986 Allow editing of library footprint from board reference. 2018-10-15 19:59:47 +01:00
Jeff Young 0bd0558833 Auto-select reference numbers in PcbNew like we do in Eeschema. 2018-10-14 00:06:41 +01:00
Seth Hillbrand 4460313104 pcbnew: Separating connectivity to subdir 2018-10-12 16:31:09 -07:00
Jeff Young 609d497870 Remember settings in Global Track & Via Properties dialog. 2018-10-10 19:49:06 +01:00
Jeff Young c5499a6b19 Use ChangeValue() so design rules popup doesn't get cleared. 
Fixes: lp:1796780
* https://bugs.launchpad.net/kicad/+bug/1796780
 2018-10-09 21:33:43 +01:00
Jeff Young 42ee4f79e4 Fix assert in Graphic Item Properties. 
Fixes: lp:1792201
* https://bugs.launchpad.net/kicad/+bug/1792201
 2018-10-09 11:08:56 +01:00
Tomasz Wlostowski e439b17fa1 eeschema-gal: make sure all other Kicad apps compile after eeschema gal hacks 2018-10-09 11:08:52 +01:00
Maciej Suminski d599a02a90 Fix unused variable warnings 2018-10-09 09:14:51 +02:00
Jeff Young 9e828e0d94 Don't default Use Netclass Values to on. 
Fixes: lp:1795939
* https://bugs.launchpad.net/kicad/+bug/1795939
 2018-10-05 15:11:18 +01:00
Jeff Young 895e187ca0 Add a bit more space for those using larger fonts. 2018-10-05 14:17:58 +01:00
Jeff Young b49ca04355 Remove max length on layer names. 
Fixes: lp:1745587
* https://bugs.launchpad.net/kicad/+bug/1745587
 2018-09-29 22:07:31 +01:00
Jeff Young 19b1ae35ce Don't assume GetFlags() != 0 means it's being edited. 
It could just mean it's selected, highlighted or brightened.

Fixes: lp:1794624
* https://bugs.launchpad.net/kicad/+bug/1794624
 2018-09-27 22:18:13 +01:00
Jeff Young fac5fcb476 Don't draw the pad preview highlighted. 2018-09-27 17:46:51 +01:00
Jeff Young 50b96b406f More net selector fixes. 2018-09-27 16:58:12 +01:00
jean-pierre charras 1685af8425 dialog_track_via_properties_base.cpp: fix a few wxWidgets alerts. 2018-09-27 13:36:50 +02:00
Wayne Stambaugh b487a8c70e Pcbnew: fix track and via properties dialog control alignment issues. 2018-09-26 09:15:58 -04:00
Baranovskiy Konstantin f68581d463 Pcbnew: fix column width in Nets dialog. 
Nets dialog (Inspect->List Nets) contains list control
that has very small width for first and last columns.
Changed algorithm for calculating optimal values for
column width.
 2018-09-26 04:26:09 -07:00
Jeff Young dfd028a66a Don't gray out non-enabled layers in layers setup panel. 
Fixes: lp:1794215
* https://bugs.launchpad.net/kicad/+bug/1794215
 2018-09-25 20:47:03 +01:00
Baranovskiy Konstantin 682cb3abe1 Pcbnew: make "Swap Layers" title translatable. 2018-09-25 12:18:50 -07:00
Wayne Stambaugh 282e37b2bf Pcbnew: change step export dialog action button text. 
Change "OK" to "Export" so user is not surprised by the fact that the
dialog does not close after the step file is created..

Fixes lp:1784260

https://bugs.launchpad.net/kicad/+bug/1784260
 2018-09-24 14:57:02 -04:00
Jeff Young efefbf0fa0 Fix typo for updating library trees. 
Fixes: lp:1794087
* https://bugs.launchpad.net/kicad/+bug/1794087
 2018-09-24 15:46:45 +01:00
Jeff Young f3c6e1fb62 Change Position Relative To to use anchor, not centroid. 
Fixes: lp:1793984
* https://bugs.launchpad.net/kicad/+bug/1793984
 2018-09-24 00:42:56 +01:00
Seth Hillbrand 525e26eb82 kicad2step: Provide floats separated 
Clang++ seems to be in left-field here as it processes a stringstream
1.0X1.0 >> double as a hexadecimal floating point ('X' character) and
throws an error rather than converting 1.0 and stopping when it reaches
a non-numeric character.  This causes errors when exporting step on Mac,
which uses clang++ by default.

Adding spaces to the string is more explicit and doesn't break gcc.  It
will be sufficient until we get rid of kicad2step as an external
utility.

Fixes: lp:1778564
* https://bugs.launchpad.net/kicad/+bug/1778564

(cherry picked from commit e7a9643b37)
 2018-09-22 08:52:46 -07:00
Jeff Young a1bcc4ba1e Don't start dragging until Update PCB dialog has been closed. 
Fixes: lp:1793828
* https://bugs.launchpad.net/kicad/+bug/1793828
 2018-09-22 16:23:13 +01:00
Jeff Young 666da3849b Make esc dismiss net and layer selector popups. 2018-09-22 16:23:13 +01:00
Jeff Young 3e45483798 Separate edge.cuts and courtyards in ModEdit default values. 
Fixes: lp:1788876
* https://bugs.launchpad.net/kicad/+bug/1788876
 2018-09-20 23:30:13 +01:00
Jeff Young 04534c83e0 Allow marker selection in high-contrast mode. 
Fixes: lp:1793357
* https://bugs.launchpad.net/kicad/+bug/1793357
 2018-09-20 21:54:47 +01:00
Jeff Young 2f2cfe423e A bit of added safety regarding edit vs. display flags. 2018-09-19 22:23:18 +01:00
Wayne Stambaugh ed94f2c5e0 Pcbnew: fix minor bug in find dialog. 
Repeating find with the same search string would result in a not found
error for absolute search strings.  Don't clear the found item if the
search string did not change from the previous search..

Fix another minor bug where the do not warp mouse pointer option was
always checked when the find dialog was called from one of the gal
canvases.

Fixes lp:1793300

https://bugs.launchpad.net/kicad/+bug/1793300
 2018-09-19 12:31:17 -04:00
Seth Hillbrand adb89afe6c Allow SELECTED for single edits 
We like to allow items that are marked SELECTED to remain so during
editing but this does not indicate that there are multiple edits queued,
so do not prevent pushing this into the undo queue.
 2018-09-18 03:52:15 -07:00
Seth Hillbrand 9cafe65e84 pcbnew: Allow user-setting rounded rectangle radius 
When designing pads, it can be helpful to not only see the resulting
rounded rectangle radius from a given percentage but also to set it,
constraining the related percentage.  This adjusts the dialog to allow
editing the rounded rectangle corner radius.  It does not change the
file format as the resulting ratio is saved.  Further updates of the pad
size or ratio will modify the radius.

Fixes: lp:1668020
* https://bugs.launchpad.net/kicad/+bug/1668020
 2018-09-17 15:59:53 -07:00
Jeff Young cd7ebaf9ee Generate duplicate footprint errors when reading netlist. 
Fixes: lp:1682970
* https://bugs.launchpad.net/kicad/+bug/1682970
 2018-09-17 18:01:08 +01:00
Jeff Young 2b634004ee Track widths and via sizes are in mils. 
Fixes: lp:1792748
* https://bugs.launchpad.net/kicad/+bug/1792748
 2018-09-15 22:46:04 +01:00
Jeff Young e5e1a315f1 Keep name & value in sync for library items. 
Also fixes library reference highlighting from board footprints.

Fixes: lp:1792243
* https://bugs.launchpad.net/kicad/+bug/1792243

Fixes: lp:1792256
* https://bugs.launchpad.net/kicad/+bug/1792256
 2018-09-13 16:41:23 +01:00
Jeff Young a46133d64b Replace SetValue() with ChangeValue() to prevent unwanted events. 
Fixes: lp:1792070
* https://bugs.launchpad.net/kicad/+bug/1792070
 2018-09-12 19:34:55 +01:00
Jeff Young 806b1fc63d Fix bugs to enable read-only grid cells to be copied. 
Fixes: lp:1791129
* https://bugs.launchpad.net/kicad/+bug/1791129
 2018-09-12 14:01:36 +01:00
Jeff Young cbb3492d98 Standardize Footprint Viewer and Footprint Browser. 
Add Display Settings to Footprint Browser.
Make each of them OpenGL on OSX and Cairo on other platforms.
Allow auto-zoom to be turned off and save last zoom setting.
Make ordering of tools in htoolbar consistent.
Standardize grid and zoom drop-downs.

Fixes: lp:1791667
* https://bugs.launchpad.net/kicad/+bug/1791667
 2018-09-12 14:01:35 +01:00
jean-pierre charras bfb0fac015 Minor fixes related to I18n 2018-09-05 13:59:20 +02:00
Maciej Suminski de65ca512f Fixed reference to PCB_EDIT_FRAME in PANEL_SETUP_LAYERS 
GetParent() in PANEL_SETUP_LAYERS::TransferDataFromWindow() returns a
wxTreebook pointer, instead of expected PCB_EDIT_FRAME resulting in a
crash.
 2018-09-04 12:29:36 +02:00
Maciej Suminski dd3d10d9ce Removed stale files related to FreeRoute support 
Fixes: lp:1787718
* https://bugs.launchpad.net/kicad/+bug/1787718
 2018-09-04 11:54:42 +02:00
jean-pierre charras 0d09128f6c Dialog copper zones: add test for thermal spoke width > zone min thickness. 
Fixes: lp:1789929
https://bugs.launchpad.net/kicad/+bug/1789929
 2018-09-03 13:57:11 +02:00
Thomas Pointhuber 2b59c976f2 Add Insert/Delete button to Tracks and Via setup panel 
GRID_TRICKS cannot handle row label events at the moment, so I disabled them.

Fixes: lp:1788877
* https://bugs.launchpad.net/kicad/+bug/1788877
 2018-09-01 17:53:49 +01:00
Jeff Young 72cf340119 Validate differential pair dimensions. 
Fixes: lp:1789293
* https://bugs.launchpad.net/kicad/+bug/1789293
 2018-09-01 14:05:16 +01:00
Jeff Young 4174ecf4c3 Only validate via size vs drill if both are specified. 
Fixes: lp:1789349
* https://bugs.launchpad.net/kicad/+bug/1789349
 2018-09-01 14:05:16 +01:00
Jeff Young c90a3efea2 Change KIDIALOG hashing algorithm to __FILE__ + __LINE__. 
Using Title + Message wasn't working for all the dialogs which
did substitutions in the message (which was a lot of them).

Fixes: lp:1789348
* https://bugs.launchpad.net/kicad/+bug/1789348
 2018-08-29 23:38:23 +01:00
Jeff Young 9125d7fdb6 Fix typo. 2018-08-29 22:45:45 +01:00
Jeff Young b562ecc5b5 Check for net changing before confirming. 
Fixes: lp:1789348
* https://bugs.launchpad.net/kicad/+bug/1789348
 2018-08-29 22:43:05 +01:00
Jeff Young 658e387ad4 Slightly better swap layer column names. 
Fixes: lp:1789390
* https://bugs.launchpad.net/kicad/+bug/1789390
 2018-08-29 22:04:07 +01:00
Jeff Young f1ef18edcb Fix assert where wxFormBuilder rows disagreed with controls. 2018-08-29 20:08:01 +01:00
Jeff Young f611333ea1 Make fast grid switching hotkeys more visible. 
Fixes: lp:1787066
* https://bugs.launchpad.net/kicad/+bug/1787066
 2018-08-29 20:08:01 +01:00
Jeff Young a8bb5d7308 Improve labels. 
First two radio buttons together read "Do not show On pads", which is
of course backwards for the second.
 2018-08-29 20:08:01 +01:00
Jeff Young 424905fb61 Fix netclass popups in netclass membership grid. 2018-08-29 20:08:01 +01:00
Jeff Young 21eea1f567 Remove HasFocus() checks (which don't work on all platforms) in favour of row highlighting which is visible without focus. 
Fixes: lp:1788873
* https://bugs.launchpad.net/kicad/+bug/1788873
 2018-08-29 20:08:01 +01:00
Jeff Young 75a4928134 Split edge.cuts and courtyard layer defaults. 
Fixes: lp:1788876
* https://bugs.launchpad.net/kicad/+bug/1788876
 2018-08-29 20:08:01 +01:00
Jeff Young 45bc1b1aff Add single-click editing to grid cells. (Experimental.) 2018-08-29 19:59:02 +01:00
Jeff Young b90a261d5c More safety fixes for uncommitted grid changes. 2018-08-29 19:59:01 +01:00
jean-pierre charras 020d837de6 Dialog pad properties: fix not working orientation choice in countries using comma as floating point separator. 
The values in choice are 0.0 90.0 not compatible with floating point notation (0,0 90,0)
and always detected as bad values (unless you have loaded a up to date dictionary, which is not necessary the case)

good values are in any case 0 90 180 and -90
 2018-08-29 17:27:50 +02:00
Wayne Stambaugh 089f27f485 Remove more dialog control borders. 2018-08-27 15:11:27 -04:00
Jeff Young 56de78c130 Remove layer limitations and warnigns now that DRC handles them. 2018-08-27 18:38:56 +01:00
Wayne Stambaugh 35a31a9787 Fix grid border on board setup net class panel. 
Fixes lp: 1789190

https://bugs.launchpad.net/kicad/+bug/1789190
 2018-08-27 12:33:50 -04:00
Thomas Pointhuber a2bc4260ef Modify style of the action plugin panel to follow common style 
and fix of an assert:
* m_grid->DeleteRows does not like to get a numRows of zero
 2018-08-27 08:26:31 -07:00
qu1ck 72f87861bb pcbnew: Add toolbar buttons for action plugins 
Allows optional toolbar buttons for action plugins.
 2018-08-26 19:39:27 -07:00
Jeff Young d10bfb13d6 Re-enable text layers now that DRC & zone fills are fixed. 
Fixes: lp:1788268
* https://bugs.launchpad.net/kicad/+bug/1788268
 2018-08-24 10:56:13 +01:00
Jeff Young 8aa0886ce7 Improve labels & layout of Track & Via Properties dialog. 2018-08-24 10:56:13 +01:00
Jeff Young ec9d38e21f Add filter to net selector widget. 
Also fixes a bug where nets wouldn't get changed because the
pads weren't changed and so the pad nets would propagate and
wipe out the changed nets on the tracks.

Also includes warning dialogs that pad nets will be changed if the
track nets are.

Fixes: lp:1779854
* https://bugs.launchpad.net/kicad/+bug/1779854
 2018-08-24 10:56:13 +01:00
Seth Hillbrand 51473d9a30 pcbnew: Update tooltip in DRC window to reflect actions 
Previous tooltips were outdated.  Current action is to center with
single-click, hightlight with right-click and close window with
double-click.

Fixes: lp:1788635
* https://bugs.launchpad.net/kicad/+bug/1788635
 2018-08-23 08:24:52 -07:00
Jeff Young da172a1089 Fix layout issue with too-short textctrl. 
Fixes: lp:1788506
* https://bugs.launchpad.net/kicad/+bug/1788506
 2018-08-23 00:58:05 +01:00
Jeff Young 30bb911154 Bring PICKER_TOOL in line with other tools. 
Use standard Magnetize() to handle grid and magnetic pads.

Use the standard menu from PCB_TOOL.  Delegating the menu to
the SELECTION_TOOL just caused grief.

Also brings clients (such as Position Relative To) into line,
and implements better Cancel behaviour.

Also improves visibility of modal status messages:
- moves Select Anchor message from status bar to popup
- moves Select Reference message from dialog to popup

Fixes: lp:1786727
* https://bugs.launchpad.net/kicad/+bug/1786727
 2018-08-23 00:58:01 +01:00
Andrew Zonenberg 60a55d75fa Split prohibited text layers for footprints and the rest of the PCB 
Fixes: lp:1788268
* https://bugs.launchpad.net/kicad/+bug/1788268
 2018-08-21 16:34:53 -07:00
Jeff Young d8782b7515 Improve Update PCB from Schematic. 
Shorten and improve informational content of messages, errors and
warnings.

Remove redundant info messages when they shadow an action, warning
or error message.

Improve title of "Update Footprints" to make it clear that it's
recreating footprints which have different assignments rather than
updating footprints from the library.

Don't perform the dryRun twice.

Don't use the old netlist method of loading footprints.  We get
better error reporting if we do it ourselves.

Be more careful checking the last pad when checking for single-pad
nets.  If the last pad has no net then pad != previouspad at the
end of the loop.

Fixes: lp:1787255
* https://bugs.launchpad.net/kicad/+bug/1787255
 2018-08-21 19:46:29 +01:00
Jeff Young c851d6d64b Fix some more MSW spacing issues. 2018-08-21 10:34:41 +01:00
Jeff Young 779398891d Follow HIG guidelines for destructive button separation. 2018-08-21 10:34:41 +01:00
Jeff Young 65f62f93ef Fix MSW spacing issues. 2018-08-21 10:34:41 +01:00
Jeff Young afacb6e7cb Improve safety around un-committed grid changes. 2018-08-21 10:34:41 +01:00
Jeff Young bd543f12b5 Bring track design rule widths in line with via design rule sizes. 2018-08-19 16:15:14 +01:00
Jeff Young b4bb36f017 Define minHeight so 3D model grid doesn't grow to include all rows. 
Fixes: lp:1787269
* https://bugs.launchpad.net/kicad/+bug/1787269
 2018-08-19 16:10:41 +01:00
Jeff Young 4364384f06 Simplify list of nets dialog. 2018-08-19 16:10:41 +01:00
Jeff Young 672d5ec1aa Make orientation popups match combobox values. 2018-08-19 16:10:41 +01:00
Jeff Young bbb76a0de0 Initialize filters with current values. 
Fixes: lp:1787403
* https://bugs.launchpad.net/kicad/+bug/1787403
 2018-08-19 16:10:41 +01:00
Jeff Young bb5e6bbd79 Include default netclass in Global Edit Track & Via Properties. 
Fixes: lp:1787403
* https://bugs.launchpad.net/kicad/+bug/1787403
 2018-08-19 16:10:41 +01:00
Jeff Young 3c455949fc Revert some dialog changes that lost button sizes. 
These are required on MSW.  Also back-dates the .fbp file to work
on Mac wxFormBuilder.
 2018-08-14 13:54:04 +01:00
Jeff Young d788c9d479 Move library table dialogs from PLAYER to KIFACE interface. 
Spooling up a full PLAYER in the background takes too long.

This also fixes bugs around how the tables are saved, although
that was just missing code rather than anything architectural.

Fixes: lp:1785436
* https://bugs.launchpad.net/kicad/+bug/1785436
 2018-08-06 21:31:53 +01:00
Jeff Young 0fbe702043 Layout adjustments to Choose Symbol and Choose Footprint. 2018-08-06 13:48:17 +01:00
Jeff Young 97c4d42ebf Improve Read Netlist tooltip for footprint assignment. 
Fixes: lp:1785200
* https://bugs.launchpad.net/kicad/+bug/1785200
 2018-08-06 13:48:17 +01:00
Jeff Young 1b71c723bc Fix pad properties Y dimension enabling. 
Fixes: lp:1785241
* https://bugs.launchpad.net/kicad/+bug/1785241
 2018-08-04 10:29:17 +01:00
Wayne Stambaugh 8e7d6063fd Minor dialog and frame window improvements. 
Drop all uses of wxRAISED_BORDER and wxSUNKEN_BORDER from dialogs and
panels used in main frame windows.

Drop use of wxSP_3DSASH options on all wxSplitterWindow definitions.

Minor dialog alignment and spacing fixes.
 2018-08-02 13:00:41 -04:00
jean-pierre charras ce3760438c Fix a few wxWidgets minor asserts. Fix also a missing bitmap button initialization. 
Fixes: lp:1783703
https://bugs.launchpad.net/kicad/+bug/1783703
 2018-08-02 13:22:11 +02:00
Jeff Young d8d4f75fa1 Fix button order and genralize Exit dialog so it can be shared more. 
This also fixes a bunch of bugs where an error during save would
still close the window (rather than cancelling the close action).

Fixes: lp:1785034
* https://bugs.launchpad.net/kicad/+bug/1785034
 2018-08-02 11:01:03 +01:00
Jeff Young 0a35c5c97e Convert Footprint Editor to component tree. 
Fixes: lp:1784178
* https://bugs.launchpad.net/kicad/+bug/1784178

Fixes: lp:1780363
* https://bugs.launchpad.net/kicad/+bug/1780363
 2018-08-01 09:35:46 +01:00
Jeff Young b400565880 Convert Place Footprint to component tree. 2018-08-01 09:35:45 +01:00
jean-pierre charras 5a2e171f9e fix a few wxWidgets asserts. 2018-07-31 13:16:58 +02:00
jean-pierre charras 882565f2e1 Fix a few wxWidgets minor asserts 2018-07-29 10:39:05 +02:00
Jeff Young 3c2c5c38ad Make icon buttons slightly wider for MSW. 
Fixes: lp:1783703
* https://bugs.launchpad.net/kicad/+bug/1783703
 2018-07-27 14:58:19 +01:00
jean-pierre charras b70dd1ecc4 Fix compil warnings 2018-07-27 11:18:24 +02:00
Jeff Young 0cca1c6721 Remove active library concept from footprint editor. 
Also bring the menu system and toolbar in line with Pcbnew,
eeschema, and the symbol library editor, which includes moving
to a standard Save As paradigm for renaming/moving items.

Fixes: lp:1748474
* https://bugs.launchpad.net/kicad/+bug/1748474

Fixes: lp:1778202
* https://bugs.launchpad.net/kicad/+bug/1778202
 2018-07-26 21:34:25 +01:00
Jeff Young cb61525394 Handle separate parsing rules for ID_SCH and ID_PCB. 
This removes the existing constructors so that all parsing must
be explicit and callers are made aware that they need to think
about illegal characters, malformed ids, etc.

Fixes: lp:1783474
* https://bugs.launchpad.net/kicad/+bug/1783474
 2018-07-26 15:43:53 +01:00
John Beard 1e11df650c Typos and inconsistencies in FP and Pad dialogs 
* A few typos like stray new lines
* Per cent -> percent
* Consistent use of full stops
* Consistent use of commas after "If 0"

Fixes: lp:1783446
https://bugs.launchpad.net/kicad/+bug/1783446
 2018-07-26 16:40:08 +02:00
Maciej Suminski dbf4bcdbb7 Converted PNS Length Tuning dialog to use TransferData{From,To}Window() 
Fixes: lp:1783694
* https://bugs.launchpad.net/kicad/+bug/1783694
 2018-07-26 10:08:44 +02:00
jean-pierre charras f13a546c9b Fix a few wxWidgets asserts or alerts. 2018-07-25 20:26:55 +02:00
Jeff Young 994a9c5ff8 Only show all layers when the stackup changes. 
Fixes: lp:1783231
* https://bugs.launchpad.net/kicad/+bug/1783231
 2018-07-24 18:43:44 +01:00
Jeff Young 2d4ba56ac0 Promote aperture pads to first-class citizens. 
Well, almost anyway.  We can't use a pad attribute for them as
that would change the file format.  So they're currently
defined as a CONN pad with no copper layers.

However, when figuring out of existing pads should be *treated*
as aperture pads, we just check for no copper layers.

Fixes: lp:1781760
* https://bugs.launchpad.net/kicad/+bug/1781760
 2018-07-24 14:57:45 +01:00
Jeff Young 4d3aeb3339 Make sure cur_lib_table is initialized. 
The panel doesn't get Show() events so do it in the constructor.
 2018-07-23 23:50:13 +01:00
Jeff Young 185b524a62 Support both add-empty and add-browse for 3D models. 
Also fixes a bug where the selected row and the grid cursor get
separated after a delete.

Fixes: lp:1782747
* https://bugs.launchpad.net/kicad/+bug/1782747
 2018-07-23 01:09:47 +01:00
Jeff Young 0c042aff7b Use mils for track widths when inches is selected. 2018-07-22 22:36:24 +01:00
jean-pierre charras 4cac974420 Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. 
Fix some issues related to S_CURVE shape support.
 2018-07-22 18:39:48 +02:00
jean-pierre charras 5ee1caf0b9 dialog DIALOG_NONCOPPER_ZONES_PROPERTIES: resize widgets when resizing the dialog frame. 2018-07-22 18:37:28 +02:00
jean-pierre charras 8026d2aa41 Fix incorrect behavior of the wxChoice used in dialog zone properties. 
For some reason the wxChoice did not close after a selection (at least on Windows).
Perhaps due to some window ID collision.
 2018-07-22 15:47:45 +02:00
Jeff Young d32fb68fa9 Remove debugging and add grouping box for Nets & Net Filters. 
Fixes: lp:1782766
* https://bugs.launchpad.net/kicad/+bug/1782766

(cherry picked from commit a75f376)
 2018-07-22 11:19:21 +01:00
Jeff Young 7cce283fea Fix diff pair custom values. 
Fixes: lp:1782971
* https://bugs.launchpad.net/kicad/+bug/1782971

(cherry picked from commit 53f35a3)
 2018-07-22 11:19:17 +01:00
Jeff Young 7dfc4e30e4 Add some debugging statements to find out what's up with GTK. 2018-07-21 23:17:46 +01:00
Jeff Young 833e0b3c0f One more attempt to get the layers list width right on GTK. 
Fixes: lp:1782766
* https://bugs.launchpad.net/kicad/+bug/1782766
 2018-07-21 14:44:01 +01:00
Jeff Young 86d98ee7fd Check via X and Y for indeterminate value before setting. 
Fixes: lp:1782889
* https://bugs.launchpad.net/kicad/+bug/1782889
 2018-07-21 14:05:03 +01:00
Jeff Young 5c646119a7 Allow user-specification of dimension units. 
Also fixes a units bug when round-tripping a dimension through
the file format.

Fixes: lp:1782797
* https://bugs.launchpad.net/kicad/+bug/1782797
 2018-07-21 13:50:21 +01:00
Jeff Young 2c833f2c91 Fix layout issues in Copper Zones dialog. 
(The list width issue probably also affects other zone dialogs.)

Fixes: lp:1782766
* https://bugs.launchpad.net/kicad/+bug/1782766
 2018-07-20 22:21:51 +01:00
Jeff Young ea3ef1eb87 Don't lose model filepath when writing spin boxes back. 
Also renames a bunch of stuff to be clearer.

Fixes: lp:1782753
* https://bugs.launchpad.net/kicad/+bug/1782753
 2018-07-20 21:59:12 +01:00
Jeff Young 87f72c3d97 Initialize layer comboboxes before trying to set them. 
Fixes: lp:1782794
* https://bugs.launchpad.net/kicad/+bug/1782794
 2018-07-20 20:29:15 +01:00
Jeff Young c1df78d531 Finish project frame library table editing. 
Fixes: lp:1782761
* https://bugs.launchpad.net/kicad/+bug/1782761
 2018-07-20 18:48:06 +01:00
Jeff Young bd90341e91 Add Footprint & Datasheet buttons to Edit Symbol dialog. 2018-07-20 18:48:06 +01:00
Maciej Suminski fecadeca23 Initialize variables in DIALOG_TEXT_PROPERTIES 
Fixes: lp:1782547
* https://bugs.launchpad.net/kicad/+bug/1782547
 2018-07-20 10:33:44 +02:00
Jeff Young 3c1dc9e5c6 Must also set local coords when moving footprint texts. 
Fixes: lp:1782542
* https://bugs.launchpad.net/kicad/+bug/1782542
 2018-07-19 23:26:24 +01:00
Jeff Young ba0c823673 Fix flicking issues on non-double-buffered platforms. 2018-07-19 21:46:41 +01:00
Jeff Young eaf5b913b6 Add Manage Symbol and Footprint Library tables to project frame. 
Fixes: lp:1780604
* https://bugs.launchpad.net/kicad/+bug/1780604
 2018-07-19 21:46:41 +01:00
Jeff Young 5621f4221a A few more spacing & font-size updates for Windows. 2018-07-19 21:46:41 +01:00
Jeff Young 829ba27206 Another round of dialog spacing/font adjustments for Windows. 2018-07-18 17:59:05 +01:00
Jeff Young 879ffa4d1c Adjust dialog spacing for Windows. 2018-07-17 22:18:27 +01:00
Jeff Young e6b55c9ae5 New net membership controls for more efficient operation. 
(cherry picked from commit f7c5a54)
 2018-07-17 15:14:28 +01:00
Jeff Young 977f27f3c4 Adjust spacing on preference panels. 
Giving them the correct parent changed the spacing.

(cherry picked from commit 7f602f3)

(cherry picked from commit 718db46)
 2018-07-17 15:14:25 +01:00
Jeff Young 909f850d16 Give panels the correct parent (the treebook, not the dialog). 
(cherry picked from commit 7338533)

(cherry picked from commit 3ce75be)
 2018-07-17 15:14:19 +01:00
Jeff Young 99db5cb543 Allow for reduced nagging with wider use of KIDIALOG. 
(cherry picked from commit c2dd5df)
 2018-07-17 15:13:53 +01:00
Jeff Young a4c5e2c82f Fix focus issues with dialog previews. 
Use SetStealsFocus() to fix the Pad Properties dialog, and remove
mouse-enter-kill-focus to fix 3D preview in Footprint Properties
dialog.

Fixes: lp:1761321
* https://bugs.launchpad.net/kicad/+bug/1761321

Fixes: lp:1690766
* https://bugs.launchpad.net/kicad/+bug/1690766

(cherry picked from commit e0c1fc9)
 2018-07-17 15:13:47 +01:00
Jeff Young deed1d67b3 Make SMD terminology consistent. 
Fixes: lp:1656688
* https://bugs.launchpad.net/kicad/+bug/1656688

(cherry picked from commit 2946163)
 2018-07-17 15:13:45 +01:00
Jeff Young 45e6dfc7af Simplify copy/paste of pad settings. 
Fixes: lp:1743141
* https://bugs.launchpad.net/kicad/+bug/1743141

(cherry picked from commit 13ece03)
 2018-07-17 15:13:39 +01:00
Jeff Young d016238c82 Rewrite Move And Swap Layers dialog. 
Fixes: lp:1670422
* https://bugs.launchpad.net/kicad/+bug/1670422

(cherry picked from commit 356a767)
 2018-07-17 15:13:35 +01:00
Jeff Young df863e44e2 Wire m_showPageLimits control up to GAL canvas. 
Fixes: lp:1499285
* https://bugs.launchpad.net/kicad/+bug/1499285

(cherry picked from commit 4cb7442)
 2018-07-17 15:13:29 +01:00
Jeff Young fb21069c5a Refresh layer selection dialogs. 
Use platform-native widgets to show selection and draw layer
colours over the PCB background colour.

(cherry picked from commit 4f95f7f)
 2018-07-17 15:13:24 +01:00
Jeff Young 49ea6e1670 Fix occurrences of "edition" which should be "editing" 
Fixes: lp:1778168
* https://bugs.launchpad.net/kicad/+bug/1778168

(cherry picked from commit bcb1220)
 2018-07-17 15:12:39 +01:00
Jeff Young d5e88f574f Clean up units infrastructure after g_UserUnit removal. 
Fixes: lp:1538239
* https://bugs.launchpad.net/kicad/+bug/1538239

(cherry picked from commit 96d7178)
 2018-07-17 15:12:36 +01:00
Jeff Young aab97c8385 Consolidate design rules UI. 
Implement new Board Setup paged dialog which includes:
  Layers Setup
  Design Rules
  Solder Mask & Paste
  Text & Drawings

Moves line width and text properties to a layer-class-based
system.  Renames unlocked to upright (which also reverses the
logic).

New Edit Text and Graphic Properties dialog which replaces
Edit Footprint Text and adds layer-class-based editing and the
italic, upright and visibility properties.

Adds Import Settings functionality which allows settings to
be imported from another project at page granularity.

Also UNIT_BINDERizes the dialog and adds editing of pcb text.

Fixes: lp:1731952
* https://bugs.launchpad.net/kicad/+bug/1731952

Fixes: lp:1743464
* https://bugs.launchpad.net/kicad/+bug/1743464

Fixes: lp:1664761
* https://bugs.launchpad.net/kicad/+bug/1664761

Fixes: lp:1753362
* https://bugs.launchpad.net/kicad/+bug/1753362

Fixes: lp:1545427
* https://bugs.launchpad.net/kicad/+bug/1545427

Fixes: lp:1753775
* https://bugs.launchpad.net/kicad/+bug/1753775

Fixes: lp:1777692
* https://bugs.launchpad.net/kicad/+bug/1777692

Fixes: lp:1780670
* https://bugs.launchpad.net/kicad/+bug/1780670

Fixes: lp:1519601
* https://bugs.launchpad.net/kicad/+bug/1519601

(cherry picked from commit 3944a5e)
 2018-07-17 15:12:34 +01:00
Jeff Young 5f3ee1e7ce More g_UserUnit erradication. 
(cherry picked from commit 3f08780)
 2018-07-17 15:12:31 +01:00
Jeff Young 0358aee89e UNIT_BINDERize print and plot dialogs. 
Fixes: lp:1778560
* https://bugs.launchpad.net/kicad/+bug/1778560

Fixes: lp:1392991
* https://bugs.launchpad.net/kicad/+bug/1392991

Fixes: lp:1780362
* https://bugs.launchpad.net/kicad/+bug/1780362

(cherry picked from commit 9df9743)
 2018-07-17 15:12:29 +01:00
Jeff Young ae2cb331b1 Merge PCBnew text edit dialogs. 
(cherry picked from commit 63b7738)
 2018-07-17 15:12:24 +01:00
Jeff Young 40c1c8285d Combine PCBnew and ModEdit Graphic Item Properties dialogs. 
Also UNIT_BINDERizes the result.

(cherry picked from commit edd3b25)
 2018-07-17 15:12:21 +01:00
Jeff Young ef3e045a9b Eradicate g_UserUnit from ERC/DRC. 
(cherry picked from commit 98b8cd4)
 2018-07-17 15:12:16 +01:00
Jeff Young 2ff414adb4 Simplify Move Exactly and Postion Relative dialogs. 
Also removes g_UserUnit references.

Fixes: lp:1660154
* https://bugs.launchpad.net/kicad/+bug/1660154

(cherry picked from commit 1639636)
 2018-07-17 15:12:11 +01:00
Jeff Young cae249bbb8 UNIT_BINDERize and simplify Layers Setup dialog. 
The colours don't add much in the way of comprehension and they
do add visual complexity.  Same for the labels at the top of
the layers list box.

Also improved the grouping to make the presets aciton more clear.

(cherry picked from commit 1a03e13)
 2018-07-17 15:12:02 +01:00
Jeff Young 3e062867de Move all the grid workarounds into our own WX_GRID class. 
(cherry picked from commit 08b4463)
 2018-07-17 15:11:38 +01:00
Jeff Young 92dcf43ae8 UNIT_BINDERize zone dialogs. 
Also includes a bunch of changes to simplifiy the terminology
and unify the copper, non-copper and keepout versions.

Also removes some legacy features:
Removes contol for fill method.  If the fill method is currently
segments the dialog will ask if you want to convert to polygons
on OK.
Removes control of boundary resolution.  We've done this with trig
since 5.0.

(cherry picked from commit 487aaeb)
 2018-07-17 15:11:32 +01:00
Jeff Young 7841f8a466 Unified preferences dialog framework. 
(cherry picked from commit 8ee3e77)
 2018-07-17 15:11:17 +01:00
Jeff Young 2283bcda4c Add text item property options when updating footprints. 
Fixes: lp:1753286
* https://bugs.launchpad.net/kicad/+bug/1753286

(cherry picked from commit b94dd87)
 2018-07-17 15:11:14 +01:00
Jeff Young bbc25cd694 Add hole-to-hole clearance testing to DRC. 
Also move courtyard testing flags to BoardSettings API.  Both are
still stored in the config until we decide where they go in order
to prevent prematurely disturbing the board file format.

Fixes: lp:684067
* https://bugs.launchpad.net/kicad/+bug/684067

(cherry picked from commit 5399f60)
 2018-07-17 15:11:11 +01:00
Jeff Young eacaa39aa2 Remove global units usage from GetSelectionText... 
... and GetMsgPanelInfo.

Step 4 in the g_UserUnit eradication effort.

Also removes a couple of conversion routines that were close
enough to extinction.

(cherry picked from commit c75da51)
 2018-07-17 15:11:09 +01:00
Jeff Young 1569842927 Pad properties usability enhancements. 
Also includes conversion to UNIT_BINDER for pad properties and
pad primitives properties dialogs.

(cherry picked from commit 4a051da)
 2018-07-17 15:11:06 +01:00
Jeff Young 0010ad37d1 In-place editing for footprint TEXTE_MODULEs. 
Fixes: lp:1102168
* https://bugs.launchpad.net/kicad/+bug/1102168

Fixes: lp:1779913
* https://bugs.launchpad.net/kicad/+bug/1779913

(cherry picked from commit 83781ab)
 2018-07-17 15:11:04 +01:00
Jeff Young 8f0aa68ab8 Fold 3D Search Paths dialog into Configure Paths. 
Use in-place editing for both.

Fixes: lp:1743823
* https://bugs.launchpad.net/kicad/+bug/1743823

(cherry picked from commit 33622cd)
 2018-07-17 15:11:01 +01:00
Jeff Young 124c6d9857 Add in-place editing and validation to Design Rules. 
Includes UNIT_BINDER transition and some general layout cleanup.

(cherry picked from commit 282119e)
 2018-07-17 15:10:55 +01:00
Jeff Young 7be85deb32 GRID_TRICKS improvements. 
Allow copy of a single cell demarcated by the grid cursor.

Paste of lib_table s-expressions should always start at 0,0.

Let caller or specialized sub-class do auto-sizing; don’t
do it from within the base GRID_TRICKS.

Don’t start GRID_TRICKS menu IDs at -1; wxWidgets doesn’t
like it when you get to 0.

Add column visibility menu.

(cherry picked from commit e5071ed)
 2018-07-17 15:10:03 +01:00
Jeff Young 0f78f97232 Get rid of 5.0 dialog focus hacks. 
It's time to fix the focus issues.  This adds a new SetInitialFocus()
routine to DIALOG_SHIM which will need to be called from a lot of
dialogs.

(cherry picked from commit 6d9647a)
 2018-07-17 15:09:58 +01:00
Jeff Young a39fb03822 Remove some references to g_UserUnit 
(cherry picked from commit 614d832)
 2018-07-17 15:09:56 +01:00
Jeff Young 74acb76e7f Switch UNIT_BINDER and DIALOG_SHIM to local units. 
The general idea is to support user-units inheritance.  The
UNIT_BINDER allows wrapped controls to inherit units from their
parent dialog, while KEYWAY_HOLDER and DIALOG_SHIM allow child
KEYWAY_HOLDERs or DIALOG_SHIMs to inherit units from their
parent.

The GetUserUnits() method signature has to move to KEYWAY_HOLDER
rather than KEYWAY_PLAYER (where it makes more sense) as it’s the
only common ancestor of KEYWAY_PLAYER and DIALOG_SHIM.

As long as we'll be using the UNIT_BINDER more widely, it also
makes sense to move evaluation and validation into it.

This commit also provides eeschema’s DIALOG_LABEL_EDITOR and
pcbnew’s DIALOG_TRACK_VIA_PROPERTIES and DIALOG_SET_GRID as
models of how to use the new user-units inheritance, eval, and
validation.

Fixes: lp:593795
* https://bugs.launchpad.net/kicad/+bug/593795

(cherry picked from commit c8bc53e)
 2018-07-17 15:09:53 +01:00
Jeff Young 4f8c546140 Implement user units uniformly in EDA_DRAW_FRAME 
Step 1 of the g_UserUnit global eradication.  This commit includes
basic hookup of hotkeys, units tool-buttons and grid dialogs.

(cherry picked from commit e0500ab)
 2018-07-17 15:09:51 +01:00
Jeff Young a1ef5401f4 More platform-standard presentation of DRC dialog. 
Also makes better use of space to significantly increase number
of markers shown.

Fixes: lp:1748676
* https://bugs.launchpad.net/kicad/+bug/1748676

(cherry picked from commit a1d8097)
 2018-07-17 15:09:46 +01:00
Jeff Young 3e190cee4b Implement selection brightening for DRC. 
The old item pointers (which aren't safe to keep around) were
removed in favour of opaque references (void*) which are then
compared against existing items when needed.

Also improves brightening by brightening the whole footprint
(ie: its pads, drawings, reference and value) rather than just
its target cross.

(cherry picked from commit 30e90b0)
 2018-07-17 15:09:40 +01:00
Jeff Young e9d877914d Dialog consistency and beautification. 
Small icons for dialog browse, refresh, and row operations.
Icons in B&W so they don't over-emphasize with respect to other
controls in the dialog.

Layout cleanup for consistency.  Removal of the blank space to
left of the fields list in the Global Fields Editor, and addition
of column-sizing-to-list-width.

More even spacing for buttons in html report panel.

Honor platform conventions for action button order and layout.

Move netlist importer to update-pcb-from-schematic algorithm
(display messages and then update instead of "dry run" checkbox)

(cherry picked from commit b21e19d)
 2018-07-17 15:09:01 +01:00
Carsten Schoenert 9f7109826d fix misspelled 'allows to' -> 'allows one to' 
Fixup small grammar issues around used 'allows to ...' almost in
code comments.
 2018-07-11 10:35:03 -04:00
Jeff Young 246a9286a9 Fix dialogs with wxID_CANCEL as the window ID. 
Fixes: lp:1778990
* https://bugs.launchpad.net/kicad/+bug/1778990

Fixes: lp:1778991
* https://bugs.launchpad.net/kicad/+bug/1778991
 2018-06-28 08:38:12 -06:00
Wayne Stambaugh 7eea8f808d Minor Pcbnew dialog fixes. 
Fix get footprint by name dialog button sizer padding.

Fix export gencad dialog file name, options, and button sizer padding.
 2018-06-27 14:28:18 -04:00
Maciej Suminski 80fa480388 Disable the DRC dialog while the checks are running 
Closing the DRC dialog while zones are refilled leads to a crash.
Disabling the dialog prevents the crash.
 2018-06-27 19:05:06 +02:00
Wayne Stambaugh 8394e2b71e Fix broken LIB_ID library nickname illegal character tests. 
During the symbol library table implementation, the legal character
tests for the footprint library table were changed and the forward
slash '/' character became illegal.  This change broke editing some
users footprint library tables that already had '/' in library table
nicknames.  This change split the library nickname and library item
name illegal character tests.
 2018-06-20 14:36:40 -04:00
Wayne Stambaugh 77217b2089 Fix resizing issues of global track and via properties dialog. 2018-06-20 11:39:11 -04:00
Seth Hillbrand 6990824597 pcbnew: Hide routing options that are not available 
Options that do not have code implementing them are now hidden from the
user so that they are not searching for ways to enable the greyed out
options.  Similarly, when selecting a routing option that disables
free-mode, we show the effect of disabling the mode in the dialog.
 2018-06-19 11:11:18 -07:00
Maciej Suminski f0b3cf8077 STEP export: Stricter contiguity check 
Stricter contiguity check points the user to gaps in the outline.

Fixes: lp:1774351
* https://bugs.launchpad.net/kicad/+bug/1774351
 2018-06-19 10:36:21 +02:00
Wayne Stambaugh 11c248a463 Fix a typo made in commit 52734058. 2018-06-18 14:57:01 -04:00
Wayne Stambaugh 52734058a7 Remove string translation wrappers used in commit 94891b75. 
Translating internal file name and path strings will almost certainly
result in a bug on MacOS.
 2018-06-18 12:14:48 -04:00
Adam Wolf 94891b75f9 Handle STEP export properly on MacOS when launched from standalone pcbnew. 2018-06-17 13:09:33 -04:00
Andrzej Wolski a99eeb44d3 Do not allow setting zero Y size for oval holes 2018-06-17 16:30:14 +02:00
Wayne Stambaugh b82bf7c449 Fix minor layout issue in keepout area properties dialog. 2018-06-14 11:12:34 -04:00
Jeff Young 5098c5796a Prevent another case of "fall behind" dialogs. 2018-06-09 00:51:39 +01:00
Seth Hillbrand abd8927d71 Dimension Edit window passes default action 
Processing enter from within the dimension editor window is only set to
the default action for top-level items.  Within the sizer, enter is
handled by the first registered button (Cancel) unless explicitly set.

Fixes: lp:1774035
* https://bugs.launchpad.net/kicad/+bug/1774035
 2018-06-06 12:31:48 -07:00
Seth Hillbrand 39ac5e0af8 Pcbnew: List nets fix calculation speed 
Similar to 6e5726613, we need to find net node count quickly without
iterating over all items in the board.
 2018-06-04 11:08:54 -07:00
Maciej Suminski 7c49bcd3a6 Clear selection before deleting DRC markers 
Pcbnew crashes when a selected DRC marker is deleted. This a possible
fix to lp:#1773863.
 2018-05-31 09:32:43 +02:00
Jeff Young d90d4ff682 Fix bugs in Export to SVG. 
We were trying to handle aOnlyOneFile at two different levels
which was preventing the Silk layer from going through the
right routine (and preventing board outlines from getting
drawn if selected).

We were also overwriting the references color local variable
before using it, meaning the reference was always rendered in
the value's color.

Fixes: lp:1774171
* https://bugs.launchpad.net/kicad/+bug/1774171
 2018-05-30 20:49:05 +01:00