haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,577 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

3973 Commits

Author SHA1 Message Date
Jeff Young 4a9d538608 Fix typo when warping cursor (coords are world-coords). 
Fixes: lp:1802811
* https://bugs.launchpad.net/kicad/+bug/1802811
 2018-11-12 22:09:31 +00:00
jean-pierre charras 0a71212929 Fix a few minor issues in SYMBOL_PREVIEW_WIDGET. 
Fixes: lp:1802808
https://bugs.launchpad.net/kicad/+bug/1802808
 2018-11-12 20:40:41 +01:00
jean-pierre charras 0d3637c2ee Fix a few minor I18n issues. 
Avoid translation of debug messages.
 2018-11-11 10:46:26 +01:00
jean-pierre charras f7cf40f2f4 Fix a few Coverity warnings. 
Sometimes a dynamic_cast was used without testing the returned value.
Some are replaced by static_cast, when the dynamic_cast was useless.
 2018-11-11 08:28:58 +01:00
Wayne Stambaugh f1f4473d8b Footprint editor: add save view to PNG file. 
Factor out save current canvas view to image file code from symbol editor
code so it can be used anywhere.

Add ability to save to any image format supported by wxBitmapType.  See
https://docs.wxwidgets.org/3.0/gdicmn_8h.html#a90a1eb6d85b5044a99b706fd979f27f5.
Currently only PNG output is implemented.

Please note that there is a minor bug that appears to be due to the
scroll bars which causes unfilled areas on the right and bottom edges
of the image.  This always existed in the save symbol editor view
image but it was not as noticeable because by default the background
color is white.  It is very noticeable in the footprint editor with
a black background.

The usual smattering of coding policy and comment fixes.

Fixes lp:1802127

https://bugs.launchpad.net/kicad/+bug/1802127
 2018-11-09 08:32:36 -05:00
Jeff Young 6860320b1b Init LibEdit with unit & conversion when opening from schematic. 2018-11-08 21:27:15 +00:00
Jeff Young 3de04e184b Convert pasted objects to current unit and DeMorgan variant. 
Fixes: lp:1797183
* https://bugs.launchpad.net/kicad/+bug/1797183
 2018-11-08 21:27:15 +00:00
John Beard 075f428aca Include directories are implied by legacy_gal linkage 
This avoids having to manually specify include/legacy_gal
in and legacy GAL targets, and harominizes with legacy_wx.

This also means .cpp files in common/legacy_gal do not
need to specify the legacy_gal subdirectory, so they
will continue to work as needed when legacy_wx is removed.
 2018-11-08 07:52:36 -05:00
Maciej Suminski 02f81d7419 Handle 'show page limits' in eeschema 2018-11-08 09:57:16 +01:00
Jeff Young cbd13c7127 Show dangling pins when moving items; don't when dragging. 
Fixes: lp:1801962
* https://bugs.launchpad.net/kicad/+bug/1801962

Fixes: lp:1801959
* https://bugs.launchpad.net/kicad/+bug/1801959
 2018-11-07 14:24:16 +00:00
Maciej Suminski d6bc402f14 Fix instantly disappearing pop-up menu in eeschema 
Fixes: lp:1798453
* https://bugs.launchpad.net/kicad/+bug/1798453
 2018-11-06 17:21:13 +01:00
Maciej Suminski 8091573bf7 Fix disappearing schematic components 
SCH_COMPONENTs should be added to VIEW only when symbol links are
resolved. Otherwise a dummy component bounding box will be used when
inserting a component to VIEW R-tree.

Fixes: lp:1801800
* https://bugs.launchpad.net/kicad/+bug/1801800
 2018-11-06 11:25:47 +01:00
Maciej Suminski 293bc52299 Fix off-grid block paste 
Fixes: lp:1801625
* https://bugs.launchpad.net/kicad/+bug/1801625
 2018-11-05 11:59:38 +01:00
Jeff Young fec8ab372e Don't set the viewport when switching screens. 
That's the job of ZoomAutomatique().

Fixes: lp:1799436
* https://bugs.launchpad.net/kicad/+bug/1799436
 2018-11-04 19:17:53 +00:00
Jeff Young 589e1f6a96 MSW and GTK need a separate dialog for opening/saving directories. 
Fixes: lp:1801528
* https://bugs.launchpad.net/kicad/+bug/1801528
 2018-11-04 12:35:01 +00:00
Jeff Young 68b07d1aff Add show/hide search tree to modedit, and fix it in libedit. 
Fixes: lp:1801531
* https://bugs.launchpad.net/kicad/+bug/1801531
 2018-11-04 12:35:01 +00:00
Jeff Young 6e810a00e4 Warp mouse from context menu before dragging. 
Fixes: lp:1798815
* https://bugs.launchpad.net/kicad/+bug/1798815
 2018-11-04 12:35:01 +00:00
Jeff Young 69952a7b9f Improve updating of symbol and footprint trees. 
In particular, update highlighting when changing footprints.
 2018-11-02 19:55:30 +00:00
jean-pierre charras be0935b339 Eeschema: Update zoom/scale limits, due to recent change in GAL. 
Fixes: lp:1797995
https://bugs.launchpad.net/kicad/+bug/1797995
 2018-11-02 14:36:12 +01:00
jean-pierre charras d465af65a7 LIB_FIELD: fix incorrect text thickness for small sized texts. 
Also remove duplicate code.
 2018-11-02 11:36:07 +01:00
jean-pierre charras 5e44686711 Eeschema, symbol editor: re-enable PNG export and fix a minor issue in SVG export (was in B&W mode instead of color). 
Add a comment in plotter.h to avoid other errors when selecting plotting mode B&W or color

Fixes: lp:1801058
https://bugs.launchpad.net/kicad/+bug/1801058
 2018-11-02 09:24:55 +01:00
John Beard bf42247971 Eeschema: fix potential crash when closing Kicad app. 
The crash happens when a wxPaint event is fired after deleting the schematic frame.
It happened only on one Linux install.

Fixes: lp:1800874
* https://bugs.launchpad.net/kicad/+bug/1800874
 2018-11-01 08:27:19 +01:00
Maciej Suminski 6602e17edc Add copyright header to sch_view.h 2018-10-31 19:17:30 +01:00
Maciej Suminski a18be5d37c Adjust GAL world unit for eeschema 2018-10-31 19:17:30 +01:00
Maciej Suminski e81c3a59a2 Refactored and unified board editor and footprint editor print dialogs 2018-10-31 19:17:30 +01:00
Maciej Suminski 17205b4599 Added VIEW::DataReference() for sharing data with another VIEW instance 2018-10-31 19:17:29 +01:00
John Beard a1fad9d3fe Eeschema: allow dragging of text 
Text doesn't have "special" handling of dragging, like connected items (it's
basically just a move).  However, allowing "drag" to work on text makes
handling text consistent when dragging other items.
 2018-10-31 16:19:03 +00:00
jean-pierre charras 7985234556 Eeschema: Fix a subtle bug in SYMBOL_PREVIEW_WIDGET. 
The dialog was using a LIB_ALIAS from library cache to show the symbol to the canvas without making a local copy.
Unfortunately, the library viewer is doing the same thing.

Now the GAL is used in Eeschema, a link to the VIEW used by the GAL canvas is stored in this class.
When The selector symbol dialog is used to choose a symbol to display in the Library viewer,
a race condition between the Library viewer GAL canvas and the dtor dialog that destroyed this link in the same instancied class.

Now, the SYMBOL_PREVIEW_WIDGET used in the dialog works on a local copy of the symbol to display.
 2018-10-31 15:52:35 +01:00
Jeff Young c4cd81a906 Remove side-effect of LIB_FIELD::SetText(). 
Fixes: lp:1800545
* https://bugs.launchpad.net/kicad/+bug/1800545
 2018-10-31 12:57:23 +00:00
Jeff Young 6888268f74 Timestamps are long rather than int. 
Fixes: lp:1800796
* https://bugs.launchpad.net/kicad/+bug/1800796
 2018-10-31 10:19:59 +00:00
jean-pierre charras 7b10490256 Library viewer: fix broken behavior of unit selector (could be Windows specific). 
Remove a useless message in debug mode about LIB_ALIAS bounding box.
 2018-10-30 17:51:12 +01:00
jean-pierre charras 49c94fb928 Eeschema, library viewer: fix a Kicad assert. 2018-10-30 15:58:08 +01:00
Jeff Young 4742c52250 Highlight symbol fields when selected. 2018-10-30 13:09:20 +00:00
Jeff Young 364be90dc5 Fix translation issues with copy/paste block. 
Also fix issues with paste not working at all from the context
menu in LibEdit.

Fixes: lp:1800513
* https://bugs.launchpad.net/kicad/+bug/1800513
 2018-10-30 11:33:49 +00:00
Jeff Young 4030eec939 Implement proper dangling end handling for block moves. 
(Most of this is actually fixing the IsDanglingStateChanged() to
correctly indicate that it *updates* the dangling state, not just
tests it.)
 2018-10-30 11:33:49 +00:00
Maciej Suminski b445b0fab2 Link eeschema with ngspice DLL 
Adds a link-time dependency for libngspice, so that other tools may
detect ngspice as a KiCad dependency.

The library is still loaded with dlopen() as it gives a way to reload it
in case of problems. The DLL name is recognized during CMake
configuration and used to load the library at runtime.
 2018-10-30 08:32:38 +01:00
Jeff Young 4fc1f4db3e LIB_ITEMs won't have parent in LibEdit. 2018-10-28 17:45:11 +00:00
Jeff Young a8c7bb0c92 Move library text items to LAYER_DEVICE. Only sch text items belong on LAYER_NOTES. 
Fixes: lp:1800350
* https://bugs.launchpad.net/kicad/+bug/1800350
 2018-10-28 17:45:11 +00:00
Jeff Young a96ebe8fac Sort reference by their numeric content. 
Fixes: lp:1464805
* https://bugs.launchpad.net/kicad/+bug/1464805
 2018-10-28 17:45:11 +00:00
jean-pierre charras c49917c5a8 Dialog edit component in lib: Fix a few minor wxWidgets alerts. 2018-10-28 18:42:16 +01:00
Stefan Brüns d1db2c7621 Use fixed version for libngspice.so.0 
CanonicalizeName only adds the lib prefix and .so suffix, so loading
libngspice.so fails until the development package is installed.
MAC/Windows code paths lookup soversion 0 of ngspice as well, as this
is the only compatible version.
 2018-10-27 10:20:09 +02:00
Jeff Young 4f11dc54fa Draw selected child items in brightened colors. 
Fixes: lp:1800114
* https://bugs.launchpad.net/kicad/+bug/1800114
 2018-10-26 23:02:05 +01:00
Jeff Young c4ff17d3ec Don't go to '-' numbering till the range reaches 3. 2018-10-26 23:02:05 +01:00
jean-pierre charras d953724365 Eeschema: fix bug: append schematic does not update canvas 
Fixes: lp:1800144
https://bugs.launchpad.net/kicad/+bug/1800144
 2018-10-26 16:42:14 +02:00
jean-pierre charras b075e76ede Eeschema: fix a draw issue when aborting a move symbol field or a sheet pin. 
The initial drawings were not updated, making the moved item invisible on screen.

Fixes: lp:1800142
https://bugs.launchpad.net/kicad/+bug/1800142
 2018-10-26 15:27:20 +02:00
Seth Hillbrand a3bbd32953 Fix minor compile warnings 2018-10-25 17:14:04 -07:00
Wayne Stambaugh ce34a713b4 Eeschema, make BOM tool add file dialog remember last used path. 
Fixes lp:1797679

https://bugs.launchpad.net/kicad/+bug/1797679
 2018-10-25 10:33:19 -04:00
jean-pierre charras 3bf1dd7671 Eeschema, Hierarchical sheet: fix missing pen width call in draw function. 
The hierarchical sheet was drawn (outline and texts) with a line thickness
that in fact the line thickness of the previously drawn item.
 2018-10-25 15:12:34 +02:00
Jeff Young 1baa904034 Dangling symbol fixes. 
No dangling symbol for text items with a NO-CONNECT.
DanglingStateChanged doesn't work with dangling flag aggregators
(which return true if any child is dangling).
Then again, we don't actually use any of the aggregators anyway
so I removed them.

Fixes: lp:1799589
* https://bugs.launchpad.net/kicad/+bug/1799589
 2018-10-24 23:51:18 +01:00
Jeff Young 1f1bdc87bd Update GAL with wire dimensions before changing them. 2018-10-24 23:18:53 +01:00
Jeff Young 66a0f60b4c Refresh preview items when Rotate or Mirror during move. 
It's not enough to just refresh the canvas because the items are
hidden on the main canvas and copies are placed into the preview
group.
 2018-10-24 22:00:50 +01:00
Jeff Young 4524dce9bb Tie up some loose ends from JP's SHEET_PIN fixes. 
Fixes: lp:1799606
* https://bugs.launchpad.net/kicad/+bug/1799606
 2018-10-24 22:00:50 +01:00
Wayne Stambaugh b9a9fe6c9e Eeschema, remove option to import schematic that has not been remapped. 
When importing an existing schematic into a sheet that was no remapped
to use the symbol library table, the user was given the option to ignore
the warning and proceed with the import.  This would end up with all of
the imported symbol links being broke.  In hindsight, this was a bad
idea so now the user cannot import schematics that have been remapped.

Fixes lp:1791280

https://bugs.launchpad.net/kicad/+bug/1791280
 2018-10-24 15:38:02 -04:00
jean-pierre charras dc21a60531 Fix incorrect management of SCH_SHEET_PIN items when adding or removing them. 
Especially new SCH_SHEET_PIN items were added twice, thus creating crashes.

Fixes: lp:1799606
https://bugs.launchpad.net/kicad/+bug/1799606
 2018-10-24 16:19:28 +02:00
Jeff Young 7d02c11880 Handle don't-always-display-cursor setting correctly. 
Fixes: lp:1798448
* https://bugs.launchpad.net/kicad/+bug/1798448
 2018-10-24 13:36:48 +01:00
Jeff Young c694c2e534 No more legacy graphics for eeschema. 2018-10-24 13:36:48 +01:00
Jeff Young 96e65c7f23 Hide existing object when displaying moving preview. 
Fixes: lp:1799478
* https://bugs.launchpad.net/kicad/+bug/1799478
 2018-10-23 20:54:42 +01:00
Jeff Young 0c06bdb1e0 Make sure aliases get their refs and values drawn correctly. 
Fixes: lp:1799460
* https://bugs.launchpad.net/kicad/+bug/1799460
 2018-10-23 20:54:42 +01:00
Jeff Young 9f350820ad Add field umbilical lines to GAL renderer. 2018-10-23 20:54:42 +01:00
Jeff Young 1606329855 AdvanceDepth() strategy has been replaced with layer depths. 
This is just a little bit of clean-up after-the-fact.
 2018-10-23 20:54:42 +01:00
jean-pierre charras ce496ff993 libedit: refresh display after deleting graphic item. 2018-10-23 15:11:32 +02:00
Michael Kavanagh 3248c270ee Update Eeschema BOM dialog html help text 
Now links to relevant section in stable eeschema docs.

Fixes: lp:1798248
https://bugs.launchpad.net/kicad/+bug/1798248
 2018-10-22 13:19:15 -04:00
jean-pierre charras 7bba7a884a Libedit: refresh display after creating/moving a graphic item 2018-10-22 13:41:38 +02:00
Jeff Young f17c18bcce Remove AdvanceDepth() hacks in favour of proper layers. 
Also removes the bounding-box cache since the last big merge
should have sorted out the Update(GEOMETRY) calls.

Fixes: lp:1797271
* https://bugs.launchpad.net/kicad/+bug/1797271

Fixes: lp:1797268
* https://bugs.launchpad.net/kicad/+bug/1797268

Fixes: lp:1797075
* https://bugs.launchpad.net/kicad/+bug/1797075
 2018-10-21 15:55:56 +01:00
jean-pierre charras 8ecdf58bad Eeschema, load a new bitmap image from file: fix crash when aborting. 
Remove duplicate code in edit_bitmap.cpp.
 2018-10-21 10:59:06 +02:00
jean-pierre charras dafeb96765 Page layout bitmap size wrong in modern/GAL canvases. 
The image scale set by pl_editor was not taken in account when drawing the page layout.

Fixes: lp:1798685
https://bugs.launchpad.net/kicad/+bug/1798685
 2018-10-20 18:24:22 +02:00
jean-pierre charras 576a0af293 Eeschema: make draw functions working with "old" libraries using a useless large negative line width (like -1000 or -2000 mils). 
They are now clamped to -1.

This is only a workaround to avoid ugly artifacts
 2018-10-20 13:08:33 +02:00
jean-pierre charras 1116acd74b Libedit: Fix broken handling of "common to all bodu style" property of lib draw items. 
Fix a minor wxWidgets assert.
 2018-10-20 12:38:36 +02:00
Maciej Suminski 9757107b61 Spice netlist exporter: handle multiline directives 
Fixes: lp:1797937
* https://bugs.launchpad.net/kicad/+bug/1797937
 2018-10-19 17:33:01 +02:00
jean-pierre charras 8f9b0f0235 Eeschema, spice netlist exporter: fix an issue that converted spice string commands to lowercase. 
Therefore, it can breaks some commands, especially filenames.

Partial fix of bug 1797937.
 2018-10-19 16:18:30 +02:00
Jeff Young c06e533689 Add hack to Resolve all symbols when painting. 
Seems rather expensive, but this is what the Legacy canvas did.
In fairness, it does check the last-mod-date of the libraries
and skips it if they haven't changed.

Fixes: lp:1798446
* https://bugs.launchpad.net/kicad/+bug/1798446
 2018-10-18 14:14:54 +01:00
Jeff Young baa4019448 Draw pin previews with the correct schematic background color. 
Fixes: lp:1798447
* https://bugs.launchpad.net/kicad/+bug/1798447
 2018-10-18 13:27:41 +01:00
Jeff Young c052b7f8ef Fix segfault when deleting sheet pins. 2018-10-18 13:27:41 +01:00
Jeff Young 8a54b1b3b7 Add view refresh calls for edit operations. 
Note that the bug referenced in the "fixes" section is only one
of many addressed by this commit.

Fixes: lp:1798449
* https://bugs.launchpad.net/kicad/+bug/1798449
 2018-10-18 12:12:48 +01:00
Tomasz Włostowski 12567c7500 eeschema-gal: don't warp cursor back to mouse when using hotkey to emulate a mouse click 
Fixes: lp:1797273
* https://bugs.launchpad.net/kicad/+bug/1797273
 2018-10-17 23:25:36 +02:00
Jeff Young c22a247dbc Fix undo issue primarily with libedit. 
Fixes: lp:1797900
* https://bugs.launchpad.net/kicad/+bug/1797900
 2018-10-17 13:10:36 +01:00
Jeff Young 254e9f4a7e Implement HardRedraw for eeschema and libedit. 2018-10-17 12:14:09 +01:00
Jeff Young e9a80a5d7f Some minor dialog layout fixups. 2018-10-17 11:23:02 +01:00
Jeff Young 924c0fa9ed Fetch symbol chooser grid settings from the right place. 2018-10-17 11:14:01 +01:00
Jeff Young c19984e4de Performance optimization for Symbol Fields Editor. 2018-10-17 02:04:44 +01:00
Jeff Young 08e1379671 Add new sheet pins to view. 2018-10-16 22:54:12 +01:00
Jeff Young 84c14c2971 Fix updating of the schematic symbols after a library save. 2018-10-16 17:07:59 +01:00
Jeff Young 1114b5cfa9 Refresh item when its dangling state changes. 
Fixes: lp:1797996
* https://bugs.launchpad.net/kicad/+bug/1797996
 2018-10-16 17:07:59 +01:00
jean-pierre charras 61f2dd21b1 Eeschema gal: fix some redraw issues for bitmap images and worksheet. 
After edition, the worksheet was not updated on screen.
Bitmap images were not shown in opengl mode due to the fact all gal layers were cached.
 2018-10-16 14:20:09 +02:00
jean-pierre charras 7c960aa5fe Eeschema: better limit for zoom out level 
Fixes: lp:1797995
https://bugs.launchpad.net/kicad/+bug/1797995
 2018-10-16 09:25:00 +02:00
Jeff Young 5fe523f534 Place object borders in front of background fills. 
This is required when rendering from the cache as the hardware
doesn't necessarily draw in the same order.
 2018-10-15 19:59:47 +01:00
jean-pierre charras 906c08afc6 Cross probing: ensure highlighted net in Eeschema is shown when cross probed from Pcbnew. 2018-10-15 20:16:48 +02:00
Tomasz Włostowski d66e0d4f7a eeschema-gal: implemented EnableDepthTest() in GAL, fixed drawing order in eeschema 2018-10-15 00:09:59 +02:00
jean-pierre charras 0777d11188 Eeschema Better fix for highlight visibility issue for cached items due to last change in code in opengl 2018-10-14 14:59:40 +02:00
jean-pierre charras 9a62f508a4 Revert "Eeschema Fix highlight visibility issue for cached items due to last change in code" 
This reverts commit b389236a72, not working in opengl.
 2018-10-14 14:57:45 +02:00
jean-pierre charras b389236a72 Eeschema Fix highlight visibility issue for cached items due to last change in code 2018-10-14 12:47:06 +02:00
jean-pierre charras fff739631c EEschema: fix wrong pin rendering for pin style PINSHAPE_OUTPUT_LOW 
Fixes: lp:1797750
https://bugs.launchpad.net/kicad/+bug/1797750
 2018-10-14 12:36:02 +02:00
Jeff Young 0bd0558833 Auto-select reference numbers in PcbNew like we do in Eeschema. 2018-10-14 00:06:41 +01:00
Jeff Young 275d5e336f Fix issue with component children disappearing when canvas origin not in view. 2018-10-13 20:54:50 +01:00
Jeff Young 29e0e6921b Turn on OpenGL caching. Time to smoke out the bugs. 2018-10-13 15:53:54 +01:00
jean-pierre charras 650478f757 Eeschema, highlight connection: show selected junctions and labels in highlight color 
Previously, only wires were shown in highlight color.
 2018-10-13 16:12:36 +02:00
jean-pierre charras 9df7626e31 Fix issue: Symbol library editor: Moving pins jumps to origin 
Also: remove outdated lines in code.

Fixes: lp:1797266
https://bugs.launchpad.net/kicad/+bug/1797266
 2018-10-13 12:09:49 +02:00
Seth Hillbrand aa622994e1 eeschema: Ensure is_moved flag is set when moving 
Prior to placing, cleaning routines need to know which schematic items
are being moved to avoid cleaning them relative to themselves.  The
IS_MOVED flag communicates this and is cleared by ClearDrawingState()

Fixes: lp:1797576
* https://bugs.launchpad.net/kicad/+bug/1797576
 2018-10-12 17:08:10 -07:00
Tomasz Włostowski e988cd9c25 Fixed crash in footprint chooser in eeschema triggering in standalone/no-pcbnew mode 
Fixes: lp:1797644
* https://bugs.launchpad.net/kicad/+bug/1797644
 2018-10-12 23:43:08 +02:00
Tomasz Włostowski 30f0e93dbb Synchronize the GAL view after invoking 'autoplace fields' tool 
Fixes: lp:1797268
* https://bugs.launchpad.net/kicad/+bug/1797268
 2018-10-12 23:27:39 +02:00