789bf6455a
Coverity fixes and code cleaning.
2023-03-02 09:04:47 -05:00
a6b1a09edf
Fix rounding errors in gerber files
...
The userToDeviceCoordinates helper returns a VECTOR2D
Converting it to VECTOR2I back and forth is a bug and generates rounding errors
Cherry picked from stable branch
2023-02-28 20:27:16 +01:00
a87550a2c6
When importing legacy PCB dimension: Use automatic dimension when Unit couldn't be determined
2023-02-28 11:59:47 +00:00
b03366c9e8
Fix CADSTAR importer memory leaks
...
We were leaking the xml tree when throwing exceptions
2023-02-27 23:57:39 +01:00
8b47c94f6e
PANEL_COLOR_SETTINGS: swap swatches and texts to avoid annoying truncation.
...
In some languages, the texts can be long, and create truncation of the left
column. So if the left column shows swatches they are truncated, or not visible
Truncating long texts is less annoying.
Fixes #14052
https://gitlab.com/kicad/code/kicad/issues/14052
2023-02-27 08:35:35 +01:00
fe9370ceea
Don't allocate all of memory when the coord system turns inside out.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14088
2023-02-26 21:53:05 +00:00
698d0b7e92
CADSTAR Sch: Fix loading of graphical arc shapes
...
Correctly load arc shapes as real arcs instead of approximating now that
v7 supports graphical arcs in the schematic.
Also fix calculation of arc geometry for ccw arcs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14101
2023-02-26 19:46:34 +01:00
51d46c0e73
plotters rework: add plot fct to use TEXT_ATTRIBUTES class to pass text settings
...
Old PLOTTER::Text is not (yet) removed, but it use negative text size
to mirrored text, which is not really compatible with some plotters (especially PDF).
Using TEXT_ATTRIBUTES is much easy and much better,
so PLOTTER::PlotText() is added.
Note: "old" PLOTTER::Text() is not removed yet.
2023-02-26 14:44:53 +01:00
bbfc5c272e
Fix my commit d07738a06c.
...
( a DC->SetPen() was deleted by mistake)
2023-02-25 19:06:46 +01:00
ece34e1a0c
Plot Gerber format: ensure all attributes are added to polygon items.
...
Especially, TA.AperFunction,EtchedComponent for net tie footprints using polygons.
2023-02-25 19:06:46 +01:00
9a0aeb4344
Adjust AC-small-signal plot names when saving placeholders.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14016
2023-02-25 13:26:33 +00:00
ee956673b1
Respect readOnly cells in GRID_TRICKS.
...
Also fixes setting colors in the signals grid as it allows us to make
it editable again.
Fixes https://gitlab.com/kicad/code/kicad/issues/14079
2023-02-25 11:02:12 +00:00
bce402a01c
Revert font spacing/tabs to the v6 model
...
While convoluted, this model matches as best we have found so far, the
alignment with scintilla. The spacing is character size for N-1 of the
characters in the 4-space tab stops. The final character is sized for
the actual space character in the stroke font (0.761905)
Fixes https://gitlab.com/kicad/code/kicad/issues/13791
2023-02-24 17:15:57 -08:00
65a10bd425
Remove unused member variable.
2023-02-24 22:43:23 +00:00
150d2fd281
Tweak the Mac default selection highlight color for better visibility.
2023-02-24 12:44:55 +00:00
4bb508eacf
Adjust stroke font baseline offset to better match 6.0.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13886
2023-02-24 12:44:55 +00:00
1651b44ab1
Fix some PCB_SHAPE properties
...
Hide irrelevant position/start/end properties
for shape classes that don't use them.
2023-02-23 20:23:44 -05:00
81256c0fa4
Prevent mutex deadlock
...
The overbar function in outline fonts recursively calls the text
function which already owns the lock. To avoid this, we have an
unlocked variant that is wrapped by the exposed text function
Fixes https://gitlab.com/kicad/code/kicad/issues/14015
2023-02-23 14:59:59 -08:00
bc8a78c6df
Eeschema plot: honor B&W plot option for bitmap images.
...
Fixes #14013
https://gitlab.com/kicad/code/kicad/issues/14013
2023-02-23 09:50:05 +01:00
f076f6fb46
Preserve unknown keys in JSON_SETTINGS
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13847
2023-02-22 19:00:47 -05:00
dce8826eb2
Fix incorrect tilt of italic texts when plotting them.
...
Fixes #14023
https://gitlab.com/kicad/code/kicad/issues/14023
2023-02-22 16:55:20 +01:00
43d3a18b86
Improve HiDPI handling of appearance/layer controls
2023-02-22 09:20:36 -05:00
89ef6b36f4
Fix layer widget in HiDPI situations
2023-02-22 09:20:30 -05:00
915446a472
Create the built-in colors in the constructor
...
This is needed so Python scripts can get built-in colors using the
SETTINGS_MANAGER.GetColorSettings() member.
Otherwise calling it with a built-in name crashes.
(cherry picked from commit aee6d9d01c
2023-02-22 12:52:44 +00:00
814dcdab31
Fix compatibility with wxWidgetsversion < 3.1.6
2023-02-22 10:05:37 +01:00
be19e967dc
Remove WX_COMPATIBILITY flag
...
Some classes had been originally designed to be usable separate from wx,
but over time our uses of the classes have become entertwined with wx
features (e.g. colors), and various changes have also leaked wx into the
classes unguarded. So just remove the option to hide wx in those classes
to simplify the code.
2023-02-22 01:44:06 +00:00
0ba116a3ee
Remove unused functions from COLOR4D
2023-02-22 01:44:06 +00:00
bcb93e9aa7
Modernize setting of compiler definitions in CMake
...
add_compile_definitions was added in 3.12, and our minimum is now
greater than that.
2023-02-22 01:44:06 +00:00
39e69a3d29
Fix up handling of font names available in multiple names
...
ttf fonts can declare multiple language names. Many by default opt to just declare one and not tag it any particular language.
However, there are CJK languages that typically leverage this function the most. They'll tag both a "en" and a cjk lang family name in CJK characters.
To be as user friendly as possible, we need to display said fonts in the CJK languages if KiCad to set to such a locale.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14011
2023-02-21 20:26:41 -05:00
d07738a06c
gr_basic.cpp: ensure a pen with width = 0 is transparent.
...
Setting its color to COLOR4D::UNSPECIFIED (i.e. opacity = 0) is not enough
for all platforms (i.e. Windows)
2023-02-21 20:06:54 +01:00
6fcb95b24e
ADDED user-defined signals.
2023-02-21 13:32:01 +00:00
ae0cf19923
Nullptr safety.
2023-02-21 13:32:01 +00:00
87eb4401e3
Add Scintilla support to WX_GRID.
2023-02-21 13:32:01 +00:00
b05b33a9ff
Fix a compil issue with gcc12.2 and Coverity warnings.
2023-02-21 11:54:38 +01:00
365c7be4ed
Fix symbol contributor link
2023-02-20 19:44:37 +00:00
31be74b8b3
Fix a few Coverity warnings
2023-02-20 09:25:01 +01:00
343e3aee55
Remove unused m_sockets
2023-02-19 23:49:43 -05:00
30a49462fe
Fix crash parsing cadstar
...
Fixes sentry KICAD-B2
2023-02-19 08:06:35 -05:00
c5a2c9c773
Try to prevent a crash in mpFXY::Plot
...
Fixes sentry kicad-c0
2023-02-19 00:38:42 -05:00
d55e2049e5
Silence some warnings with static_casts
2023-02-18 23:36:50 -05:00
aacc9746e3
Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere
2023-02-18 22:57:18 -05:00
dffd2da8c8
Fix the shared_lock added and micro-opt the reindex
2023-02-18 11:28:19 -05:00
e053fbefd7
Use a shared_mutex to read/write lock the nickIndex
...
Fixes sentry kicad-ax
2023-02-18 10:17:58 -05:00
f7d59f2e89
Enable properties panel in footprint editor
2023-02-17 20:35:56 -05:00
2975f53647
PCM: auto reload global libs after dialog is run
...
This adds Reset() method to KIFACE to reload global libs stored in
global static vars.
Also refactors some lib reload code in various frames to have
common MAIL_RELOAD_LIB handler.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12500
2023-02-17 17:24:32 +00:00
7b4abb1f7b
FT_Face is also not thread, protect getTextAsGlyphs
2023-02-17 14:39:52 +00:00
65d5b34da3
freetype is not thread safe, zone filler can trigger multi-thread access
...
sentry KICAD-B1
https://freetype.org/freetype2/docs/reference/ft2-base_interface.html
[Since 2.5.6] In multi-threaded applications it is easiest to use one FT_Library object per thread.
In case this is too cumbersome, a single FT_Library object across threads is possible also, as long as a mutex lock is used around FT_New_Face and FT_Done_Face.
2023-02-17 07:26:52 -05:00
576bef4ba0
Fix Ukrainian language name
...
Should refer to the language not to a Ukrainian person
2023-02-16 15:10:47 -08:00
5c1b15f8e3
Make LIB_TREE_NODE sort irreflexive
...
std::sort requires explicit ordering of all elements. It does not allow
for equality in its output
2023-02-16 13:00:18 -08:00
c189053ee5
CURLINFO_SIZE_DOWNLOAD_T is a enum entry, use the version check instead
2023-02-14 23:44:46 -05:00
94b5ddbb50
CURLOPT_XFERINFOFUNCTION is an enum entry not a define, the check is invalid
2023-02-14 23:24:02 -05:00
e5b376721d
Properties: remove assertion that no longer makes sense
2023-02-14 21:08:36 -05:00
473979d686
Fix handling of PPI when loading embedded images
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13884
2023-02-14 19:42:06 -05:00
03484aedbc
Workaround wxWidgets enforced min pen width by using transparent pen.
...
Also fixes some bugs in our shape printing code when a border is not
specified but a fill is.
Fixes https://gitlab.com/kicad/code/kicad/issues/13891
2023-02-14 14:44:04 +00:00
4b07e3e413
Common Actions: Find Previous
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8968
2023-02-14 08:21:37 -05:00
785f1acdb0
Archive .ibs files.
...
Also archives .pkg files that share a name with an archived .ibs file.
Fixes https://gitlab.com/kicad/code/kicad/issues/12102
2023-02-14 11:59:17 +00:00
e8e407dfba
It's not impossible for the font face to fail loading
...
LoadFont()'s only usage already checked for nullptr to fallback, let's actually return nullptr on a failed load
Fixes sentry KICAD-8Z
Make the cause of sentry KICAD-95
2023-02-13 20:09:05 -05:00
9647a22e50
Prevent another GAL crash on init due to psuedo-race
...
Fixes Sentry KICAD-98
2023-02-13 19:10:49 -05:00
eb7fec52d5
Add archiving of SPICE files.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12102
2023-02-13 22:46:07 +00:00
d915cb780e
Search Pane: add Activation (enter/double click) event support
2023-02-13 10:57:05 -05:00
58350b4521
Ensure gal is initialized before letting DoRepaint blowup spectacularly.
...
Maybe a fix for KICAD-6B
2023-02-13 07:18:07 -05:00
837ba323fb
Add doc link to custom rules syntax help.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13727
2023-02-12 21:34:35 +00:00
4665823089
Turn on and fix MSVC compliance mode issues
...
We want /permissive- to enable debug performance improvements in MSVC 17.5+.
This flag is also default under C++20 so we'll have to deal with these compile issues anyway at some point in the future.
In particular, MSVC becomes pedantic about ternary types.
See https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#ambiguous-conditional-operator-arguments
MSFT cites https://cplusplus.github.io/CWG/issues/1805.html
2023-02-12 16:30:37 -05:00
1e756dbdd8
Save cursor positions in sim workbook.
2023-02-12 20:40:23 +00:00
e5176ff4d6
ADDED power dissipation plotting and cursors.
...
Also fixes a bug so that voltages, currents and power dissipations are
only probed if the flag is set -- this keeps ngspice from throwing an
error if you probe something twice (for instance, if you have .probe
commands in text and turn off the auto-probing).
2023-02-11 21:11:07 +00:00
bc108023b3
ADDED operating point overlay for SCH_EDIT_FRAME.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-11 21:11:07 +00:00
2a5bb71fbd
ADDED operating point text variables for labels and symbols.
...
ADDED formatting for cursors and operationg points
Also fixes a bunch of bugs to make the new cursors work with .ac sims.
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-11 21:11:07 +00:00
39d35a8bec
Better cursor feedback for plot window.
2023-02-11 21:11:07 +00:00
f0bd25b397
ADDED use-settable simulation trace colors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2536
2023-02-11 21:11:07 +00:00
09822c7f18
ADDED direct access to signals & cursors.
...
ADDED differential cursors.
Fixes https://gitlab.com/kicad/code/kicad/issues/4447
Fixes https://gitlab.com/kicad/code/kicad/issues/6221
2023-02-11 21:11:07 +00:00
8b4c4b8500
Board-specific hint for board version of Net Settings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13630
2023-02-11 21:11:07 +00:00
0dcc34ddc8
Simplify Remove Unused Pads dialog.
2023-02-11 21:11:07 +00:00
b000d68def
Move simulator to tool framework.
2023-02-11 21:11:07 +00:00
946e0a4b98
ADDED support for e-series based tuning.
2023-02-11 21:11:07 +00:00
61dd4b7043
Properties: fix rebuilding when availability changes
2023-02-11 15:50:51 -05:00
189ce373bb
Remove default hotkeys for grid set/reset.
...
This is a waste of hotkeys for what should be seldom used activities.
If a user needs hotkeys for this, they can bind them manually
2023-02-11 13:20:53 -05:00
eb240fda9a
Properties: introduce validators; re-enable zone hatch settings
2023-02-11 11:44:58 -05:00
254168c788
Properties: introduce method chaining for initialization
2023-02-11 11:44:58 -05:00
609ef96e42
Attempt to fix GitLab template duplication
2023-02-11 11:41:12 -05:00
6948a0bebd
Expose new netclass storage to SWIG
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13337
2023-02-11 09:50:24 -05:00
822d7af4b7
Hide scrollbars in editors by default.
2023-02-11 16:39:09 +03:00
fda3feaf3f
Revert "Add doc link to custom rules syntax help."
...
This reverts commit 7874735810
2023-02-10 15:33:03 -08:00
4ac6d6a0bd
Fix "wxEXPAND overrides alignment flags in box sizers" assert.
...
wxALIGN_CENTER_VERTICAL flag is ignored if wxEXPAND is present in
box sizers.
2023-02-11 02:15:44 +03:00
7978fdbfce
Plot colored drawing sheet text with the correct color
2023-02-09 14:12:48 +00:00
5da5ccc4bf
pagelayout_editor: fix some minor issues:
...
- text color not always stored in file
- Indicator for changes in main title not updated after save.
2023-02-09 14:16:26 +01:00
ae2da76615
Pcb printing: fix incorrect pos. of the board when printed without worksheet.
...
Fixes #13258
https://gitlab.com/kicad/code/kicad/issues/13258
2023-02-08 11:05:31 +01:00
a493a2c822
kicad-cli, pcbnew pàlot: honor the color options when ploting pdf files
...
--black-and-white and -t were shown in help, but not handled
Fixes #13805
https://gitlab.com/kicad/code/kicad/issues/13805
2023-02-07 20:20:45 +01:00
0d903d43a0
pagelayout editor: Add tests for invalid parameters.
...
Invalid parameters are repeat count < 1, size < 0 and default size < 0.01 mm
2023-02-07 12:53:34 +01:00
823607796b
Additional safety around wks bitmaps
...
Invalid files can create large problems for unloaded PNG data
Fixes https://gitlab.com/kicad/code/kicad/issues/13801
2023-02-07 12:08:39 +01:00
23d0e6b4c0
Fix compil on msys2 (Structured Exception Handling not really supported)
2023-02-05 10:39:25 +01:00
525d0da126
Move __try into lambda.
2023-02-05 07:55:01 +03:00
b913e9be1e
Move more of defragment inside the __try block.
2023-02-05 07:45:03 +03:00
74a242c662
Catch access violation in defragment due to OpenGL drivers on Windows.
2023-02-05 07:03:04 +03:00
729be64850
Preferences dialog: try to reduce its width, in non English languages.
...
Step 2: Remove some useless spacers, and do not force some widgets
to have a too large size.
2023-02-04 17:45:39 +01:00
6b5eeeb861
Preferences dialog: try to reduce its width, in non English languages.
...
Remove some useless spacers, and do not force some widgets to have a to
large size (by removing empty areas).
Work in progress: one panel is still too big.
2023-02-04 14:36:14 +01:00
90e759e738
Dialogs: minor cosmetic fixes (reduce a few spaces between widgets)
2023-02-03 16:58:30 +01:00
9a34178f66
add CURRENT_DATE to text var autocomplete
2023-02-03 00:10:55 +00:00
e20c86ad5e
Minor dialog layout improvements.
2023-02-02 16:54:52 -05:00
7874735810
Add doc link to custom rules syntax help.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13727
2023-02-01 23:40:53 +00:00
8b6fda2890
PANEL_COMMON_SETTINGS_BASE: Reduce the minimal width of the panel.
...
Other languages than English can have much bigger sentences, thus
creating a very large panel.
2023-02-01 11:29:55 +01:00
Wayne Stambaugh
Salvador E. Tropea
Johannes Pfister
Roberto Fernandez Bautista
jean-pierre charras
Jeff Young
Seth Hillbrand
Jon Evans
Ian McInerney
Marek Roszko
qu1ck
Mike Williams
Alex
FPiorski
Graham Keeth