Commit Graph

275 Commits

Author SHA1 Message Date
jean-pierre charras 4d48376eae Fix some warnings detected by PVS-STUDIO (not used vars) 2022-07-26 16:00:14 +02:00
luz paz 79fa911e0e Fix various typos
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
2022-07-21 16:31:41 +00:00
Seth Hillbrand 98431eed79 Avoid scaling unity models
There is no benefit to applying the identity transformation to models
when exporting the board to STEP

Fixes https://gitlab.com/kicad/code/kicad/issues/12036
2022-07-19 10:36:33 -07:00
Wayne Stambaugh a830261973 KiCad2Step source code cleaning. 2022-07-07 07:48:24 -04:00
Wayne Stambaugh 497061de35 Fix KiCad2Step virtual keyword handling.
The "virtual" keyword has been deprecated from the board file format so
use "exclude_from_bom" as the flag for the old virtual behavior.  This
is only a partial fix.  Full support for the "exclude_from_bom" will be
added later for V7.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10563
2022-07-05 08:59:22 -04:00
jean-pierre charras 2ff2a6ffcd Kicad2step: fix STEP export from Pcbnew, broken by changes in commit 8456d6c
also: DIALOG_EXPORT_STEP: remember tolerance option during a session.
2022-07-01 09:56:15 +02:00
Adam Wahab 8456d6cea9 Corrected syntax in kicad2step's help message regarding user-specified origin. 2022-06-28 23:24:13 +00:00
Jeff Young e85105a907 Add board stackup parsing to Kicad2Step.
Fixes https://gitlab.com/kicad/code/kicad/issues/11565
2022-05-09 21:03:13 +01:00
jean-pierre charras d2c5eb1f23 Fix a minor error in commit b154acc: the commit was using a too old file. 2022-04-14 15:35:49 +02:00
jean-pierre charras b154acccdc STEP export: handle polygons with arcs (and convert arcs to segments).
Fixes #11389
https://gitlab.com/kicad/code/kicad/issues/11389
2022-04-14 14:53:13 +02:00
Jeff Young 9a654ec8b9 wxT-ify utils. 2022-02-09 17:04:32 +00:00
Marek Roszko 41f54349a5 Replace inserts/push_backs with emplace in some spots 2022-02-05 19:53:31 -05:00
Marek Roszko 1c77eb14d7 Fix a set of odd null on new checks PVS V668 2022-02-05 14:38:07 -05:00
Marek Roszko a7ebfc31f9 Fix some leaking objects identified by PVS Studio V773 2022-02-05 11:16:11 -05:00
Seth Hillbrand 098e8f7d9b Revert "cmake: adding KICAD_MACOSX_APP_BUNDLE option"
This reverts commit ea9f960cc1.

Reverted for updates as this currently breaks kicad-mac-builder
2022-01-31 15:57:56 -08:00
Davide Gerhard ea9f960cc1 cmake: adding KICAD_MACOSX_APP_BUNDLE option
ADDED: with cmake KICAD_MACOSX_APP_BUNDLE option the user can disable
the macOS app bundle creation when compiling on macOS. This permit to
use/install KiCad like any other *nix platform (/usr/bin, /usr/share,
ecc.). By default, cmake build the app bundle.
2022-01-28 15:49:37 -08:00
Steven A. Falco 042f584859 Missing include file 2022-01-21 17:00:12 +00:00
Jeff Young dcaec78cc5 A bit more angle cleanup. 2022-01-18 02:18:55 +00:00
Jeff Young 1539fa5af2 Move SHAPE_ARC to EDA_ANGLE. 2022-01-16 01:19:45 +00:00
Ian McInerney fb36e1b582 Revert caf406943e and don't install the kicad2step lib
This fixes https://gitlab.com/kicad/code/kicad/-/issues/9944 and reverts
caf406943e. The original fix caused issues
with some CMake versions because it tried to give library dependencies
to an object library, which can't have any library dependencies.
Instead, we need it as a static library, and since there is no need to
actually have it as an end-user library, it shouldn't be in the install
command.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9944
2021-12-30 15:18:30 +00:00
jean-pierre charras 5622a51193 Fix linking issue in kicad2step (double definition of some symbols) 2021-12-12 08:52:41 +01:00
Wayne Stambaugh caf406943e Do not install kicad2step build library object file.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9944
2021-12-11 08:48:47 -05:00
Seth Hillbrand 1b1bf8a17b Better handling of escaped characters in STEP parser
Fixes https://gitlab.com/kicad/code/kicad/issues/9897
2021-12-08 15:55:42 -08:00
Ian McInerney e57bde6582 Remove last vestiges of the KICAD_USE_OCE build flag
This build flag was removed in a previous commit, but some last uses
remained.
2021-12-01 15:53:00 +00:00
jean-pierre charras a93c2c24fa kicad2step: fix compatibility with OCC versions < 7.5 2021-11-21 17:27:18 +01:00
Seth Hillbrand b3e2206377 Create specific writer for OpenCascade messages
Needed later for integration, so good idea to get framework set now

Fixes https://gitlab.com/kicad/code/kicad/issues/9694
2021-11-20 09:12:55 -08:00
jean-pierre charras 38d8e00d10 kicad2step, 3d_resolver: show a debug message only in DEBUG mode... 2021-11-07 09:39:33 +01:00
jean-pierre charras 5e6f490959 Fix kicad2step, incorrect export of oval holes in pads. 2021-10-17 18:30:03 +02:00
jean-pierre charras 6632cb056c Fix issues with arcs in kicad2step, due to last kicad_pcb format changes.
Fixes #9409
https://gitlab.com/kicad/code/kicad/issues/9409
2021-10-17 17:45:12 +02:00
Marek Roszko 08940acf01 Fix compile error due 2021-09-22 07:46:53 -04:00
Jeff Young 5eb6b488f3 Formatting. 2021-09-22 12:19:29 +01:00
Jeff Young d11c10252d More changes to file resolvers.
Copy Kicad2Step fixes back to Kicad's file resolver.

Remove Kicad2Step's autogeneration of some variables in favour of
just reading the config file passed by Kicad verbatim.

Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-09-22 11:28:45 +01:00
Marek Roszko a6fb687a0e Fix rejection of default variables from exportpaths.cfg
Fix #7670
2021-09-21 19:43:41 -04:00
Jeff Young 9d35c551ba More debug output for models that are not found.
Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-09-21 17:52:57 +01:00
Jeff Young 490cc42cb5 Remove vestiges of m_ConfigDir from Kicad2Step.
The converter uses paths passed in via a config file in the OS's
temp directory.

Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-09-21 13:39:33 +01:00
Jeff Young 24f3c49631 Fix logic error in FileResolvers.
If Normalize() was not needed after finding a searchpath then we were
never updating tname and just blindly returning it.

Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-09-21 12:35:16 +01:00
Jean-Samuel Reynaud aa85bb27fa
Fix configuration phase on Ubuntu 18.04 (bionic).
Error messsage was:
"CMake Error at utils/kicad2step/CMakeLists.txt:68 (install):
  install TARGETS given no ARCHIVE DESTINATION for static library target"

 Perhaps cmake version (3.10.2 on bionic) need that since on ubuntu focal (20.04) there is no error (cmake is 3.16.3 on focal). As I see cmake 3.14 add an autodetection mecanism to find the destinations.
2021-09-20 11:52:31 +02:00
Marek Roszko 347e6f914d Add OK button to close step export dialog
Because someone out there might shrink their titlebar to absurdly small sizes and then wonder why suddenly the UX is poor.

Fix #9192
2021-09-19 23:11:11 -04:00
Marek Roszko b2ba86578b Don't erroneously print "step file written"
Fix #9193
2021-09-19 20:55:04 -04:00
Jeff Young a71d856e94 Ignore the drill oval keyword; x either equals y or it doesn't.
Fixes https://gitlab.com/kicad/code/kicad/issues/9193
2021-09-19 20:45:40 +01:00
Jeff Young 21313a4c1a Don't exit when we fail to find a 3D model: there may be more.
Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-09-15 21:53:15 +01:00
Jeff Young 0ae17f1e63 Update Kicad2Step error messages to current terminology. 2021-09-14 13:35:31 +01:00
Jeff Young 48082e3234 Improve debugability of 3D file resolver failures.
Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-09-14 12:28:17 +01:00
Marek Roszko ebda02255c Fix step pcb coloring 2021-09-13 21:18:22 -04:00
Marek Roszko 4f861e084d Give the board boards unique names in STEP exports 2021-09-12 17:43:26 -04:00
Marek Roszko c84619cd7f Undo APIEXPORT thats not required
I was doing a dll before a static and well. Our unit test system isnt setup to handle DLLs at all. Ugh
2021-09-11 23:08:33 -04:00
Marek Roszko 74fd23f573 Add (off by default) build option to link kicad2step directly into pcbnew
Because debugging it separately is annoying.
2021-09-11 22:56:16 -04:00
Marek Roszko f42505b422 Expand the board in the step export to an assembly always 2021-09-11 22:56:16 -04:00
Jeff Young 61ef431c56 Apply fixes from Kicad2Step filename resolver back to Kicad. 2021-09-09 11:17:21 +01:00
Jeff Young 0e96ac4d7b Improve logic and error reporting of Kicad2Step file resolver. 2021-09-08 15:29:41 +01:00