5cf346c233
Unify symbol browser/editor unit display
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11881
(cherry picked from commit aeef5b00a8
2022-06-21 16:23:27 -07:00
92fbc42214
PANEL_SYM_LIB_TABLE: fix a bug in filenames from wxFileDialog dialog.
...
We want the full path, so use GetPaths.
GetFilenames sometimes return the full path in wxWidgets 3.1.7, not always the filename
Fixes #11821
https://gitlab.com/kicad/code/kicad/issues/11821
2022-06-16 13:06:19 +02:00
16d63b7772
Handle alt pins in plot code.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11728
(cherry picked from commit e4798199c6
2022-06-12 10:39:31 +01:00
797cb2aaac
Typo.
...
LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not.
Fixes https://gitlab.com/kicad/code/kicad/issues/11556
(cherry picked from commit d381fd8b29
2022-06-12 10:39:31 +01:00
bbe70e2f67
Repair Eagle importer page number handling.
...
The root sheet needs a page number, and the other sheets need to not
have their last step in the path duplicated.
Fixes https://gitlab.com/kicad/code/kicad/issues/11409
(cherry picked from commit aaff163d7c
2022-06-08 15:58:52 +01:00
c861c31f24
Eeschema: fix symbol library remap bug.
...
The original decision to escape the legacy symbol library names results
in them being escaped every time they are opened which cause the curly
braces '}' from the original escaping to be escaped on subsequent
openings. This resulted in the symbol library names in the rescue
library not matching the library ID in the schematic.
This fix is likely to have other corner case bugs given the potential
for escaped characters in legacy symbol libraries. Given that we now
have escaped rescue libraries in play, removing the escaping will only
result in more issues so we will have to fix the corner cases as we go.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
2022-06-05 18:12:39 -04:00
7168441a1b
Symbol checker: fix incorrect test for duplicate pins.
...
From master branch
https://gitlab.com/kicad/code/kicad/issues/11660
2022-06-04 11:07:13 +02:00
c117708220
Unset forced cursor before leaving two-click place.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11607
(cherry picked from commit 79a0ce9137
2022-05-31 23:21:43 +01:00
6b2bb4d808
Allow sheet recursion, fix sheet paths in "Highlight on PCB".
...
"Highlight on PCB" and "Select" - "Items in Same Hierarchical Sheet"
actions were extended to select items on subsheets too.
"Highlight on PCB" now uses a proper full sheet path, allowing it to
work in subsheets.
Fixes https://gitlab.com/kicad/code/kicad/issues/11493
2022-05-25 23:38:52 +00:00
7fdfd77422
Change default value of MatchByReference to false.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11382
(cherry picked from commit 5802ede3fd
2022-05-14 12:44:14 +00:00
d971cbefcb
Resolve title variable when plotting
...
Be sure to use variable name if it exists when plotting the file
Fixes https://gitlab.com/kicad/code/kicad/issues/11608
2022-05-12 15:30:45 -07:00
7563f51212
Fix eda_doc not looking for schematic locally
...
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0ef85251ef75
2022-05-11 03:33:40 +00:00
bd97aaa63e
Symbol Fields Table fields list: improve scrollbar behaviour on Windows.
2022-05-09 23:51:57 +00:00
e811b9a2dd
Hierarchy: update just selection on sheet change
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11550
2022-05-09 17:31:29 +00:00
8524042352
Implement cross-references for labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11564
(cherry picked from commit f9f0f6fe24
2022-05-09 12:22:49 +01:00
5b24003f6c
Promote field selection to field-owner for Autoplace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11529
(cherry picked from commit f6f316bd8c
2022-05-09 12:07:33 +01:00
362eec7ee3
Update findnext to handle new instance data architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11424
(cherry picked from commit e0f2a5f07c
2022-05-09 00:36:27 +01:00
c63c3d1891
Fix minor layout issue in dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11490
(cherry picked from commit 2cccd5b090
2022-05-09 00:36:27 +01:00
f4b5b65342
Initialize virtual page no. to something more reasonable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11295
(cherry picked from commit 52eb210aa8
2022-05-09 00:36:27 +01:00
624d88dff9
Disable background color when printing in black & white.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11180
(cherry picked from commit 6738708a7f
2022-05-09 00:36:27 +01:00
1831e034be
Fix missing line keeping tabs from switching.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11417
(cherry picked from commit fc2eb2d7c9
2022-05-09 00:36:27 +01:00
2dcff109df
Update Selection Filter title bar with language changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11421
(cherry picked from commit 4ab2c93070
2022-05-09 00:36:27 +01:00
e05c8f8852
Catch throws in DeleteSymbol
...
DeleteSymbol may call SaveSymbol if the name is changed. In this case,
SaveSymbol may throw back and needs to be caught
Fixes https://gitlab.com/kicad/code/kicad/issues/11566
2022-05-06 16:13:13 -07:00
f4d4f23876
Catch errors when saving individual symbols
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11566
2022-05-06 09:47:55 -07:00
827abb01a3
Eeschema: fix broken project symbol rescue.
...
The legacy symbol library plugin code was changed to escape symbol names
which broke the LIB_ID string comparison when checking to see if symbols
needed to be rescued. Escaping the LIB_ID names before comparison resolves
the issue.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
(cherry picked from commit a19490b097
2022-05-06 10:09:19 -04:00
ed153bd7d7
Symbol editor crash: Fix use of a null pointer.
...
LIB_TEXT::Clone() did not copy a member set to nullptr.
From Master branch
Fixes #11569
https://gitlab.com/kicad/code/kicad/issues/11569
2022-05-06 12:54:32 +02:00
82631db1bb
Eeschema, backannotate: fix minor issues in displayed messages.
...
From Master branch
Fixes #11530 https://gitlab.com/kicad/code/kicad/issues/11530
2022-05-05 11:29:58 +02:00
ba276fe470
Fix botched commit
2022-05-02 16:28:39 -07:00
4d47857738
Catch IO_ERRORs that we throw
...
FILEOUTPUT_FORMATTER likes to throw when it gets an issue. We need to
catch this to avoid the app falling apart
Fixes https://gitlab.com/kicad/code/kicad/issues/11516
2022-05-02 15:15:04 -07:00
729cf7a39d
Use instance data to store values
...
Previous use of instance was as an "override" of the default value.
This has changed to be used as the primary storage location for all
values. This means that we cannot clear the instance data when setting
a new value for all instances, instead we have to change the instance
data and the default value is superfluous
Fixes https://gitlab.com/kicad/code/kicad/issues/11439
(cherry picked from commit 1a70465927
2022-04-25 13:03:41 -07:00
cf5f36aac5
Fix broken comparison in pin_numbers
...
Pin names like "+V" were incorrectly parsed as doubles leading to broken
comparisons. These caused heap overflows when sorting pin tables
This corrects the comparison so that numeric sorts are only performed
when there is an actual number in the symbol segment. Also adds unit
tests for common error cases
(cherry picked from commit aac6f576c2
2022-04-19 14:49:52 -07:00
cc51807241
Fix minimum size calculation for new hierarchical sheets
...
These constants are given in mil, but are used in a context of internal
units.
2022-04-18 02:16:17 +02:00
851f893e8e
Fix crash due to cleared view data
...
When changing fields, we need to update the view before allowing canvas
updates
2022-04-15 14:56:18 -07:00
2de1bd7a4a
Ensure "Open Recent" and "Clear files" menu titles are updated after language change.
...
From Master branch.
2022-04-14 15:06:17 +02:00
250942264b
CADSTAR Sch: Clear symbol of all elements before overwriting with new one
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11378
(cherry picked from commit 85f6ff48e7
2022-04-12 21:42:03 +01:00
b2eb1f829e
Dual-purpose IsMovableFromAnchorPoint to keep from moving symbols off-grid.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11360
(cherry picked from commit 8358685920
2022-04-12 13:24:34 +01:00
63ce2307c8
Adjust LIB_SYMBOL compare for use with ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10783
(cherry picked from commit 117bd4fc22
2022-04-12 13:24:14 +01:00
03bc9551c7
Don't save schematic symbol back to lib manager.
...
Also, since it doesn't get saved, changing symbols will lose any edits.
Make sure to ask the user first.
Fixes https://gitlab.com/kicad/code/kicad/issues/10767
(cherry picked from commit 16acba34d3
2022-04-12 13:24:14 +01:00
c8cd214cb0
Make sure to add any now-necessary junctions after a rotate.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
(cherry picked from commit 74a578047c
2022-04-12 13:24:14 +01:00
fe11bc8330
Change the behavior of ACTION_MENU::Add to require clones if required outside the function
2022-04-11 20:39:08 -04:00
c2d72180f8
Revert "Change the behavior of ACTION_MENU::Add to require clones if required outside the function"
...
This reverts commit 651f50a26d
2022-04-11 11:03:19 -07:00
651f50a26d
Change the behavior of ACTION_MENU::Add to require clones if required outside the function
...
Fix https://gitlab.com/kicad/code/kicad/-/issues/10994
2022-04-10 22:40:58 -04:00
529048dac1
Better error reporting for DP uncoupled length.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10087
(cherry picked from commit 722b2588f4
2022-04-09 23:09:10 +01:00
48a776f7c5
Repair code that was supposed to be after LoadSymbol().
...
(Even the comment said so.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11199
(cherry picked from commit ed361925ba
2022-04-09 21:23:18 +01:00
43929781a2
On-the-fly translations for pin electrical types.
...
Also add on-the-fly translation for editor title bars.
Fixes https://gitlab.com/kicad/code/kicad/issues/11324
(cherry picked from commit 68ca385e07
2022-04-09 21:22:50 +01:00
e02229a234
Don't flag pin missing driver when there is an NC
...
The NC flag indicates user intention to override the lack of connection
to input pins
2022-04-07 09:29:02 -07:00
e740db61f5
Show non-driven error on single-pin nets
...
Better to have both the single-pin error message and the non-driven
error message when an input pin is not connected than miss error
messages when the pin is connected to a blank net
Fixes https://gitlab.com/kicad/code/kicad/issues/10430
2022-04-06 16:53:23 -07:00
7d9cf00fd9
Improve sheet schematic import messages and simplify code.
...
There was also a logic bug when the selected schematic was in a different
path than the current project and was already part of the current project.
The symbol library table reconciliation code was still run which was wrong.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11075
(cherry picked from commit e336a0e403
2022-04-04 17:19:40 -04:00
6127ae92a5
PLOTTER: do not clamp coordinates to an arbitrary value.
...
Previously, coordinates were clamped to +- 60 inches. It makes no sense to
clamp them at plotter level: max cooed depends on the editor (schematic/board...)
Rename MAX_PAGE_SIZE_MILS to MAX_PAGE_SIZE_EESCHEMA_MILS and use it only for Eeschema.
Fixes #11196
https://gitlab.com/kicad/code/kicad/issues/11196
(cherry picked from commit 21144481d2
2022-04-04 13:52:21 -07:00
f7f6ea54fe
Fix incorrect m_SyncPinEdit setting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11331
(cherry picked from commit 3f9cfc0ac1
2022-04-04 21:51:30 +01:00
Seth Hillbrand
jean-pierre charras
Jeff Young
Wayne Stambaugh
Alex
Jonathan Haas
Marek Roszko
Mike Williams
Simon Richter
Roberto Fernandez Bautista