haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,471 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

411 Commits

Author SHA1 Message Date
Jeff Young 7356f9568d Move grid disable modifier from ALT to CTRL. 
Also had to move the H/V/45 disable modifier from CTRL to SHIFT.

Fixes https://gitlab.com/kicad/code/kicad/issues/8124
 2021-05-09 20:17:40 +01:00
Marek Roszko 21fde9b629 enum class PCB_SHAPE_TYPE_T 2021-04-30 22:36:12 -04:00
Jeff Young dc0cf3b802 Clean up a confusing API. 
AllowDRCViolations is kept in any mode as a *setting*, but only
controls router behaviour when the mode is mark obstacles.

Fixes https://gitlab.com/kicad/code/kicad/issues/7795
 2021-04-10 11:08:02 +01:00
Jeff Young 3fd3be9843 Layer fixes for PCBNew drawing tools. 
1) Implement layer changes for dimension drawing tool
2) Ensure drawing layer is visible for (1) and for the text drawing
tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/8106
 2021-04-07 15:02:48 +01:00
Jeff Young e50b450092 Formatting and organisation. 2021-04-07 14:50:29 +01:00
Jeff Young ec45855aed Make sure drawing layer is visible. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8106
 2021-04-06 00:06:23 +01:00
jean-pierre charras d3bf20e80b Pcbnew, place free via: take netcode from the pad, if the via is inside a pad. 
Fixes #8089
https://gitlab.com/kicad/code/kicad/issues/8089
 2021-04-02 17:19:44 +02:00
Jon Evans c04e19f9ac Include optimization: move some things from common.h to point-of-use 2021-03-20 12:09:18 -04:00
jean-pierre charras 3ba7fc0cc2 Move board stackup table drawing code from drawing_tool.cpp to drawing_stackup_table_tool.cpp 
This avoid a too large drawing_tool.cpp file.
Remove also values in internal units and convert them to mm.
 2021-03-14 17:44:16 +01:00
Fabien Corona f428ce03f2 ADDED: pcbnew - stackup / characteristics table 2021-03-13 20:19:46 +00:00
Jeff Young 93db7a130a Offset 3D models when moving footprint origin. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7868
 2021-03-12 17:37:38 +00:00
Jon Evans 18037e2f65 Rework bitmap system to load from archived PNGs 
Bitmaps are now identified by an enum class instead of by pointers.
Bitmap loading and caching is now handled by a class in common, and
we no longer compile most bitmaps into the binary, so there is no
longer a bitmaps static library.

Instead, bitmaps are archived to a .tar.gz file which is installed
in ${KICAD_DATA}/resources/images.tar.gz

The source PNGs are checked in to Git as the original CPP files were,
so that people can build without the required dependencies to convert
SVGs to PNGs.

Initial support is also added for dark theme icons, although this
is not yet exposed in the GUI.

Stubs are present for multi-resolution image resources, but this is
not fully-baked yet and could use some refinement.
 2021-03-11 08:37:35 -05:00
Jonathan Haas 274d4e2eb4 Fix orientation of orthogonal dimensions 
When drawing and editing orthogonal dimensions, take distance and
relative position to the end points into account.

Fixes https://gitlab.com/kicad/code/kicad/issues/7243

Fixes https://gitlab.com/kicad/code/kicad/issues/7189
 2021-03-08 00:13:38 +00:00
Jon Evans 1fc399fa31 Fix a few more cases of picking up wrong mouse positions 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7745
 2021-03-03 20:09:24 -05:00
Marek Roszko b82fcbcad6 More exception var disuse warnings 2021-02-26 19:30:58 -05:00
Seth Hillbrand 0bab025832 Fixup toolchaining for immediate mode 
The move tool can stack on others, so when we re-enter the previous tool
this caused another immediate action.  We flag re-entry in the tool
stack to check for this and avoid unexpected tool starts
 2021-02-24 10:44:54 -08:00
Seth Hillbrand 0518d9c546 Add more force-immediate tools 2021-02-23 17:05:03 -08:00
Jeff Young 34c2028e7b Assign via net before running DRC checks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7579
 2021-02-17 19:39:56 +00:00
Jeff Young d66de5bb35 Exclude footprints and groups from VIA_PLACER DRC testing. 
(Their children need to get tested, but not the parent objects
themselves.)

Fixes https://gitlab.com/kicad/code/kicad/issues/7569
 2021-02-17 14:08:53 +00:00
Jeff Young b7672d3c92 Respece router Allow DRC Violations in free via placer. 
Also don't check for collision on non-copper layers, but do check
for hole clearance violations.

Fixes https://gitlab.com/kicad/code/kicad/issues/7532
 2021-02-14 22:32:12 +00:00
Jeff Young e2f8b1a4b1 Interpreting wxDialog::ShowModal()'s retval as bool is never what you want. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7454
 2021-02-08 17:40:57 +00:00
Mikolaj Wielgus 5aaedd86ed Add "Limit graphic lines to 45 deg" to line drawing tool context menu 
Fixes https://gitlab.com/kicad/code/kicad/issues/7181
 2021-02-08 16:20:38 +00:00
Jeff Young 6272b48481 Make sure layer gets passed in to rules evaluation. 2021-02-08 14:53:49 +00:00
Jeff Young 8571687f51 Upgrade place via tool to new DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7358
 2021-02-01 23:00:13 +00:00
Seth Hillbrand 386ead30c5 All circle and arc tools to select all at first 
Non-layer elements can be logical centers for the circle and arc tools.
We allow the non-layer to snap for the center points and revert to only
on-layer elements after

Fixes https://gitlab.com/kicad/code/kicad/issues/7327
 2021-01-29 10:14:44 -08:00
Jeff Young 35978adef9 Don't run dimension updates while parsing files. 
They mess up the geometry when only partial values are provided.

Fixes https://gitlab.com/kicad/code/kicad/issues/7177
 2021-01-19 16:09:44 +00:00
Jeff Young 68efdb2fff Push shared parts of GRID_HELPERs into common. 2021-01-16 23:18:10 +00:00
Roberto Fernandez Bautista 00918c68f5 Don't do clever snapping logic when drawing a circle 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7131
 2021-01-16 08:39:20 +00:00
Jon Evans 70c397a9b4 Implement free vias fully 
CHANGED: manually-placed (stitching) vias won't have their nets automatically updated
(unless the via is placed directly on a track segment)

CHANGED: stitching vias can be placed on footprint pads and pick up their nets

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5484
 2020-12-20 16:29:50 -05:00
Jeff Young acfbcb4beb Make distinction between PCBNew-wide tools and Board-specific tools. 
The old names were really hard to keep straight (even for me, who named
many of them).
 2020-12-16 13:32:46 +00:00
Jeff Young 22a6b36257 Don't allow dbl-click to leak through to other tools. 
This only applies if the tool doesn't handle properties (which also
handles double-click events).

Fixes https://gitlab.com/kicad/code/kicad/issues/6735
 2020-12-14 22:15:43 +00:00
Jeff Young 60ecd4698c Nets don't have properites; netclasses do. 2020-12-08 13:05:39 +00:00
Jeff Young e882753ebf Grid snapping fixes. 
1) Uniformly honour the GAL grid snap settings
2) Make more uniform use of GRID_HELPERs
3) Smarten EDIT_LINE for mid-point snapping

Fixes https://gitlab.com/kicad/code/kicad/issues/6558
 2020-12-03 19:55:58 +00:00
Jeff Young 3c521942ed Smarten isEmpty checks to include nothing-but-whitespace. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
 2020-12-01 16:39:06 +00:00
Jeff Young 0293f880ec Fix a bunch of group issues with importing graphics. 
Groups do not own their children; they only reference them.  That
being said, they do own *selection* and *moving* of their children.
This might address some of 6493, but in any case will be a
pre-requisite for fixing it.

Fixes https://gitlab.com/kicad/code/kicad/issues/6493
 2020-11-27 22:03:14 +00:00
Ian McInerney d50d728d19 Cleanup compiler warnings 2020-11-25 00:08:09 +00:00
Jeff Young 9c7c05c161 Mostly formatting cleanup but a few type-casting cleanups too. 2020-11-24 22:16:41 +00:00
Jeff Young 9e9946628a Go back to arrow cursor on a cancel (or finish). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6421
 2020-11-19 20:09:28 +00:00
Jeff Young ec020dd19f First-class support for filled shapes. 2020-11-14 01:40:32 +00:00
Jeff Young bdbb68f813 MODULE -> FOOTPRINT. 2020-11-13 16:04:03 +00:00
Jeff Young 52a46341db More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young f5443de7f9 D_PAD -> PAD. 2020-11-13 15:16:24 +00:00
Jeff Young 84dd5108ba Remove some "class_" prefixes from files. 2020-11-13 15:16:23 +00:00
Jeff Young f7333ad64a Update some classnames including archaic zone names. 2020-11-12 10:31:25 +00:00
Jeff Young 4dc877d0e9 Module -> Footprint. 2020-11-08 21:43:19 +00:00
Jeff Young f33e44e630 Drop selection when creating new text item. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6310
 2020-11-08 00:14:43 +00:00
Jeff Young 0ebea4be53 Cleanup and naming conventions. 2020-11-07 18:50:30 +00:00
Jeff Young 23d6cde0b0 Don't swally properties command when tool has no current item. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6311
 2020-11-06 13:21:29 +00:00
Jeff Young 8b295a3bd7 Handle properties dialog while creating an arc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6215
 2020-11-05 20:21:06 +00:00
Jeff Young a6552f14f1 Improve SNR (code, status bar and user messages). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6304
 2020-11-05 16:38:04 +00:00
Jeff Young 8c782506b9 Appy units updating more consistently to editing assistants. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6283
 2020-11-04 14:11:25 +00:00
Ian McInerney dc542be91d Fix parentage of groups 
In the footprint editor, we must parent the group to the module
not the board.

Fixes https://gitlab.com/kicad/code/kicad/issues/6181
 2020-10-26 23:53:38 +00:00
jean-pierre charras f74ffc5623 Pcbnew: Fix incorrect position of the graphic crosshairs cursor in H,V,45deg 
forced mode, when the graphic polygon tool is active, but a graphic item is not started.
(The code was using the last created point, but it does not exist before starting
a line)

Fixes #6079
https://gitlab.com/kicad/code/kicad/issues/6079
 2020-10-26 11:56:09 +01:00
Jon Evans e832a94a9c Turn on zone visibility when you start drawing a zone 
It's disconcerting to have the zone turn invisible when
you finish drawing and drop the selection.
 2020-10-17 15:53:02 -04:00
Jeff Young 92d84b0d67 Naming updates. 2020-10-15 01:35:16 +01:00
Jeff Young ef3b7052e0 Remove layer nag dialogs and just ignore non-shapes on Edge_Cuts. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5812
 2020-10-13 20:22:31 +01:00
Jeff Young 70c3c5c514 Retire the two-item version of BOARD_CONNECTED_ITEM::GetClearance(). 2020-10-12 18:40:03 +01:00
Ian McInerney 5aa796b5fe Cleanup compiler warnings 2020-10-10 15:24:35 +01:00
Jeff Young 9c6977a994 Remember mirror setting in print dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5909
 2020-10-08 14:15:10 +01:00
Marek Roszko f5e0754f65 Use the setCursor lambda pattern and fix up the initial cursor states 2020-10-07 23:26:14 -04:00
Mark Roszko d9485129c8 Implement more context specific cursors using both stock and custom cursors. 2020-10-08 00:50:28 +00:00
Jeff Young 305fe54971 Drawing tool needs to pass resetLocalCoords event after recording it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5879
 2020-10-06 12:08:31 +01:00
Jeff Young 37906511f5 Class renaming. 
DRAWSEGMENT  -> PCB_SHAPE
EDGE_MODULE  -> FP_SHAPE
TEXTE_PCB    -> PCB_TEXT
TEXTE_MODULE -> FP_TEXT
 2020-10-05 11:55:33 +01:00
Jeff Young 7a4900b8dc PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T 
Also updated footprint text and zone types for consistencey.
 2020-10-04 16:49:04 +01:00
Mikolaj Wielgus 400c15b8eb Add mils to units, remove useMils variables 2020-10-03 20:06:56 +00:00
Jon Evans acf13a1869 ADDED: Orthogonal dimension object 2020-09-21 23:55:02 -04:00
Jon Evans 18e17abd6a Rename "Keepout" to "Rule Area" 
These objects can now be used in advanced DRC rules and
not just for keeping things out.  Also remove the restriction
that at least one of the "basic" keepout rules must be set,
so that these areas can be used for more advanced rules.
 2020-09-21 23:55:02 -04:00
jean-pierre charras 492a634413 Fp editor: Fix bug when moving fp anchor: pad shapes where not updated on screen. 2020-09-21 14:43:26 +02:00
Jeff Young 8dd725469f Process properties command locally within drawing tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5612

Fixes https://gitlab.com/kicad/code/kicad/issues/5615
 2020-09-17 22:32:22 +01:00
Jon Evans e9b627bfd8 ADDED: Center marker dimension type 2020-09-16 20:55:11 -04:00
Jon Evans 75ffce1a0b ADDED: Leader dimension object 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
 2020-09-15 23:37:38 -04:00
Seth Hillbrand 08bf5f4b4e ADDED: 45° snapping for rectangles aka Squares 
The snap obeys only the Ctrl key and not the global preference setting
for drawsegments because rectangles are _always_ on H/V lines when drawn

Fixes https://gitlab.com/kicad/code/kicad/issues/5607
 2020-09-15 11:22:26 -07:00
Jon Evans 3940e20fcb Expose extension offset and zero suppression settings 2020-09-12 11:52:59 -04:00
Jon Evans e40287d327 Fix auto units to work when drawing new dimensions 2020-09-12 10:30:33 -04:00
Jon Evans 0e9997d9ca Add new dimension features to board design defaults 2020-09-11 21:12:36 -04:00
Jon Evans b11e315d10 Refactor DIMENSION to hide internal details; add some new properties 
This is a board file format change to account for the new properties.
Also, we now only store the critical information about the dimension's
geometry in the board, rather than storing every drawn line.

The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION
is the implementation that exists today (we will add more dimension
types in the future)
 2020-09-11 21:12:36 -04:00
Seth Hillbrand f493e270ea ADDED: Menu option to enable/disable snap to grid 
You can now enable and disable snap to grid when drawing/editing across
all apps.  You can also tie snap to grid to the visibility of the grid
to allow rapid enable/disable via grid display.
 2020-09-10 20:09:30 -07:00
Seth Hillbrand 4026904cc4 Make grid snapping depend on grid visibility 
Turning the grid view on enables snapping to the grid.  Turning it off
removes the snap and allows free draw
 2020-09-09 10:18:15 -07:00
Seth Hillbrand 173b4ff588 Add snapping to eeschema 
This generalizes both the SetPosition() function and ORIGIN_VIEWITEM
class away from the pcbnew-centric.
 2020-09-09 10:18:15 -07:00
Jeff Young 6e72f609f0 Make sure router and via tools update when sizes change. 
Also adds a size menu to the context menu for the Via tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/5321
 2020-08-31 23:33:02 +01:00
Jeff Young c71bb246e6 Don't allow preview to try and draw empty polygons. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5314
 2020-08-22 23:46:56 +01:00
Seth Hillbrand 20de1b2b4f Minor code tightening 2020-08-20 20:18:31 -07:00
PJM 29ddc73d6c Pcbnew: Allow rects to have overlapping end corner locations 
CHANGED: If a rectangle is drawn and the location of the second corner
is the same as another rectangle's second corner, Pcbnew crashes. The
reason is that a call is made to DRAWSEGMENT::GetLength(), but that
function only handles shapes of type S_CURVE and S_SEGMENT.  This code
checks if the overlapping end points are from a rectangle and if so
it doesn't call DRAWSEGMENT::GetLength().

Fixes https://gitlab.com/kicad/code/kicad/issues/5282
 2020-08-21 02:58:32 +00:00
Ian McInerney c479deaf02 Use groups when doing graphics import 
ADDED: Allow DXF/SVG graphics to be imported as a group

Also, cleanup the placement routine to allow the edit tool's flip
and rotate routines to be used when placing the items.
 2020-08-20 01:22:48 +01:00
Marek Roszko d2086eecdd Don't update panel while drawing a dimension 2020-08-18 13:11:47 +00:00
Marek Roszko 73b2a10cab Don't try updating msgpanel while segments. 2020-08-18 13:11:47 +00:00
Marek Roszko a0956fbf97 text tool: msgpanel on motion is the same as msgpanel on not moved text.... 2020-08-18 13:11:47 +00:00
Jeff Young 34705fd8b2 More clone vs duplicate bugs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5120
 2020-08-10 14:45:01 +01:00
Fabien Corona 133d082cc5 Pcbnew fix arc edition 2020-08-09 23:03:31 +00:00
Jeff Young e5b50d90a7 Update DRC rules to new layer and disallow grammars. 
Also adds support for hooking rules up to named zones.

Fixes https://gitlab.com/kicad/code/kicad/issues/2041
 2020-08-07 21:49:36 +01:00
Jeff Young 7108a25278 Fix issues flipping text. 
This is a really hard problem to get right.  This algorithm won't
look quite right if you assemble a paragraph from disjoint text
objects and flip them all top-to-bottom (as it will re-order the
text).  But this is really the nature of the problem (and has to
stay that way to correctly flip disjoint graphic items or mixed
text and graphic items).  The real fix here is to support text
wrapped in a single text box.

Fixes https://gitlab.com/kicad/code/kicad/issues/4480
 2020-08-02 17:05:13 +01:00
Thomas Pointhuber 7ba6a77c94 Improve arc geometry manager to choose the direction which makes more sense 
As long as the arc angle stays below <60°, it will automatically choose between
clockwise and counter clockwise. This allows the user to choose the direction
with a simple mouse movement.
 2020-07-03 15:05:17 +00:00
Jon Evans 0d4ee39f75 CHANGED: Copper zones can be on more than one layer 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1963
 2020-06-28 08:52:37 -04:00
Jeff Young 367fd79b5f Don't try and second-guess the user. 
(Especially now that polygons are useful on copper layers for custom
pad shapes.)
 2020-06-27 22:08:13 +01:00
Jon Evans a16c9df79c Delete the right object in arc cleanup 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4694
 2020-06-21 13:03:14 -04:00
jean-pierre charras ad69e449fe Fix a collision name in drawing_tool.h with a msys2 header 2020-06-21 10:36:01 +02:00
Jeff Young a3cab09fb4 Make it clearer that drawSegment() can modifiy the current seg pointer. 
This might also quiet the Coverity warning, but I've also marked it as a
false positive (as it might still mess up on the new code).
 2020-06-17 18:44:39 +01:00
Seth Hillbrand 8c57821e9b pcbnew: Move ratsnest items to separate folder 2020-06-16 11:15:14 -07:00
Jeff Young aeed8e6e2c Finish implementation of DRAWSEGMENT::C_RECT. 
It's currently only supported in the Footprint Editor.  It could be
easily added to the board editor (all the code is there), but the board
editor is a little short on room in the drawing tools toolbar.
 2020-06-15 20:51:31 +01:00
Jeff Young 47ab7c78a6 Divorce GRID_HELPER from the parent frame. 
This moves GRID_HELPER fully into the tool framework.
 2020-06-13 22:44:16 +01:00