a4b38fbb80
Coverity warning fixes.
2023-12-18 16:09:13 -05:00
c7facfd4d4
remove unused variables
2023-12-18 18:54:47 +00:00
cfa55d958a
performance efficiencies
2023-12-18 18:45:02 +00:00
1c73d3d967
nullptr safety
2023-12-18 18:36:14 +00:00
e4baf877c8
performance efficiencies
2023-12-18 18:36:02 +00:00
8251fca66a
performance efficiencies
2023-12-18 17:39:29 +00:00
68cbb820a7
performance efficiencies
2023-12-18 17:20:34 +00:00
3aa20e2008
Create Array: fix mismatched tooltips
...
Partially addresses https://gitlab.com/kicad/code/kicad/-/issues/16391
2023-12-18 12:02:11 -05:00
11805d6696
performance efficiencies
2023-12-18 17:01:55 +00:00
47e07f507e
nullptr safety
...
(Can't actually happen as the 4 base fields are mandatory,
but it'll keep Coverity happy.)
2023-12-18 17:01:55 +00:00
fc903592ed
Hotkeys: fix multiple assignment of N key
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16376
2023-12-18 11:13:47 -05:00
2ee75b1aec
BOM Generation: Unifying reference concatenation using more pythonic string join to avoid trailing comma.
2023-12-18 14:44:12 +00:00
fd91f8933e
Fix a SPICE simulator crash on run of a second OP command.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16341
2023-12-18 09:43:40 -05:00
9e1ceba5d8
Symbol Fields Table: save modified presets without changes to schematic
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16381
2023-12-18 09:28:59 -05:00
3b36307425
Remove shadowed variable.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16363
2023-12-18 14:24:04 +00:00
6b1d00a528
Smallest font size was a bit too small.
2023-12-18 14:24:04 +00:00
25c03da5a5
Coding policy and Doxygen comment fixes.
2023-12-18 08:32:41 -05:00
421cf3d344
sentry-native update to 0.6.7
2023-12-17 21:39:10 -05:00
de2f5f6547
argparse update
2023-12-17 21:29:05 -05:00
4a9994931a
Avoid double-move
...
This was flagged by coverity but doesn't seem to be an actual issue in
g++/clang. It technically leaves the moved rvalue in a "valid but
undefined state", so it is best to avoid. The single copy into an
lvalue is (I think) cheap
2023-12-17 21:25:39 -05:00
33f75fbd0a
Update bs_thread_pool to 3.5.0
2023-12-17 21:25:31 -05:00
83f4597f05
Remove a unused var
2023-12-17 21:19:07 -05:00
8e6b8911c8
Update nlohmann_json to 3.11.3 to silence char_traits deprecated warning
2023-12-17 21:14:08 -05:00
71383c9c73
Fix warnings about sprintf use.
2023-12-17 20:56:15 -05:00
93811b801d
Add macOS CI build
2023-12-17 20:20:14 -05:00
a944310f7b
Move sheet navigation commands below active tool commands.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16367
2023-12-17 22:06:47 +00:00
16c8050f3d
Fix event/flag race condition.
2023-12-17 21:55:29 +00:00
08a00633b1
Make sure child items get edit flags cleared in commit.
...
In the footprint editor, in particular, we often just
add the parent footprint to the commit rather than the
actual modified item(s).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16389
2023-12-17 21:55:29 +00:00
eb3fd10af8
Fix obscured object selection issue in board and footprint editors.
...
This selection improvement feature is hidden behind the advanced
configuration key "PcbSelectionVisibilityRatio". It is turned off (1.0)
by default. Value values are from 0.0 to less that 1.0. From testing,
using a value between 0.1 and 0.3 produces the best results.
This fix uses normal alpha blending described in the link below. The
current design only uses the alpha of the object's color. It could be
improved by doing a full color alpha blending but using the color alpha
alone seems to result in satisfactory results.
https://en.wikipedia.org/wiki/Alpha_compositing
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16126
2023-12-17 16:43:56 -05:00
1b0cc82c56
Move a couple of stragglers to BOARD_COMMIT.
2023-12-17 21:01:31 +00:00
a96b7116d0
Make sure de-selected items get redrawn.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16385
2023-12-17 17:59:43 +00:00
b29a56530c
Remove undo-of-ungroup hack.
...
The hack assumed that the parent group would be the first
deleted item of type group in the undo list. While this
will be true when undoing a user ungroup command, it will
not be when undoing an ungroup side-effect, such as when a
member of a group is deleted during UpdateFromPCB.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16384
2023-12-17 15:35:35 +00:00
c5ac2337e4
PNS mitering: construct arcs from start, end, angle.
...
Previously, arc endpoint and expected miter endpoint could differ,
causing very small loops later on.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16360
2023-12-17 05:47:07 +03:00
3b26f96fe4
Tuning Patterns: read/write min_amplitude.
2023-12-17 05:32:02 +03:00
a52da69c03
Fix overly agressive assert.
...
An item can be added for group/ungroup and add/delete.
2023-12-16 16:20:36 +00:00
9fb06f95a0
Fix msys2 build.
2023-12-16 16:17:24 +00:00
66a15f6acf
Re-factor frame pointer out of generator API.
2023-12-16 16:11:45 +00:00
ea3c87f243
Move group/ungroup to COMMIT infrastructure.
2023-12-16 14:17:25 +00:00
27f5ecf716
French translation update
2023-12-16 13:48:27 +01:00
d8b1e3fcb3
test_prettifier: Better warning message for commit 8e647c24
2023-12-16 13:30:06 +01:00
8849891893
Add a update notice modal dialog instead of the incomplete notifications
2023-12-16 06:47:41 -05:00
8e647c24b4
QA test, prettifier: Update golden files to the latest version.
...
Add also a warning when a golden file is too old and creates comparison error.
2023-12-16 10:49:23 +01:00
c16db03321
Reserve strings.
2023-12-16 12:25:32 +03:00
1df84f4d92
Move some PCB_GENERATOR special-cases to propMgr listeners.
2023-12-15 21:04:33 +00:00
0ab474e596
Comments.
2023-12-15 18:02:52 +00:00
4844cffc00
Make sure PCB_GENERATOR's lock status follows their members.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16372
2023-12-15 17:37:36 +00:00
bcc823e8ff
Always leave library browse button active.
...
It's a bit of a hack, but it makes it easy for users to
switch from inferred models to specific library models.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16261
2023-12-15 13:31:09 +00:00
9b2cde9571
Use FormatBool for PCB_GENERATOR serialisation
2023-12-14 21:22:59 +00:00
e41f5efb03
Use modern bool style for footprint locking (locked yes)
...
Add some simple tests for specific footprint load/save checks
(including round-trip stability)
2023-12-14 21:22:59 +00:00
481fa1f959
Allow PCB reference image locking and UUID to be saved
...
Add some unit tests for reference image saving/loading.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16334
2023-12-14 21:22:59 +00:00
Wayne Stambaugh
Jeff Young
Mike Williams
Christian Weickhmann
Marek Roszko
Seth Hillbrand
Alex Shvartzkop
jean-pierre charras
John Beard