haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,424 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

273 Commits

Author SHA1 Message Date
Jeff Young 7cfe19d9fd Cleanup. 2019-06-17 22:15:20 +01:00
Jeff Young 1f35ec5521 Beware of copying events and losing the m_passEvent flag. 
Fixes: lp:1833031
* https://bugs.launchpad.net/kicad/+bug/1833031
 2019-06-17 14:44:39 +01:00
Jeff Young 5d7739a662 Handle '&'s in menu labels. 
Fixes: lp:1832904
* https://bugs.launchpad.net/kicad/+bug/1832904
 2019-06-17 10:45:23 +01:00
Jeff Young e6d5110ccf Implement I18N for ACTIONs. 
It's a bit of a hack because they're statically initialized and
so we can't make use of the _() macro.  We do still want it in the
code, however, because the string harvesting is based off of it.

Fixes: lp:1833000
* https://bugs.launchpad.net/kicad/+bug/1833000
 2019-06-17 10:45:23 +01:00
Wayne Stambaugh 418bd28347 Fix build error. 2019-06-16 18:31:10 -04:00
Jeff Young dd3617cfda Fix compile issue. 2019-06-16 22:46:35 +01:00
Jeff Young de67f3f1e9 Move a few more things to ACTIONs. 2019-06-16 19:53:30 +01:00
Jeff Young 909aeba3d9 Transition some more stuff from the MVC view to the controller. 2019-06-16 19:53:30 +01:00
Jeff Young c7bfa9857e Use more reflective naming of what the tool does. 2019-06-16 19:52:07 +01:00
Jeff Young e4fbd003e0 Make m_passEvent event-specific rather than global. 
If a tool called something like clearSelection while processing a
MOUSE_CLICK, the SELECTION_TOOL will pass the clearSelection
COMMAND_EVENT because it handles it as a transition, not as an
event. Because m_passEvent is effectively global, the tool manager
would then interpret that as passing the MOUSE_CLICK and we'd end
up processing the click by multiple tools.
 2019-06-16 12:06:49 +01:00
jean-pierre charras 6a8e69f9c9 Fix a compil warning. 2019-06-16 09:12:32 +02:00
Jeff Young 0f4bdbd184 Tighten down the POINT_EDITORs a bit more. 2019-06-16 01:33:39 +01:00
Jeff Young 18ebced8f4 Code hygiene. 2019-06-15 20:43:52 +01:00
Jeff Young 19aba615c2 Remove selection condition from conditional menu separators. 
We don't allow duplicate separators anyway so all they really do
is complicate the code.
 2019-06-15 20:43:51 +01:00
Jeff Young 5610261dce Immediate-action hotkeys (and context menu actions) for eeschema. 2019-06-15 20:43:51 +01:00
Jeff Young 83ee51370c Cancel interactive editing when switching sheets. 
Fixes: lp:1819278
* https://bugs.launchpad.net/kicad/+bug/1819278
 2019-06-14 16:54:46 +01:00
Maciej Suminski 7d69a917b9 Fixed a crash in EE_SELECTION_TOOL::SelectPoint() 
The for loop is continued after an item removal, so the removed item
is not accessed anymore.
 2019-06-14 13:00:39 +02:00
Jeff Young 8cc1e2b5e7 Fix breakage in wire moving/dragging/etc. 
Fixes: lp:1832750
* https://bugs.launchpad.net/kicad/+bug/1832750
 2019-06-13 19:58:37 +01:00
Jeff Young 8f84c3ec4f Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal. 2019-06-13 19:58:37 +01:00
Jeff Young ce1f35a1be Cleanup some left-over vestiages of the legacy canvas architecture. 2019-06-13 15:51:32 +01:00
Jeff Young 4043a15482 When pasting a sheet link to existing copy if it already appears in the hierarchy. 
Fixes: lp:1830633
* https://bugs.launchpad.net/kicad/+bug/1830633
 2019-06-13 15:51:32 +01:00
Jeff Young c0e1f7a17a Add dragging of wire ends, corners and junctions. 
Fixes: lp:1830007
* https://bugs.launchpad.net/kicad/+bug/1830007
 2019-06-11 21:20:19 +01:00
Jeff Young b1b7408cf2 Accidentally checked in some debugging stuff. 2019-06-11 18:53:36 +01:00
Jeff Young 7726b039b2 Re-jigger standard submenus so they both link AND work. 2019-06-11 18:03:16 +01:00
Jeff Young 05652d4787 Rework the preparation for eeschema's move-tool. 
There are a whole bunch of cases which all have to work:
 regular move
 move followed by drag
 drag followed by move
 move followed by duplicate
 duplicate
 paste
and all both with and without Warp Mouse on Move checked.
 2019-06-11 18:03:16 +01:00
Jeff Young e4d16abcbd Fix overly-generic flag test when synchronizing pins. 
Fixes: lp:1832170
* https://bugs.launchpad.net/kicad/+bug/1832170
 2019-06-11 09:29:30 +01:00
Jeff Young 09a3c5b280 Update pasted items' parent pointers. 
Fixes crashes when trying to manipulate the item after the paste,
and weird redraw behaviour with pins.

Fixes: lp:1832178
* https://bugs.launchpad.net/kicad/+bug/1832178
 2019-06-11 09:22:56 +01:00
Jeff Young 6623ab91a8 Fix issue with picker tool activation. 2019-06-11 00:25:38 +01:00
Jeff Young e9017ce0b1 Update status bar when selected items are modified. 
Fixes: lp:1831801
* https://bugs.launchpad.net/kicad/+bug/1831801
 2019-06-10 23:46:01 +01:00
Jeff Young a568e70b99 Follow naming conventions. 2019-06-10 23:46:01 +01:00
Jeff Young 5e49517781 Move hotkeys to ACTION architecture. 2019-06-10 23:46:00 +01:00
Jeff Young 765606012f Convert separate-compilation of selection.cpp to polymorphism. 2019-06-10 23:46:00 +01:00
Jeff Young e606587ff6 Move remaining Symbol Tree ctx menu cmds to ACTIONS. 
Also moves the various Player instantiators down into COMMON_TOOLS
for better sharing.
 2019-06-10 23:46:00 +01:00
Jeff Young b9927a0655 Don't put standard menu items into symbol tree context menu. 2019-06-05 23:33:15 +01:00
Jeff Young 469fc3b572 Finish moving symbol editor tree context menu to ACTIONs. 2019-06-05 23:29:59 +01:00
Jeff Young 2d40425e4d Move footprint & symbol tree context menus to tool infrastructure. 
Fixes: lp:1831692
* https://bugs.launchpad.net/kicad/+bug/1831692
 2019-06-05 20:16:48 +01:00
Jeff Young 1ea5b04e22 More ACTIONS work. Nearly done now. 2019-06-04 22:31:42 +01:00
Jon Evans 1721cc1700 Ensure pasted sheets get parents set properly for screen discovery 
Fixes: lp:1831460
* https://bugs.launchpad.net/kicad/+bug/1831460
 2019-06-03 20:30:35 -04:00
Jeff Young 1bf04d1722 More ACTIONs work. 2019-06-04 00:51:16 +01:00
Jeff Young 568c8c336b Move DRC control to a tool; move assorted commands to ACTIONS. 2019-06-03 21:08:30 +01:00
Jeff Young 9f1e2e34b7 Move some dupicated tools to common tools. 2019-06-03 21:08:30 +01:00
Jeff Young 33773bad4d Yet more command conversions to ACTIONs. 2019-06-02 21:10:56 +01:00
Jeff Young dfc2fe3929 Don't try to post-process an empty clipboard paste. 
Fixes: lp:1831364
* https://bugs.launchpad.net/kicad/+bug/1831364
 2019-06-02 16:21:44 +01:00
Jeff Young 7f1ed30ff5 Move DeMorgan handling to ACTIONs. 2019-06-01 23:03:24 +01:00
Jeff Young 39b91c90dd Moved more operations to ACTIONs. 2019-06-01 23:03:24 +01:00
Jeff Young 3777c5270b Move some more Eeschema operations to ACTIONs. 2019-06-01 16:29:12 +01:00
Jeff Young f1076c0f48 Fix missing reference keeping history from getting saved. 
Fixes: lp:1830185
* https://bugs.launchpad.net/kicad/+bug/1830185
 2019-05-31 23:38:15 +01:00
Jeff Young c7fa5c567f Load sheet content after a paste. 
Fixes: lp:1830633
* https://bugs.launchpad.net/kicad/+bug/1830633
 2019-05-31 23:38:15 +01:00
Jeff Young 1dd1ddf83b Try an "add wires" strategy instead of trying to figure out what to pick up and what to anchor. 
Fixes: lp:1831199
* https://bugs.launchpad.net/kicad/+bug/1831199
 2019-05-31 21:56:35 +01:00
Jeff Young d7774b94fc Fix regression with switching between drag and move operation. 2019-05-31 21:56:35 +01:00
Jeff Young ead1914b1d Don't autopan until mouse moves. 2019-05-31 21:55:30 +01:00
Jeff Young d2daab808c Remove some legacy cursor handling stuff. 2019-05-31 21:54:22 +01:00
jean-pierre charras 4842c73530 Fix minor compil warnings. 2019-05-31 21:38:30 +02:00
Jeff Young 0260b32125 Push resetLocalCoords down into COMMON_TOOLS. 
Fixes: lp:1830693
* https://bugs.launchpad.net/kicad/+bug/1830693
 2019-05-29 00:26:29 +01:00
Jeff Young db90e97d0b fixup! Implement undo for Page Settings in PlEditor, Eeschema and PCBNew. 2019-05-27 14:12:20 +01:00
Jeff Young d24a2afaca Fix duplicate to work like paste to keep pins from getting duplicated. 
Also fixes the post-duplicate move to start at the cursor pos.
Also fixes the fact that duplicate wasn't getting its hotkey.

Fixes: lp:1830596
* https://bugs.launchpad.net/kicad/+bug/1830596
 2019-05-27 11:58:56 +01:00
Jeff Young 800cc1a11c Fix intial drag point for paste in LibEdit. 2019-05-27 11:58:56 +01:00
Jeff Young e9e28b9aac Retire legacy block architecture. 2019-05-27 11:58:56 +01:00
Jeff Young 927d2a645c Move LibEdit Save operations to ACTIONS. 2019-05-27 11:58:55 +01:00
Jeff Young 6936effaa7 Implement undo for Page Settings in PlEditor, Eeschema and PCBNew. 
Fixes: lp:1820059
* https://bugs.launchpad.net/kicad/+bug/1820059
 2019-05-27 11:58:55 +01:00
jean-pierre charras 568d4e2b19 Avoid including id.h in a lot of files that do not use it. 2019-05-26 08:14:25 +02:00
jean-pierre charras b8e2054b23 Activate context menu in LIB_VIEW_FRAME canvas. 2019-05-25 10:13:27 +02:00
Jeff Young a3dfce5adb Implement common file menu actions and move Eeschema over. 2019-05-25 01:14:21 +01:00
Jeff Young 85f984ccd9 Add point-editor activation for immediate-mode drawing. 2019-05-24 19:49:09 +01:00
Jeff Young 323bb0f8e1 Moving PageLayout editor to GAL canvas and modern toolset. 2019-05-24 19:49:09 +01:00
Michael Kavanagh 43a5bb72ca Fix swapped mirror icons in eeschema context menu 
Fixes: lp:1828631
* https://bugs.launchpad.net/kicad/+bug/1828631
 2019-05-24 13:12:58 -04:00
Jon Evans ab3ada5200 Clear moving flag for second-click-placed items 
Fixes: lp:1830227
* https://bugs.launchpad.net/kicad/+bug/1830227
 2019-05-23 21:51:14 -04:00
Jeff Young ebd8c44eee Don't confuse SCH_ITEMs and LIB_ITEMs. 
Fixes: lp:1829826
* https://bugs.launchpad.net/kicad/+bug/1829826
 2019-05-23 22:57:53 +01:00
jean-pierre charras 872c8ca37b Remove a duplicate icon. 2019-05-23 16:21:06 +02:00
John Beard e1f6230e8c Do not statically construct wxTimer 
If you construct wxTimer statically, it will be constructed
before WX init, which means you might get assertions about
missing m_impl's within the timer class.

The solution is to construct the wxTimer at run time. In this
case, static within the function will be constructed only after
the function is called (and actually the scope only needed to be
this function anyway).
 2019-05-23 11:28:11 +01:00
Jeff Young 0047f88f82 Mark unfold bus menu as clean so it doesn't get generated a second time. 
Fixes: lp:1829878
* https://bugs.launchpad.net/kicad/+bug/1829878
 2019-05-23 00:27:53 +01:00
Jeff Young 1636405b66 Set a reference point for all selection sizes. 
Fixes: lp:1829833
* https://bugs.launchpad.net/kicad/+bug/1829833
 2019-05-23 00:27:53 +01:00
Tomasz Włostowski ecb81426a4 eemodern: fixed use-after-free in SCH_DRAWING_TOOLS::DrawSheet(). 2019-05-23 00:28:58 +02:00
Jeff Young 323ecada8d Generate refresh preview events when objects are moving. 
Fixes: lp:1829683
* https://bugs.launchpad.net/kicad/+bug/1829683
 2019-05-22 21:48:04 +01:00
Jeff Young fbffb9ae1e Don't put KICAD_T arrays on stack and expect them to be there when you need them. 
Fixes: lp:1829748
* https://bugs.launchpad.net/kicad/+bug/1829748
 2019-05-22 21:48:04 +01:00
Jeff Young 67f7571f04 Don't call VIEW::Redraw() from within the tool. 
Fixes: lp:1828824
* https://bugs.launchpad.net/kicad/+bug/1828824
 2019-05-22 21:48:04 +01:00
Jeff Young 67cc2aac2e Rework Eeschema find/replace for modern toolset. 
Fixes: lp:1827274
* https://bugs.launchpad.net/kicad/+bug/1827274

Fixes: lp:1827240
* https://bugs.launchpad.net/kicad/+bug/1827240
 2019-05-22 21:48:04 +01:00
Tomasz Włostowski 2b38b23a5e eemodern: fixed use-after-free crash in LIB_EDIT_TOOL::DoDelete() 2019-05-22 21:35:03 +02:00
jean-pierre charras f18807ea0f Eeschema: Ensure axis are always drawn in libedit and viewlib 
Fixes: lp:1822408
https://bugs.launchpad.net/kicad/+bug/1822408
 2019-05-22 10:04:34 +02:00
Seth Hillbrand e1373d70ae libedit: Ensure proper dereference in shared tools 
Fixes: lp:1829826
* https://bugs.launchpad.net/kicad/+bug/1829826
 2019-05-21 19:43:15 -07:00
Tomasz Włostowski bc52f0a03b eemodern: clean printf debug gibberish, implement inline drag, move & cursor warp/reference point options 2019-05-20 21:04:46 +02:00
Tomasz Włostowski af30eca3cb eemodern: hover selection should autoclear after invoking properties dialog 2019-05-20 21:04:46 +02:00
Tomasz Włostowski aff3243f3b eeschema: fix use-after-free crash in GetScreen()/GetCurrentSheet() 2019-05-20 21:04:46 +02:00
Tomasz Włostowski 034669bf30 eemodern: implement drag-related settings in the Preferences window 2019-05-20 21:04:46 +02:00
Tomasz Włostowski 5ea46e8b78 eemodern: initial attempt at inline drag/move actions 2019-05-20 21:04:46 +02:00
Jeff Young 813de6a1f3 Implement brightening for Eeschema Find/Replace. 2019-05-18 14:28:22 +01:00
Jeff Young 21a7621ddb Fix issues with multiple M or G commands in a row. 2019-05-18 14:11:19 +01:00
Jeff Young 952108dd43 Implement SCH_SHEET_PIN selection, rotation and mirroring. 
Fixes: lp:1829521
* https://bugs.launchpad.net/kicad/+bug/1829521
 2019-05-18 00:23:12 +01:00
Jeff Young 5f851a4bad Add AutoplaceFields to symbol tool context menu. 2019-05-18 00:21:49 +01:00
Jeff Young 7c25001622 Implement immediate actions for adding and importing sheet pins. 
Fixes: lp:1829314
* https://bugs.launchpad.net/kicad/+bug/1829314
 2019-05-18 00:21:49 +01:00
Jeff Young 6b3fe33d6f Improve selection logic for sloppy selections. 2019-05-17 00:48:39 +01:00
Jeff Young 5dd71b5563 Disable pin table and part properties when there's no part. 
Fixes: lp:1828962
* https://bugs.launchpad.net/kicad/+bug/1828962
 2019-05-16 23:53:33 +01:00
Jeff Young 68224e0fcd Don't double-add pins to parent part when pasting. 
Also adds undo to paste operations in LibEdit.

Fixes: lp:1829355
* https://bugs.launchpad.net/kicad/+bug/1829355
 2019-05-16 23:53:11 +01:00
Jeff Young 0dd1584394 Add import-sheet-pin error message and move messages to status popups. 
Fixes: lp:1829314
* https://bugs.launchpad.net/kicad/+bug/1829314
 2019-05-16 23:11:22 +01:00
Jeff Young 6630a7227d Constrain SHEET_PIN movement, and keep them attached when resizing SHEET. 
Fixes: lp:1829314
* https://bugs.launchpad.net/kicad/+bug/1829314
 2019-05-16 22:36:19 +01:00
Jeff Young fbb807f3bb Move some more menu & toolbar items to modern toolset. 2019-05-16 19:57:06 +01:00
Jeff Young eba892009d Improve hit-test logic by gradually increasing threshold. 
Fixes: lp:1828222
* https://bugs.launchpad.net/kicad/+bug/1828222
 2019-05-16 19:57:05 +01:00
Jeff Young 69afa27a5f Implement ACTION_TOOLBAR and update some of the menus to ACTION_MENU. 
This gives us better separation of MVC in line with the design of
the modern toolset.  It also reduces a whole bunch of duplicated
data.
 2019-05-15 17:50:52 +01:00
Jeff Young f9e4ee1fc9 CONTEXT_MENU -> ACTION_MENU. (Now used for menu-bar menus too.) 2019-05-15 17:50:52 +01:00
Jeff Young e850592587 Cleanup. 2019-05-15 17:50:52 +01:00